Ankush Menat
b147b85e6a
chore: whitespace / eof fixes
2021-09-01 16:57:21 +05:30
Ankush Menat
010060d92e
chore: correct indentation
2021-09-01 15:02:29 +05:30
rohitwaghchaure
e6799d78ef
fix: operation time auto set to zero ( #27188 )
2021-08-27 10:46:45 +05:30
Frappe PR Bot
a1737c9a0c
fix: Production Plan: load document defaults for plan items & remove name column from listview ( #26584 ) ( #27184 )
...
(cherry picked from commit 69d88a921273c9e0ea29d7131232686a0be7bb78)
Co-authored-by: Richard Case <64409021+casesolved-co-uk@users.noreply.github.com>
2021-08-26 23:04:54 +05:30
Noah Jacob
422f67a4c9
refactor: update manufacturing module onboarding ( #26945 )
...
* refactor: updated manufacturing onboarding cards
* refactor: added form tours
* refactor: updated form tours and card descriptions
* Fix: Case of description
Co-authored-by: Nabin Hait <nabinhait@gmail.com>
2021-08-26 21:40:48 +05:30
Ankush Menat
ae55eab599
chore: remove deprecated and empty QUnit tests ( #27179 )
...
* chore: remove deprecated and empty QUnit tests
* ci: fix UI test config
Testing library was added on Frappe, in order to reuse command testing
library has to be installed during setup process.
2021-08-26 20:43:06 +05:30
Ankush Menat
c07dce940e
fix: don't allow BOM's item code at any level of child items ( #27157 )
...
* refactor: bom recursion checking
* fix: dont allow bom recursion
if same item_code is added in child items at any level, it shouldn't be allowed.
* test: add test for bom recursion
* test: fix broken prodplan test using recursive bom
* test: fix recursive bom in tests
2021-08-26 18:33:42 +05:30
18alantom
b389b8c3ad
fix: prevent over riding scrap table values, name kwargs, set currency
2021-08-26 13:15:57 +05:30
18alantom
e20d21924c
Merge branch 'develop' into feat-bom-process-loss-fp
2021-08-26 13:05:59 +05:30
rohitwaghchaure
ad45ddcabe
fix: sequence of sub-operations in job card ( #27138 )
2021-08-25 20:07:18 +05:30
18alantom
95a2565d86
fix: correct value in test
2021-08-24 20:18:53 +05:30
18alantom
aff9aee29c
Merge branch 'develop' into feat-bom-process-loss-fp
2021-08-24 20:15:51 +05:30
18alantom
c3ce3f918d
fix: remove spurious function 'toggle_operations'
2021-08-24 20:15:19 +05:30
18alantom
8f73d587f9
feat: process loss report, fix set pl query condition
2021-08-24 18:38:23 +05:30
18alantom
b58853e89d
feat: add procss_loss_qty field in work order
2021-08-24 16:11:29 +05:30
18alantom
7fb08173b5
fix: reword error messages, fix test values
2021-08-24 15:01:38 +05:30
rohitwaghchaure
6106a635f8
Merge branch 'develop' into fix-scrap-items-updation
2021-08-24 12:10:04 +05:30
Alan
62c590261c
refactor: rectify typo ( #27057 )
...
[skip ci]
2021-08-20 18:21:09 +05:30
18alantom
6ef16ee4fb
fix: update scrap table item details; typo
2021-08-20 12:24:13 +05:30
Noah Jacob
f13315809e
refactor: renamed varint_item_code to variant_item_code ( #27025 )
2021-08-19 20:28:30 +05:30
Alan
9225f02599
fix: pass planned start date to created work order ( #27031 )
...
* fix: pass planned start date to created workorder
* test: production plan to work order start date
Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
2021-08-19 18:49:20 +05:30
Alan
09f34e558e
fix: set production plan to completed even on over production ( #27027 )
2021-08-19 15:51:36 +05:30
Ankush Menat
4551d7d602
chore: mass trailing whitespace and EOF fixes
2021-08-19 13:43:28 +05:30
18alantom
cc177f3415
fix: wo tests, sider, account for pl in se validation
2021-08-17 16:49:00 +05:30
18alantom
2670adc0c0
test: check manufacture completion qty in se and wo
2021-08-17 16:40:44 +05:30
18alantom
ad73d3fbfb
refactor: validation error message formatting
2021-08-17 16:40:16 +05:30
18alantom
23ef51a981
fix: sider
2021-08-17 16:40:05 +05:30
18alantom
47a4a3d888
refactor: polyfill ??
2021-08-17 16:39:05 +05:30
18alantom
55acb2e843
fix: sider
2021-08-17 16:37:34 +05:30
18alantom
cdf253aeb4
fix: add more validations, remove source wh req for pl item
2021-08-17 16:36:32 +05:30
18alantom
8ecb146231
test: add bom tests for process loss val, add se test for qty calc
2021-08-17 16:36:24 +05:30
18alantom
7433b97106
refactor: shift auto entry of is process loss check, update validations
2021-08-17 16:35:16 +05:30
18alantom
984c97ed4e
feat: add is process loss autoset and validation
2021-08-17 16:28:54 +05:30
18alantom
b6dc0efa27
feat: add provision for process loss in manufac
2021-08-17 16:23:19 +05:30
Rohit Waghchaure
eb1e3181a4
fix: conflicts while merging brnach version-13 to develop
2021-08-17 10:53:19 +05:30
Shariq Ansari
b32c2fa561
fix: updated erpnext wspace json files ( #26380 )
...
* fix: updated erpnext wspace json files
* fix: updated wspace json files
* fix: updated wspace json files
* fix: removed padding code from wspace json files
* fix: Updated restrict_to_domain in wspace json
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2021-08-13 12:19:16 +05:30
Frappe PR Bot
210441d9b5
fix: price list with 0 value are ignored (bp #26655 )
...
* fix: price list with 0 value are ignored
Steps to reproduce:
1. Create 2 item price for two different supplier. One of them should be
zero.
2. Create PO
3. Add supplier with non-zero price and add item.
4. change supplier. Price won't change. If price was non-zero it
would've changed.
Root cause: falsiness check instead of null value check is used for
checking if price list value exists. 0 is evaluated as false.
* refactor: make get_price_list_rate function pure
(cherry picked from commit 16d4de5130
2021-08-09 11:34:33 +05:30
Frappe PR Bot
3dfbf19e8f
fix: allow alternative items when using job card (bp #26724 )
...
(cherry picked from commit 7e0c57fa3f
2021-08-09 11:33:55 +05:30
Ankush
7e0c57fa3f
fix: allow alternative items when using job card ( #26724 )
2021-08-09 10:46:29 +05:30
Ankush
16d4de5130
fix: price list with 0 value are ignored ( #26655 )
...
* fix: price list with 0 value are ignored
Steps to reproduce:
1. Create 2 item price for two different supplier. One of them should be
zero.
2. Create PO
3. Add supplier with non-zero price and add item.
4. change supplier. Price won't change. If price was non-zero it
would've changed.
Root cause: falsiness check instead of null value check is used for
checking if price list value exists. 0 is evaluated as false.
* refactor: make get_price_list_rate function pure
2021-08-09 10:41:24 +05:30
Noah Jacob
cb44aed78b
test: get sales order with variant
2021-08-06 11:16:25 +05:30
Noah Jacob
041ac339b1
style: improved formatting of sql query
2021-08-05 16:37:22 +05:30
Noah Jacob
b10465eebe
refactor: created function to get bom_item for query
2021-08-05 16:37:22 +05:30
noahjacob
9b0b2daf4a
refactor: updated sql query for item variants
2021-08-05 16:37:22 +05:30
noahjacob
cf4078756d
fix: fixed fetching sales order of item variant in production plan
2021-08-05 16:37:21 +05:30
Frappe PR Bot
1b9a5c851d
fix: incorrect amount in work order required items table. ( #26585 ) ( #26623 )
...
* fix: amount in work order not equal to rate * qty
* fix: patch for amount in work order required items
(cherry picked from commit cd12d95a24
2021-08-03 20:06:36 +05:30
Rohit Waghchaure
343143037c
fix: conflicts
2021-08-01 14:45:24 +05:30
Frappe PR Bot
1b6dd84c0a
fix(bom): remove manual permission checking ( #26689 ) ( #26690 )
...
get_list does the permission checking.
(cherry picked from commit d95f16ac8f
2021-07-28 18:11:11 +05:30
Ankush
8ed7a21cd5
fix(bom): remove manual permission checking ( #26689 )
...
get_list does the permission checking.
(cherry picked from commit d95f16ac8f
2021-07-28 11:12:27 +00:00
Ankush
d95f16ac8f
fix(bom): remove manual permission checking ( #26689 )
...
get_list does the permission checking.
2021-07-28 16:38:59 +05:30
