barredterra
fd7be5da99
feat: remove obsolete "debit_to" field
2023-06-14 13:01:28 +05:30
barredterra
c142d89952
tests: remove obsolete test
2023-06-14 13:01:14 +05:30
barredterra
ac8b6bba5c
feat: resolve dunning on payment entry
2023-06-14 13:00:47 +05:30
barredterra
270040303c
refactor: make sider happy
2023-06-14 12:59:27 +05:30
barredterra
6b6f4dd017
refactor: run pre-commit
2023-06-14 12:59:26 +05:30
barredterra
ff7ec977e6
feat: more info for payment deductions
2023-06-14 12:59:26 +05:30
barredterra
16a23d9f0f
refactor: dunning
2023-06-14 12:59:26 +05:30
barredterra
603117eb6b
feat: change print format to reflect doctype changes
2023-06-14 12:56:28 +05:30
barredterra
3895c03ba9
feat: change make_gl_entries to work with new data structure
2023-06-14 12:56:28 +05:30
barredterra
bc40f3f425
refactor: rename interest_amount to interest, dunning_level
2023-06-14 12:54:17 +05:30
barredterra
be5fb94837
feat: currency section , debit_to, base_dunning_amount
2023-06-14 12:54:14 +05:30
barredterra
df840cca75
refactor: validate totals
2023-06-14 12:54:01 +05:30
barredterra
24e7a21839
refactor: remove redndant argument
2023-06-14 12:54:00 +05:30
barredterra
f143fe7dcc
refactor: tests
2023-06-14 12:53:56 +05:30
barredterra
676ed6b881
feat: hide fields in print
2023-06-14 12:50:57 +05:30
barredterra
043066a2c8
style: use double quotes
2023-06-14 12:50:41 +05:30
barredterra
938f7d2266
reafctor: validate instead of postprocess
2023-06-14 12:42:21 +05:30
barredterra
9016baddca
feat: company address query + style
2023-06-14 12:42:21 +05:30
barredterra
b07620aacf
feat: child table triggers calculation of totals
2023-06-14 12:42:20 +05:30
barredterra
b186f8e9d7
feat: address display
2023-06-14 12:42:17 +05:30
barredterra
db47e1b69c
feat: address and contact queries
2023-06-14 12:42:02 +05:30
barredterra
4f51dfe4c5
refactor: remove unnecessary code
2023-06-14 12:42:02 +05:30
barredterra
2d0dadd9ac
feat: rework dunning backend
2023-06-14 12:41:59 +05:30
Gursheen Anand
ba4ab06ae3
fix: changed account types in controller method
2023-06-14 12:39:16 +05:30
barredterra
2ee919220a
feat: rework dunning frontend
2023-06-14 12:37:58 +05:30
barredterra
8976e94a1d
feat: rework doctypes
2023-06-14 12:37:55 +05:30
barredterra
86a8b0b30f
refactor: doctype naming
...
Overdue Payments -> Overdue Payment
2023-06-14 12:37:31 +05:30
barredterra
487c6018bf
feat: restructure dunning doctype
2023-06-14 12:37:02 +05:30
barredterra
e7705327f0
feat: filter invoices
2023-06-14 12:35:30 +05:30
barredterra
e5b57ec965
feat: Overdue Payments table
2023-06-14 12:35:29 +05:30
Deepesh Garg
937c0feefe
fix: Lower deduction certificate not getting applied ( #35667 )
2023-06-13 20:06:36 +05:30
Anand Baburajan
491a50a027
fix: make showing taxes as table in print configurable ( #35672 )
2023-06-13 19:42:56 +05:30
Devin Slauenwhite
20de27d480
fix(accounts): validate payment entry references with latest data. ( #31166 )
...
* test: payment entry over allocation.
* fix: validate allocated_amount against latest outstanding amount.
* fix: payment entry get outstanding documents for advance payments
* fix: only fetch latest outstanding_amount.
* fix: throw if reference is allocated
* test: throw error if a reference has been partially allocated after inital creation.
* chore: test name
* fix: remove unused part of test
* chore: linter
* chore: more user friendly error messages
* fix: only validate outstanding amount if partly paid and don't filter by cost center
* chore: minor refactor for doc.cost_center
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
---------
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com>
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
2023-06-13 19:06:53 +05:30
Ankush Menat
a3ea985348
refactor: Use db.set_single_value ( #35668 )
...
I just applied semgrep autofix. Untested completed, review before merging.
```yaml
- id: frappe-set-value-semantics
patterns:
- pattern-either:
- pattern: frappe.db.set_value($DOCTYPE, None, $...AFTER)
- pattern: frappe.db.set_value($DOCTYPE, $DOCTYPE, $...AFTER)
fix: frappe.db.set_single_value($DOCTYPE, $...AFTER)
message: |
If $DOCTYPE is a single doctype then using `frappe.db.set_value` is discouraged for setting values in DB. Use db.set_single_value for single doctype instead.
languages: [python]
severity: ERROR
```
2023-06-13 17:30:38 +05:30
Gursheen Anand
17341adf1c
fix: calculate outstanding amount on reconcile correctly
2023-06-13 15:00:46 +05:30
ruthra kumar
b43e068852
Merge pull request #35659 from ruthra-kumar/fix_attribute_error_in_payment_reconciliation
...
fix: attribute error on payment reconciliation tool
2023-06-13 10:16:26 +05:30
ruthra kumar
b672616617
Merge pull request #35620 from ruthra-kumar/err_higher_allowance_for_debit_credit_diff
...
fix: allow custom rounding loss allowance in Exchange Rate Revaluation
2023-06-13 09:46:08 +05:30
ruthra kumar
bada5796fa
fix: attribute error on payment reconciliation tool
2023-06-13 09:32:24 +05:30
ruthra kumar
96a0132501
fix: allow user to set rounding loss allowance for accounts balance
2023-06-12 22:05:08 +05:30
Gursheen Anand
5e9821dce2
test: modify test to check posting date
2023-06-12 18:00:15 +05:30
ruthra kumar
42f4f80e0c
fix: Payment against credit notes will be considered as payment against parent invoice in Accounts Receivable/Payable report ( #35642 )
...
* fix: payment against credit note should be linked to parent invoice
* test: AR/AP report for payment against cr note scenario
* fix: cr_note shows up as outstanding invoice
Payment made against cr_note causes it be reported as outstanding invoice
2023-06-12 17:35:13 +05:30
Gursheen Anand
a06017c2c3
fix: Use advance account from Reconciliation document for fetching Payment Entries
2023-06-12 15:24:53 +05:30
Deepesh Garg
2f24546b21
fix: Make difference entry button not working ( #35622 )
2023-06-12 15:20:28 +05:30
Deepesh Garg
e30c3eafef
fix: Stock ledger preview
2023-06-12 11:46:51 +05:30
Gursheen Anand
7591f1010b
fix: Make get party account method return a list instead of a single default account.
2023-06-12 11:06:03 +05:30
David Arnold
c1b42b858d
fix: set Phone and Email option in doctypes ( #35549 )
2023-06-11 19:34:41 +05:30
ruthra kumar
dcbd7d5f1f
fix: incorrect TCS amount while customer has advance payment ( #35397 )
...
* fix: incorrect TCS amount while customer has advance payment
* test: only unallocated advance should for threshold breach validation
2023-06-10 20:55:30 +05:30
Raffael Meyer
b91bb17779
refactor: get default contact or address ( #35248 )
...
* refactor: get_party_shipping_address
* refactor: get_default_contact
* chore: adding docstrings
* fix: keep original order
* fix: use get_all instead of get_list
---------
Co-authored-by: ruthra kumar <ruthra@erpnext.com>
2023-06-08 19:49:09 +05:30
Gursheen Anand
b65e58c1ae
test: add tests for advance liability entries
...
Add Sales and Purchase Invoice Tests to check if GL entries and Outstanding Amount are generated correctly when advance entries are recorded as liability.
Few changes to return value of added column in Payment Entry References.
2023-06-08 18:15:37 +05:30
ruthra kumar
992d61bd90
chore: fix travis
2023-06-08 15:11:46 +05:30
