Ankush Menat
a3ea985348
refactor: Use db.set_single_value
( #35668 )
...
I just applied semgrep autofix. Untested completed, review before merging.
```yaml
- id: frappe-set-value-semantics
patterns:
- pattern-either:
- pattern: frappe.db.set_value($DOCTYPE, None, $...AFTER)
- pattern: frappe.db.set_value($DOCTYPE, $DOCTYPE, $...AFTER)
fix: frappe.db.set_single_value($DOCTYPE, $...AFTER)
message: |
If $DOCTYPE is a single doctype then using `frappe.db.set_value` is discouraged for setting values in DB. Use db.set_single_value for single doctype instead.
languages: [python]
severity: ERROR
```
2023-06-13 17:30:38 +05:30
ruthra kumar
b43e068852
Merge pull request #35659 from ruthra-kumar/fix_attribute_error_in_payment_reconciliation
...
fix: attribute error on payment reconciliation tool
2023-06-13 10:16:26 +05:30
ruthra kumar
b672616617
Merge pull request #35620 from ruthra-kumar/err_higher_allowance_for_debit_credit_diff
...
fix: allow custom rounding loss allowance in Exchange Rate Revaluation
2023-06-13 09:46:08 +05:30
ruthra kumar
bada5796fa
fix: attribute error on payment reconciliation tool
2023-06-13 09:32:24 +05:30
ruthra kumar
96a0132501
fix: allow user to set rounding loss allowance for accounts balance
2023-06-12 22:05:08 +05:30
ruthra kumar
42f4f80e0c
fix: Payment against credit notes will be considered as payment against parent invoice in Accounts Receivable/Payable report ( #35642 )
...
* fix: payment against credit note should be linked to parent invoice
* test: AR/AP report for payment against cr note scenario
* fix: cr_note shows up as outstanding invoice
Payment made against cr_note causes it be reported as outstanding invoice
2023-06-12 17:35:13 +05:30
Deepesh Garg
2f24546b21
fix: Make difference entry button not working ( #35622 )
2023-06-12 15:20:28 +05:30
David Arnold
c1b42b858d
fix: set Phone and Email option in doctypes ( #35549 )
2023-06-11 19:34:41 +05:30
ruthra kumar
dcbd7d5f1f
fix: incorrect TCS amount while customer has advance payment ( #35397 )
...
* fix: incorrect TCS amount while customer has advance payment
* test: only unallocated advance should for threshold breach validation
2023-06-10 20:55:30 +05:30
ruthra kumar
992d61bd90
chore: fix travis
2023-06-08 15:11:46 +05:30
Dirk van der Laarse
3b409af9a0
fix: exclude disabled customers when fetching customers on process statement of accounts ( #35539 )
...
fix: exclude disabled when fetching customers
2023-06-07 22:01:44 +05:30
Raffael Meyer
e1f3b7cbc8
fix: pass translated label to change button type ( #35564 )
...
fix: change button type for translated labels
Co-authored-by: Marica <maricadsouza221197@gmail.com>
2023-06-07 21:49:02 +05:30
Ankush Menat
4507cb3cd7
fix: enqueue_after_commit
wherever it makes sense ( #35588 )
2023-06-07 11:58:36 +05:30
rohitwaghchaure
14292ffc6f
Merge pull request #34564 from rohitwaghchaure/serial-no-normalization
...
Feat: Serial No Normalization and Serial Batch Bundle
2023-06-02 18:13:02 +05:30
Deepesh Garg
abc6fe0b06
refactor!: Remove custom cashflow report mapper ( #35523 )
...
* refactor: Remove custom cashflow mapper
* chore: patch to delete docs
* fix: Cleanup defaults during install
* fix: Remove custom cashflow mapper from consolidated financial statement
2023-06-02 17:48:59 +05:30
Rohit Waghchaure
74ab20f97a
fix: travis for POS merge invoice and putaway rule
2023-06-02 17:14:18 +05:30
Rohit Waghchaure
f8bf4aa7c8
fix: travis for work order, pos invoice and landed cost voucher
2023-06-02 17:14:17 +05:30
Rohit Waghchaure
48fbf99e6d
fix: travis for sales and purchase invoice
2023-06-02 17:14:17 +05:30
Rohit Waghchaure
c2d7461d3c
fix: travis issue
2023-06-02 17:14:17 +05:30
Rohit Waghchaure
9b72845f0f
feat: serial and batch bundle for pick list
2023-06-02 17:14:16 +05:30
Rohit Waghchaure
648efca940
feat: auto create serial and batch bundle
2023-06-02 17:14:16 +05:30
Rohit Waghchaure
0eaf6de5de
feat: serial and batch bundle for POS
2023-06-02 17:14:16 +05:30
Rohit Waghchaure
467046436b
refactor: serial no ledger and batchwise balance history report
2023-06-02 17:14:16 +05:30
Rohit Waghchaure
5bb3173676
refactor: rename doctype serial and batch ledger to serial and batch entry
2023-06-02 17:14:15 +05:30
Rohit Waghchaure
e6143abb8a
refactor: added new file serial batch bundle
2023-06-02 17:14:14 +05:30
Rohit Waghchaure
6c9b212dd1
fix: removed sales and purchase fields from serial nos
2023-06-02 17:14:14 +05:30
Nabin Hait
f11d9b019d
fix: Ignore permissions while submitting account closing balance record ( #35536 )
2023-06-02 16:57:00 +05:30
brunoherrick
4eb2717c3b
feat(accounts): add Portuguese SNC CoA ( #35486 )
...
The ultimate goal of this commit is to add an updated Portuguese Chart of Accounts (CoA), based on Portugal's SNC norm. Account numbers are included. "Account types" shall ideally be confirmed and improved by an accountant. Howbeit, the account types are mostly inspired on former OpenERP, now designated Odoo.
2023-06-01 15:38:18 +05:30
ruthra kumar
c02fc955c5
Merge pull request #35518 from ruthra-kumar/add_precision_in_exchange_rate_revaluation
...
fix:higher precision causes ERR to misjudge zero bal acc as non-zero
2023-06-01 14:59:04 +05:30
ruthra kumar
0cd47f07a6
fix: higher precision makes ERR to misjudge zero bal acc as non-zero
2023-06-01 14:24:03 +05:30
Akshay
e08d6fb2cb
chore: typo in pricing rule schema ( #35457 )
2023-06-01 14:16:52 +05:30
Deepesh Garg
27d5e6a99b
fix: Error while validating budget ( #35487 )
...
* fix: Error while validating budget
* chore: remove print statement
2023-05-31 10:51:33 +05:30
Akshay
1ab04344db
fix (ui): debit note issued status indicator color ( #35401 )
...
* fix: debit note issued status indicator color
* fix: change DebitNoteIssued color from grey to gray
2023-05-29 09:42:01 +05:30
Sagar Sharma
027de41600
fix: incorrect POS Reserved Qty
in Stock Projected Qty
Report
2023-05-27 12:05:37 +05:30
Anand Baburajan
edb7b0db8f
fix: incorrect depr schedule and posting dates on selling of existing assets [dev] ( #35398 )
...
* fix: calc depr amount properly on selling of existing assets and fix incorrect posting dates
* chore: get number_of_depreciations_booked properly
* chore: fix test_gle_made_by_asset_sale_for_existing_asset
2023-05-24 12:29:46 +05:30
ruthra kumar
1587ce3bfb
Merge pull request #35335 from ruthra-kumar/incorrect_tds_calcuation_if_supplier_has_different_category
...
fix: tds incorrectly calculated for invoice that are below threshold
2023-05-18 12:38:31 +05:30
ruthra kumar
132846bbd1
fix(test): cumulative threshold checks
2023-05-18 12:00:59 +05:30
ruthra kumar
84b7c1bba0
fix: tds incorrectly calculated for invoice that are below threshold
...
Two purchase invoices for the same supplier, using different tax
withholding categories have this issue.
| Category | single | cumulative |
|----------+--------+------------|
| cat1 | 100 | 500 |
| cat2 | 1000 | 5000 |
1. PINV1 of net total: 105/- uses cat1. TDS is calculated as it
breached single threshold
2. PINV2 of net total: 200/- uses cat2. TDS incorrectly calculated as
PINV1 already has TDS calculated and 'consider_party_ledger_amount' is enabled.
2023-05-17 13:55:41 +05:30
ruthra kumar
e927f6cab1
Merge pull request #35239 from ashish-greycube/patch-8
...
fix: in payment_entry difference amount cal is broken
2023-05-17 10:25:55 +05:30
Ashish Shah
ae4e56747c
refactor: use 'flt' for base_total_taxes_and_charges
...
difference_amount calculation is broken, as calculation gives NaN. Fix is make frm.doc.base_total_taxes_and_charges as flt(frm.doc.base_total_taxes_and_charges)
2023-05-16 16:55:11 +05:30
ruthra kumar
776a83066d
fix: cancelled vouchers in tax withheld vouchers list ( #35309 )
2023-05-16 15:54:46 +05:30
Phanupong Janthapoon
2b59a95162
fix: share_transfer display wrong currency symbo
...
In multi-companies setting, on amount and rate field of Share Transfer
doctype are displaying wrong currency symbol, when create a
Share Transfer of others company that has different currency than
the main company. This due to the lack of `options` on those fields.
To fix this, add `options` to `amount` and `rate` fields.
2023-05-14 08:06:58 +05:30
Ankush Menat
2ea38333f0
refactor: use job_id
instead of job_name
( #35242 )
...
depends on https://github.com/frappe/frappe/pull/20951
2023-05-10 13:26:10 +05:30
ruthra kumar
afe9d7614b
Merge pull request #35212 from ruthra-kumar/chore_change_throw_to_msgprint
...
chore: convert throw to msgprint in payment reconciliation job hook
2023-05-08 17:57:13 +05:30
ruthra kumar
73134d57bf
chore: convert throw to msgprint
2023-05-08 16:42:12 +05:30
ruthra kumar
34a5f24026
Merge pull request #35186 from ruthra-kumar/child_account_should_inherit_parent_account_currency
...
fix: child acc will inherit acc currency if explicitly specified
2023-05-08 14:09:46 +05:30
ruthra kumar
f6ea8fd8d7
test: currency inheritance on child accounts
2023-05-08 13:30:39 +05:30
Rohit Waghchaure
15f5f98858
fix: error regarding accepted and supplier warehouse
2023-05-07 20:27:17 +05:30
ruthra kumar
abe691c03d
fix: child acc will inherit acc currency if explicitly specified
2023-05-06 10:40:41 +05:30
ruthra kumar
7e24215b3a
Merge pull request #35107 from ruthra-kumar/fix_incorrect_paid_amount_if_bank_cash_account_missing
...
fix: incorrect paid_amount and exchange rate in Payment Entry
2023-05-02 15:07:36 +05:30