* feat: Sales Pipeline Analytics Report
* fix: sider Issues and added tests
* fix: Semgrep Issue
* feat: Opportunity Summary by Sales Stage Report
* fix: add some checks and tests
* fix: sider issues and test
* fix: additional checks for error handling and minor changes
* fix: remove unused conditions
* fix: Changes mentioned on PR
* fix: currency conversions and other changes
* fix: remove unused imports
* fix: correction for failing test case
* fix: recorrected failing test case
* fix: sider issues and resolve test case errors
* fix: rewrite query using query builder
* fix: test case changes
* fix: sider fixes and other changes
* fix: clear data before running test
* fix: test case fixed
* refactor: code formatting
- smaller functions
- variable and function naming
* refactor: improve code formatting
* fix: linter issues
* fix: linter issues
* fix: change indentation to tabs
* fix: linter issues
* fix: naming, code formatting
* fix: quarterly values not showing up in Sales Pipeline Analytics
* fix: typo in tests
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
* chore: remove deprecated and empty QUnit tests
* ci: fix UI test config
Testing library was added on Frappe, in order to reuse command testing
library has to be installed during setup process.
* feat: provision to create customer from opportunity
* fead: linking of address and contact
* revert: create_opportunity_address_contact
* enabming print hide and no copy
* fix: lead name issue
* fix: change lead name wrt first name, middle and last name
Co-authored-by: Jannat Patel <31363128+pateljannat@users.noreply.github.com>
Summary: When a Lead is created with mobile_no, mobile_no value gets lost (mobile_no value is overwritten by phone value)
It is backport of https://github.com/frappe/erpnext/pull/26116
Steps to reproduce
[1]Create a Lead.
[2]Enter
Person Name(lead_name): before_fix
Under Contact section,
enter Phone(phone): 11 and
Mobile No.(mobile_no):22
[3]Save it
[4] F12,
cur_frm.doc.phone : 11 (correct)
cur_frm.doc.mobile_no : 11 (incorrect, it should be 22)
[5]Under Address & Contact section ,check contact_html it shows
before_fix
Phone: 11 (Primary label is missing)
Phone: 22 (incorrect, it should be Mobile No:22, also Primary label is missing)
Actual:
mobile_no value is lost. it is overwritten by phone value
following is image with error (before fix)
Expected:
mobile_no value should be retained
following is image after fix
Steps to reproduce
[1]Create a Lead.
[2]Enter Person Name(lead_name): XX
under Contact section, enter Phone(phone): 11 and Mobile No.(mobile_no):22
[3]Save it
[4] F12,
cur_frm.doc.phone : 11 (correct)
cur_frm.doc.mobile_no : 11 (incorrect)
[5]Under Address & Contact section ,check contact_html it shows
ty
Phone: 22 (correct)
Phone: 11 (in correct)
Actual:
mobile_no value is lost. it is overwritten by phone value
Expected:
mobile_no value should be retained
