Commit Graph

74 Commits

Author SHA1 Message Date
Ankush Menat
8bbec42fa0
fix: undo changes to patch (#26983)
* fix: undo changes to patch

* ci: ignore empty body / head
2021-08-17 15:14:13 +05:30
Rucha Mahabal
39efc62b94
feat: Organizational Chart (#26893)
* feat: Organizational Chart

* feat: org chart mobile interactions

* feat(mobile): sibling node group expansion and rendering

* fix: expanded node group interactions and visibility

* feat: connectors for mobile node cards

* fix: don't refresh connections for same node

- remove all connectors while expanding a group node

* chore: create separate files for Desktop and Mobile view and bundle assets

* refactor: add options to chart

- method to return the node data

- wrapper for showing the hierarchy

* feat: setup node edit action

* fix: revert changes in employee descendants query

* refactor: use arcs instead of bezier curves for cleaner connectors

* feat: add arc to connectors in mobile view

* fix: edit node button overflowing

* fix: sider

* fix: removing orphaned connectors

* fix: unnecessary variables

* feat: handle multiple root / orphan nodes

* perf: Optimise Rendering

- optimise get_children function

- use promises instead of callbacks

- optimise selectors

- use const wherever possible

- use pure js instead of jquery for connectors for faster rendering

* fix: do not sort by number of connections

* feat: use icon for connections on mobile view

* fix: exclude active node while fetching sibling group

* fix: sibling group expansion not working for root nodes

* fix(mobile): collapsed nodes not expanding

* fix: sider

* test: UI tests for org chart desktop

* test: UI tests for org chart mobile

fix(mobile): detach node before emptying hierarchy

fix(mobile): sibling group not rendering for first level

* fix: sider

* ci(cypress): use env variable for key

documentation ref: https://docs.cypress.io/guides/guides/command-line\#cypress-run

* fix(tests): clear filter before typing

* fix(tests): apply filters correctly

* fix: tests

* fix: tests

* fix: tests

* fix(test): increase timeout for record creation

* fix: sider

* fix: sider

* feat: Expand All nodes option in Desktop view

* feat: add html2canvas for easily exporting html to images using canvas

* feat: Export chart option in desktop view

* fix(style): longer titles overflowing

* fix: remove unnecessary imports

* fix: test

* fix: make bundled assets for hierarchy chart

* fix(style): apply svg container margin only in desktop view

* fix: Nest `.level` class style under `.hierarchy` class (#26905)

fix: Nest `.level` class style under `.hierarchy` class

* fix: add z-index to filter to avoid svg wrapper overlapping

* fix: expand all nodes not working when there are only 2 levels

- added dom freeze while expanding all nodes and exporting

* fix: test

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2021-08-16 20:42:23 +05:30
Ankush Menat
2a43fe1a22
ci: ignore backports while checking docs (#26962)
[skip ci]
2021-08-16 18:03:21 +05:30
Rucha Mahabal
4981746b9a
Merge branch 'develop' into org-chart-develop 2021-08-15 20:50:56 +05:30
Ankush Menat
8a6b82b196
ci: ignore js files in unittests (#26934)
* ci: ignore js files in unittests

- Avoid running python unittests on PRs that ONLY change JS files.

* ci: ignore md files in test workflows
2021-08-13 12:59:27 +05:30
Rucha Mahabal
9dfddca22e ci(cypress): use env variable for key
documentation ref: https://docs.cypress.io/guides/guides/command-line\#cypress-run
2021-08-10 17:56:23 +05:30
Ankush
0bb60b37df
chore: add timeout to GHA workflows (#26714) 2021-07-29 17:15:12 +05:30
Ankush
e906acdc49
chore: change location of backport action (#26705) 2021-07-29 13:56:21 +05:30
Ankush
057a0a9842
ci: auto backport squashed commits based on labels (#26622) 2021-07-25 12:49:05 +05:30
Ankush Menat
28d52c4a95
chore: remove warning rules
semgrep-action doesn't consider severity, hence ignoring these rules for now.
2021-07-21 19:54:06 +05:30
Suraj Shetty
47f200a70d
chore: Update stale.yml
reduce `daysUntilStale` & `daysUntilClose` to keep the contributors active.
2021-07-20 16:13:49 +05:30
Ankush
a6d80dcc2a
chore: disable semgrep on push events (#26523) 2021-07-16 13:01:57 +05:30
Ankush
1b5f3cf605
ci: make semgrep ignore existing errors (#26516) 2021-07-15 19:30:05 +05:30
Ankush Menat
203c2b2292 ci: show bench logs if ui test fails 2021-07-12 10:09:50 +05:30
Ankush Menat
a68344fe8a refactor: extend commands from frappe 2021-07-01 21:26:18 +05:30
Ankush Menat
3f14b92e2c ci: UI tests workflow 2021-07-01 21:26:18 +05:30
Suraj Shetty
e8e4841e5e ci: Build frappe assets
- Build frappe assets since it is used for print views
2021-06-17 20:23:18 +05:30
Gavin D'souza
c68006b607 ci: Update ERPNext backup patch test >= v10
* Generated v10 backup archive
    * used old v7 erpnext backup hosted via build.erpnext.com
    * upgraded to v10 frappe + erpnext
* Hosted backup on https://erpnext.com/files/v10-erpnext.sql.gz
2021-06-04 11:49:56 +05:30
Suraj Shetty
5b17f335d1
ci: Add coveralls_repo_token env variable 2021-06-01 08:18:56 +05:30
Nabin Hait
a3d1b6973a fix: merge conflict 2021-05-31 11:21:33 +05:30
Suraj Shetty
97687839b0
ci: Run mariadb tests after PR merge for coverage badge 2021-05-28 13:39:53 +05:30
Ankush Menat
073dcf7e42
ci(semgrep): fix false positives (#25823) 2021-05-25 14:06:10 +05:30
Suraj Shetty
28fdb2e6fa ci: Update Python version to 3.7 2021-05-12 23:13:11 +05:30
Suraj Shetty
1f025a84f5 ci: Update frappe branch 2021-05-12 18:14:22 +05:30
Ankush Menat
b1f8c80be3
ci: enable semgrep check on v13 branches and update rules (#25647)
* ci: enable semgrep on v13 branches

* ci: break semgrep steps for nicer output

* ci: update semgrep rules inline with frappe repo
2021-05-11 18:27:20 +05:30
Suraj Shetty
042118aafd ci: Use only 3 containers for now 2021-05-11 10:09:06 +05:30
Suraj Shetty
6408367285 ci: Add test orchestrator URL 2021-05-10 23:48:37 +05:30
Suraj Shetty
5ce2da8bed fix: Pass ORCHESTRATOR_URL via secrets 2021-05-10 16:13:43 +05:30
Suraj Shetty
dfb8aa017d ci: Check limits 2021-05-09 14:38:54 +05:30
Suraj Shetty
7044bcfaab ci: Try parallel testing with orchestrator 2021-05-09 11:29:00 +05:30
Suraj Shetty
d27e70a67a ci: Fix coveralls 2021-05-08 16:02:40 +05:30
Suraj Shetty
622bf077e7 ci: Disble failfast temporarily 2021-05-08 13:51:34 +05:30
Suraj Shetty
ccf6249bfb chore: Debug 2021-05-08 00:05:48 +05:30
Suraj Shetty
490aed2a16 chore: Debug 2021-05-08 00:04:34 +05:30
Suraj Shetty
5117cbc08c ci: Enable coveralls 2021-05-07 00:32:00 +05:30
Suraj Shetty
5f7546d876 chore: Debug 2021-05-06 15:13:09 +05:30
Suraj Shetty
af4af7737f chore: Debug 2021-05-06 13:05:03 +05:30
Suraj Shetty
ee35444c3f fix: Frappe branch 2021-05-04 18:58:20 +05:30
Suraj Shetty
cd8ee8ea97 ci: Try Parallel tests 2021-05-04 18:36:45 +05:30
Mohammad Hasnain Mohsin Rajan
0dc00219e8
fix: coveralls different services for different events (#25513) 2021-04-29 15:21:16 +05:30
Mohammad Hasnain Mohsin Rajan
c9187b00af
fix: change coveralls version (#25499) 2021-04-28 13:32:27 +05:30
Rohan Bansal
524b81abd9 feat: manage Python 3 compatiblity with dependencies 2021-04-20 14:13:55 +05:30
Ankush Menat
c28fcba779
ci(semgrep): add correctness rule for on_cancel
Changes done to doctype object in `on_submit` are not commited to
database. Add rule to catch similar bugs.
2021-04-18 13:22:19 +05:30
Ankush Menat
67e647232c
ci(semgrep): Add semgrep testing (#24871)
Adds semgrep testing in CI.

Refer to:
- https://github.com/frappe/frappe/pull/12524
- https://github.com/frappe/frappe/pull/12577
2021-04-16 21:44:49 +05:30
Mohammad Hasnain Mohsin Rajan
192ab05869
ci: use ubuntu 18 specifically (#24904) 2021-03-18 17:12:12 +05:30
Sagar Vora
c647b6088a
ci: update badge in README and add push event trigger (#24911) 2021-03-17 20:04:59 +05:30
Sagar Vora
19bb8c1137
ci: get branch name from GITHUB_REF if GITHUB_BASE_REF not available (#24913) 2021-03-17 20:03:54 +05:30
Mohammad Hasnain Mohsin Rajan
46d5431bad
fix: Github Action not failing when tests fail (#24867)
Co-authored-by: Sagar Vora <sagar@resilient.tech>
2021-03-15 11:17:19 +05:30
Mohammad Hasnain Mohsin Rajan
0f60f08f3e
ci: Port CI test from Travis to Github Actions (#24846) 2021-03-12 14:09:52 +05:30
Suraj Shetty
8586c08639 chore: Update translation syntax checker 2021-02-01 20:09:42 +05:30