Ankush Menat
a3ea985348
refactor: Use db.set_single_value ( #35668 )
...
I just applied semgrep autofix. Untested completed, review before merging.
```yaml
- id: frappe-set-value-semantics
patterns:
- pattern-either:
- pattern: frappe.db.set_value($DOCTYPE, None, $...AFTER)
- pattern: frappe.db.set_value($DOCTYPE, $DOCTYPE, $...AFTER)
fix: frappe.db.set_single_value($DOCTYPE, $...AFTER)
message: |
If $DOCTYPE is a single doctype then using `frappe.db.set_value` is discouraged for setting values in DB. Use db.set_single_value for single doctype instead.
languages: [python]
severity: ERROR
```
2023-06-13 17:30:38 +05:30
Anand Baburajan
7bd369c49b
fix: calculate wdv depr schedule properly for existing assets [dev] ( #35614 )
...
* fix: calculate wdv depr schedule properly for existing assets
* fix: calculate wdv depr schedule properly for existing assets properly
* chore: properly call _get_pro_rata_amt
2023-06-09 12:53:10 +05:30
Rohit Waghchaure
42b229435c
fix: stock reco test case for serial and batch bundle
2023-06-02 17:14:18 +05:30
Rohit Waghchaure
26b39ac7f4
fix: travis for asset capitalization and asset repair
2023-06-02 17:14:18 +05:30
Rohit Waghchaure
440510337c
fix: travis
2023-06-02 17:14:16 +05:30
Rohit Waghchaure
16f26fb3d8
refactor: serial and batch package creation for finished item and cleanup code
2023-06-02 17:14:15 +05:30
Ankush Menat
4bdd276f74
Merge pull request #35409 from nabinhait/workspace-cleanup
...
refactor: Workspace cleanup
2023-05-31 16:40:26 +05:30
Sagar Vora
517d8a03ec
chore: remove whitelisting for method not accessed from UI
2023-05-31 14:39:03 +05:30
Anand Baburajan
dbdc420066
fix: allow assets with depr entries to be cancelled ( #35477 )
...
fix: allow asset with depr entries to be cancelled
2023-05-30 16:28:57 +05:30
Nabin Hait
243c49c550
refactor: Workspace cleanup
2023-05-30 13:17:59 +05:30
Anand Baburajan
ae26d72f7f
fix: monthly wdv depr schedule for existing assets [dev] ( #35460 )
...
fix: monthly wdv depr schedule for existing assets
2023-05-29 23:18:07 +05:30
Anand Baburajan
edb7b0db8f
fix: incorrect depr schedule and posting dates on selling of existing assets [dev] ( #35398 )
...
* fix: calc depr amount properly on selling of existing assets and fix incorrect posting dates
* chore: get number_of_depreciations_booked properly
* chore: fix test_gle_made_by_asset_sale_for_existing_asset
2023-05-24 12:29:46 +05:30
Anand Baburajan
8c53e0f004
fix: depreciation schedule for existing assets [dev] ( #35256 )
...
* fix: depreciation schedule for existing assets
* chore: correct logic for existing assets and fix test
* chore: properly check if depr amount is non zero
2023-05-17 22:29:09 +05:30
mergify[bot]
49674585a5
fix: handle expected_value_after_useful_life properly in asset value adjustment (backport #35117 ) ( #35119 )
...
fix: handle expected_value_after_useful_life properly in asset value adjustment (#35117 )
(cherry picked from commit 80230fec3ef079b75825447a61836f8a9ce64f57)
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com>
2023-05-01 19:59:58 +05:30
Ernesto Ruiz
c4512d552e
chore: Add translate function to Depreciation Journal Entry Remark ( #35022 )
...
chore: Add translate function to Depreciation Journal Entry Remark
2023-04-25 20:56:53 +05:30
Anand Baburajan
e08d636bf7
fix: use filter_by_finance_book instead of only_depreciable_assets in fixed asset register ( #35031 )
...
fix: use filter_by_finance_book instead of only_depreciable_assets
2023-04-25 15:16:50 +05:30
Anand Baburajan
ca388ed9cd
fix: value of depreciable assets not updating after manual depr entry [develop] ( #35020 )
...
* fix: value of depreciable assets not updating after manual depr entry
* chore: add asset depr schedule to jv's ignore_doctypes_on_cancel_all
2023-04-25 12:45:05 +05:30
Anand Baburajan
c957a5cd2e
fix: provide filter by depreciable assets in fixed asset register ( #34803 )
2023-04-11 12:16:07 +05:30
Anand Baburajan
29e025c012
Merge pull request #34778 from AnandBaburajan/asset_value_adjust_get_depr_amt
...
fix: improper usage of get_depreciation_amount in asset_value_adjustment
2023-04-07 16:48:06 +05:30
Anand Baburajan
90dee8b663
Merge pull request #34735 from ihosseinu/asset_movement_translation_fix
...
'Make Asset Movement' button translation fix in asset_list.js
2023-04-07 15:30:26 +05:30
anandbaburajan
984905109d
fix: improper usage of get_depreciation_amount in asset_value_adjustment
2023-04-07 15:23:02 +05:30
Anand Baburajan
5cc3c08059
fix: asset monthly WDV and DD schedule and refactor [develop] ( #34646 )
...
* fix: monthly wdv and dd schedule
* chore: minor rename
* chore: fix tests
2023-04-05 11:46:31 +05:30
Hossein Yousefian
b70615ef18
'Make Asset Movement' button translation fix
2023-04-04 14:49:43 +03:30
Anand Baburajan
d999dea3e4
chore: improve asset depr posting failure msg ( #34661 )
...
* chore: improve asset depr posting error msg
* chore: add period
* chore: improve msg
2023-03-30 16:38:37 +05:30
anandbaburajan
af3e807607
chore: auto fill asset name and available for use date
2023-03-30 15:28:59 +05:30
anandbaburajan
2b0470d1f5
fix: incorrect arg name in asset value adjustment
2023-03-30 12:50:33 +05:30
Bevan Tony Medrano
ddc3050e99
Asset maintenance task add dropdown "3 Yearly" ( #34607 )
...
* feat(asset_maintenance.json):Add 3 yearly in periodicity dropdown
* add server side implications for 3 yearly
(cherry picked from commit 625b8e800537cceabffda50a0bbed1effc2e2aa5)
2023-03-29 12:16:03 +00:00
Anand Baburajan
e6b0196493
fix: recalculate wdv rate after asset repair [develop] ( #34570 )
...
fix: recalculate wdv rate after asset repair
2023-03-23 21:10:22 +05:30
Anand Baburajan
6d6a7bcb50
fix: incorrect depr schedules after asset repair [develop] ( #34544 )
...
* fix: backport missing changes from #30838
* fix: incorrect schedule after repair
2023-03-21 20:07:27 +05:30
Anand Baburajan
b6b8392413
fix: refactor asset depr schedule and remove unnecessary depr method ( #34434 )
...
* fix: remove depr method from depr schedule and refactor assetdeprsch
* chore: use assetdeprsch's depr method, not deprschedule's
* fix: use default 0 value for NDB and OAD
* chore: fix rounded numbers
* chore: correct rounding in test_website_item_price_for_logged_in_user
2023-03-16 18:18:47 +05:30
anandbaburajan
dd74839eba
fix: manual depr schedule
2023-02-26 17:36:36 +05:30
anandbaburajan
76861eb332
fix: fiscal year error for existing assets in fixed asset register
2023-02-21 13:04:01 +05:30
anandbaburajan
e50bd52162
fix: asset repair status after deletion and asset status after manual depr entry
2023-02-17 15:32:24 +05:30
anandbaburajan
c533213225
fix: opening_accumulated_depreciation and precision in charts
2023-02-13 17:22:31 +05:30
anandbaburajan
e5da0d7a63
chore: refactor AssetDepreciationSchedule
2023-02-03 22:23:17 +05:30
anandbaburajan
8ea9e4576f
fix: asset value for manual depr entries
2023-02-03 21:43:18 +05:30
barredterra
11d165c274
fix(Fixed Asset Register): error when selecting more than one fiscal year
2023-01-30 19:33:58 +01:00
anandbaburajan
f487660a7c
fix: disposal_was_made_on_original_schedule_date
2023-01-30 21:33:43 +05:30
anandbaburajan
86cf5c89ab
chore: add depr_entry_posting_status in create_asset
2023-01-17 00:31:21 +05:30
anandbaburajan
cebb5a42f4
chore: add missing /n in options
2023-01-17 00:26:50 +05:30
anandbaburajan
a144bb01fe
chore: stying
2023-01-16 23:26:39 +05:30
anandbaburajan
cf7b43f7f0
fix: handle_post_depr_entries_fail, show error alert and send email
2023-01-16 23:10:02 +05:30
anandbaburajan
61cd0f98fd
fix: asset repair link and improve notes
2023-01-16 18:35:40 +05:30
Poruri Sai Rahul
8119442c94
FIX: Remove usage of "six.string_types" ( #33603 )
...
FIX: Remove usage of six.string_types
six is no longer a dependency
2023-01-16 08:47:28 +05:30
anandbaburajan
aa1f2a7297
fix: asset value in fixed asset register
2023-01-10 23:05:09 +05:30
anandbaburajan
312e51e8b2
chore: more refactoring and adding test for duplicate asset_depr_schedule
2023-01-03 15:09:04 +05:30
anandbaburajan
7c5168eeac
chore: allow manually submitting and cancelling asset depr schedule
2023-01-02 17:07:28 +05:30
anandbaburajan
482116db9f
chore: improve tests
2022-12-27 10:03:32 +05:30
anandbaburajan
6d791cabd1
chore: more refactoring
2022-12-26 22:13:11 +05:30
anandbaburajan
03662be150
chore: have different functions for draft. active and cancelled depr schedules
2022-12-25 18:05:19 +05:30
