marination
7e207c8901
fix: Call Redisearch index creation functions on enabling redisearch in settings
2022-03-31 16:29:18 +05:30
Marica
901d8eac57
Merge pull request #30509 from marination/buying-validate-items
...
fix: Add non-existent Item check and cleanup in `validate_for_items`
2022-03-31 14:52:34 +05:30
Saqib Ansari
9af353ffa9
Merge pull request #30461 from nextchamp-saqib/fix-asset-warehouse-validation
...
fix(asset): do not validate warehouse on asset purchase
2022-03-31 14:15:16 +05:30
Deepesh Garg
544533ced2
Merge pull request #30486 from deepeshgarg007/account_currenct_change_test
...
fix: Account currency validation
2022-03-31 13:39:04 +05:30
marination
93f6346cea
fix: (test) change expected exception due to https://github.com/frappe/frappe/pull/16454
2022-03-31 13:07:51 +05:30
Saqib Ansari
4623a1bc57
fix(test): Item MacBook does not exist
2022-03-31 12:48:00 +05:30
marination
982a246eec
fix: Add non-existent Item check and cleanup in validate_for_items
...
- Added a validation if invalid item code ia passed via data import/API, etc.
- Used DB APIs instead of raw sql
- Separated checks into separate functions
- Added return types to functions
- Better variable naming and removed redundant utils import in function
2022-03-31 11:47:20 +05:30
Saqib Ansari
199a6da960
perf: skip warehouse validation for non-stock items
2022-03-31 11:41:52 +05:30
Ankush Menat
b981fae5a4
fix: remove naming series from bin, repost queue ( #30497 )
...
Removing naming series from:
1. Bin
2. Repost queue
These doctypes are not user facing and dont really need naming series.
Current implementation of naming makes stock transaction sequential if
these documents are to be created during submission.
2022-03-30 21:46:15 +05:30
Deepesh Garg
45f78977bf
Merge pull request #30493 from nabinhait/party-account-in-ar-ap-report
...
feat: Receivable/Payable Account column and filter in AR/AP report
2022-03-30 21:16:32 +05:30
Deepesh Garg
d93edbc859
fix: make test record
2022-03-30 21:07:56 +05:30
mergify[bot]
89a9afab94
fix: cast array slice index integer while splitting serial_nos array ( #30468 ) ( #30496 )
...
(cherry picked from commit 3f3717952c94af428c3d4c919aceb6b8cbae7679)
Co-authored-by: Anoop <anoop@earthianslive.com>
2022-03-30 17:00:28 +05:30
Sagar Vora
7bece37918
fix: update get_cached_value usage based on changes in definition
2022-03-30 15:35:56 +05:30
Saqib Ansari
5408980223
Merge pull request #30453 from rahib-hassan/fix-paymentorder-row-delete
...
fix: enable row deletion in reference table
2022-03-30 15:31:54 +05:30
Saqib Ansari
291415d255
Merge pull request #30453 from rahib-hassan/fix-paymentorder-row-delete
...
fix: enable row deletion in reference table
2022-03-30 15:00:16 +05:30
Saqib Ansari
03e6a6c699
Merge branch 'develop' into fix-asset-warehouse-validation
2022-03-30 14:58:49 +05:30
Rucha Mahabal
9ff1904aec
fix: explicitly check if additional salary is recurring while fetching components for payroll ( #30489 )
2022-03-30 14:47:11 +05:30
Ankush Menat
8ab226a2fc
test: add class to uniquely id item dashboard ( #30487 )
2022-03-30 13:20:54 +05:30
Deepesh Garg
d4cc7c553e
fix: Account currency validation
2022-03-30 12:43:18 +05:30
Marica
7e719a12f1
Merge pull request #30377 from marination/stock-entry-items-idx
...
fix: Dont set `idx` while adding WO items to Stock Entry
2022-03-30 11:14:18 +05:30
Saqib Ansari
87dc9c6331
Merge pull request #30470 from nextchamp-saqib/fix-dn-credit-limit-validation
...
fix: credit limit validation in delivery note
2022-03-30 11:08:25 +05:30
marination
b5ad626d23
fix: Linter
2022-03-30 10:22:05 +05:30
Saqib Ansari
6528218ac3
perf: skip warehouse validation for non-stock items
2022-03-29 18:43:33 +05:30
Ankush Menat
b80fac03af
fix: validate 0 transfer qty in stock entry ( #30476 )
2022-03-29 17:19:22 +05:30
Ankush Menat
b12fe0f15b
fix: dont check for failed repost while freezing ( #30472 )
...
[skip ci]
2022-03-29 13:54:26 +05:30
marination
fa3b953cf7
test: idx mapping correctness
2022-03-29 13:54:14 +05:30
Saqib Ansari
c122882884
fix: credit limit validation in delivery note
2022-03-29 13:36:00 +05:30
Marica
88a460b54e
Merge branch 'develop' into stock-entry-items-idx
2022-03-29 13:18:08 +05:30
Ankush Menat
0cb9cdb414
Merge branch 'develop' into fix-asset-warehouse-validation
2022-03-29 11:48:35 +05:30
Ankush Menat
76dce2eddc
fix: use name for links not item_code ( #30462 )
2022-03-29 11:21:03 +05:30
Saqib Ansari
b60fad6113
Merge branch 'develop' of https://github.com/frappe/erpnext into fix-asset-warehouse-validation
2022-03-29 10:50:21 +05:30
Saqib Ansari
136466d255
fix(asset): do not validate warehouse on asset purchase
2022-03-29 10:47:27 +05:30
marination
639d380c1f
chore: Remove redundant idx query and value setting
...
- idx can be removed from `select_columns` as it is already in the main query
- setting idx to '' is not required as it is not used further
2022-03-28 21:00:00 +05:30
Ankush Menat
40d7418dca
Merge branch 'develop' into stock-entry-items-idx
2022-03-28 20:21:21 +05:30
Ankush Menat
3821a97a75
Merge branch 'develop' into mergify/bp/develop/pr-30395
2022-03-28 20:14:19 +05:30
Ankush Menat
494bd9ef78
style: format code with black
2022-03-28 18:52:46 +05:30
Ankush Menat
8dff4d66a4
fix: bom valuation - handle lack of LPP ( #30454 )
2022-03-28 18:18:23 +05:30
Sagar Vora
77c36f6d22
fix: set options for Currency field Incoming Rate ( #30384 )
2022-03-28 17:55:23 +05:30
Raffael Meyer
c01fe74cf0
fix(patch): fix failing patches ( #30427 )
...
* patch: reload Opportunity
* patch: reload child tables before doctype
2022-03-28 17:53:54 +05:30
Saqib Ansari
eea183957a
Merge pull request #30419 from nextchamp-saqib/fix-item-tax-template-patch
...
fix: move item tax to item tax template patch
2022-03-28 17:34:31 +05:30
rahib-hassan
500870b2b0
fix: enable row deletion in reference table
2022-03-28 15:25:01 +05:30
Ankush Menat
b58b1343bb
refactor: dont harcode "serial_no" field
2022-03-28 12:07:00 +05:30
Ankush Menat
98468fab18
fix: ignore circular dependencies on barcode scan
2022-03-28 12:07:00 +05:30
Ankush Menat
806f420ddd
fix: revert global flag added for erasing barcode
...
This looked like a hack and doesn't even work anyway! how can row level
barcode-item relation be maitnained on entire form?
2022-03-28 12:07:00 +05:30
Ankush Menat
17a2ceb5d1
style: prettier js
2022-03-28 12:07:00 +05:30
Ankush Menat
9f0e7949aa
fix: clean up if item is not found
2022-03-28 12:07:00 +05:30
Ankush Menat
32e44f5121
fix: correctly capture first serial no
2022-03-28 12:07:00 +05:30
Ankush Menat
b3c604d679
refactor: dont hardcode child table name
2022-03-28 12:07:00 +05:30
Ankush Menat
3a8656b3c8
refactor: split data update responsibilty to multiple functions
...
Apply "single responsibilty principle"
2022-03-28 12:07:00 +05:30
Ankush Menat
c34847e801
refactor: dont hardcode child table "items"
2022-03-28 12:07:00 +05:30
