Suraj Shetty
23bc87f2aa
Merge branch 'develop' of https://github.com/frappe/erpnext into move-exotel-to-separate-app
2023-07-14 16:21:48 +05:30
Anand Baburajan
988d755906
refactor!: removing loan management module ( #35522 )
...
* chore: resolving conflicts
* refactor: bank_clearance and add hook for get_payment_entries_for_bank_clearance
* refactor: bank_reconciliation_tool and add hook for get_matching_vouchers_for_bank_reconciliation
* fix: remove sales invoice from bank_reconciliation_doctypes and use hook for voucher clearance
* refactor: remove loan tests from test_bank_transaction
* refactor: bank_clearance_summary and add hook for get_entries_for_bank_clearance_summary
* refactor: removed test_bank_reconciliation_statement
* refactor: bank_reconciliation_statement and add hook for get_amounts_not_reflected_in_system_for_bank_reconciliation_statement
* refactor: add missing hook and patches for module removal and deprecation warning
* refactor: remove loan management translations
* chore: add erpnext tests dependent on lending
2023-06-30 11:02:49 +05:30
Gursheen Kaur Anand
5113a417a1
fix!: UX of supplier linking with supplier users on portal pages ( #35836 )
...
* fix: create and add Portal Users child table in Supplier/Customer
Issue #35772
* fix: modify the original permission check hook
* fix: auto-add role for portal users
* fix: added patch for auto-populating portal users
* fix: modify patch to fetch users correctly
* fix: remove unnecessary code for updating naming_series
* fix(UX): show portal user in list view
Also split columns to reduce whitespace.
* refactor: simpler role checking
* fix: consider parenttype while fetching portal user
* refactor: simpler code, rename variable
* test: supplier portal user can access their docs
* refactor: only add role if not added
* refactor: rename and move patch to supplier
* refactor: dont add role if no perm or existing doc
* fix: add role before save
* refactor: run query directly
* refactor: split patch and apply roles
- if role isn't present dont add portal user
- ignore failure as it's not critical
* test: fix permission creation for webform test
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-06-28 11:22:40 +05:30
Ankush Menat
a3ea985348
refactor: Use db.set_single_value ( #35668 )
...
I just applied semgrep autofix. Untested completed, review before merging.
```yaml
- id: frappe-set-value-semantics
patterns:
- pattern-either:
- pattern: frappe.db.set_value($DOCTYPE, None, $...AFTER)
- pattern: frappe.db.set_value($DOCTYPE, $DOCTYPE, $...AFTER)
fix: frappe.db.set_single_value($DOCTYPE, $...AFTER)
message: |
If $DOCTYPE is a single doctype then using `frappe.db.set_value` is discouraged for setting values in DB. Use db.set_single_value for single doctype instead.
languages: [python]
severity: ERROR
```
2023-06-13 17:30:38 +05:30
Suraj Shetty
3593573ed2
Merge branch 'develop' of https://github.com/frappe/erpnext into move-exotel-to-separate-app
2022-07-22 12:24:20 +05:30
Rucha Mahabal
d8aa1c59f1
Merge branch 'develop' into hr-separation
2022-07-12 19:27:19 +05:30
Rucha Mahabal
ef02e58859
Merge branch 'develop' into hr-separation
2022-07-07 13:46:54 +05:30
Sagar Sharma
f9885746a8
Merge branch 'develop' into subcontracting
2022-07-07 09:56:23 +05:30
Rucha Mahabal
6a65c8aff4
Merge branch 'develop' into hr-separation
2022-06-28 11:51:59 +05:30
s-aga-r
f6ef3068d7
Merge branch 'develop' into subcontracting
2022-06-20 23:10:31 +05:30
Sagar Vora
ec9861266e
Merge remote-tracking branch 'upstream/develop' into remove-india
2022-06-19 22:57:22 +05:30
Ankush Menat
6f2086d770
test: verify that all patches exist in patches.txt ( #31371 )
...
* chore: delete orphaned patches
* test: orphan/missing entries in patches.txt
[skip ci]
2022-06-16 22:15:06 +05:30
Rucha Mahabal
3fe2ef6790
chore: update import paths for HR
2022-06-15 12:43:45 +05:30
Marica
f5ebaed191
Merge branch 'develop' into subcontract-supplied-items
2022-06-13 18:32:43 +05:30
marination
b8f468cb4f
test: PO Supplied Qty reset on cancel/submit
2022-06-13 18:31:35 +05:30
Sagar Sharma
f755430098
Merge branch 'develop' into subcontracting
2022-06-13 03:00:53 -07:00
Gavin D'souza
e9af68e947
test: Remove deprecated as_tuple kwarg in FrappeTestAPI.post
2022-06-13 14:26:59 +05:30
Rucha Mahabal
512c82f76d
chore: Update imports/paths for doctypes moved to erpnext setup module
2022-06-10 15:06:54 +05:30
s-aga-r
992ba974e2
Merge branch 'develop' into subcontracting
2022-06-03 13:25:49 +05:30
Ankush Menat
c02598a51b
chore: remove framework tests from erpnext
...
Similar tests exist in FW and this is failing because someone updated
the translations
2022-05-30 11:12:17 +05:30
Sagar Sharma
4ff734c25a
Merge branch 'develop' into subcontracting
2022-05-25 12:32:33 +05:30
Ankush Menat
a36174afdf
test: search test failing because of stale data ( #31098 )
2022-05-23 15:12:11 +05:30
Sagar Sharma
213113bc00
Merge branch 'develop' into subcontracting
2022-05-20 12:13:13 +05:30
Sagar Sharma
409df263e8
refactor!: change "is_subcontracted" field type from "Select" to "Check"
2022-05-20 10:45:33 +05:30
Ankush Menat
3263ecf54c
test: check translation files ( #31006 )
2022-05-13 16:38:04 +05:30
Suraj Shetty
ec1607e825
Merge branch 'develop' of https://github.com/frappe/erpnext into move-exotel-to-separate-app
2022-05-08 16:10:55 +05:30
Suraj Shetty
53e4fee4db
refactor: Remove exotel
...
Move it to separate app
2022-05-08 16:04:14 +05:30
Ankush Menat
ad7c113c0d
test: activation
2022-05-05 11:02:23 +05:30
Deepesh Garg
429361ce87
chore: Remove domains from Setup
2022-04-27 13:32:51 +05:30
Suraj Shetty
ff41b8da4e
fix: Update received_by if "to" is changed
2022-04-13 20:12:08 +05:30
Suraj Shetty
cef28df8db
test: Do not overwrite frappe.form_dict to retain proxy reference
...
Set frappe.local.form_dict instead
2022-04-13 19:10:19 +05:30
Suraj Shetty
7ff5bc9e3d
test: Clean up form_dict
...
To avoid failures like
https://github.com/frappe/erpnext/runs/5887687369?check_suite_focus=true#step:12:783
2022-04-08 21:33:29 +05:30
Suraj Shetty
117e5d05a3
Merge branch 'develop' into exotel-fixes
2022-04-04 18:21:46 +05:30
Suraj Shetty
40d33b5fec
test: Use FrappeAPITestCase to track coverage
2022-04-04 11:15:29 +05:30
Suraj Shetty
f4b8573e64
test: Fix erroneous code
2022-04-04 09:31:15 +05:30
Suraj Shetty
0e9ebad9c6
test: Refactor exotel test setup
...
- Remove unnecessary code
- Move test data to separate file
- Make proper test assertions
2022-04-04 07:23:08 +05:30
Subin Tom
e57e7bb02c
fix: added tests(fixed)
2022-04-02 17:16:56 +05:30
Sagar Sharma
d074c93ac7
refactor!: change "is_subcontracted" field type from "Select" to "Check"
2022-04-01 13:22:44 +05:30
Ankush Menat
494bd9ef78
style: format code with black
2022-03-28 18:52:46 +05:30
Ankush Menat
10d5fb8cd1
test: check printviews for all docs
2022-03-25 10:51:19 +05:30
Sagar Vora
3d45f3a6a8
Merge remote-tracking branch 'upstream/develop' into remove-india
2022-03-03 10:20:50 +05:30
Saqib Ansari
056a0ec421
Merge pull request #30034 from nextchamp-saqib/fix-pos-flaky-test
...
fix(test): flaky test_point_of_sale
2022-03-01 15:32:33 +05:30
Saqib Ansari
47fe87a72f
fix(test): flaky test_point_of_sale
2022-03-01 14:56:24 +05:30
Ankush Menat
b0d1e6db54
test(refactor): use FrappeTestCase
2022-02-28 17:23:32 +05:30
Marica
e8e9bc4daa
Merge pull request #29733 from dj12djdjs/fix-user-unique-cart
...
fix(e-commerce): Unique Shopping Cart Per Logged In User
2022-02-25 16:35:14 +05:30
Sagar Vora
5159e2e6c5
refactor: remove India specific code
2022-02-25 11:36:18 +05:30
Ankush Menat
afc81351b7
test: only test erpnext doctypes
...
Co-authored-by: gavin <gavin18d@gmail.com>
2022-02-21 15:32:28 +05:30
Ankush Menat
e3ea431ef3
test: test all form loads
2022-02-21 15:32:28 +05:30
Devin Slauenwhite
aeee334843
Merge remote-tracking branch 'upstream/develop' into feat-user-unique-cart
2022-02-09 11:08:24 -05:00
Devin Slauenwhite
d636c3fb04
test: many users linked to customer shopping cart
2022-02-09 10:52:38 -05:00
