Deepesh Garg
c70abaa43a
Merge pull request #36684 from deepeshgarg007/gl_transaction_currency
...
feat: Transaction currency columns in GL report
2023-08-17 16:06:23 +05:30
Shariq Ansari
5d9dde92fa
Merge pull request #36685 from shariquerik/api-fix
2023-08-17 13:09:14 +05:30
Shariq Ansari
21c1141fdb
chore: linter fix
2023-08-17 12:14:13 +05:30
Shariq Ansari
7ec6909159
fix: check tax and charges if it is passed
2023-08-17 11:59:47 +05:30
Deepesh Garg
35be3ac5a1
feat: Transaction currency columns in GL report
2023-08-17 11:31:40 +05:30
ruthra kumar
a0fc68538f
refactor: toggle for negative rates in Selling Settings
2023-08-15 07:34:33 +05:30
Anand Baburajan
627986efa1
fix: wrap none type rate under flt ( #36602 )
2023-08-11 18:01:27 +05:30
ruthra kumar
11cd163db7
fix: unhide uom and stock_uom fields in print view
2023-08-10 14:40:47 +05:30
Deepesh Garg
492ea3bcc8
fix: Debit credit difference while submitting Sales Invoice ( #36523 )
...
* fix: Debit credit difference while submitting Sales Invoice
* test(fix): Update gl entry comparison
* test(fix): Update gl entry comparison
2023-08-08 11:39:44 +05:30
s-aga-r
758b31d895
fix: get incoming rate instead of BOM rate ( #36496 )
...
* fix: get incoming rate instead of BOM rate
* test: add test case for SCR rm rate
2023-08-05 19:28:38 +05:30
ruthra kumar
466734fb4b
fix(test): replace hardcoded reference to adv with dynamic one
2023-08-05 14:11:57 +05:30
Gursheen Kaur Anand
edbefee10c
fix: payment allocation in invoice payment schedule ( #36440 )
...
* fix: payment allocation in invoice payment schedule
* test: payment allocation for payment terms
* chore: linting issues
2023-08-04 17:49:17 +05:30
Deepesh Garg
04820b14da
Merge pull request #35644 from ruthra-kumar/book_gain_loss_in_je
...
refactor: booking exchange gain/loss amount through journal
2023-08-04 09:53:26 +05:30
Devin Slauenwhite
dedf24b86d
fix: don't allow negative rates ( #36027 )
...
* fix: don't allow negative rate
* test: don't allow negative rate
* fix: only check for -rate on items child table
2023-08-02 16:26:55 +05:30
Deepesh Garg
c6b024c34b
Merge pull request #36167 from barredterra/percentage-rounding
...
fix: rounding of percentage fields
2023-07-30 14:41:30 +05:30
ruthra kumar
46ea814400
chore: cancel gain/loss je while posting reverse gl
2023-07-28 08:34:36 +05:30
ruthra kumar
804afaa647
chore(test): use existing company for unit test
2023-07-27 09:30:38 +05:30
ruthra kumar
acc7322874
chore: add msgprint for exc JE
2023-07-27 07:52:01 +05:30
ruthra kumar
47bbb37291
chore: use frappetestcase
2023-07-27 05:54:13 +05:30
ruthra kumar
ae424fdfed
test: assert ledger after cr note cancellation
2023-07-26 22:33:58 +05:30
ruthra kumar
e3d2a2c5bd
test: cr notes against invoice
2023-07-26 22:33:58 +05:30
ruthra kumar
1ea1bfebc4
refactor: convert class method to standalone function
2023-07-26 22:33:58 +05:30
ruthra kumar
c0b3b069b5
refactor: split make_exchage_gain_loss_journal into smaller function
2023-07-26 22:33:58 +05:30
ruthra kumar
6628632fbb
chore: type info
2023-07-26 22:33:58 +05:30
ruthra kumar
70dd9d0671
chore(test): fix broken unit test
2023-07-26 22:33:58 +05:30
ruthra kumar
f3363e813a
test: journals against sales invoice
2023-07-26 22:33:58 +05:30
ruthra kumar
f4a65cccc4
refactor: handle diff amount in various names
2023-07-26 22:33:58 +05:30
ruthra kumar
5695d6a5a6
refactor: unit tests for journals
2023-07-26 22:33:58 +05:30
ruthra kumar
0567243772
refactor: dr/cr logic for journals as payments
2023-07-26 22:33:58 +05:30
ruthra kumar
73cc1ba654
refactor: assert payment ledger outstanding in both currencies
2023-07-26 22:33:58 +05:30
ruthra kumar
6e18bb6456
refactor: cancel gain/loss JE on Journal as payment cancellation
2023-07-26 22:33:58 +05:30
ruthra kumar
f119a1e115
refactor: linkage between journal as payment and gain/loss journal
2023-07-26 22:33:58 +05:30
ruthra kumar
cd42b26839
chore: code cleanup
2023-07-26 22:33:58 +05:30
ruthra kumar
78bc712756
refactor: only post on base currency for exchange gain/loss
2023-07-26 22:33:58 +05:30
ruthra kumar
389cadf157
refactor(test): assert Exc journal when reconciling Journa to invoic
2023-07-26 22:33:58 +05:30
ruthra kumar
ee3ce82ea8
chore: remove debugging statements and fixing failing unit tests
2023-07-26 22:33:58 +05:30
ruthra kumar
7b516f8463
refactor: exc booking logic for Journal Entry
2023-07-26 22:33:58 +05:30
ruthra kumar
34b5e849a2
chore: fix logic for purchase invoice and some typos
2023-07-26 22:33:58 +05:30
ruthra kumar
5e1cd1f227
test: different scenarios for exchange booking
2023-07-26 22:33:58 +05:30
ruthra kumar
81cd7873d3
refactor: book exchange gain/loss through journal
2023-07-26 22:33:58 +05:30
Smit Vora
1b8490dc98
Merge branch 'develop' into fix-tax-breakup-for-diff-tax-rates
2023-07-24 20:20:19 +05:30
Sagar Vora
4205f564a0
fix(regional): set frappe.flags.company temporarily, where required
2023-07-24 18:37:58 +05:30
DaizyModi
6f376cf103
fix: remove unused params
2023-07-24 18:02:42 +05:30
ruthra kumar
662ccd467c
fix: allocation logic on 'Get Outstanding Invoices' btn in PE
...
1. fixed broken `payment_term` filter in Payment References section
2. Throw error if user fails to select 'Payment Term' for an invoice
with 'Payment Term based allocation' enabled.
2023-07-23 11:37:27 +05:30
DaizyModi
653117c2a9
test: fix test case for itemised tax breakup
2023-07-21 17:56:33 +05:30
DaizyModi
b84deec601
fix: Correct Tax Breakup for different tax rates for same hsn code
2023-07-21 17:43:27 +05:30
mergify[bot]
b4db5e9561
fix: validate docs in closed accounting period on save ( #36157 )
...
fix: validate docs in closed accounting period on save (#36157 )
(cherry picked from commit 5985e02574e387ef92a2bf0a9d2d1b49ad57cdd3)
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com>
2023-07-18 17:40:49 +05:30
barredterra
ecaf0aba3c
fix: rounding of percentage fields
...
Always round with precision of 2
2023-07-17 16:45:11 +02:00
Deepesh Garg
ce9164ec69
fix: Validate for missing expense account ( #36078 )
...
* fix: Validate for missing expense account
* fix: Validate for missing expense account
2023-07-11 12:03:38 +05:30
rohitwaghchaure
06dcc4ed96
Merge pull request #36063 from rohitwaghchaure/fixed-valuation-for-dn-return
...
fix: Delivery Note return valuation
2023-07-10 17:48:41 +05:30
