Rohit Waghchaure
10558344b0
fix: timeout error in the repost item valuation
2021-06-03 16:34:31 +05:30
Marica
7437748a1d
Merge pull request #25805 from ankush/refactor_item
...
refactor: item doctype
2021-06-03 14:23:18 +05:30
Saqib Ansari
81b9a5ee47
fix(pos): cannot cancel consolidated sales invoice
2021-06-03 12:59:09 +05:30
Saqib Ansari
311b378328
fix(pos): searching items with barcode or serial no
2021-06-03 12:58:53 +05:30
rohitwaghchaure
40b90e5b6e
Merge pull request #25478 from noahjacob/prod_plan_feat
...
feat: Added check box to combine items with same BOM
2021-06-03 12:37:02 +05:30
Marica
e7d9200e0f
Merge pull request #25221 from Alchez/dev-quality-inspection-accounts
...
feat: create Quality Inspections from account and stock documents
2021-06-03 01:39:05 +05:30
barredterra
9affcd8f54
Merge branch 'version-13-hotfix' into item-tax-templates
2021-06-02 17:54:02 +02:00
Nabin Hait
88d94dbf0a
Merge pull request #25915 from rohitwaghchaure/fixed-work-order-no-able-to-select-item
...
fix: not able to select the item code in work order
2021-06-02 19:00:34 +05:30
Raffael Meyer
f6627550d1
fix: remove wrong tax_category
2021-06-02 15:17:00 +02:00
barredterra
3c748efae3
feat: add Item Tax Templates for german COAs "SKR03" and "SKR04"
2021-06-02 13:27:15 +02:00
barredterra
b6f27a4cae
feat: set is_default for german tax templates
2021-06-02 13:20:33 +02:00
barredterra
f259bf48aa
refactor: make tax category
2021-06-02 13:20:03 +02:00
barredterra
e3557ff131
Merge branch 'version-13-hotfix' into item-tax-templates
2021-06-02 12:17:27 +02:00
Rohan Bansal
a06ec03efc
test: add test for new QI function
2021-06-02 14:55:31 +05:30
Rohan Bansal
11aff80dea
Merge remote-tracking branch 'upstream/version-13-hotfix' into dev-quality-inspection-accounts
2021-06-02 14:22:32 +05:30
Rohit Waghchaure
721b4130db
fix: not able to select the item code in work order
2021-06-02 14:13:09 +05:30
Deepesh Garg
7c7c084159
fix: Check for tax category
2021-06-02 14:12:28 +05:30
Deepesh Garg
ca34eec2d6
Merge branch 'version-13-hotfix' of https://github.com/frappe/erpnext into bootstraped_gst_setup
2021-06-02 13:26:27 +05:30
Deepesh Garg
b3ed807b70
fix: Regional settings setup
2021-06-02 13:26:21 +05:30
Deepesh Garg
c6dcc9d94a
fix(India): Taxable value for invoices with additional discount
2021-06-01 13:13:04 +05:30
Rohit Waghchaure
6432aaa07a
feat: added reports to check incorrect qty and valuation for serialized items
2021-06-01 12:46:43 +05:30
Fisher Yu
865663857c
fix: chart of accounts importer always error ( #25882 )
...
* fix: chart of accounts importer always error
chart of accounts importer always error Parent Account Missing
* Update chart_of_accounts_importer.py
2021-06-01 12:15:58 +05:30
Ankush Menat
2c7fac0e76
fix: reload doc for possible future schema changes ( #25904 )
2021-06-01 11:56:00 +05:30
Deepesh Garg
2f5885627d
fix: Labeling and other fixes
2021-06-01 11:07:18 +05:30
Jannat Patel
1175e0686b
refactor: leave balance report ( #25771 )
...
* refactor: leave balance report
* refactor: sql to orm
2021-06-01 10:53:00 +05:30
Ganga Manoj
c8b34798fe
fix(Delivery Note): Assign Product Bundle's conversion_factor to Packed Items ( #25840 )
2021-06-01 10:44:26 +05:30
rohitwaghchaure
970f00922d
Merge pull request #25898 from anupamvs/stock-reconciliation
...
fix: featching serialized items
2021-05-31 20:00:35 +05:30
Jannat Patel
022b5c973a
fix: wrap dates in getdate for leave application ( #25899 )
...
* fix: wrap dates in getdate for leave application
* fix: translation issue
* fix: replaced today with getdate
2021-05-31 19:49:53 +05:30
Ganga Manoj
908b0090e9
fix: Create POS Invoice for Product Bundles ( #25847 )
...
Co-authored-by: Saqib <nextchamp.saqib@gmail.com>
2021-05-31 19:49:03 +05:30
Deepesh Garg
0ea6725baa
fix: Rename Loan Management workspace to Loans ( #25856 )
2021-05-31 19:48:31 +05:30
Anupam
0358b64743
fix: featching serialized items
2021-05-31 15:59:32 +05:30
Raffael Meyer
80540d38ba
fix: add_deduct_tax in Purchase Taxes setup ( #25871 )
2021-05-31 15:36:20 +05:30
Saqib
89f621baa4
fix(pos): closing entry shows incorrect expected amount ( #25868 )
2021-05-31 09:56:49 +05:30
Rucha Mahabal
3be28054de
refactor: Vehicle Expenses Report ( #25727 )
...
* refactor: Vehicle Expense Report
* test: Vehicle Expenses Report
* feat: Added Employee filter to report
- fix Vehicle Log form view
* fix: set currency fieldtype for chart data
- added filters for employee and vehicle
* fix: service expenses not getting set
2021-05-31 09:11:42 +05:30
Marica
42b2ea556f
Merge pull request #25358 from noahjacob/maintenance_feat
...
refactor: maintenance schedule and visit enhancements.
2021-05-30 01:20:30 +05:30
Deepesh Garg
48b1a82fa1
fix: Add accounts and templates for reverse charge
2021-05-29 23:54:51 +05:30
Deepesh Garg
ea4f8102e8
Merge pull request #25869 from nextchamp-saqib/plaid-link-reset
...
fix(plaid): cannot reset plaid link for a bank account
2021-05-29 20:05:25 +05:30
Deepesh Garg
d067e25dad
Merge pull request #25828 from Anuja-pawar/issue-summary-report-fix
...
fix: Add Hold status column in the Issue Summary Report
2021-05-29 19:24:15 +05:30
Deepesh Garg
c3d8115ca1
Merge pull request #25849 from nextchamp-saqib/pos-rate-as-identifier
...
fix(pos): cannot add same item with different rates
2021-05-29 17:33:11 +05:30
Deepesh Garg
5483f21fe7
Merge pull request #25872 from nextchamp-saqib/fix-pos-broken-img
...
fix(pos): rendering of broken image on pos
2021-05-29 17:28:03 +05:30
Ankush Menat
431d3295b4
fix: use dictionary filter instead of list ( #25874 )
...
Item query doesn't support list filter anymore.
2021-05-28 21:12:25 +05:30
Deepesh Garg
fb9cb0fd23
Merge pull request #25866 from deepeshgarg007/itc_reversa_address
...
fix(India): Show only company addresses for ITC reversal entry
2021-05-28 18:46:09 +05:30
Saqib Ansari
b72b4c0bf9
fix(pos): rendering of broken image on pos
2021-05-28 17:38:01 +05:30
Noah Jacob
6fb218e033
refactor: suggested changes
2021-05-28 16:15:50 +05:30
Saqib Ansari
05386ff12f
chore: remove unwanted method
2021-05-28 12:58:18 +05:30
Deepesh Garg
20be7fb93d
fix(India): Show only company addresses for ITC reversal entry
2021-05-28 11:57:38 +05:30
Saqib Ansari
bbce2e91a3
fix: reset plaid link button
2021-05-28 11:56:47 +05:30
Saqib Ansari
d24eccd623
fix(plaid): cannot reset plaid link for a bank account
2021-05-28 11:36:24 +05:30
noahjacob
0b02f1335f
refactor: removed redundant links in test case
2021-05-28 11:04:34 +05:30
noahjacob
d071586589
refactor: removed maintenance schedule detail link
2021-05-28 10:54:35 +05:30
noahjacob
7fa045c1c9
refactor: using parent form links of maintenance schedule
2021-05-28 10:54:35 +05:30
noahjacob
3bca90dbe6
refactor: updated mapping for maintenance schedule links in maintenance visit
2021-05-28 10:54:22 +05:30
Suraj Shetty
68b050de97
Merge pull request #25863 from surajshetty3416/website-theme-fixes-version-13-hotfix
2021-05-28 10:48:23 +05:30
Ganga Manoj
17736afab5
fix(POS): Fix stock availability calculation if negative_stock_allowed is checked ( #25859 )
2021-05-28 10:03:41 +05:30
Ganga Manoj
8a776a63cd
fix(POS): Add Product Bundles to POS item search ( #25860 )
2021-05-28 09:56:30 +05:30
Suraj Shetty
f4db3139b7
refactor: Use css variables for breakpoint value
2021-05-28 09:22:46 +05:30
prssanna
c4d4be3265
fix: ensure website theme is applied correctly
2021-05-28 09:22:45 +05:30
Suraj Shetty
113a6f3d80
fix: Use frappe.safe_eval instead of eval
2021-05-28 09:10:34 +05:30
Suraj Shetty
96542c3d04
style: Fix sider issues
2021-05-28 09:10:34 +05:30
Suraj Shetty
273589e835
test: Fix a case where test used to fail due to holiday list
...
- fixes: "Please set a default Holiday List for Employee EMP-00009 or Company Wind Power LLC" error
2021-05-28 09:10:33 +05:30
Suraj Shetty
54354a84e1
test: Fix permission error
2021-05-28 09:10:33 +05:30
Suraj Shetty
d48ea663d9
test: Fix test name
...
- Rename TestSubcontractedItemToBeReceived > TestSubcontractedItemToBeTransferred
2021-05-28 09:10:33 +05:30
Suraj Shetty
d1a13ec050
test: Fix valuation rate for raw materials
2021-05-28 09:10:33 +05:30
Suraj Shetty
a891d6eed2
fix: allow_zero_valuation_rate for rejected qty
2021-05-28 09:10:33 +05:30
Suraj Shetty
19c5fd72d6
refactor: Rename assertEquals to assertEqual to avoid deprecation warnings
2021-05-28 09:10:33 +05:30
Suraj Shetty
ab8816e11d
test: Fix test dependency
2021-05-28 09:09:36 +05:30
Suraj Shetty
175cb27bcb
test: Pass ConflictingTaxRule during tax rule test
2021-05-28 09:09:36 +05:30
Suraj Shetty
c26d41acf9
chore: Remove unnecessary print statements
2021-05-28 09:09:36 +05:30
Suraj Shetty
232cd28d67
test: Fix dependencies
2021-05-28 09:07:57 +05:30
Suraj Shetty
7b74985a54
test: Fix test_dependencies
2021-05-28 09:07:57 +05:30
Suraj Shetty
34e620fb5b
test: Fix dependency
2021-05-28 09:07:57 +05:30
Deepesh Garg
a150645b57
fix: Remove GL Entry from print
2021-05-27 20:10:50 +05:30
Deepesh Garg
2e83cb77ca
fix: Split GL Entry
2021-05-27 20:09:45 +05:30
Deepesh Garg
4311fdc3a1
Merge branch 'version-13-hotfix' of https://github.com/frappe/erpnext into bootstraped_gst_setup
2021-05-27 17:49:23 +05:30
barredterra
50794407b4
feat: Item Tax Templates for Germany
2021-05-27 14:17:53 +02:00
barredterra
86ee3ebb09
feat: create tax category during taxes setup
2021-05-27 14:16:26 +02:00
barredterra
46d39d27aa
fix: validate company in taxes setup
2021-05-27 14:16:01 +02:00
anushka19
04dfaf3b2a
fix: Broken help links fixed
2021-05-27 17:45:37 +05:30
Deepesh Garg
740c68d075
fix: Debug Test
2021-05-27 17:43:53 +05:30
noahjacob
fbc8694291
refactor: added maintenance schedule links to parent form
2021-05-27 17:37:57 +05:30
noahjacob
bd783e8072
refactor: renamed item_ref to item_reference
2021-05-27 17:34:16 +05:30
noahjacob
9e4c28852e
refactor: added maintenance visit to maintenance schedule dashboard
2021-05-27 17:25:50 +05:30
Anuja P
bb0a40b995
fix: ageing error in PSOA
2021-05-27 17:15:47 +05:30
Deepesh Garg
ea18230274
fix: Update GL Entry ordering
2021-05-27 16:40:37 +05:30
Saqib Ansari
3382655b5e
fix: sider issues
2021-05-27 14:27:38 +05:30
Saqib Ansari
45a89a7c67
fix(pos): cannot add same item with different rates
2021-05-27 13:49:45 +05:30
Deepesh Garg
be3671fe7b
fix: Create new supplier for test case
2021-05-27 13:27:17 +05:30
Anuja P
e2059fb9f6
fix: spaces to tabs
2021-05-26 20:07:53 +05:30
Anuja P
5e4128e70c
fix: patch for existing issues
2021-05-26 20:03:14 +05:30
noahjacob
dc51388666
style: fixed indentations and formatting
2021-05-26 18:28:24 +05:30
Rohan Bansal
9857d63523
fix: add requested changes
2021-05-26 15:41:36 +05:30
Rohan Bansal
1e3a3b27c6
style: semgrep issues
2021-05-26 15:18:10 +05:30
Rohan Bansal
1cdf5a0dba
fix: add requested changes
2021-05-26 14:42:15 +05:30
Rohan Bansal
c5b074269a
Merge remote-tracking branch 'upstream/version-13-hotfix' into dev-quality-inspection-accounts
2021-05-26 14:32:14 +05:30
Marica
477a90e2ac
Merge pull request #25833 from ankush/translation_fixes
...
fix(ux): fix unstranslated text in msgprint/throw
2021-05-26 14:12:36 +05:30
Marica
7342eb64e9
Merge pull request #25810 from marination/se-supplier-customer
...
chore: Cleanup Customer and Supplier Details section in Stock Entry
2021-05-26 14:10:41 +05:30
Anupam Kumar
349ef8274b
fix: student invalid password reset link ( #25826 )
2021-05-26 12:14:02 +05:30
Deepesh Garg
36a11bf9ce
Merge pull request #25841 from nextchamp-saqib/fix(gstr-1)--incorrect-gstin-fetched-incase-of-branch-company-address
...
fix(gstr-1): incorrect gstin fetched incase of branch company address
2021-05-26 11:20:30 +05:30
Marica
be157e7467
Merge branch 'version-13-hotfix' into se-supplier-customer
2021-05-26 11:19:50 +05:30
Anurag Mishra
2e0e4a7861
refactor: Additional Salary form clean up ( #25785 )
...
* feat: additional salary clean up
* fix: Label and description
* fix: labels
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
2021-05-26 11:13:19 +05:30
Anuja P
db5217e48e
fix: renaming hold to on hold
2021-05-26 11:09:48 +05:30
Saqib Ansari
0e804e292a
fix(gstr-1): incorrect gstin fetched incase of branch company address
2021-05-26 10:54:16 +05:30
Anuja P
f3f87886a9
Merge branch 'version-13-hotfix' of https://github.com/frappe/erpnext into issue-summary-report-fix
2021-05-26 10:21:46 +05:30
Deepesh Garg
5e27c7dae2
fix: Add non group filter for account
2021-05-25 22:34:58 +05:30
Deepesh Garg
8fddd0f0c1
fix: Update TDS rate for test
2021-05-25 22:03:50 +05:30
Ankush Menat
ff96bdf0c1
fix(ux): fix unstranslated text in msgprint/throw
2021-05-25 20:59:20 +05:30
Deepesh Garg
81376ea44f
feat: Show net values in Party Accounts ( #25714 )
2021-05-25 20:39:17 +05:30
Ganga Manoj
18cfced032
fix(Material Request): Make status on list and form view the same ( #24856 )
2021-05-25 19:54:07 +05:30
Ganga Manoj
99636c6aca
fix: rearrange buttons for company doctype ( #25617 )
2021-05-25 19:17:01 +05:30
Afshan
4d61fa2497
fix: incorrect cr/dr shown in general ledger for multi-currency transactions ( #25654 )
2021-05-25 19:16:02 +05:30
Laurynas Sakalauskas
6a62ad325f
fix(plaid): withdrawals and deposits are recorded incorrectly ( #25784 )
2021-05-25 19:09:44 +05:30
Rakshith N
507a211c81
fix: fetch email id from dialog box in pos past order summary' ( #25808 )
2021-05-25 19:03:29 +05:30
Deepesh Garg
84f270e732
fix: Remove unwanted commits
2021-05-25 18:03:42 +05:30
noahjacob
73e41c0bd6
refactor: suggested changes
2021-05-25 18:01:47 +05:30
Deepesh Garg
55a3fb57dd
fix: Linting Issues
2021-05-25 17:40:06 +05:30
Deepesh Garg
36d47f97f4
fix: Linting issues
2021-05-25 17:40:04 +05:30
Deepesh Garg
6f84cee6fe
fix: Uncommentt test
2021-05-25 17:39:06 +05:30
Deepesh Garg
b07f7d1b70
fix: Linting and other fixes
2021-05-25 17:39:04 +05:30
Deepesh Garg
c9da1fc568
chore: Test case for adance TDS allocation
2021-05-25 17:37:17 +05:30
Deepesh Garg
a23aaf43f4
fix: Allocate advance taxes only for payment entry
2021-05-25 17:36:06 +05:30
Deepesh Garg
e2f83ffaa4
fix: Linting fixes and other checks
2021-05-25 17:35:41 +05:30
Deepesh Garg
77dcee9d67
fix: Test Cases
2021-05-25 17:35:15 +05:30
Deepesh Garg
fd380d34f9
fix: Linting errors
2021-05-25 17:35:05 +05:30
Deepesh Garg
a87e3fcb7c
fix: TDS report cleanup
2021-05-25 17:34:45 +05:30
Deepesh Garg
79b422c0a9
fix: Advance TDS in TDS payable monthly report
2021-05-25 17:33:59 +05:30
Deepesh Garg
d18dde7757
fix: Add tds in PO and code cleanup
2021-05-25 17:32:28 +05:30
Deepesh Garg
c26de28613
fix: TDS against Purhase Orders
2021-05-25 17:25:13 +05:30
Deepesh Garg
61c5e478af
feat: Tax deduction against advance payments
2021-05-25 17:20:52 +05:30
Deepesh Garg
c9aa726818
feat: Tax deduction against advance payments
2021-05-25 17:17:40 +05:30
Anuja P
3efd411ddb
fix: Hold status is added in the report
2021-05-25 16:24:01 +05:30
Deepesh Garg
09d9bd19ac
Merge pull request #25816 from deepeshgarg007/jv_diff_ignore_v13
...
fix: Ignore rounding diff while importing JV using data import
2021-05-25 10:59:50 +05:30
rohitwaghchaure
bc7c5bfbe2
Merge pull request #25817 from rohitwaghchaure/fix-removed-serial-no-validate-for-sales-invoice
...
fix: removed serial no validation for sales invoice
2021-05-25 10:40:46 +05:30
Rohit Waghchaure
b4f0347c02
fix: removed serial no validation for sales invoice
2021-05-24 23:39:25 +05:30
Deepesh Garg
7c0383a9a6
Merge pull request #25815 from deepeshgarg007/cash_flow_mapper_v13
...
fix: Cashflow mapper not showing data
2021-05-24 20:40:07 +05:30
Anurag Mishra
5670cf4386
feat: enhancements in Training Event ( #25782 )
...
* feat: Some Minor fixes
* fix: patch file
* fix: patch
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
2021-05-24 20:24:20 +05:30
Deepesh Garg
25112244ed
fix: Ignore rounding diff while importig JV using data import
2021-05-24 20:01:21 +05:30
Deepesh Garg
c348215f61
fix: Cashlfow mapper not showing data
2021-05-24 19:57:53 +05:30
Deepesh Garg
63e4ab4f2d
Merge pull request #25777 from Anuja-pawar/fix-process-SOA-format
...
fix: Process Statement of Accounts formatting
2021-05-24 19:55:21 +05:30
Saqib
dd5b31f8c4
fix: set disable rounded total if it is globally enabled ( #25789 )
2021-05-24 18:23:03 +05:30
Saqib
b6d061fa8c
fix(pos): handle db lock timeout error while pos closing ( #25813 )
2021-05-24 18:22:03 +05:30
Ankush Menat
15f8a0fb22
test: fix flaky test
2021-05-24 17:55:39 +05:30
Ankush Menat
3aed662f46
chore: translation / semgrep / sider fixes
2021-05-24 17:55:39 +05:30
Ankush Menat
c15fef571f
test: item naming series behaviour
2021-05-24 17:55:39 +05:30
Ankush Menat
76dd6e9046
test: contextmanager to change settings
2021-05-24 17:55:39 +05:30
Ankush Menat
42e057d079
test: add test for get_timeline_data in item
2021-05-24 17:55:38 +05:30
Ankush Menat
e971b4592e
test: add test for is_stock_item
2021-05-24 17:55:38 +05:30
Ankush Menat
57266a7343
refactor: check_stock_uom_with_bin
2021-05-24 17:55:38 +05:30
Ankush Menat
fc54cf68ac
test: add tests for checking stock_uom with bin
2021-05-24 17:55:38 +05:30
Ankush Menat
4e360f805f
test: hoist defaults to function signature
2021-05-24 17:55:38 +05:30
Ankush Menat
eb17732876
test: add test for item attribute completion
2021-05-24 17:55:37 +05:30
Ankush Menat
f5a937bc45
test: check index creation on item table
2021-05-24 17:55:37 +05:30
Ankush Menat
b9fa12d572
test: add tests for uom conversion function
2021-05-24 17:55:37 +05:30
Ankush Menat
019be66b7b
fix: consider all UOMs for intermediate conversion
...
- Using `get_value` will restrict intermediate UOM to first UOM that is
found.
- A self join is required to truly capture the required behaviour.
- Add explanation and examples.
2021-05-24 17:55:37 +05:30
Ankush Menat
0d7f54c6c2
refactor: simplify UOM conversion logic
...
- Remove unnecessary sql query
- Remove convoluted matching logic and be explcitiy while querying.
- better variable names for understanding matching cases
2021-05-24 17:55:37 +05:30
Ankush Menat
297dc5e345
perf: add basic optimisation for uom conversion
2021-05-24 17:55:37 +05:30
Ankush Menat
958d485ba4
refactor: msgprint(raise_exception)->frappe.throw
2021-05-24 17:55:36 +05:30
Ankush Menat
ccbde0efa0
refactor: use enumerate instead of trackign index
...
also removed dead code
2021-05-24 17:55:36 +05:30
Ankush Menat
44c489223b
chore: remove py2 compat code
2021-05-24 17:55:18 +05:30
Jannat Patel
dc7afa743c
fix: profitability test ( #25812 )
...
* fix: profitability test
* fix: replaced class method
* fix: removed print statement
2021-05-24 17:33:48 +05:30
noahjacob
bf1b3b89d1
refactor: updated conditional visibility of check box
2021-05-24 17:03:15 +05:30
rohitwaghchaure
6809ff4f64
Merge pull request #25776 from rohitwaghchaure/fixed-warehouse-not-found-issue
...
fix: warehouse not found in stock entry
2021-05-24 17:00:06 +05:30
marination
c12264f6bc
chore: Cleanup Customer and Supplier Details section in Stock Entry
...
- Changed depends on value to "Send to Subcontractor" for supplier fields
- Removed Customer fields as they are not relevant to any Stock Entry purpose
- Renamed section to "Supplier Details" visibe on subcontracting transfer
2021-05-24 13:20:22 +05:30
rohitwaghchaure
ce88c945cd
Update stock_entry.js
2021-05-24 11:53:27 +05:30
krishnagirishp
5457db0601
chore: remove uses of six.PY2 in codebase ( #25062 )
...
* remove uses of six.py2 in codebase
* changes based on pr feedback
* Update amazon_mws_api.py
Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
2021-05-23 21:13:44 +05:30
Ankush Menat
7b4a38c71e
chore: remove print from account controller ( #25807 )
...
This is polluting test output and it's not useful for debugging without
context.
2021-05-23 18:49:26 +05:30
Ankush Menat
c229ac9322
refactor: add guard clause for readability
...
Both functions only execute based on a condition. In such cases
condition should immediately exit the function, this is called "guard
clause" and helps in readability (less indent, and easy to "exit" when
reading the code.
2021-05-23 16:31:29 +05:30
Ankush Menat
4b484d741d
refactor: use is_new() instead of __islocal
...
Interface over implementation.
2021-05-23 16:31:29 +05:30
Ankush Menat
931c886f92
fix: not checking all fields
...
`break` will break out of the loop without checking remaining fields.
2021-05-23 16:31:29 +05:30
Ankush Menat
83e6e2e68a
refactor: add guard clause for readability
2021-05-23 16:31:29 +05:30
Ankush Menat
0b4858d8e5
refactor: eliminate unnecessary loop, container casts
2021-05-23 16:31:29 +05:30
Ankush Menat
ad58a8164a
refactor: code cleanup
...
minor fixes for improving code quality
2021-05-23 16:31:29 +05:30
Ankush Menat
4a2dbd4885
refactor: cleanup get_timeline_data, remove py2
2021-05-23 16:31:28 +05:30
Ankush Menat
330353a5ce
refactor: use frappe.throw instread of recreating
...
_msgprint was basically duplicating behvaiour of frappe.throw
2021-05-23 16:31:16 +05:30
Marica
eaf0465c44
Merge pull request #25797 from marination/item-variants-report
...
fix: Item Variant Details Report
2021-05-22 19:05:54 +05:30
marination
b0019bcf5b
fix: Item Variant Details Report
...
Co-authored-by: gavindsouza <gavin18d@gmail.com>
- Handling of variants with special characters
- Set data in appropriately named columns
- Code cleanup
2021-05-21 21:42:11 +05:30
rohitwaghchaure
ab34f5b485
Merge pull request #25742 from ankush/disable_submit_btn
...
fix: duplicate stock entry on multiple click
2021-05-21 18:13:01 +05:30
rohitwaghchaure
579a1b7028
Merge pull request #25779 from ankush/parallel_stock_transactions
...
fix: wrong quantity after transaction for parallel stock transactions
2021-05-21 18:11:34 +05:30
Saqib
0b5e340b6e
fix(pos): return case for item with available qty equal to one ( #25760 )
2021-05-21 16:32:56 +05:30
Saqib
e930456be2
fix(e-invoicing): 'NoneType' object is not iterable ( #25781 )
2021-05-21 16:31:12 +05:30
Alan
1097dc89c5
fix: show allow zero valuation only when auto checked ( #25778 )
2021-05-21 14:04:03 +05:30
Ankush Menat
4dcac4ae81
refactor(minor): Use identity instead of equality
...
Ignore false positive.
2021-05-21 13:49:58 +05:30
Ankush Menat
9979cf5fcc
fix: wrong quantity after transaction for parallel stock transactions
...
When two transactions are inserted parallelly then previous SLE could be
incorrect for some of them. Locking SLE table would prevent reading from
it till transaction is complete.
2021-05-21 12:31:06 +05:30
rohitwaghchaure
651e934415
Merge pull request #25683 from noahjacob/supplier_item_group_link
...
feat: linking supplier with an item group for filtering items
2021-05-21 12:07:53 +05:30
Rohit Waghchaure
795909fdcd
fix: warehouse not found in stock entry
2021-05-21 11:31:01 +05:30
Anuja P
605ea044f3
fix: update process SOA format
2021-05-21 11:24:33 +05:30
rohitwaghchaure
84730aa4a5
Merge pull request #25754 from rohitwaghchaure/fixed-do-not-repost-if-scheduler-is-in-running-13
...
fix: the status of repost item valuation showing In Progress since long time
2021-05-21 09:50:18 +05:30
Rucha Mahabal
722cfdb7e5
Merge pull request #25701 from anupamvs/timesheet-refactor
...
refactor: timesheet
2021-05-20 23:43:19 +05:30
Rucha Mahabal
a7d0dbb085
fix: calculate total billing amount on fetching timesheets
...
- show timesheet billing amounts in doc currency
2021-05-20 23:02:11 +05:30
Rucha Mahabal
8a407f1ec3
fix: sider issues
2021-05-20 22:23:44 +05:30
Rucha Mahabal
be247ec3de
fix: error message placeholders and sider issues
2021-05-20 22:17:20 +05:30
Rucha Mahabal
0d8b9a9d0a
fix(patch): billable field not renamed
2021-05-20 19:53:30 +05:30
noahjacob
f0e6a16910
test: updated test for generated schedule dates
2021-05-20 19:29:12 +05:30
Deepesh Garg
181c5d240b
Merge pull request #25767 from deepeshgarg007/gst-ptach-fix-1
...
fix: Do not throw error on migrate
2021-05-20 18:40:48 +05:30
Mohammad Hasnain Mohsin Rajan
21e662f678
fix: apply permission while selecting projects ( #25765 )
2021-05-20 17:20:05 +05:30
Deepesh Garg
4427390ab3
fix: Do not throw error in migrate
2021-05-20 17:19:24 +05:30
noahjacob
0169cd845a
fix: sider
2021-05-20 15:40:07 +05:30
Anupam
1270febfff
fix: sider issues
2021-05-20 14:15:58 +05:30
Anupam
aa516e5d17
fix: review changes
2021-05-20 14:12:18 +05:30
Anupam
aeb88385bb
patch: timesheet changes
2021-05-20 14:11:36 +05:30
noahjacob
08598238d7
refactor: suggested changes
2021-05-20 13:23:10 +05:30
Deepesh Garg
8bc90ffcf5
Merge pull request #25755 from nextchamp-saqib/improve-missing-cost-center-msg
...
fix: missing cost center message on creating gl entries
2021-05-20 11:20:43 +05:30
Saqib Ansari
b9ad385232
fix: remove uncessary query
2021-05-19 19:13:06 +05:30
Saqib Ansari
7fb385a89f
fix: cannot bypass e-invoicing for non gst item invoices
2021-05-19 18:47:06 +05:30
Saqib
4bd641367b
fix: address template with upper filter throws jinja error ( #25756 )
2021-05-19 16:38:53 +05:30
noahjacob
516c789127
refactor: variable names and suggested changes
2021-05-19 16:01:39 +05:30
Anupam
4e73c8a79f
restructuring timesheet fields
2021-05-19 14:58:12 +05:30
noahjacob
bf7f0530e6
fix: added error handling if entry already exists
2021-05-19 13:53:22 +05:30
noahjacob
8e34c49ac9
refactor: using get_all instead of get_list
2021-05-19 13:51:36 +05:30
noahjacob
3768216dca
refactor: updated permissions and mandatory fields
2021-05-19 13:50:35 +05:30
Saqib Ansari
f79ef5d8cf
fix: missing cost center message on creating gl entries
2021-05-19 13:04:44 +05:30
Rohit Waghchaure
5456873641
fix: run scheduler for reposting if there is no scheduler is running for the reposting
2021-05-19 12:30:28 +05:30
Anupam
9bd779401d
added multi-currency fields
2021-05-18 22:41:28 +05:30
anushka19
90f7ec840c
fix: Accumulated depreciation ( #25748 )
...
* fix: Accumulated depreciation
* fix: Sider issues
2021-05-18 22:21:42 +05:30
Saqib
8d7d4b0ba7
fix: expected amount in pos closing payments table ( #25737 )
2021-05-18 18:39:35 +05:30
Syed Mujeer Hashmi
426b04003c
fix: Project filter for Kanban Board
...
Signed-off-by: Syed Mujeer Hashmi <mujeerhashmi@4csolutions.in>
2021-05-18 17:02:21 +05:30
Marica
814fd19424
Merge pull request #25732 from noahjacob/ux_landed_cost_voucher
...
refactor: updated applicable charges form in landed cost voucher
2021-05-18 16:39:31 +05:30
Ankush Menat
ecbb8cbc84
revert: "fix: duplicate stock entry ( #25486 )"
...
Not required anymore, submit button is disabled.
2021-05-18 16:35:55 +05:30
Ankush Menat
042b8524cc
fix: disable submit button to avoid multiple calls
2021-05-18 16:35:49 +05:30
Marica
5da34bddd6
Merge pull request #25731 from ankush/escaping_company_name
...
fix: escape company name
2021-05-18 16:35:19 +05:30
Devin Slauenwhite
bdba064fa6
fix: duplicate stock entry ( #25486 )
...
Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
2021-05-18 16:12:53 +05:30
noahjacob
0ab0fcdd51
feat: added supplier item group link in supplier dashboard
2021-05-18 15:21:24 +05:30
noahjacob
ca2fb47d44
feat: updates item_code filters if item_group is linked to supplier
2021-05-18 15:01:05 +05:30
Ankush Menat
b6783b158f
chore: translation fixes
2021-05-17 17:06:41 +05:30
Ankush Menat
f3b3d81e0b
fix: escape company name in deferred_revenue
2021-05-17 17:06:41 +05:30
noahjacob
41ac8be6f2
refactor: base_amount field moved below amount field and renamed
2021-05-17 13:58:27 +05:30
Anupam
42d2f663fa
fix: sider fixes
2021-05-17 11:08:26 +05:30
Deepesh Garg
87baa646e7
Merge pull request #25260 from AfshanKhan/dimension-wise-accounts-balance-reports
...
feat: Dimension-wise Accounts Balance Report
2021-05-16 18:04:01 +05:30
Anupam
35137ba9e0
removing currency filter and added rate conversion while fetching timesheets in SI
2021-05-16 14:17:56 +05:30
Anupam
cab998c293
adding patch
2021-05-15 20:40:20 +05:30
Anupam
fd4743cc31
refactor: timesheet
2021-05-15 20:01:17 +05:30
Alan
55c2fec683
feat: add pending qty section to batch/serial selector dialog ( #25519 )
...
* feat: add pending qty section to batch/serial selector dialog
* fix: call attach in setup and refresh, fix conditional
* refactor: camel to snake casing
2021-05-14 12:36:41 +05:30
rohitwaghchaure
2aa401826e
fix: validation message of quality inspection in purchase receipt ( #25666 )
2021-05-14 12:34:50 +05:30
Alan
98fc4195b3
fix: send emails on rfq submit ( #25695 )
...
* fix: send emails on rfq submit
* fix: check if email is present for supplier
2021-05-14 12:22:28 +05:30
Alan
eca86290bc
fix: show uom for item in selector dialog ( #25697 )
2021-05-14 12:21:38 +05:30
Deepesh Garg
be3cde9313
chore: Code clean up for purchase receipt GL ( #25379 )
...
* chore: Code clean up for purchase receipt GL
* fix: add params for debit and credit in account curreny
* chore: Asset GL entry code cleanup
* fix: Syntax error
* fix: Update variable names
* fix: function naming
* fix: Add undefined variables
* fix: Supplier warehouse fetching
* fix: Linting issues
2021-05-14 12:20:38 +05:30
Deepesh Garg
55fe85d850
feat(India): Multiple GST enhancement and fixes ( #25249 )
...
* fix: RCM tax calculation
* feat(India): ITC Reversal via Journal Entry
* fix: Reverse Charge booking logic and validation
* fix: Addd patch for availed ITC fields
* fix: Hooks method to update availed ITC field
* fix: Cleanup and fixes in GSTR3B report
* fix: Update params in GSTR-1 report
* fix: Debit note using Sales Invoice
* fix: Setup and patch
* fix: GSTR 3B report cleanup and updates
* fix: Add method to get invoices liable to reverse charge
* fix: Add taxable value in Purchase Invoice Item
* fix: Inward supplies liable to reverse charge
* fix: Linting issues
* fix: GSTR3B report test
2021-05-14 12:17:41 +05:30
rohitwaghchaure
ba940bb9e1
Merge pull request #25702 from rohitwaghchaure/change-today-to-now-for-reposting
...
fix: change today to now to get data for reposting
2021-05-13 17:44:38 +05:30
rohitwaghchaure
fc44478810
Update repost_item_valuation.py
2021-05-13 17:42:33 +05:30
Rohit Waghchaure
af1376c1df
chore: change today to now to get data for reposting
2021-05-13 17:39:49 +05:30
Mohammad Hasnain Mohsin Rajan
e85770fe3f
fix: bank statement import via google sheet ( #25676 )
...
* fix: google sheet bank statement import
* fix: quotes
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
* chore: add translation
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
* chore: grammar
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
* fix: remove comment
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2021-05-13 17:33:18 +05:30
rohitwaghchaure
d42dd5d868
Merge pull request #25694 from rohitwaghchaure/fixed-warehouse-tree-time-out-error-13hotfix
...
fix: timeout error while loading warehouse tree
2021-05-13 17:21:16 +05:30
Rohit Waghchaure
27f50d5852
fix: timeout error while loading warehouse tree
2021-05-13 15:54:35 +05:30
Deepesh Garg
95e05fbdac
fix: Parameter for get_filtered_list_for_consolidated_report in consolidated balance sheet
2021-05-13 14:59:28 +05:30
Anurag Mishra
0c482fde5f
feat: Leave Policy Assignment Refactor ( #24327 )
...
* feat: Leave Policy Assignment Refactor
* fix: Changes Requested
* fix: sider
* fix: changes requested
* test: fixed
* test: fixed wrong set query
* fix: remove commented code
* fix(style): extra space
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
2021-05-13 13:20:14 +05:30
rohitwaghchaure
0612300631
Merge pull request #25688 from rohitwaghchaure/fixed-woocommerce-order-sync-issue
...
fix: Woocommerce order sync issue
2021-05-12 23:07:46 +05:30
Rohit Waghchaure
c3c54fe058
fix: Woocommerce order sync issue
2021-05-12 19:42:04 +05:30
rohitwaghchaure
3c79ee3a2b
Merge pull request #25672 from rohitwaghchaure/fixed-don-not-mao-set-warehouse
...
fix: don't map set warehouse from delivery note to purchase receipt
2021-05-12 17:47:28 +05:30
Afshan
dc205e805f
fix: Dialog variable assignment after definition in POS ( #25681 )
2021-05-12 17:42:06 +05:30
rohitwaghchaure
4fbabb4132
Merge pull request #25679 from rohitwaghchaure/fixed-new-fields-not-added
...
fix: updated modified time in purchase invoice to pull new fields
2021-05-12 16:40:23 +05:30
Rohit Waghchaure
9f017a351b
fix: updated modified time to pull new fields
2021-05-12 16:35:19 +05:30
Mohammad Hasnain Mohsin Rajan
e7a2fdd81a
fix: change links in workspace ( #25674 )
2021-05-12 13:02:32 +05:30
Rohit Waghchaure
d984be0ccd
fix: don't map set warehouse from delivery note to purchase receipt
2021-05-12 12:32:14 +05:30
rohitwaghchaure
958c96ee3f
Merge pull request #25660 from deepeshgarg007/promotional_item_cost_center
...
fix: Breaking cost center validation
2021-05-11 18:08:17 +05:30
Deepesh Garg
a665f14620
fix: Error on adding bank account to plaid ( #25658 )
2021-05-11 17:33:59 +05:30
Deepesh Garg
a60c3081cf
fix: Breaking cost center validation
2021-05-11 16:38:33 +05:30
Deepesh Garg
d2520680bc
fix: Error on applying TDS without party ( #25632 )
...
* fix: Error on applying TDS without party
* fix: Add placeholder value
2021-05-10 21:17:06 +05:30
Deepesh Garg
83f98f6992
Merge pull request #25653 from deepeshgarg007/tax_labels
...
fix: Client script breaking while settings tax labels
2021-05-10 18:24:02 +05:30
Deepesh Garg
9f0823a164
fix: Linting issues
2021-05-10 16:07:41 +05:30
Saqib
55d47a2baa
fix(pos): UI fixes related to overflowing payment section ( #25652 )
...
* fix: additional fields overflowing in payment section
* fix: pos profile filter in pos opening dialog
* fix: item quantity pill
2021-05-10 15:59:37 +05:30
Deepesh Garg
13dfb9734c
fix: Lable for transaction child tables
2021-05-10 15:38:32 +05:30
Deepesh Garg
1a48eb49cf
fix: Client script breaking while settings tax labels
2021-05-10 14:37:10 +05:30
Ganga Manoj
f2eb8dd1d5
feat: Transaction Deletion Record ( #25354 )
...
Co-authored-by: Saqib <nextchamp.saqib@gmail.com>
2021-05-10 14:02:58 +05:30
Ankush Menat
6e179c3092
fix: sync shopify customer addresses ( #25481 )
2021-05-10 13:24:26 +05:30
Saqib
9226cd3932
feat(india): reduced rate of depreciation as per IT Act ( #25648 )
...
* feat(india): reduced rate of depreciation as per IT Act
* refactor: check date difference instead of month difference
* feat: add test for regional feature
2021-05-10 12:36:56 +05:30
noahjacob
50f52dfbcb
refactor: variable names and refactored cancel function into submit function
2021-05-09 20:04:06 +05:30
noahjacob
7715441842
feat: added supplier item group doctype
2021-05-09 20:02:23 +05:30
Ganga Manoj
aa9e172091
feat: Add Create Expense Claim button in Delivery Trip ( #25526 )
...
* feat(Delivery Trip): Add employee_code field
* feat(Expense Claim): Add Delivery Trip Number field
* feat(Delivery Trip): Add Create Expense Claim button
* feat(Delivery Trip): Make Create Expense Claim button show up after save
* fix(Delivery Trip): Fix Sider issues
* fix(Delivery Trip): Display button after submit
* fix(Delivery Trip & Expense Claim): Rename new fields
* fix(Delivery Trip): Add button in refresh
* fix(Delivery Trip): Remove redundant line
* fix(Expense Claim): Display delivery_trip only if non-empty
* fix(Delivery Trip): Add test for Create Expense Claim
* fix(Delivery Trip): Fix Sider Issue
* fix(Delivery Trip): Only display Create Expense Claim if the driver is an employee
* fix(Delivery Trip): Fix test
* fix(Delivery Trip): Fix make_expense_claim()
* fix: sider
Co-authored-by: Saqib <nextchamp.saqib@gmail.com>
2021-05-08 17:15:33 +05:30
rohitwaghchaure
64bd4f27b8
Merge pull request #25611 from rohitwaghchaure/validation-to-check-duplicate-serial-nos
...
fix: added validation in stock entry to check duplicate serial nos
2021-05-07 23:30:27 +05:30
rohitwaghchaure
42fe07bd19
Merge pull request #25551 from rohitwaghchaure/fixed-total-stock-summary-report
...
fix: total stock summary report not working
2021-05-07 23:30:06 +05:30
rohitwaghchaure
1726ce547c
Merge pull request #25471 from rohitwaghchaure/allow-to-receipt-same-serial-no
...
fix: allow to receive same serial numbers multiple times
2021-05-07 23:27:50 +05:30
Alan
c6dc9eaf2e
feat!: add pick batch button ( #25413 )
...
* feat!: add pick batch button
BREAKING CHANGE: replaces setup_serial_no with setup_serial_or_batch_no.
* refactor: use setup_serial_or_batch_no instead of setup_serial_no
* refactor: use setup_serial_or_batch_no instead of setup_serial_no
* refactor: use setup_serial_or_batch_no instead of setup_serial_no
* style: add sider review changes
* refactor: make consice, extract function
* refactor: camel to snake casing
2021-05-07 20:30:04 +05:30
Ankush Menat
90e671905a
chore: replace assertEquals with alias assertEqual ( #25613 )
...
* chore: replace assertEquals with alias assertEqual
assertEquals has been deprecated.
ref: https://docs.python.org/3/library/unittest.html#deprecated-aliases
* chore: sider fixes
2021-05-07 20:28:51 +05:30
Ankush Menat
e28165ea87
fix: force https for shopify webhook registration ( #25630 )
2021-05-07 20:27:51 +05:30
Anupam Kumar
da7fefe29d
fix: timesheet filter date exclusive issue ( #25626 )
2021-05-07 20:26:50 +05:30
Saqib
27cf19a19f
feat(pos): show POS reserved stock in stock projected qty report ( #25593 )
...
* feat(pos): consider POS reserved stock in stock projected qty report
* chore: remove unwanted string formats
2021-05-07 13:37:42 +05:30
Ganga Manoj
5618ce3852
fix(Material Request): Add 'Partially Received' to Status drop-down list ( #24857 )
...
Co-authored-by: Ganga Manoj <ganga_manoj@Gangas-MacBook-Air.local>
Co-authored-by: Nabin Hait <nabinhait@gmail.com>
2021-05-07 13:35:09 +05:30
Rucha Mahabal
062d30146f
fix: Include search fields in Project Link field query ( #25505 )
...
* fix: Include search fields in Project Link field query
* fix: add project_name to Project search fields
2021-05-07 13:31:14 +05:30
Umair Sayed
7f79d463f6
fix: Stock and Accounts Settings form refactor ( #25534 )
...
* stock and accounts settings page
* fix: Stock and accounts settings page cleanup
Co-authored-by: Umair Sayed <umairsayed@Umairs-MacBook-Air.local>
2021-05-07 12:28:57 +05:30
Shariq Ansari
735fbdc350
fix: Updating Standard Notification's channel field ( #25564 )
2021-05-07 12:26:32 +05:30
Deepesh Garg
00e00e4e90
fix: Report summary showing inflated values when values are accumulated in Group Company ( #25577 )
...
* fix: Report summary showing inflated values when values are accumullated in Group Company
* fix: Remove extra space
* fix: Translate strings
* fix: Remove unintended changes
2021-05-07 12:16:44 +05:30
Shadrak Gurupnor
f648d2d7c4
fix: added tax_types list ( #25587 )
2021-05-07 12:15:19 +05:30
Ankush Menat
996f7e53a1
fix: update shopify api version ( #25600 )
2021-05-07 12:14:14 +05:30
Anuja Pawar
f132ed4335
fix: update item level cost center from POS ( #25609 )
2021-05-07 12:11:09 +05:30
Alan
0e0de6baa1
fix: prevent spurious defaults for items when making prec from dnote ( #25559 )
...
* fix: prevent spurious defaults for items when making prec from dnote
* refactor: make concise, use dict comp
2021-05-07 11:40:02 +05:30
Noah Jacob
4ecae62194
fix: added is_stock_item filter ( #25530 )
2021-05-06 19:42:01 +05:30
Nabin Hait
134eaa5786
perf: Performance enhancement on setup wizard ( #25605 )
...
* perf: Performance enhancement on setup wizard
* fix: create departments without updating nsm
2021-05-06 19:13:54 +05:30
Rohit Waghchaure
695becdd05
fix: added validation in stock entry to check duplicate serial nos
2021-05-06 18:03:32 +05:30
rohitwaghchaure
dc6233b703
Merge pull request #25541 from rohitwaghchaure/fixed-incorrect-serial-no-set
...
fix: serial no changed after saving stock reconciliation
2021-05-06 17:44:36 +05:30
Saqib
900a8fb21a
feat(pos): ability to retry on pos closing failure ( #25595 )
...
* feat(pos): ability to retry on pos closing failure
* fix: sider issues
* fix: sider issues
* fix: mark all queued closing entry as failed
* feat: add headline message
2021-05-06 17:02:47 +05:30
Sagar Vora
f43a86d90f
perf: significant reduction in time taken to save a delivery note ( #25475 )
2021-05-06 16:40:06 +05:30
Saqib
d502f76319
feat(e-invoicing): e-way bill validity field ( #25555 )
2021-05-06 16:10:55 +05:30
Deepesh Garg
8a1f86db16
Merge pull request #25582 from deepeshgarg007/this_variable
...
fix: function call to update payment schedule labels
2021-05-06 15:50:47 +05:30
Deepesh Garg
9dd0a26e92
Merge pull request #25598 from deepeshgarg007/payment_reco_invoice_fix
...
fix: Invoices not getting fetched during payment reconciliation
2021-05-06 15:49:19 +05:30
rohitwaghchaure
7ed531611b
Merge pull request #25588 from 18alantom/fix-check-schedule-date
...
fix: check for None in item.schedule_date before setting
2021-05-06 14:04:14 +05:30
Rohit Waghchaure
bb3e5d00f4
fix: allow to receive same serial numbers multiple times
2021-05-06 12:38:35 +05:30
Deepesh Garg
85b675a554
fix: Invoices not fetch during payment reconciliation
2021-05-05 20:57:31 +05:30
Deepesh Garg
ffea9d4126
fix: Check if payment schedule exists
2021-05-05 12:28:40 +05:30
18alantom
136eb30081
fix: use get_serial_nos for splitting
2021-05-05 12:26:29 +05:30
Deepesh Garg
1bb7bb74ad
fix: Check if payment schedule exits before updating label
2021-05-05 12:19:57 +05:30
18alantom
2a20a03c28
fix: check for None in item.schedule_date before setting
2021-05-05 11:59:15 +05:30
rohitwaghchaure
8be414873b
Merge pull request #25575 from rohitwaghchaure/fixed-stock-balance-report-and-batchwise-report
...
fix: stock balance and batch-wise balance history report showing different closing stock
2021-05-05 10:04:23 +05:30
Deepesh Garg
04923d6a65
fix: function call to update payment schedule labels
2021-05-04 21:01:12 +05:30
Asharam Seervi
18ad15ed16
fix: designation insufficient permission on lead doctype. ( #25331 )
2021-05-04 19:28:07 +05:30
Afshan
eebc6e9277
refactor: Show item's full name on hover over item in POS ( #25554 )
...
Co-authored-by: Saqib <nextchamp.saqib@gmail.com>
2021-05-04 17:05:12 +05:30
Rushabh Mehta
5fc4f1e37d
Merge pull request #25238 from alyf-de/datev_fixes
...
feat: Improve DATEV export
2021-05-04 15:38:57 +05:30
Rohit Waghchaure
ba8dc1ffbd
fix: stock balance and batchwise balance history report showing different closing stock
2021-05-04 15:03:10 +05:30
Saqib
384f4b5b7e
fix: can't open general ledger from consolidated financial report ( #25542 )
2021-05-04 12:33:49 +05:30
Saqib
076020643d
fix: empty payment term column in accounts receivable report ( #25556 )
2021-05-04 12:26:49 +05:30
18alantom
308905b1be
fix: semgrep, refactor default mutable dict
2021-05-04 11:46:13 +05:30
18alantom
e36f303042
fix: use percent string templates for db.sql calls
2021-05-04 11:46:13 +05:30
barredterra
24e2cc9107
Merge branch 'develop' into datev_fixes
2021-05-03 18:19:28 +02:00
Suraj Shetty
ca37380d2e
Merge branch 'develop' of github.com:frappe/erpnext into develop
2021-05-03 19:44:22 +05:30
Rucha Mahabal
f1bdfac7a8
fix: Employee Separation ( #25503 )
...
* fix: Employee Separation
- add ignore_mandatory flag for project creation
- form clean-up
* fix: Employee Separation test
2021-05-03 18:37:00 +05:30
rohitwaghchaure
1f4df80565
Merge pull request #25531 from noahjacob/fix_mr_filter
...
fix: updated item filters for material request
2021-05-03 18:36:25 +05:30
rohitwaghchaure
88734eea14
Merge pull request #25557 from rohitwaghchaure/increased-timeout-of-stoc-reco
...
fix: stock reconciliation getting time out error during submission
2021-05-03 18:25:33 +05:30
Rohit Waghchaure
8f34ca4ac6
fix: stock reconciliation getting time out error during submission
2021-05-03 15:32:13 +05:30
Saqib
cdc99cdd49
fix(pos): incorrect expense account set in pos invoice ( #25543 )
2021-05-03 11:54:55 +05:30
rohitwaghchaure
9cc7c294e7
Update stock_reconciliation.py
2021-05-03 10:25:53 +05:30
Deepesh Garg
0ae702aab9
Merge branch 'develop' of https://github.com/frappe/erpnext into bootstraped_gst_setup
2021-05-02 22:37:04 +05:30
Deepesh Garg
84ec295b43
Merge pull request #25546 from deepeshgarg007/loan_schedule_fixes
...
fix: Minor fixes in loan
2021-05-02 22:35:34 +05:30
Deepesh Garg
1bac72b74d
fix: Add GST accounts to GST Settings
2021-05-02 22:29:48 +05:30
Deepesh Garg
72e602ae54
fix: Add validation for GST Settings
2021-05-02 18:22:29 +05:30
Rohit Waghchaure
6a5a380c07
fix: total stock summary report not working
2021-05-02 18:02:28 +05:30
Rohit Waghchaure
35d4829383
fix: serial no changed after saving stock reconciliation
2021-05-02 17:57:28 +05:30
rohitwaghchaure
5f177aaeaa
Merge pull request #25545 from rohitwaghchaure/fixed-depost-withdrwal-values-has-not-updated
...
fix: rename field has not updated value of deposit and withdrawal fields
2021-05-02 17:54:22 +05:30
Deepesh Garg
c571141c1f
fix: Test cases
2021-05-02 15:31:04 +05:30
Deepesh Garg
f6610c96dd
fix: Gracefully handle duplicate bank account name to make setup faster
2021-05-02 12:23:11 +05:30
Deepesh Garg
a66184fe3c
fix: Remove redundant get_doc
2021-05-02 12:22:16 +05:30
Deepesh Garg
824f089569
fix: Auto write off on loan closure
2021-05-01 22:07:13 +05:30
Deepesh Garg
1efafb3ce8
fix: Do not roundoff balance amount
2021-05-01 21:52:43 +05:30
Rohit Waghchaure
2fb573781d
fix: rename field has not updated value of deposit and withdrawal fields
2021-05-01 17:56:40 +05:30
Nabin Hait
0c7448fc41
fix: Fixed merge conflict
2021-05-01 14:54:22 +05:30
Nabin Hait
a2fcca85a5
fix: Fixed merge conflict
2021-05-01 14:53:13 +05:30
Nabin Hait
d8cd5a95cb
bumped to version 13.2.0
2021-05-01 15:12:44 +05:50
Nabin Hait
3c788f0325
chore: Add release note for v13.2.0
2021-05-01 14:42:30 +05:30
rohitwaghchaure
2e38f1514f
fix: stock ledger entry created against draft stock entry ( #25539 )
2021-05-01 13:53:46 +05:30
rohitwaghchaure
00ea336b52
fix: stock ledger entry created against draft stock entry ( #25540 )
2021-05-01 13:53:39 +05:30
Afshan
1fd1e2bb60
fix: fieldname when updating docfield property ( #25517 )
2021-04-30 18:41:26 +05:30
Afshan
5a4615fd4e
fix: allow to cancel loan with cancelled replayment entry ( #25508 )
2021-04-30 18:40:43 +05:30
Nabin Hait
a19c6a9278
fix: Fetch total stock at company in PO ( #25533 )
2021-04-30 18:38:49 +05:30
Nabin Hait
da0ba15cbf
fix: Fetch total stock at company in PO ( #25532 )
2021-04-30 18:38:41 +05:30
Deepesh Garg
204ea1027f
fix: Ignore validations for Tax Setup
2021-04-30 16:35:52 +05:30
Raffael Meyer
07a081d8ac
Merge branch 'develop' into datev_fixes
2021-04-30 12:25:40 +02:00
noahjacob
a90c81626f
fix: updated item filters for material request
2021-04-30 15:49:36 +05:30
Deepesh Garg
88d40e8dc4
fix: Remove extra space
2021-04-30 15:33:33 +05:30
Deepesh Garg
1deef5229e
fix: Linting and translation issues
2021-04-30 15:20:55 +05:30
Deepesh Garg
bd5ee7d725
fix: Use party account currency
2021-04-30 15:20:45 +05:30
Deepesh Garg
9cbca06f4e
fix: Updated filters for process statement of accounts
2021-04-30 15:20:31 +05:30
Deepesh Garg
303f6d2d36
Merge branch 'version-13-pre-release' of https://github.com/frappe/erpnext into psoa_fixes_v13_pre_release
2021-04-30 15:17:07 +05:30
Deepesh Garg
178938b2f0
fix: Ageing errors in PSOA
2021-04-30 15:14:24 +05:30
Deepesh Garg
c4231c72a6
Merge pull request #25524 from aerele/develop
...
fix: List invoices in Payment Reconciliation Payment
2021-04-30 14:15:33 +05:30
noahjacob
c0352010d3
test: creating schedule and visit
2021-04-30 14:09:30 +05:30
Anuja P
435e93bda9
fix: allocated amount change wrt paid amount change
2021-04-30 13:52:48 +05:30
Deepesh Garg
8aa57953ee
Merge pull request #25490 from deepeshgarg007/psoa_fixes_v2
...
fix: Ageing errors in PSOA
2021-04-30 13:07:00 +05:30
Deepesh Garg
cd9fa61659
Merge pull request #25521 from ernestoruiz89/patch-4
...
fix: Make strings translatable
2021-04-30 12:58:26 +05:30
Deepesh Garg
26920b439a
Merge pull request #25394 from meike289/feature/check-field-subscription-invoice
...
feat: new check field in subscriptions for (not) submitting invoices
2021-04-30 12:32:45 +05:30
noahjacob
7ad66caf7f
refactor: migrated calculation and validation logic in js to py
2021-04-30 11:43:38 +05:30
Deepesh Garg
0dc411951e
Merge pull request #25438 from nextchamp-saqib/round-off-diff-allowance
...
fix: ignore fraction difference while making round off gl entry
2021-04-30 11:11:21 +05:30
Vignesh S
7783a56c08
fix: List invoices in Payment Reconciliation Payment
...
Invoices are not listed in the Payment Reconciliation Payment table due to a typo in the code
2021-04-29 22:39:42 +05:30
Ernesto Ruiz
76e1e68cf4
fix: Make strings translatable
...
Make strings translatable
2021-04-29 08:24:56 -06:00
Saqib Ansari
3e83542360
fix: sider issues
2021-04-29 18:12:47 +05:30
Saqib
2bde1baa38
fix: remove print statement
2021-04-29 18:12:42 +05:30
Saqib Ansari
6dd1c5cf92
refactor: remove extra fields
2021-04-29 18:12:36 +05:30
Saqib Ansari
3a5ecb7587
fix: test
2021-04-29 18:12:32 +05:30
Saqib Ansari
973afeac3c
feat: set dynamic labels for payment schedule fields
2021-04-29 18:12:27 +05:30
Saqib Ansari
a91eebf6aa
feat: base payment amount in payment schedule
2021-04-29 18:12:23 +05:30
Saqib Ansari
e70d9c925c
fix: payment amount showing in foreign currency
2021-04-29 18:12:17 +05:30
Anuja Pawar
07fb98b91d
Merge branch 'develop' into fix_PE_allocated_amt
2021-04-29 17:17:21 +05:30
Anuja P
dd1e7624bf
fix: changing paid amount should change allocated amount
2021-04-29 17:00:59 +05:30
Deepesh Garg
7bf25b4cef
Merge pull request #25292 from nextchamp-saqib/payment-term-amount-display-currency-fix
...
fix: payment amount showing in foreign currency
2021-04-29 16:33:01 +05:30
Saqib Ansari
6fb417590f
fix: sider issues
2021-04-29 14:05:20 +05:30
noahjacob
90c667205a
test: added on_cancel test
2021-04-29 13:06:04 +05:30
noahjacob
93c22ebbb9
refactor: created separate function to update work_order on cancel
2021-04-29 12:57:41 +05:30
Deepesh Garg
3386d4948e
Merge pull request #25507 from AfshanKhan/fix-cancel-loan
...
fix: allow to cancel loan with cancelled repayment entry
2021-04-29 12:31:52 +05:30
Saqib
83e3820575
fix: remove print statement
2021-04-29 12:21:56 +05:30
Noah Jacob
dc086dd52f
fix: item stock levels displaying inconsistently ( #25506 )
...
* fix: fixed stock levels dashboard not displaying after any interactions
* fix: minor translation fix
2021-04-29 11:03:27 +05:30
Afshan
ab052599c0
fix: allow to cancel loan with cancelled replayment entry
2021-04-28 20:21:04 +05:30
noahjacob
56f697052c
test: added test case for combining items
2021-04-28 20:12:33 +05:30
noahjacob
b7ca913904
fix: Added Item Reference field to link tables and update work_order_qty
2021-04-28 19:27:20 +05:30
Raffael Meyer
d75b4c37a3
Merge branch 'develop' into feature/check-field-subscription-invoice
2021-04-28 12:38:49 +02:00
Raffael Meyer
a949480acf
fix: add translation to make semgrep pass
2021-04-28 12:38:23 +02:00
Saqib Ansari
44b07e4ef5
refactor: remove extra fields
2021-04-28 15:11:57 +05:30
Saqib Ansari
da5b55c4f5
fix: test
2021-04-28 14:55:33 +05:30
Saqib Ansari
3f7ec95af8
Merge branch 'develop' of https://github.com/frappe/erpnext into payment-term-amount-display-currency-fix
2021-04-28 14:45:27 +05:30
Saqib Ansari
aa4f750d8c
fix: test
2021-04-28 14:42:49 +05:30
Saqib Ansari
3f53b87379
Merge branch 'develop' of https://github.com/frappe/erpnext into round-off-diff-allowance
2021-04-28 14:34:51 +05:30
noahjacob
82905166d9
fix: Fixed updating sales order work qty after cancelling work order
2021-04-28 10:14:36 +05:30
Nabin Hait
b7fea12cdf
Merge branch 'version-13' into develop
2021-04-27 20:08:01 +05:30
Nabin Hait
3e5c6424ed
bumped to version 13.1.1
2021-04-27 20:28:01 +05:50
Rucha Mahabal
a86a51f020
fix(HR): Permission error while adding weekly holidays ( #25450 )
2021-04-27 20:01:49 +05:30
Saqib
7b3dd3585b
fix: unexpected keyword argument 'merge_logs' ( #25489 )
...
* fix: unexpected keyword arguement 'merge_logs'
* fix: reference error
* fix: test
2021-04-27 20:01:08 +05:30
Saqib
ad4365eb0e
fix: unexpected keyword argument 'merge_logs' ( #25489 )
...
* fix: unexpected keyword arguement 'merge_logs'
* fix: reference error
* fix: test
2021-04-27 20:00:21 +05:30
Deepesh Garg
8a1e5e189c
fix: Ageing errors in PSOA
2021-04-27 16:57:34 +05:30
barredterra
5b9d3f15a2
docs: replace whitespace indent in docstring with tabs
2021-04-27 12:34:10 +02:00
Raffael Meyer
b2be91e731
Merge branch 'develop' into datev_fixes
2021-04-27 12:21:14 +02:00
rohitwaghchaure
b9078a0c86
Merge pull request #25126 from rohitwaghchaure/purchase-invoice-to-purchase-receipt-develop
...
feat: purchase receipt creation from purchase invoice
2021-04-27 09:56:28 +05:30
Deepesh Garg
ebc6c51abe
Merge pull request #25384 from deepeshgarg007/psoa_fixes
...
fix: Updated filters for process statement of accounts
2021-04-26 22:58:42 +05:30
Afshan
df06e49e0c
feat: enable custom field search on POS ( #25421 )
...
* feat: multi lingual item search in POS
* fix: limit the options for selection and broken down funtion for geting condition
2021-04-26 22:48:13 +05:30
Anurag Mishra
7f1b2de74d
feat: Employee Referral ( #24997 )
...
* feat: Employee referal design and status sync
* feat: create job Applicant and linked Document
* feat: Added list view indicator
* chore: formatted file
* feat: Addedd Employee Referral form Dashboard
* feat: pay compensation via additional salary
* test: Employee Rreferral
* Update erpnext/hr/doctype/employee_advance/employee_advance.js
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
* fix: changes requested
* fix: changes requested
* fix: sider
* fix: translation
* fix: test
* feat: added to Dashboard
* fix: changes
* chore: clean-up Employee Referral form
- fix labels
- fix full name field
- fix failing test
- set title for Employee Referral form
- set fields in List View and Standard Filter
* feat: option to add a resume link
- copy resume and resume link from Employee Referral to Job Applicant
* fix: multiple fixes
- confirm before rejecting employee referral
- set primary actions for custom buttons
- Validations for additional salary against employee referrals with status as accepted only
- fix list view indicators
- code formatting style
* feat: Add field to track Referral Bonus Payment Status
- fix visibility of additional salary button
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
2021-04-26 22:23:48 +05:30
Saqib
b643776c53
feat(e-invoicing): auto calculate distance for e-way bill generations ( #25480 )
2021-04-26 17:12:20 +05:30
Rucha Mahabal
1608658700
Merge pull request #25209 from NagariaHussain/employee-util-report
...
feat: Employee Hours Utilization Report
2021-04-26 17:04:35 +05:30
Saqib
34ce4edf29
fix: cannot scan spacebar character in pos ( #25479 )
2021-04-26 16:38:57 +05:30
Rucha Mahabal
d5ca9474ce
fix: add employee name in report data
2021-04-26 16:10:06 +05:30
Rucha Mahabal
926a9aed58
Merge branch 'develop' into employee-util-report
2021-04-26 16:03:39 +05:30
Rucha Mahabal
7a84d76489
fix: tests
2021-04-26 16:03:10 +05:30
noahjacob
1e912db3bb
feat: Added check box to combine items
2021-04-26 16:01:17 +05:30
Ankush Menat
9178d95cca
fix: can not create item variants ( #25433 )
...
* fix: item_code assigned to function returning None
* fix: ignore has_variants and attributes in variant
* fix: patch to remove has_variants and attributes
* chore: fix whitespace in translation
2021-04-26 15:37:17 +05:30
Jannat Patel
616f1d3624
fix: issue in project custom status ( #25452 )
2021-04-26 15:35:49 +05:30
Sagar Vora
71342320ce
fix(Italy): multiple fixes in import supplier invoice ( #25466 )
...
* fix(Italy): remove incorrect method, use defined variable
* fix: show attach section after save; use db_set
2021-04-26 15:32:28 +05:30
Deepesh Garg
4c8d15b487
fix: Incorrect GL Entry validation ( #25474 )
...
* fix: Incorrect GL Entry validation
* fix: Add validation for party accounts
* fix: Scrub labels
* fix: Translation
2021-04-26 15:24:34 +05:30
Deepesh Garg
ab7664e595
Merge pull request #25444 from deepeshgarg007/gstr_backward_compatiability
...
fix: Backward compatibility for GSTR-1 report
2021-04-26 15:09:55 +05:30
Deepesh Garg
0b9aa58b81
Merge branch 'develop' of https://github.com/frappe/erpnext into psoa_fixes
2021-04-26 14:51:20 +05:30
Deepesh Garg
968ec110f3
fix: Linting and translation issues
2021-04-26 14:51:00 +05:30
Rucha Mahabal
4716ebea5a
feat: Add % Utilization (Billed Only)
...
- Added billed utilization metric in report summary
2021-04-26 11:40:26 +05:30
Anuja Pawar
fee9a56d4e
Merge branch 'develop' into fix_allocated_amt_in_PE
2021-04-26 11:36:10 +05:30
Anuja P
802518b8ac
Merge branch 'fix_allocated_amt_in_PE' of https://github.com/Anuja-pawar/erpnext into fix_allocated_amt_in_PE
2021-04-26 11:34:33 +05:30
Anuja P
f74d8d2e16
fix: suggested changes
2021-04-26 11:31:51 +05:30
Rucha Mahabal
2a1a472371
chore: clean-up
...
- set default date filters for last month instead of year
- added abbreviations for columns to use them in the metrics labels
2021-04-26 11:18:32 +05:30
Shadrak Gurupnor
b9d4719285
fix: circular loop in project task ( #25454 )
...
* fix: circular loop in project task
2021-04-26 11:14:07 +05:30
Rucha Mahabal
0decc2b66a
fix: validate Standard Working Hours
...
- use standard working hours in metrics calculation
2021-04-26 11:00:54 +05:30
Rucha Mahabal
b7a7e1b11a
Merge branch 'develop' into employee-util-report
2021-04-26 10:25:42 +05:30
Rucha Mahabal
e939da982e
Merge branch 'develop' into profitability-report
2021-04-26 09:17:12 +05:30
Rucha Mahabal
2a25c7505e
fix: report column widths
2021-04-25 20:29:14 +05:30
Walstan Baptista
4a805b5622
chore: frappe.whitelist for doc methods ( #25465 )
2021-04-24 14:23:08 +05:30
Anuja Pawar
dc215ec08d
Merge branch 'develop' into fix_allocated_amt_in_PE
2021-04-23 22:06:15 +05:30
Rucha Mahabal
e63f3b2f36
fix: standard working hours message and link for HR Settings
2021-04-23 20:33:42 +05:30
Rucha Mahabal
184317d5bd
fix(HR): Permission error while adding weekly holidays ( #25450 )
2021-04-23 20:03:50 +05:30
Anuja P
dc599e0164
fix: to update Allocated amount after Paid Amount is changed
2021-04-23 19:24:53 +05:30
Saqib Ansari
c5c9f9a941
feat: set dynamic labels for payment schedule fields
2021-04-23 15:34:58 +05:30
Saqib Ansari
d552fe6778
feat: base payment amount in payment schedule
2021-04-23 14:46:52 +05:30
Suraj Shetty
52ea6b126b
Revert "fix: email digest user not found"
...
This reverts commit 188657d05a
.
2021-04-23 14:14:47 +05:30
Saqib Ansari
242242c43f
Merge branch 'develop' of https://github.com/frappe/erpnext into payment-term-amount-display-currency-fix
2021-04-23 13:54:13 +05:30
meike289
8787ebf83d
Apply suggestions from code review
...
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2021-04-23 08:06:29 +02:00
Anoop
c21ce42559
fix(patch): lab module patch fix ( #25447 )
...
* fix(patch): lab module patch fix
* fix: param
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
2021-04-22 22:44:44 +05:30
Deepesh Garg
eed60bf035
fix: Backward compatibility for GSTR-1 report
2021-04-22 17:11:22 +05:30
pateljannat
84ef7419da
fix: sider
2021-04-22 16:31:16 +05:30
Saqib
3d4acf9e5c
fix: permission error after submitting exchange rate revaluation ( #25432 )
2021-04-22 16:16:03 +05:30
Rucha Mahabal
e3b8057eb4
fix: Laboratory Module patch ( #25431 )
2021-04-22 16:11:17 +05:30
pateljannat
2004fec8eb
fix: removed multicurrency
2021-04-22 14:52:36 +05:30
Saqib
19b73968d7
fix(pos): validations & minor ui issues ( #25351 )
...
* fix: pos print format
* fix: stock validation on pos invoice creation
2021-04-22 13:38:20 +05:30
Saqib Ansari
b0e160ff78
fix: ignore fraction difference while making round off gl entry
2021-04-22 13:23:50 +05:30
pateljannat
ba6ad7f5be
fix: escape for format and msg for working hours if not set
2021-04-22 11:19:44 +05:30
Mohammad Hasnain Mohsin Rajan
7f932cfb30
fix: display reconcile tool when closing balance 0 ( #25417 )
...
Co-authored-by: Saqib <nextchamp.saqib@gmail.com>
2021-04-22 04:53:09 +05:30
Alan
157b388209
fix: change subcontracted item display ( #25425 )
2021-04-21 21:00:22 +05:30
Deepesh Garg
66a71bdd1a
fix: Issues on new company setup
2021-04-21 20:42:20 +05:30
Deepesh Garg
50997709d5
fix: Update country-wise-tax JSON and tax setup
2021-04-21 20:41:57 +05:30
Ernesto Ruiz
090177494d
fix: Make strings translatable
...
Make strings translatable
2021-04-21 09:04:06 -06:00
Deepesh Garg
e5e20c50a9
Merge branch 'develop' into purchase-invoice-to-purchase-receipt-develop
2021-04-21 19:09:41 +05:30
pateljannat
485464d1f4
fix: added back a hook
2021-04-21 18:04:58 +05:30
Afshan
6d3305c446
fix: added total column
2021-04-21 15:34:58 +05:30