Deepesh Garg
4abc7da2c0
chore: Add test case
2022-01-19 14:28:00 +05:30
Deepesh Garg
d37feb8208
feat: Splitting group assets
2022-01-19 10:00:05 +05:30
Saqib Ansari
35a6b58c12
feat: purchase grouped asset
2022-01-18 13:10:23 +05:30
Shariq Ansari
bc187c121a
fix: updated standard workspace json files
2022-01-13 19:24:11 +05:30
Saqib Ansari
11fae15bec
fix(asset): check if fixed asset account is set against company ( #29189 )
2022-01-12 13:23:18 +05:30
Saqib
56bc8a52f4
Merge branch 'develop' into home-onboarding
2021-12-15 10:40:40 +05:30
Saqib Ansari
2137e56947
revert: "fix: expected value after useful life validation"
2021-12-13 22:34:54 +05:30
Saqib
4984513597
Merge pull request #28677 from GangaManoj/fix-adjust-asset-value
...
fix: Fix 'Adjust Asset Value' button
2021-12-13 21:51:09 +05:30
Jannat Patel
74d086ffd1
Merge branch 'develop' into home-onboarding
2021-12-13 17:51:38 +05:30
Ganga Manoj
51c707a0ce
Merge branch 'develop' into fix-adjust-asset-value
2021-12-08 19:20:23 +05:30
Ganga Manoj
539cba1b15
Merge branch 'develop' into fix-clear-depr-schedule
2021-12-08 19:19:33 +05:30
Saqib
b1ba98c129
feat: Make Depreciation Entry posting more flexible ( #28421 )
2021-12-06 11:43:09 +05:30
Saqib Ansari
56df646067
fix(test): test_depr_entry_posting_with_income_account
2021-12-06 11:19:58 +05:30
Saqib
fa42cf796b
Merge branch 'develop' into depreciate-existing-asset
2021-12-02 12:13:12 +05:30
Ganga Manoj
9bc28210c9
fix: Make buttons translatable ( #28679 )
2021-12-02 11:31:38 +05:30
Jannat Patel
a108df8efc
fix: assigned proper form tour to onboarding steps
2021-12-02 11:27:37 +05:30
GangaManoj
4629308d94
fix: Rename function
2021-12-02 01:22:18 +05:30
GangaManoj
5b224f841b
fix: Rename variable
2021-12-02 01:19:35 +05:30
GangaManoj
6f1cf94c9f
fix: Fix 'Adjust Asset Value' button
2021-12-02 01:18:30 +05:30
GangaManoj
828769ca70
fix: Remove unnecessary variable
2021-12-02 01:09:15 +05:30
GangaManoj
774ac852c9
fix: Test if depreciation schedules are set up properly for existing assets
2021-12-01 22:51:55 +05:30
GangaManoj
de002005ac
fix: Modify has_pro_rata() to include existing assets
2021-12-01 22:51:08 +05:30
GangaManoj
5c3d4caeda
fix: Create Depreciation Schedules properly for existing Assets
2021-12-01 21:48:47 +05:30
Ankush Menat
bb00d38dd7
Merge branch 'develop' into asset-capitalization
2021-11-30 19:32:11 +05:30
GangaManoj
c94f1ed39a
fix: Change order of import statements
2021-11-25 22:18:57 +05:30
GangaManoj
b28f137ee8
fix: Remove unused import
2021-11-25 22:17:54 +05:30
GangaManoj
6b75d1439f
fix: Add test for consumption of serialized Assets
2021-11-25 22:10:24 +05:30
GangaManoj
efac7b0904
fix: Create setUpClass
2021-11-25 19:02:01 +05:30
GangaManoj
eea80b6c01
fix: Create stock item
2021-11-25 19:01:22 +05:30
GangaManoj
c9e79ef1f2
fix: Replace 'item' with 'item_code' in tests
2021-11-25 18:53:48 +05:30
Ganga Manoj
068177d293
Merge branch 'develop' into serialized-item-consumption
2021-11-24 05:29:56 +05:30
Ganga Manoj
5ef709f569
Merge branch 'develop' into depr-expense-account
2021-11-24 05:26:40 +05:30
GangaManoj
4311936b7d
fix: Edit dates and frequency of depreciation
2021-11-24 05:21:31 +05:30
GangaManoj
6ec5a19063
fix: Test if clear_depreciation_schedule() works for multiple finance books
2021-11-24 03:23:02 +05:30
GangaManoj
33a0b1db2c
fix: Retain depreciation schedule rows that are linked with JEs while clearing the schedule
2021-11-24 03:16:17 +05:30
GangaManoj
f455de2924
fix: Test if multiple Depreciation Schedules are set up for multiple Finance Books
2021-11-23 23:26:32 +05:30
GangaManoj
60d82d913c
fix: Test Depreciation Entry posting when Depreciation Expense Account is an Income Account
2021-11-23 23:07:27 +05:30
GangaManoj
a36713cd2d
fix: Test Depreciation Entry posting when Depreciation Expense Account is an Expense Account
2021-11-23 21:03:03 +05:30
GangaManoj
d406775d1a
fix: Check root_type of Depreciation Expense Account
2021-11-23 20:21:24 +05:30
Ganga Manoj
2e01b40465
Merge branch 'develop' into fix-clear-depr-schedule
2021-11-23 02:41:04 +05:30
GangaManoj
475d8394e4
fix: Clear Depreciation Schedule entries that aren't linked with Journal Entries before modifying the schedule
2021-11-22 21:51:32 +05:30
Ganga Manoj
624e58d1de
fix: Filter out cancelled and non-depreciable Assets in Asset Value Adjustment ( #28443 )
2021-11-22 11:36:35 +05:30
GangaManoj
059d1f3b74
fix: Rename loop variable
2021-11-19 05:35:41 +05:30
GangaManoj
a4043c035d
fix: Prevent clearing of Depreciation Schedule on adding more than one Finance Book
2021-11-19 05:27:06 +05:30
GangaManoj
cb93cc972d
fix: Check all ancestors and not just the root node
2021-11-17 05:22:43 +05:30
GangaManoj
62fbbe8915
fix: Only raise an error if Depreciation Expense Account is neither an Income nor an Expense Account
2021-11-17 04:59:59 +05:30
GangaManoj
8fc31e3cea
fix: Make Depreciation Entry posting more flexible
2021-11-17 04:58:13 +05:30
GangaManoj
aa34780265
fix: Filter Depreciation Expense Account by root type
2021-11-17 04:57:40 +05:30
Saqib
950261d860
Merge branch 'develop' into serialized-item-consumption
2021-11-16 15:59:53 +05:30
GangaManoj
1393f97ad5
fix: Add serial no to Stock Entry doc to decrease quantity for Stock Items consumed during repair
2021-11-11 18:48:23 +05:30
GangaManoj
4668bb4be0
feat: Add 'Add Serial No' button in the Stock Items table
2021-11-11 18:42:25 +05:30
GangaManoj
abb535540a
fix: Rename item to item_code
2021-11-11 18:41:16 +05:30
GangaManoj
1aed8c4b2f
feat: Add Serial No field
2021-11-11 18:40:38 +05:30
Saif Ur Rehman
13f8edd43f
Merge remote-tracking branch 'upstream/develop' into asset-capitalization
...
# Conflicts:
# erpnext/accounts/doctype/sales_invoice/sales_invoice.py
2021-11-09 12:17:17 +05:00
Ankush Menat
8fe5feb6a4
chore: remove all six compat code
2021-11-05 11:16:29 +05:30
Ankush Menat
6098e92ba9
chore: remove utf-8 compat code
2021-11-05 11:16:29 +05:30
Saif Ur Rehman
85d1a237ce
fix(Asset Capitalization): Reverse depreciation on cancel
2021-11-04 14:15:47 +05:00
Saif Ur Rehman
dc3c27fd1b
fix(Asset Capitalization): update code for changes in depreciation logic
2021-11-04 13:47:33 +05:00
Saif Ur Rehman
2d9da22721
Merge branch 'develop' of https://github.com/frappe/erpnext into asset-capitalization
...
# Conflicts:
# erpnext/accounts/doctype/sales_invoice/sales_invoice.py
# erpnext/assets/doctype/asset/test_asset.py
# erpnext/assets/workspace/assets/assets.json
2021-11-04 12:48:33 +05:00
Saqib
ec0a72423a
fix: Calculate depreciation_amount accurately ( #27585 )
2021-11-02 18:45:03 +05:30
Saqib
7681600b5e
fix: test wdv method for indian region
2021-11-02 17:47:44 +05:30
GangaManoj
f047c6ffc8
fix: Test for WDV
2021-11-02 16:43:31 +05:30
Ganga Manoj
15e9b5170d
fix: Make status filter optional ( #28126 )
2021-10-29 18:07:11 +05:30
GangaManoj
06c505ddc2
fix: Linters
2021-10-27 05:23:01 +05:30
GangaManoj
9e7022830e
fix: Only add additional depreciation schedule row on sale if depreciation_amount > 0
2021-10-25 01:34:42 +05:30
GangaManoj
0b8cb5dd47
fix: Add missing digit
2021-10-15 04:56:00 +05:30
GangaManoj
fdeb273fa0
fix: Sider issues
2021-10-15 04:53:23 +05:30
GangaManoj
60aae4423d
fix: Add missing digit
2021-10-15 04:03:30 +05:30
GangaManoj
371b621364
fix: Compare date strings
2021-10-15 04:02:27 +05:30
GangaManoj
e9d310a13e
fix: Format tests
2021-10-15 01:45:53 +05:30
Ganga Manoj
5a0289a810
Merge branch 'develop' into fix-depr-after-sale
2021-10-14 22:37:07 +05:30
GangaManoj
968be70bd1
fix: Remove PR creation from all tests in TestDepreciationBasics
2021-10-14 22:33:35 +05:30
GangaManoj
09215a9781
fix: Remove PR creation from all tests for Depreciation Methods
2021-10-14 22:32:55 +05:30
GangaManoj
4bf01bb4b7
fix: Move Purchase Receipt creation to setUpClass
2021-10-14 22:32:54 +05:30
Saqib
1f70dd6e98
fix: value_after_depreciation calculation ( #27954 )
2021-10-14 16:23:12 +05:30
Ganga Manoj
8cc81a96fc
Merge branch 'develop' into fix-depr-after-sale
2021-10-14 03:12:44 +05:30
GangaManoj
e8986df3ca
fix: Move test for Finance Books to Depreciation test suite
2021-10-13 21:36:10 +05:30
GangaManoj
83ec9879ee
fix: Add test to validate available_for_use_date
2021-10-13 21:21:50 +05:30
GangaManoj
749d1b6ee6
fix: Enable cwip accounting
2021-10-13 20:49:07 +05:30
Shariq Ansari
790c1cda6f
fix: Removing unused fields from workspace JSON files #27612
...
fix: Removing unused fields from workspace JSON files
2021-10-13 16:18:20 +05:30
GangaManoj
a7ec007dcf
fix: Add tests to validate item
2021-10-12 01:33:46 +05:30
GangaManoj
d8aaf3d389
fix: Add tests to validate Asset values
2021-10-12 01:07:11 +05:30
GangaManoj
4918e9533b
fix: Add tearDownClass()
2021-10-10 03:51:35 +05:30
GangaManoj
ef3f2fcb3a
fix: Replace setUp() with setUpClass()
2021-10-10 03:50:45 +05:30
GangaManoj
adebf2d71b
fix: Adjust depreciation_amount in final row
2021-10-06 02:04:05 +05:30
Saqib
065a2ce983
fix(asset): expected value after useful life validation ( #27539 )
2021-10-05 11:14:16 +05:30
Saqib
424efd41e5
feat(regional): toggle for reduced depreciation rate as per IT Act ( #27600 )
2021-09-28 18:12:02 +05:30
GangaManoj
c84c983073
fix: Categorize into test suites
2021-09-28 01:22:38 +05:30
GangaManoj
40ec2d622b
fix: Add tests for depreciation
2021-09-27 22:14:42 +05:30
GangaManoj
fdd9e6cc3c
fix: Replace asset.schedules with asset.get('schedules')
2021-09-27 22:14:16 +05:30
GangaManoj
b9fb59da58
fix: Reset depreciation schedule on returning asset
2021-09-25 19:04:16 +05:30
GangaManoj
249672c35d
fix: Add depreciation_schedule details in create_asset()
2021-09-21 07:11:40 +05:30
GangaManoj
700e78d69b
fix: Remove extra brackets
2021-09-21 07:11:40 +05:30
GangaManoj
3c8879e777
fix: Calculate depreciation_amount accurately
2021-09-21 06:07:06 +05:30
GangaManoj
164a2ad28d
fix: Calculate depreciation_left accurately
2021-09-20 04:33:30 +05:30
Saif Ur Rehman
86a6293e62
test(Asset Capitalization): unit tests
2021-09-16 23:24:46 +05:00
Saif Ur Rehman
c311b8ea4f
fix(Asset Capitalization): validation edge cases
2021-09-16 23:23:22 +05:00
Saif Ur Rehman
003cfe2717
fix(Asset Capitalization): Hide source items section if table is empty
2021-09-16 23:21:09 +05:00
Saif Ur Rehman
132b517584
fix(Asset Captalization): run_serially on posting_date changed
2021-09-16 23:20:36 +05:00
Saif Ur Rehman
d173e06e69
chore(Asset Capitalization): isort linting
2021-09-14 15:13:35 +05:00
Saif Ur Rehman
8873ef7b67
chore(Asset Capitalization): isort linting
2021-09-14 15:05:39 +05:00
Saif Ur Rehman
dc24a657fd
chore(Asset Capitalization): linting
2021-09-14 12:40:17 +05:00
Saif Ur Rehman
8c54be7e99
chore(Asset Capitalization): linting
2021-09-14 12:30:40 +05:00
Saif Ur Rehman
7a5d75b68d
feat(Asset Capitalization): Submission and Cancellation
2021-09-13 23:01:52 +05:00
Saif Ur Rehman
3b9bc8e4ef
feat(Asset Capitalization): Finance Book field in Asset Row
2021-09-12 14:28:14 +05:00
Saif Ur Rehman
702b5c32c1
feat(Asset Capitalization): Accounting Fields
2021-09-08 16:36:07 +05:00
Saif Ur Rehman
6c748966e7
feat: Asset Capitalization Form
2021-09-06 17:27:47 +05:00
Chillar Anand
915b34391c
chore: Clean up imports ( #27302 )
...
* chore: Added isort to pre-commit config
* chore: Sort imports with isort
* chore: Clean up imports with pycln
* chore: Sort imports with isort
* chore: Fix import issues
* chore: Clean up sider issues
* chore: Remove import errors from flake8 ignore list
* chore: Clean up lint issues
2021-09-02 16:44:59 +05:30
Ankush Menat
7d9819f352
fix: remove duplicate imports
2021-09-01 15:33:35 +05:30
Ankush Menat
694ae81618
fix: remove bare excepts
2021-09-01 15:02:28 +05:30
Kamal Johnson
a285b5b78b
feat: Accounts, Selling & Assets Onboarding cleanup ( #27112 )
...
* refactor: company form fields arrangement
* refactor: accounts onboarding steps
* refactor: re-arrange fields & modify labels in company form
* feat: onbording steps for accounts module
* fix: updated onboarding steps for selling module
* fix: remove unwanted steps from accounts
* feat: add more onboarding steps
* feat: Refactor onboarding-module for accounting workspace
* feat: Add basic asset onboarding steps
* feat: Add basic asset item form tour
* feat: Add basic selling onboarding-steps
* feat: Add basic form tour for purchase recipt
* feat: Add basic form tour for existing asset
* feat: Adding asset category form tour
* feat: Add form tour for asset category
* feat: Refactor sales taxes and charges template form tour with new method
* refactor: Remove old form tour for accounts settings
* refactor: Change asset category form tour with new tour method
* refactor: Change asset item form tour with new tour method
* refactor: Change purchase receipt form tour with new tour method
* refactor: Change asset form tour with new tour method
* refactor: Remove old form tour for selling settings
* refactor: general fix/typo in onboarding steps
* Apply suggestions from code review
Co-authored-by: Nabin Hait <nabinhait@gmail.com>
* refactor: Remove old form tour method for sales order.
* fix: removed duplicate section break
* fix: Removed duplicate fields
Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com>
Co-authored-by: Anuja <anuja.pawar20@gmail.com>
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com>
Co-authored-by: Nabin Hait <nabinhait@gmail.com>
2021-08-27 15:47:11 +05:30
Ankush Menat
ae55eab599
chore: remove deprecated and empty QUnit tests ( #27179 )
...
* chore: remove deprecated and empty QUnit tests
* ci: fix UI test config
Testing library was added on Frappe, in order to reuse command testing
library has to be installed during setup process.
2021-08-26 20:43:06 +05:30
Ashish Shah
b99c011947
fix: unable to create manual / auto asset depreciation entry when cost_center is mandatory ( #26912 )
...
Summary : unable to create manual / auto asset depreciation entry when cost_center is mandatory
Reason: Though we are calculating value for depreciation_cost_center, it is not passed in credit_entry(it is passed in debit_entry) and this prevents creation of manual / auto asset depreciation entry when cost_center is mandatory
Solution : pass already calculated depreciation_cost_center value in credit_entry (in line with, already done as in debit_entry)
2021-08-25 21:33:08 +05:30
Ankush Menat
4551d7d602
chore: mass trailing whitespace and EOF fixes
2021-08-19 13:43:28 +05:30
Rohit Waghchaure
eb1e3181a4
fix: conflicts while merging brnach version-13 to develop
2021-08-17 10:53:19 +05:30
Shariq Ansari
b32c2fa561
fix: updated erpnext wspace json files ( #26380 )
...
* fix: updated erpnext wspace json files
* fix: updated wspace json files
* fix: updated wspace json files
* fix: removed padding code from wspace json files
* fix: Updated restrict_to_domain in wspace json
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2021-08-13 12:19:16 +05:30
Ganga Manoj
54c31ed33c
feat: depreciate asset after sale ( #26543 )
2021-08-12 13:42:56 +05:30
marination
455d300fca
Revert "test: fix POS Closing Entry Test"
...
This reverts commit 8f1a3aef2e
.
2021-08-11 17:00:46 +05:30
marination
867939fcae
test: fixed asset movement tests
...
- set cwip account in company to avoid value missing
- removed unused statement
- removed trailing spaces
2021-08-11 16:40:07 +05:30
Saqib
2ae2580706
fix(asset): incorrect date difference calculation ( #26793 )
2021-08-10 16:37:48 +05:30
Saqib
363225d2ba
fix(asset): incorrect date difference calculation ( #26805 )
2021-08-10 16:37:23 +05:30
GangaManoj
56cdcebbf4
fix: Sider issues
2021-07-16 02:23:55 +05:30
Saqib
2e507b47a8
fix(Asset Repair): cancellation
2021-07-09 22:39:34 +05:30
GangaManoj
073b50f7fd
fix(Asset Repair): Rearrange fields
2021-07-09 22:38:58 +05:30
GangaManoj
fd7fb37697
fix(Asset Repair): Simplify code for Asset Repair creation in tests
2021-07-09 22:38:58 +05:30
GangaManoj
e328e3b48a
fix(Asset Repair): Edit description for total_repair_cost
2021-07-09 22:38:57 +05:30
GangaManoj
c8caafa680
fix(Asset Repair): Move filters for cost_center, warehouse and project to setup
2021-07-09 22:38:57 +05:30
GangaManoj
267fed2d23
fix(Asset): Add comment
2021-07-09 22:38:57 +05:30
GangaManoj
597016bb34
fix(Asset): Remove extra tabs
2021-07-09 22:38:57 +05:30
GangaManoj
7c37e83535
fix(Asset): Remove to_date field
2021-07-09 22:38:57 +05:30
GangaManoj
cba0966ec5
fix(Asset Repair): Change controller hooks
2021-07-09 22:38:57 +05:30
GangaManoj
81bcae7433
fix(Asset): Remove redundant code
2021-07-09 22:38:57 +05:30
GangaManoj
f3ae1dd23b
fix(Asset): Fix test
2021-07-09 22:38:57 +05:30
GangaManoj
18bbfdf343
fix(Asset Repair): Remove test that's no longer necessary
2021-07-09 22:38:56 +05:30
GangaManoj
39dba43b87
fix(Asset): Fix value_after_depreciation calculation
2021-07-09 22:38:56 +05:30
GangaManoj
3ba9fb32de
fix(Asset Repair): Replace asset_value with value_after_depreciation in tests
2021-07-09 22:38:56 +05:30
GangaManoj
72ea64f6ac
fix: Sider issues
2021-07-09 22:38:49 +05:30
GangaManoj
307fe43e08
fix: Remove changes made to Asset Maintenance
2021-07-09 22:38:02 +05:30
GangaManoj
55bca4cbc7
fix(Asset Repair): Revert Stock Entry on cancellation
2021-07-09 22:38:02 +05:30
GangaManoj
c34e6b1889
fix(Asset): Fix tests for Asset Repair
2021-07-09 22:38:02 +05:30
GangaManoj
ba9558527d
fix(Asset Repair): Return Depreciation Schedule to original state on cancellation
2021-07-09 22:37:08 +05:30
GangaManoj
6c2f4ce6a5
fix(Asset Repair): Increase stock quantity and decrease asset value on cancellation
2021-07-09 22:37:08 +05:30
GangaManoj
ad78888c86
fix(Asset Repair): Compute total_value instantly
2021-07-09 22:37:08 +05:30
GangaManoj
e921878633
fix: Rename 'Stock Item' to 'Asset Repair Consumed Item'
2021-07-09 22:37:08 +05:30
GangaManoj
852881e33e
fix(Asset Repair): Fix tests
2021-07-09 22:37:04 +05:30
GangaManoj
42fd7ffbc0
fix(Asset Repair): Set completion_date on changing repair_status to 'Completed'
2021-07-09 22:36:05 +05:30
GangaManoj
68e0c96c03
fix(Asset Repair): Prevent some fields from being copied on duplicating the doc
2021-07-09 22:36:05 +05:30
GangaManoj
399d17e40e
fix(Asset Repair): Make Error Description non-mandatory
2021-07-09 22:36:05 +05:30
GangaManoj
e755c74a60
fix(Asset Repair): Add Stock Entry field
2021-07-09 22:36:04 +05:30
GangaManoj
4004bcd436
fix(Asset Repair): Move Total Repair Cost to the Stock Consumption Details section
2021-07-09 22:36:04 +05:30
GangaManoj
bd1796cbb6
fix: Replace edit_dates with flags.increase_in_asset_life
2021-07-09 22:36:04 +05:30
GangaManoj
ae8cb335b6
fix(Asset Repair): Fix depreciation_amount calculation
2021-07-09 22:36:04 +05:30
GangaManoj
be536040df
fix: Add comments
2021-07-09 22:36:04 +05:30
GangaManoj
bd336c7d8e
fix(Asset): Add function to clear old depreciation schedule
2021-07-09 22:36:04 +05:30
GangaManoj
54cbc8324a
fix(Asset Repair): Create GL Entries for each item in Stock Items
2021-07-09 22:36:04 +05:30
GangaManoj
50826f16ee
fix(Asset): Replace asset_value with value_after_depreciation in Finance Books
2021-07-09 22:36:04 +05:30
GangaManoj
d354a301cb
fix(Asset Repair): Display value_after_depreciation in Finance Books
2021-07-09 22:36:04 +05:30
GangaManoj
9520efb941
fix(Asset Repair): Filter Warehouse by Company
2021-07-09 22:36:03 +05:30
GangaManoj
96de4fdf1f
fix(Asset Repair): Fix GL Entry creation
2021-07-09 22:36:03 +05:30
GangaManoj
71eaf3dbd8
fix(Asset Repair): Fix Sider issues
2021-07-09 22:36:03 +05:30
GangaManoj
75fbda10ad
fix(Asset Repair): Make Cost Center non-mandatory
2021-07-09 22:36:03 +05:30
GangaManoj
0aaf88cc0a
fix(Asset Repair): Uncheck allow_on_submit for all fields
2021-07-09 22:36:03 +05:30
GangaManoj
9779aa11fb
fix(Asset Repair): Use existing function from asset.py for fetching fixed_asset_account
2021-07-09 22:36:03 +05:30
GangaManoj
aff9709525
fix(Asset Repair): Add mandatory_depends_on condition for Purchase Invoice
2021-07-09 22:36:03 +05:30
GangaManoj
17fa121779
fix(Asset Repair): Filter Cost Center and Project by Company
2021-07-09 22:36:03 +05:30
GangaManoj
867fd02b2d
fix(Asset Repair): Add Company field
2021-07-09 22:36:03 +05:30
GangaManoj
5ab0cabf91
fix(Asset Repair): Make Stock Items and Warehouse mandatory if stock_consumption is checked
2021-07-09 22:36:03 +05:30
GangaManoj
654074ad7a
fix(Asset Repair): Add title to error messages
2021-07-09 22:36:03 +05:30
GangaManoj
fd272569aa
fix(Asset Repair): Display fields according to the state of the doc
2021-07-09 22:36:02 +05:30
GangaManoj
4e620c3b32
fix: Set asset_name as title
2021-07-09 22:35:49 +05:30
GangaManoj
65b2f9234b
fix(Asset Repair): Set company when creating Stock Entry
2021-07-09 22:15:58 +05:30
GangaManoj
2833903ce5
fix(Asset Repair): Add tests
2021-07-09 22:15:42 +05:30
GangaManoj
70de974496
fix(Asset): Add depreciation schedule details in create_asset()
2021-07-09 22:15:42 +05:30
GangaManoj
3f9f0ffdfe
fix(Asset Repair): Add Company in GL Entries
2021-07-09 22:15:42 +05:30
GangaManoj
c6ed66ec5b
fix(Asset Repair): Remove unnecessary condition
2021-07-09 22:15:42 +05:30
GangaManoj
794807ecc3
fix(Asset Repair): Only modify depreciation schedule if calculate_depreciation is checked
2021-07-09 22:15:42 +05:30
GangaManoj
97193a4632
fix: Sider issues
2021-07-09 22:15:10 +05:30
GangaManoj
4e284433d1
fix: Fix depreciation_amount calculation
2021-07-09 22:12:46 +05:30
GangaManoj
42c70fba3c
fix: Modify depreciation schedule when increase_in_asset_life is not a multiple of frequency_of_depreciation)
2021-07-09 22:11:50 +05:30
GangaManoj
58bc967073
fix: Rename 'Fixed Asset Depreciation Settings' to 'Fixed Asset Deafults'
2021-07-09 22:10:35 +05:30
GangaManoj
9e26f2d797
fix: Organize buttons
2021-07-09 22:08:56 +05:30
Saqib
f6f924b340
Merge branch 'develop' into asset-credit-note
2021-07-09 10:38:50 +05:30
GangaManoj
3a7f25b218
fix: Make functions more readable
2021-07-07 15:59:52 +05:30
GangaManoj
ca87745be1
fix: Rename get_gl_entries_on_asset_movement to get_gl_entries_on_asset_disposal_and_regain
2021-07-06 23:43:08 +05:30
Saqib
40c90d03a4
fix(Asset Repair): cancellation
2021-06-28 11:42:28 +05:30
GangaManoj
ca2dbcec59
fix(Asset Repair): Rearrange fields
2021-06-26 01:32:17 +05:30
GangaManoj
dcb8a2895c
fix(Asset Repair): Simplify code for Asset Repair creation in tests
2021-06-24 22:30:08 +05:30
GangaManoj
c73e137bfa
fix(Asset Repair): Edit description for total_repair_cost
2021-06-24 22:27:30 +05:30
GangaManoj
b44e4121da
fix(Asset Repair): Move filters for cost_center, warehouse and project to setup
2021-06-24 22:25:45 +05:30
GangaManoj
289b449f2b
fix(Asset): Add comment
2021-06-24 22:21:08 +05:30
GangaManoj
f4e8e7d933
fix(Asset): Remove extra tabs
2021-06-24 22:18:59 +05:30
GangaManoj
e21d44c5c3
fix(Asset): Remove to_date field
2021-06-24 15:04:44 +05:30
GangaManoj
2fdb923953
fix(Asset Repair): Change controller hooks
2021-06-24 14:56:34 +05:30
GangaManoj
550fe8ae39
fix(Asset): Remove redundant code
2021-06-24 13:22:26 +05:30
GangaManoj
60a44ae1e6
fix(Asset): Fix test
2021-06-24 12:44:13 +05:30
GangaManoj
dce2113736
fix(Asset Repair): Remove test that's no longer necessary
2021-06-23 22:26:45 +05:30
GangaManoj
2f5f9d8566
fix(Asset): Fix value_after_depreciation calculation
2021-06-23 22:19:05 +05:30
GangaManoj
80399802c6
fix(Asset Repair): Replace asset_value with value_after_depreciation in tests
2021-06-23 13:26:47 +05:30
GangaManoj
32d7b1f6ad
fix(Sales Invoice): Fix GL Entry creation for Return Invoices linked with Assets
2021-06-23 11:24:05 +05:30
GangaManoj
2e45965405
fix(Asset Repair): Fix Sider issues
2021-06-22 17:24:14 +05:30
GangaManoj
859c8c92f7
fix: Remove changes made to Asset Maintenance
2021-06-22 17:16:12 +05:30
GangaManoj
2ea325c0c3
fix(Asset Repair): Revert Stock Entry on cancellation
2021-06-22 16:33:10 +05:30
GangaManoj
3a44d88866
fix(Asset): Fix tests for Asset Repair
2021-06-22 16:28:29 +05:30
GangaManoj
3b0eac79bf
fix(Asset Repair): Compute total_value
2021-06-22 16:26:09 +05:30
Saqib
4b4eb990a9
Merge branch 'develop' into asset-repair-refactor
2021-06-22 16:21:13 +05:30
GangaManoj
5776a962b3
fix(Asset Repair): Return Depreciation Schedule to original state on cancellation
2021-06-21 18:57:11 +05:30
GangaManoj
91a99e0d89
fix(Asset Repair): Increase stock quantity and decrease asset value on cancellation
2021-06-21 15:22:02 +05:30
GangaManoj
f88a13b292
fix(Asset Repair): Compute total_value instantly
2021-06-21 15:02:40 +05:30
GangaManoj
a34bf5edec
fix: Rename 'Stock Item' to 'Asset Repair Consumed Item'
2021-06-21 14:55:34 +05:30
GangaManoj
b081d79332
fix(Asset Repair): Fix tests
2021-06-21 14:52:00 +05:30
GangaManoj
740df95c58
fix(Asset Repair): Set completion_date on changing repair_status to 'Completed'
2021-06-20 17:44:35 +05:30
GangaManoj
23876c0854
fix(Asset Repair): Prevent some fields from being copied on duplicating the doc
2021-06-19 15:23:06 +05:30
GangaManoj
012b9eaeff
fix(Asset Repair): Make Error Description non-mandatory
2021-06-19 15:18:54 +05:30
GangaManoj
7db7988e4c
fix(Asset Repair): Add Stock Entry field
2021-06-19 14:54:30 +05:30
GangaManoj
09ba6f6477
fix(Asset Repair): Move Total Repair Cost to the Stock Consumption Details section
2021-06-19 14:06:45 +05:30
GangaManoj
da8da9fa4e
fix: Replace edit_dates with flags.increase_in_asset_life
2021-06-19 14:00:26 +05:30
GangaManoj
2b93e54e1f
fix(Asset Repair): Fix depreciation_amount calculation
2021-06-19 13:45:37 +05:30
GangaManoj
93b9752771
fix: Add comments
2021-06-19 13:06:27 +05:30
GangaManoj
94dfd0e318
fix(Asset): Add function to clear old depreciation schedule
2021-06-18 09:59:45 +05:30
GangaManoj
354116142a
fix(Asset Repair): Create GL Entries for each item in Stock Items
2021-06-18 09:53:18 +05:30
GangaManoj
05c70ac584
fix(Asset): Replace asset_value with value_after_depreciation in Finance Books
2021-06-17 13:02:02 +05:30
GangaManoj
66d4e2ba51
fix(Asset Repair): Display value_after_depreciation in Finance Books
2021-06-17 08:28:19 +05:30
GangaManoj
34997789cd
fix(Asset Repair): Filter Warehouse by Company
2021-06-16 10:48:07 +05:30
GangaManoj
6d6aee29e8
fix(Asset Repair): Fix GL Entry creation
2021-06-16 10:42:37 +05:30
GangaManoj
491763fa27
fix(Asset Repair): Fix Sider issues
2021-06-16 08:45:54 +05:30
GangaManoj
a33e751b0f
fix(Asset Repair): Make Cost Center non-mandatory
2021-06-16 08:35:50 +05:30
GangaManoj
abb0c769a4
fix(Asset Repair): Uncheck allow_on_submit for all fields
2021-06-16 08:33:05 +05:30
GangaManoj
c61bbc5915
fix(Asset Repair): Use existing function from asset.py for fetching fixed_asset_account
2021-06-16 08:26:02 +05:30
GangaManoj
94ac52c47d
fix(Asset Repair): Add mandatory_depends_on condition for Purchase Invoice
2021-06-16 08:18:45 +05:30
GangaManoj
71c60f75d7
fix(Asset Repair): Filter Cost Center and Project by Company
2021-06-16 08:13:36 +05:30
GangaManoj
9e07b7d4a7
fix(Asset Repair): Add Company field
2021-06-16 08:07:06 +05:30
GangaManoj
bf52f55870
fix(Asset Repair): Make Stock Items and Warehouse mandatory if stock_consumption is checked
2021-06-16 07:56:40 +05:30
GangaManoj
695cd70994
fix(Asset Repair): Add title to error messages
2021-06-16 07:50:03 +05:30
GangaManoj
14ea9ebcb7
fix(Asset Repair): Display fields according to the state of the doc
2021-06-16 07:03:32 +05:30
GangaManoj
285bc60684
fix(Asset Repair): Set asset_name as title
2021-06-15 12:02:07 +05:30
GangaManoj
d4acf87feb
fix(Asset Repair): Make Accounting Dimensions section collapsible
2021-06-15 11:37:17 +05:30
Ankush Menat
9891780f5a
perf(minor): remove unnecessary comprehensions (port #25645 )
2021-06-11 18:40:22 +05:30
Ankush Menat
a9c84f749a
perf(minor): remove unnecessary comprehensions ( #25645 )
2021-06-11 16:00:48 +05:30
Saqib
6eeaf9b933
Merge branch 'version-13-hotfix' into asset-repair-refactor
2021-06-08 17:26:50 +05:30
GangaManoj
12d9e3b1e6
fix(Asset Repair): Add tests
2021-06-03 22:41:57 +05:30
GangaManoj
b55649f2ec
fix(Asset): Add depreciation schedule details in create_asset()
2021-06-03 22:28:30 +05:30
GangaManoj
aa9bbe51bd
fix(Asset Repair): Add Company in GL Entries
2021-06-03 21:28:58 +05:30
GangaManoj
034f7bde33
fix(Asset Repair): Remove unnecessary condition
2021-06-03 21:12:43 +05:30
GangaManoj
9fb47795c4
fix(Asset Repair): Only modify depreciation schedule if calculate_depreciation is checked
2021-06-03 04:55:49 +05:30
GangaManoj
2ceeb8138d
fix(Asset Repair): Set company when creating Stock Entry
2021-06-03 01:54:44 +05:30
GangaManoj
960840dc3a
fix(Asset Repair): Set completion_date
2021-06-03 01:53:13 +05:30
Suraj Shetty
19c5fd72d6
refactor: Rename assertEquals to assertEqual to avoid deprecation warnings
2021-05-28 09:10:33 +05:30
GangaManoj
03a6977a01
fix: Sider issues
2021-05-25 21:35:06 +05:30
GangaManoj
1d7dda2664
fix(Asset): Fix depreciation_amount calculation
2021-05-25 21:35:03 +05:30
GangaManoj
28ca383534
feat(Asset): Edit value_after_depreciation
2021-05-25 21:31:13 +05:30