Ankush Menat
915e0347b0
chore!: remove activity log feeds ( #33294 )
...
- This contains little to no information and practically no one uses this.
- Also causes a lot of problem by adding way too many feeds in activity
log to the point where activity page doesn't even load.
2022-12-12 15:14:30 +05:30
Ankush Menat
7e1742956c
refactor: Remove usage of deprecated methods ( #32914 )
...
Warn: Just used regex to replace all usage.
```regex
s/frappe.db.set(\(.*\),\(.*\),\(.*\))/\1.db_set(\2, \3)/g
```
Required after: https://github.com/frappe/frappe/pull/18815
2022-11-09 20:09:06 +05:30
Rohit Waghchaure
f9a7b31b5b
fix: Purposes not set
2022-08-24 17:16:01 +05:30
Rucha Mahabal
3fe2ef6790
chore: update import paths for HR
2022-06-15 12:43:45 +05:30
Rucha Mahabal
512c82f76d
chore: Update imports/paths for doctypes moved to erpnext setup module
2022-06-10 15:06:54 +05:30
Noah Jacob
8261b2bb4f
refactor: trigger generate schedule when any change made in items table ( #29874 )
...
* refactor: trigger generate schedule when any change made in items table
* chore: added serial validation on server side
* test: serials updated in schedules after save
* fix: schedule not generating after updating some fields
* feat: generate_schedule is triggered on_save when items table is changed
* test: updated tests to check other field changes on save
* chore: removed serial validation function for schedules table and added no_of_visits validation function
* test: updated for manually deleted schedele rows
* refactor: updated validate_items_table_change to return bool
* test: updated test_schedule_with_serials to cover validate_items_table_change
* fix: linting
2022-04-12 15:30:49 +05:30
Ankush Menat
60fb71bd2a
fix: ignore item-less maintenance visit for sr no ( #30684 )
2022-04-12 11:14:02 +05:30
Ankush Menat
a896895a9e
fix: bulk fix (~330) missing translations
2022-04-04 13:59:51 +05:30
Ankush Menat
494bd9ef78
style: format code with black
2022-03-28 18:52:46 +05:30
Noah Jacob
11c9a5a79f
fix: update status on visit cancel ( #29389 )
...
* fix: update status on cancelling visit
* test: updated test for cancelling visits
2022-01-21 14:48:33 +05:30
Noah Jacob
dec7513773
fix: Serial No. filters for unscheduled visits
2022-01-17 18:31:58 +05:30
Noah Jacob
b98c61f2a7
refactor: moved purpose table mandatory check to server
2021-12-17 13:47:39 +05:30
Noah Jacob
90d32006f4
fix(test): fixed test case not creating serials
2021-12-17 13:32:30 +05:30
Noah Jacob
450369dbae
Merge branch 'develop' into maint_sch_link_fix
2021-12-17 12:07:26 +05:30
Noah Jacob
9109660a69
test: added test for serial no. filters
2021-12-17 11:57:17 +05:30
Noah Jacob
4cb5b627a1
fix: mapping to maintenance visit gets erased ( #28917 )
...
* fix: mappings to maintenance visit gets erased
* test: mapping of schedule to visit
2021-12-16 23:06:48 +05:30
Noah Jacob
4f52b86d7e
refactor: update_serial_no function and code cleanup
2021-12-15 15:24:39 +05:30
aaronmenezes
90b98440e2
fix: Maintenence Visit -Purpose (item ) tables is not visible on submitted or saved entries ( #28792 )
2021-12-08 14:48:19 +05:30
Noah Jacob
eb522a3746
refactor: map serial from schedule if only one
2021-12-06 13:43:02 +05:30
Deepesh Garg
ce06aaa0ae
Merge pull request #27735 from GangaManoj/fix-so-cancellation-message
...
fix: Sales Order cancellation message
2021-11-15 18:51:30 +05:30
Ankush Menat
6098e92ba9
chore: remove utf-8 compat code
2021-11-05 11:16:29 +05:30
Saqib
cc07c71bbd
Merge branch 'develop' into fix-so-cancellation-message
2021-10-27 15:19:18 +05:30
GangaManoj
78825f2c6c
fix: Add extra line
2021-10-27 06:18:24 +05:30
GangaManoj
29fc4da4c6
fix: Create Maintenance Visit
2021-10-27 04:47:26 +05:30
Noah Jacob
af1b9e100e
fix: changes in schedules gets overwritten on save
2021-10-19 12:08:32 +05:30
Ankush Menat
3d3655ed73
fix: ignore random periodicity in validations
2021-10-05 15:52:11 +05:30
Marica
cc143bca0d
fix: Maintenance Schedule child table status for legacy data ( #27554 )
...
* fix: Maintenance Schedule child table status for legacy data
* fix: Include legacy draft schedules in patch
* fix: Pre-commit formatting
2021-09-30 14:08:45 +05:30
Noah Jacob
5e0b21582a
fix: table data deleted on submitted maintenance schedule ( #27513 )
2021-09-15 17:37:52 +05:30
Noah Jacob
acdb10377f
refactor: .doc missing and empty row on new doc ( #27408 )
...
* refactor: .doc missing and empty row on new doc
* fix: let -> const
2021-09-09 18:54:00 +05:30
Chillar Anand
915b34391c
chore: Clean up imports ( #27302 )
...
* chore: Added isort to pre-commit config
* chore: Sort imports with isort
* chore: Clean up imports with pycln
* chore: Sort imports with isort
* chore: Fix import issues
* chore: Clean up sider issues
* chore: Remove import errors from flake8 ignore list
* chore: Clean up lint issues
2021-09-02 16:44:59 +05:30
Pawan Mehta
db69d1dc00
fix: fetch from more than one sales order in Maintenance Visit ( #26924 )
...
* [fix] #26336
* fix(ux): make customer field reqd for fetching SO
Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
2021-08-26 22:54:24 +05:30
Ankush Menat
ae55eab599
chore: remove deprecated and empty QUnit tests ( #27179 )
...
* chore: remove deprecated and empty QUnit tests
* ci: fix UI test config
Testing library was added on Frappe, in order to reuse command testing
library has to be installed during setup process.
2021-08-26 20:43:06 +05:30
Ankush Menat
4551d7d602
chore: mass trailing whitespace and EOF fixes
2021-08-19 13:43:28 +05:30
Nabin Hait
0950481253
fix: merge conflict
2021-06-15 20:18:06 +05:30
Noah Jacob
6fb218e033
refactor: suggested changes
2021-05-28 16:15:50 +05:30
noahjacob
0b02f1335f
refactor: removed redundant links in test case
2021-05-28 11:04:34 +05:30
noahjacob
d071586589
refactor: removed maintenance schedule detail link
2021-05-28 10:54:35 +05:30
noahjacob
7fa045c1c9
refactor: using parent form links of maintenance schedule
2021-05-28 10:54:35 +05:30
noahjacob
3bca90dbe6
refactor: updated mapping for maintenance schedule links in maintenance visit
2021-05-28 10:54:22 +05:30
noahjacob
fbc8694291
refactor: added maintenance schedule links to parent form
2021-05-27 17:37:57 +05:30
noahjacob
bd783e8072
refactor: renamed item_ref to item_reference
2021-05-27 17:34:16 +05:30
noahjacob
9e4c28852e
refactor: added maintenance visit to maintenance schedule dashboard
2021-05-27 17:25:50 +05:30
noahjacob
dc51388666
style: fixed indentations and formatting
2021-05-26 18:28:24 +05:30
Suraj Shetty
81d49e9c71
fix: Use extend_cscript function to properly extend class methods to cscript
2021-05-21 17:03:09 +05:30
noahjacob
f0e6a16910
test: updated test for generated schedule dates
2021-05-20 19:29:12 +05:30
noahjacob
0169cd845a
fix: sider
2021-05-20 15:40:07 +05:30
noahjacob
08598238d7
refactor: suggested changes
2021-05-20 13:23:10 +05:30
Faris Ansari
69eb6d476e
Merge remote-tracking branch 'upstream/develop' into esbuild
2021-05-07 15:21:33 +05:30
noahjacob
c0352010d3
test: creating schedule and visit
2021-04-30 14:09:30 +05:30
noahjacob
7ad66caf7f
refactor: migrated calculation and validation logic in js to py
2021-04-30 11:43:38 +05:30
