Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
44,877 Commits 3 Branches 0 Tags 1 GiB
17ef3c964f
Commit Graph

155 Commits

Author SHA1 Message Date
Ankush Menat
8dc1ce12d4 chore: simplify bug report form 2021-12-22 12:13:31 +05:30
Ankush Menat
fe597cdd3b chore: remove unused issue tempaltes 
[skip ci]
 2021-12-10 18:33:58 +05:30
Ankush Menat
fcb614d1b7 chore: correct form format for issues 2021-12-10 18:23:24 +05:30
Ankush Menat
bf48f17600 chore: new and improved bug report form 
[skip ci]
 2021-12-10 18:17:21 +05:30
Ankush Menat
ffa3d45c42 chore: update stale rules and apply on issues 
[skip ci]
 2021-12-10 18:17:21 +05:30
Conor
03370c63c5
chore: minor typo correction in CONTRIBUTING (#28386) 2021-11-14 09:46:31 +05:30
Ankush Menat
b728597ef4 fix: use hotfix branches for patch tests 2021-11-10 19:41:55 +05:30
Revant Nandgaonkar
c2697bca76 ci: change GITHUB_PAT to CI_PAT 2021-11-03 13:52:37 +05:30
Revant Nandgaonkar
c587f18735 chore: migrate docker to github actions 2021-11-02 12:09:41 +05:30
Ankush Menat
27cbeb920e test(patch): run patch tests for major releases 
Run patch tests one at a time
v10 db -> v12-> v13 -> .... -> frappe:corresponding base branch and PR.
 2021-11-01 17:44:46 +05:30
Ankush Menat
4ad2b851c4 chore: change semgrep rules repo name 
[skip ci]
 2021-10-22 22:39:11 +05:30
Ankush Menat
cc1baae5eb
ci: move semgrep rules out of repo (#28067) 
Moving semgrep rules out of repos as it's unnecessary to maintain
same ruleset for different repos and different branches.
 2021-10-22 21:43:50 +05:30
Ankush Menat
5ada11b1af ci: run semgrep after basic linters 2021-10-20 19:09:57 +05:30
Ankush Menat
92c0dcc3ea ci: install dev requirements in CI 2021-10-20 19:09:57 +05:30
gavin
9916b87767
ci: Rule Added for using frappe.qb over db.sql* (#28000) 
ERPNext port of https://github.com/frappe/frappe/pull/14481


Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
Co-authored-by: abhishek <as7122000@gmail.com>
 2021-10-19 14:20:09 +05:30
Mohammad Hussain Nagaria
904381295e
chore: Add Try on Frappe Cloud button to README (#27950) 2021-10-13 20:07:27 +05:30
Ankush Menat
06b426e9c3
ci: rule to fail PRs that add a new manual commit (#27928) 
Manual commits are frequent source of bugs, confusions or undefined
behaviour.

All new manual commits should be explcitly ignored with explanation on
why it's added. This will only fail for new additions. Existing ones
need to be cleaned up manually.
 2021-10-12 23:01:37 +05:30
ChillarAnand
4dc17a856e fix(CI): Use bugbear instead of flake8-mutable 2021-10-11 11:17:55 +05:30
Chillar Anand
772d4753e7
refactor: Clean up mutable defaults and add CI check (#27828) 
* refactor: Clean up mutable defaults and add CI check
 2021-10-06 16:58:48 +00:00
Ankush Menat
35e30bdcaf
ci: fail build if asset bundling fails (#27820) 2021-10-05 21:44:34 +05:30
Suraj Shetty
1fc8fcc258 ci: Upload coverage report to codecov 2021-09-10 08:08:00 +05:30
Dany Robert
fa819f2fb0
fix: General Ledger translation issues (#27298) 
* fix: remove translations from GL report options

Options need not be translated, their display label gets translated
client side.

* fix: make group by options translatable

* ci: semgrep rule for translated options in report

Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
 2021-09-08 16:28:05 +05:30
Ankush Menat
5596988c94
ci: fix docs checker for wiki based docs (#27380) 2021-09-07 14:53:30 +05:30
Chillar Anand
915b34391c
chore: Clean up imports (#27302) 
* chore: Added isort to pre-commit config

* chore: Sort imports with isort

* chore: Clean up imports with pycln

* chore: Sort imports with isort

* chore: Fix import issues

* chore: Clean up sider issues

* chore: Remove import errors from flake8 ignore list

* chore: Clean up lint issues
 2021-09-02 16:44:59 +05:30
Ankush Menat
65279c2471
ci: add strict config for flake8 2021-09-01 16:57:21 +05:30
Alan
72ece75b11
ci(semgrep): add translation checks for report labels (#27280) 
* ci(semgrep): add translation checks for report labels

* refactor: shift report tests to it's own yml

path can't be applied on a test id basis

* ci: ignore regional report in translation checks

[skip ci]
 2021-09-01 14:19:39 +05:30
gavin
dea14eef51
Merge pull request #27240 from ankush/ubuntu_ci 
ci: switch to latest LTS Ubuntu version
 2021-08-31 18:22:30 +05:30
Ankush Menat
602374a0a4
ci: switch to latest LTS Ubuntu version 2021-08-30 19:32:53 +05:30
Ankush Menat
9de0f7538f
ci: concurrency control for CI jobs (#27230) 
similar to https://github.com/frappe/frappe/pull/14061

This will ensure that only one instance of the following tests run per
PR and cancel previous running/queued jobs when new commits are pushed.

- Server / unit tests
- UI tests
- Patch test
 2021-08-30 14:07:13 +05:30
Ankush Menat
e5e00700e5
ci: use node action instead of apt (#27220) 2021-08-30 12:07:11 +05:30
Ankush Menat
ae55eab599
chore: remove deprecated and empty QUnit tests (#27179) 
* chore: remove deprecated and empty QUnit tests

* ci: fix UI test config

Testing library was added on Frappe, in order to reuse command testing
library has to be installed during setup process.
 2021-08-26 20:43:06 +05:30
Ankush Menat
8bbec42fa0
fix: undo changes to patch (#26983) 
* fix: undo changes to patch

* ci: ignore empty body / head
 2021-08-17 15:14:13 +05:30
Rucha Mahabal
39efc62b94
feat: Organizational Chart (#26893) 
* feat: Organizational Chart

* feat: org chart mobile interactions

* feat(mobile): sibling node group expansion and rendering

* fix: expanded node group interactions and visibility

* feat: connectors for mobile node cards

* fix: don't refresh connections for same node

- remove all connectors while expanding a group node

* chore: create separate files for Desktop and Mobile view and bundle assets

* refactor: add options to chart

- method to return the node data

- wrapper for showing the hierarchy

* feat: setup node edit action

* fix: revert changes in employee descendants query

* refactor: use arcs instead of bezier curves for cleaner connectors

* feat: add arc to connectors in mobile view

* fix: edit node button overflowing

* fix: sider

* fix: removing orphaned connectors

* fix: unnecessary variables

* feat: handle multiple root / orphan nodes

* perf: Optimise Rendering

- optimise get_children function

- use promises instead of callbacks

- optimise selectors

- use const wherever possible

- use pure js instead of jquery for connectors for faster rendering

* fix: do not sort by number of connections

* feat: use icon for connections on mobile view

* fix: exclude active node while fetching sibling group

* fix: sibling group expansion not working for root nodes

* fix(mobile): collapsed nodes not expanding

* fix: sider

* test: UI tests for org chart desktop

* test: UI tests for org chart mobile

fix(mobile): detach node before emptying hierarchy

fix(mobile): sibling group not rendering for first level

* fix: sider

* ci(cypress): use env variable for key

documentation ref: https://docs.cypress.io/guides/guides/command-line\#cypress-run

* fix(tests): clear filter before typing

* fix(tests): apply filters correctly

* fix: tests

* fix: tests

* fix: tests

* fix(test): increase timeout for record creation

* fix: sider

* fix: sider

* feat: Expand All nodes option in Desktop view

* feat: add html2canvas for easily exporting html to images using canvas

* feat: Export chart option in desktop view

* fix(style): longer titles overflowing

* fix: remove unnecessary imports

* fix: test

* fix: make bundled assets for hierarchy chart

* fix(style): apply svg container margin only in desktop view

* fix: Nest `.level` class style under `.hierarchy` class (#26905)

fix: Nest `.level` class style under `.hierarchy` class

* fix: add z-index to filter to avoid svg wrapper overlapping

* fix: expand all nodes not working when there are only 2 levels

- added dom freeze while expanding all nodes and exporting

* fix: test

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
 2021-08-16 20:42:23 +05:30
Ankush Menat
2a43fe1a22
ci: ignore backports while checking docs (#26962) 
[skip ci]
 2021-08-16 18:03:21 +05:30
Rucha Mahabal
4981746b9a
Merge branch 'develop' into org-chart-develop 2021-08-15 20:50:56 +05:30
Ankush Menat
8a6b82b196
ci: ignore js files in unittests (#26934) 
* ci: ignore js files in unittests

- Avoid running python unittests on PRs that ONLY change JS files.

* ci: ignore md files in test workflows
 2021-08-13 12:59:27 +05:30
Rucha Mahabal
9dfddca22e ci(cypress): use env variable for key 
documentation ref: https://docs.cypress.io/guides/guides/command-line\#cypress-run
 2021-08-10 17:56:23 +05:30
Ankush
0bb60b37df
chore: add timeout to GHA workflows (#26714) 2021-07-29 17:15:12 +05:30
Ankush
e906acdc49
chore: change location of backport action (#26705) 2021-07-29 13:56:21 +05:30
Ankush
057a0a9842
ci: auto backport squashed commits based on labels (#26622) 2021-07-25 12:49:05 +05:30
Ankush Menat
28d52c4a95
chore: remove warning rules 
semgrep-action doesn't consider severity, hence ignoring these rules for now.
 2021-07-21 19:54:06 +05:30
Suraj Shetty
47f200a70d
chore: Update stale.yml 
reduce `daysUntilStale` & `daysUntilClose` to keep the contributors active.
 2021-07-20 16:13:49 +05:30
Ankush
a6d80dcc2a
chore: disable semgrep on push events (#26523) 2021-07-16 13:01:57 +05:30
Ankush
1b5f3cf605
ci: make semgrep ignore existing errors (#26516) 2021-07-15 19:30:05 +05:30
Ankush Menat
203c2b2292 ci: show bench logs if ui test fails 2021-07-12 10:09:50 +05:30
Ankush Menat
a68344fe8a refactor: extend commands from frappe 2021-07-01 21:26:18 +05:30
Ankush Menat
3f14b92e2c ci: UI tests workflow 2021-07-01 21:26:18 +05:30
Suraj Shetty
e8e4841e5e ci: Build frappe assets 
- Build frappe assets since it is used for print views
 2021-06-17 20:23:18 +05:30
Gavin D'souza
c68006b607 ci: Update ERPNext backup patch test >= v10 
* Generated v10 backup archive
    * used old v7 erpnext backup hosted via build.erpnext.com
    * upgraded to v10 frappe + erpnext
* Hosted backup on https://erpnext.com/files/v10-erpnext.sql.gz
 2021-06-04 11:49:56 +05:30
Suraj Shetty
5b17f335d1
ci: Add coveralls_repo_token env variable 2021-06-01 08:18:56 +05:30
Nabin Hait
a3d1b6973a fix: merge conflict 2021-05-31 11:21:33 +05:30
Suraj Shetty
97687839b0
ci: Run mariadb tests after PR merge for coverage badge 2021-05-28 13:39:53 +05:30
Ankush Menat
073dcf7e42
ci(semgrep): fix false positives (#25823) 2021-05-25 14:06:10 +05:30
Suraj Shetty
28fdb2e6fa ci: Update Python version to 3.7 2021-05-12 23:13:11 +05:30
Suraj Shetty
1f025a84f5 ci: Update frappe branch 2021-05-12 18:14:22 +05:30
Ankush Menat
b1f8c80be3
ci: enable semgrep check on v13 branches and update rules (#25647) 
* ci: enable semgrep on v13 branches

* ci: break semgrep steps for nicer output

* ci: update semgrep rules inline with frappe repo
 2021-05-11 18:27:20 +05:30
Suraj Shetty
042118aafd ci: Use only 3 containers for now 2021-05-11 10:09:06 +05:30
Suraj Shetty
6408367285 ci: Add test orchestrator URL 2021-05-10 23:48:37 +05:30
Suraj Shetty
5ce2da8bed fix: Pass ORCHESTRATOR_URL via secrets 2021-05-10 16:13:43 +05:30
Suraj Shetty
dfb8aa017d ci: Check limits 2021-05-09 14:38:54 +05:30
Suraj Shetty
7044bcfaab ci: Try parallel testing with orchestrator 2021-05-09 11:29:00 +05:30
Suraj Shetty
d27e70a67a ci: Fix coveralls 2021-05-08 16:02:40 +05:30
Suraj Shetty
622bf077e7 ci: Disble failfast temporarily 2021-05-08 13:51:34 +05:30
Suraj Shetty
ccf6249bfb chore: Debug 2021-05-08 00:05:48 +05:30
Suraj Shetty
490aed2a16 chore: Debug 2021-05-08 00:04:34 +05:30
Suraj Shetty
5117cbc08c ci: Enable coveralls 2021-05-07 00:32:00 +05:30
Suraj Shetty
5f7546d876 chore: Debug 2021-05-06 15:13:09 +05:30
Suraj Shetty
af4af7737f chore: Debug 2021-05-06 13:05:03 +05:30
Suraj Shetty
ee35444c3f fix: Frappe branch 2021-05-04 18:58:20 +05:30
Suraj Shetty
cd8ee8ea97 ci: Try Parallel tests 2021-05-04 18:36:45 +05:30
Mohammad Hasnain Mohsin Rajan
0dc00219e8
fix: coveralls different services for different events (#25513) 2021-04-29 15:21:16 +05:30
Mohammad Hasnain Mohsin Rajan
c9187b00af
fix: change coveralls version (#25499) 2021-04-28 13:32:27 +05:30
Rohan Bansal
524b81abd9 feat: manage Python 3 compatiblity with dependencies 2021-04-20 14:13:55 +05:30
Ankush Menat
c28fcba779
ci(semgrep): add correctness rule for on_cancel 
Changes done to doctype object in `on_submit` are not commited to
database. Add rule to catch similar bugs.
 2021-04-18 13:22:19 +05:30
Ankush Menat
67e647232c
ci(semgrep): Add semgrep testing (#24871) 
Adds semgrep testing in CI.

Refer to:
- https://github.com/frappe/frappe/pull/12524
- https://github.com/frappe/frappe/pull/12577
 2021-04-16 21:44:49 +05:30
Mohammad Hasnain Mohsin Rajan
192ab05869
ci: use ubuntu 18 specifically (#24904) 2021-03-18 17:12:12 +05:30
Sagar Vora
c647b6088a
ci: update badge in README and add push event trigger (#24911) 2021-03-17 20:04:59 +05:30
Sagar Vora
19bb8c1137
ci: get branch name from GITHUB_REF if GITHUB_BASE_REF not available (#24913) 2021-03-17 20:03:54 +05:30
Mohammad Hasnain Mohsin Rajan
46d5431bad
fix: Github Action not failing when tests fail (#24867) 
Co-authored-by: Sagar Vora <sagar@resilient.tech>
 2021-03-15 11:17:19 +05:30
Mohammad Hasnain Mohsin Rajan
0f60f08f3e
ci: Port CI test from Travis to Github Actions (#24846) 2021-03-12 14:09:52 +05:30
Suraj Shetty
8586c08639 chore: Update translation syntax checker 2021-02-01 20:09:42 +05:30
Raffael Meyer
f2206c27e7
fix: allow other github links in same PR (#23995) 2020-12-15 09:35:16 +05:30
gavin
31ac7d982a
chore(GitHub): Add issue template config 2020-11-27 15:58:07 +05:30
Suraj Shetty
0a6770a4ef
chore: GitHub actions for translation syntax validation and docs link (#23627) 
* chore: Add GA for translation syntax validation

* chore: Documentation link checker

Co-authored-by: Gavin D'souza <gavin18d@gmail.com>

* fix: URL

Co-authored-by: Nabin Hait <nabinhait@gmail.com>

Co-authored-by: Gavin D'souza <gavin18d@gmail.com>
Co-authored-by: Nabin Hait <nabinhait@gmail.com>
 2020-10-14 10:21:31 +05:30
Revant Nandgaonkar
d39c97e281
fix: trigger docker build on release (#22353) 2020-06-19 23:56:53 +05:30
Chinmay Pai
755e7c812a
chore: update travis url for docker build action (#22274) 
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
 2020-06-18 10:05:53 +05:30
Revant Nandgaonkar
3375a2e85a
ci: trigger docker build on release (#22128) 2020-06-06 21:08:49 +05:30
Mangesh-Khairnar
df1ba3eec7 chore: Add github action to automate backporting 2020-02-19 19:33:27 +05:30
gavin
5e39968878 chore: update discuss.frappe.io link in template (#20412) 2020-01-27 15:26:02 +05:30
Gavin D'souza
ce77c4ac4c fix(docs): link update frappe => erpnext 2019-10-22 13:20:02 +05:30
Gavin D'souza
22bc0a929b chore(docs): Added contribution templates, SECURITY policy 2019-10-22 13:14:57 +05:30
Prateeksha Singh
50b6a5ddc8
Update stale.yml 2018-11-26 14:44:26 +05:30
Rushabh Mehta
2a5dc911e6 [github] remove issue template 2018-07-05 10:47:59 +05:30
Rushabh Mehta
b9b2bc9ace
Update PULL_REQUEST_TEMPLATE.md 2018-07-05 10:45:48 +05:30
Prateeksha Singh
f845e749f2
Update stale-bot config 2018-06-25 11:06:32 +05:30
Prateeksha Singh
f9284228f1 [probot-stale] add config 2018-06-21 10:28:44 +05:30
Shreya Shah
0cf4ee6bf2 Fix sentence structure (#14357) 2018-06-05 14:18:16 +05:30
Ameya Shenoy
cce7189b4f Added issue and PR Templates (#14300) 2018-05-31 08:42:52 +05:30
Rushabh Mehta
c75becc42c [minor] README.md and CONTRIBUTING.md 2017-04-28 16:09:57 +05:30
Rushabh Mehta
fe5c95e360 Update CONTRIBUTING.md 2017-03-27 20:41:51 +05:30