ruthra kumar
0cf9ff0a04
Merge pull request #38766 from ruthra-kumar/7101_only_treat_none
...
fix: validation error on reconciling PE to Journals as Invoice
2023-12-15 13:09:06 +05:30
Gursheen Anand
f7b2380ec1
fix: skip jvs against bank accounts
2023-12-15 12:30:15 +05:30
ruthra kumar
5eeb650dfd
fix: validation error on reconciling PE to Journals as Invoice
...
With the same exchange rate on Journal Entry and Payment Entry,
reconcilition should not post exc gain/loss journal and should not
throw validation error
2023-12-15 11:46:12 +05:30
ruthra kumar
c68ad73c6e
Merge pull request #38717 from ruthra-kumar/7101_payment_reconciiation_bug
...
fix: fetch exc rate of multi currency journals on reconciliation
2023-12-14 09:35:12 +05:30
ruthra kumar
1b3ba25220
fix: fetch exc rate of multi currency journals
2023-12-13 16:39:42 +05:30
ruthra kumar
d4ac57704c
Merge pull request #38685 from ruthra-kumar/get_list_for_virtual_child_doctypes
...
refactor: add `get_list` for virtual child doctypes
2023-12-12 14:40:43 +05:30
ruthra kumar
15c90551b6
refactor: add get_list for virtual child doctypes
2023-12-12 13:36:03 +05:30
ruthra kumar
0acd0f50c5
Merge pull request #38679 from ruthra-kumar/refactor_repost_test
...
refactor(test): repost utility deletion flag test
2023-12-12 12:43:58 +05:30
ruthra kumar
acb6e8e120
refactor(test): update repost settings before test case
2023-12-12 11:39:55 +05:30
ruthra kumar
ccff588563
refactor: increase limit and remove explicit call to start_repost
2023-12-12 11:30:33 +05:30
ruthra kumar
a97b3db749
refactor: remove explicit commit on repost
2023-12-12 10:34:51 +05:30
ruthra kumar
cc15f695b4
refactor(test): repost utility deletion flag test
2023-12-12 10:24:24 +05:30
Raffael Meyer
6ad298adfc
fix: typo in unittest ( #38673 )
2023-12-12 09:55:15 +05:30
Raffael Meyer
f99bb61181
Merge pull request #38591 from barredterra/de-morgan
2023-12-06 22:30:03 +01:00
sandratridz
d34787cf6d
fix: only highest eligible coupon applied ( #38416 )
...
* fix: application of pricing rule when coupon is used
2023-12-06 14:41:02 +05:30
barredterra
eb9ee3f79b
refactor: simplify conditional logic
...
Command: `sourcery review --fix --enable de-morgan .`
2023-12-05 11:22:55 +01:00
ruthra kumar
5da3e532c9
Merge pull request #38580 from ruthra-kumar/finance_book_filter_bug_in_general_ledger
...
fix: sql error while filtering on finance book in GL
2023-12-05 14:40:34 +05:30
ruthra kumar
b1d9f3132d
fix: sql error while filtering on finance book in GL
2023-12-05 14:06:15 +05:30
ruthra kumar
84ee50e492
Merge pull request #38570 from ruthra-kumar/ignore_unreconcile_on_pi_cancel
...
refactor: ignore unreconcile doc on PI cancel/delete
2023-12-05 12:02:44 +05:30
ruthra kumar
1a5d56977e
refactor: ingore on JE cancel as well
2023-12-05 11:34:25 +05:30
ruthra kumar
4ca84eadb6
refactor: ignore unreconcile doc on PI cancel/delete
2023-12-05 10:14:44 +05:30
Gursheen Anand
ab6e92aae1
fix: limit end date to current date
2023-12-04 16:47:28 +05:30
s-aga-r
fc12238fcc
Merge pull request #38543 from s-aga-r/FIX-6734
...
fix: don't show non-stock items in Stock Analytics report
2023-12-04 12:08:07 +05:30
s-aga-r
15fff84bb5
fix: linter
2023-12-04 12:05:27 +05:30
ruthra kumar
94fabe0321
Merge pull request #38220 from rtdany10/wrong-advance
...
fix: exclude `invoice_doctypes` from party advance
2023-12-04 10:57:15 +05:30
ruthra kumar
dd39da0b77
fix: incorrectly treating normal payment as advance ( #38437 )
...
fix: treating normal payment as advance
2023-12-04 10:08:37 +05:30
Nihantra C. Patel
d659d407a0
fix: Group By in Item-wise Purchase Register ( #38503 )
2023-12-03 23:22:04 +05:30
ruthra kumar
2815d196de
Merge pull request #38525 from ruthra-kumar/multiple_minor_fixes
...
fix: multiple minor fixes in report and Exchange Rate Revaluation
2023-12-03 16:43:01 +05:30
ruthra kumar
64266c4d38
fix: remove hardcoded, implicit rounding loss allowance
2023-12-03 10:58:14 +05:30
Sagar Vora
b6a7549407
fix: use predefined onload property load_after_mapping ( #38209 )
2023-12-02 20:06:19 +05:30
Deepesh Garg
af7bc4f178
Merge pull request #38401 from pps190/fix-pe-jv-outstanding
...
fix: don't consider cancelled entries
2023-12-02 19:44:10 +05:30
rohitwaghchaure
5e9016ffab
fix: validation error has not throw for the batch ( #38494 )
...
* fix: validation error has not throw for the batch
* chore: fix test cases
2023-12-01 21:42:22 +05:30
ruthra kumar
9656412bba
Merge pull request #38440 from rtdany10/pe-split-message
...
fix(pe): show split alert only on splitting
2023-12-01 12:39:39 +05:30
ruthra kumar
61280117eb
Merge pull request #38393 from ruthra-kumar/refactor_advance_as_liability
...
refactor: GL entries build logic for `Advance in Separate Party Account` option.
2023-12-01 12:36:59 +05:30
ruthra kumar
961bdf0d24
refactor: handle forex payment advance entries
2023-12-01 12:13:00 +05:30
ruthra kumar
080aa30407
refactor(test): filter on document names
2023-12-01 12:09:37 +05:30
ruthra kumar
eecf9cd1d8
fix(test): use correct account type for testing
2023-12-01 11:43:57 +05:30
NandhiniDevi
e2a519464b
add supplier group filter in purchase register ( #38421 )
...
* add supplier group field in purchase register
* Update purchase_register.js
2023-12-01 11:34:38 +05:30
s-aga-r
832734ff4c
Merge pull request #38450 from s-aga-r/FIX-38151
...
fix(ux): make valuation field read only when it can't be modified
2023-11-30 17:22:54 +05:30
s-aga-r
3d4156cc7d
fix(ux): make PI rate field read-only having PR ref
2023-11-30 16:28:03 +05:30
ruthra kumar
cc053ad894
Merge pull request #38457 from ruthra-kumar/use_flt_on_outstanding_on_ar_ap_summary
...
refactor: use flt on outstanding on AR/AP summary report
2023-11-30 16:23:28 +05:30
ruthra kumar
e4bdd3a28d
refactor: use flt on outstanding on AR/AP summary report
2023-11-30 15:57:57 +05:30
Ankush Menat
63313eef6f
feat: enable automatic type annotations ( #38452 )
2023-11-30 08:23:48 +00:00
ruthra kumar
de3795a7d4
Merge pull request #38446 from ruthra-kumar/filter_bug_on_payment_reconciliation
...
refactor: pass on filter to up front outstanding query as well
2023-11-30 12:54:46 +05:30
ruthra kumar
cfd3230c75
refactor: pass on filter to upfront outstanding query as well
2023-11-30 12:22:55 +05:30
Dany Robert
96b13c59c1
fix(pe): show split alert only on splitting
2023-11-30 06:20:15 +00:00
Devin Slauenwhite
ff27cccff4
refactor: get outstanding journal entry using query builder
2023-11-29 21:44:56 +00:00
rohitwaghchaure
258148b615
Merge pull request #38365 from Nandhinidevi123/sales_register
...
feat:add customer group filter in sales register
2023-11-29 13:37:22 +05:30
ruthra kumar
0255e09285
test: ledger pre and post reconciliation on advance as liability
2023-11-29 10:57:28 +05:30
ruthra kumar
2add802d0d
refactor(test): advance allocation on purchase invoice
2023-11-29 08:59:14 +05:30
