Deepesh Garg
f056e9e7c5
Merge pull request #33569 from ruthra-kumar/patch_to_update_new_je_type_in_property_setters
...
chore: patch property setters for JE with new entry type
2023-01-09 21:01:52 +05:30
Deepesh Garg
57a6c37833
Merge pull request #32933 from AnandBaburajan/asset_depreciation_schedule
...
feat: separating depreciation schedule from assets into a new doc
2023-01-09 20:47:21 +05:30
sonali
917b2190aa
fix: remove comments
2023-01-09 20:07:24 +05:30
Ankush Menat
fa4af2acce
refactor: convert heatmap queries to QB ( #33581 )
...
Uses new `UnixTimestamp` function, don't backport.
2023-01-09 20:00:22 +05:30
safvanhuzain
99f5e869e0
fix(stock entry): wrong valuation rate in repack
2023-01-09 13:11:37 +00:00
Rohit Waghchaure
05df8579cd
fix: linters issue
2023-01-09 18:23:22 +05:30
Rohit Waghchaure
d1d4671320
feat: provision to disable get last purchase rate
...
fix: set_incoming_rate condition
2023-01-09 18:10:52 +05:30
Rohit Waghchaure
7249657d15
fix: timeout error in the Purchase Invoice
2023-01-09 14:53:54 +05:30
ruthra kumar
789e448f0e
chore: patch property setters for JE with new entry type
2023-01-08 11:45:28 +05:30
Devin Slauenwhite
e35ac4f8c2
fix: move include in manufacturing to manufacturing tab.
2023-01-07 22:47:16 -05:00
ruthra kumar
c717e87c9e
fix: better handling of duplicate bundle items
2023-01-06 16:21:20 +05:30
rohitwaghchaure
525f054c45
Merge pull request #33548 from rohitwaghchaure/fixed-incorrect-wo-status
...
fix: incorrect status in the work order
2023-01-06 16:01:24 +05:30
Rohit Waghchaure
b0baba84a0
fix: incorrect status in the work order
2023-01-06 14:16:18 +05:30
ruthra kumar
51b082b43c
Merge pull request #33537 from ruthra-kumar/sales_partner_in_ar_report
...
refactor: Sales Partner column in AR and AR Summary Report
2023-01-06 12:07:50 +05:30
Vishal
9fd1c3efb4
fix: test case added for FG_BASED OPERTING COST
2023-01-06 11:18:09 +05:30
Vishal
6b0b49ee3f
fix: minor changes added
2023-01-06 11:18:09 +05:30
Vishal
bc1bdd58a7
feat: Add operating cost based on bom quanity without creating job card
2023-01-06 11:18:09 +05:30
s-aga-r
348dc32514
chore: enable No Copy attribute for route in Item Group
2023-01-05 12:25:50 +05:30
rohitwaghchaure
f6da6ece0a
Merge pull request #33524 from rohitwaghchaure/revamp-process-loss-feature
...
refactor: revamp process loss feature & added tab breaks
2023-01-04 18:37:32 +05:30
ruthra kumar
ee94127974
refactor: Sales Partner column in AR and AR Summary Report
2023-01-04 12:41:02 +05:30
Anand Baburajan
3ae47ab32c
Merge branch 'develop' into asset_depreciation_schedule
2023-01-04 01:34:08 +05:30
Rohit Waghchaure
524c0994e0
test: test cases for process loss
2023-01-03 22:47:52 +05:30
Deepesh Garg
c78399c618
fix: Missing opening entry in general ledger ( #33519 )
2023-01-03 21:35:03 +05:30
Deepesh Garg
1a83a67d41
fix: Get payment entry button not visible in Bank Clearance doc ( #33518 )
2023-01-03 21:34:49 +05:30
Rohit Waghchaure
ae039777f9
refactor: revamp process loss feature & added tab breaks
2023-01-03 19:05:41 +05:30
Sagar Sharma
9f59330fa9
Merge branch 'develop' into fix/github-issue/33417
2023-01-03 18:51:27 +05:30
Deepesh Garg
a3ab8f973a
fix: Deferred revenue date comparison ( #33515 )
2023-01-03 17:51:41 +05:30
s-aga-r
751bdc98ed
fix: set supplier details while mapping SE(Send to Subcontractor)
2023-01-03 17:17:23 +05:30
Deepesh Garg
9a3d947e89
fix: Exchange gain and loss booking on multi-currency invoice reconciliation ( #32900 )
...
* fix: Exchange gain and loss booking on multi-curreny invoice reconciliation
* test: Update test cases
* chore: Ignore SQL linting rule
* chore: Joural Entry for exchange gainand loss booking
* chore: Journal entry for exchange gain loss booking
* test: Update test case
* chore: Default exchange gain and loss account
2023-01-03 16:55:15 +05:30
Anand Baburajan
d9c91fa072
Merge branch 'develop' into asset_depreciation_schedule
2023-01-03 15:10:07 +05:30
anandbaburajan
312e51e8b2
chore: more refactoring and adding test for duplicate asset_depr_schedule
2023-01-03 15:09:04 +05:30
anandbaburajan
adb5249257
chore: fix patch
2023-01-03 13:03:12 +05:30
anandbaburajan
7b6b5ae581
chore: refactoring patch
2023-01-03 09:21:08 +05:30
anandbaburajan
e501c2db51
chore: just testing patch
2023-01-02 21:11:53 +05:30
anandbaburajan
357c17214d
chore: fix patch
2023-01-02 20:32:29 +05:30
rohitwaghchaure
6a4e25c1f9
Merge pull request #33504 from rohitwaghchaure/fixed-incorrect-picked-qty-in-so
...
fix: [concurrency issue] incorrect picked qty in sales order
2023-01-02 20:12:05 +05:30
Rohit Waghchaure
aba83849a6
fix: [concurrency issue] incorrect picked qty in sales order
2023-01-02 18:46:22 +05:30
Anand Baburajan
72c2e77a5d
Merge branch 'develop' into asset_depreciation_schedule
2023-01-02 17:07:58 +05:30
anandbaburajan
7c5168eeac
chore: allow manually submitting and cancelling asset depr schedule
2023-01-02 17:07:28 +05:30
ruthra kumar
914b23038c
refactor: Exchange rate revaluation to handle accounts with zero account balance ( #33165 )
...
* refactor: new type for JE - Exchange Gain or Loss
* refactor: skip few validations for Exchanage Gain Or Loss type Jour
* refactor: ERR create 2 journals for handling zero and non-zero compa
1. Additional check box accounts table to identify accounts with zero balance
2. Accounts with zero balance only in either of the 2 currencies will be handled on separate Journal
* refactor: skips few validation for allowing 0 debit/credit
* fix: General Ledger presentaion currency
* test: fix test case in general ledger
* test: fix failing test case in AR report
2023-01-02 14:33:14 +05:30
s-aga-r
b425c2d7ec
Merge branch 'develop' into fix/github-issue/28766
2023-01-02 11:25:13 +05:30
Sagar Sharma
e18b0ebe92
Merge branch 'develop' into fix-get-bin-details
2023-01-02 10:49:29 +05:30
Sagar Sharma
49025db33c
Merge branch 'develop' into fix/github-issue/28766
2023-01-02 10:27:42 +05:30
Marc de Lima Lucio
3c393bfdc5
fix: javascript: execution blocked by undefined route options ( #33405 )
...
Some implementations of DocField.get_route_options_for_new_doc() returned no value instead of an empty object in some cases, which caused a JavaScript error.
2023-01-02 09:18:25 +05:30
MOHAMMED NIYAS
d054f37602
feat: calculate hours ( #33464 )
...
* feat: calculate hours
* chore: Linting Issues
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
2023-01-02 09:17:14 +05:30
Sabu Siyad
010718ffed
fix(ecommerce/cart): explicitly set frappe.boot ( #33431 )
...
related: https://github.com/frappe/frappe/pull/18323
Signed-off-by: Sabu Siyad <hello@ssiyad.com>
Signed-off-by: Sabu Siyad <hello@ssiyad.com>
2023-01-02 08:58:01 +05:30
Devin Slauenwhite
98c39c4f5f
fix: update payment entry references ( #33274 )
...
* fix: set_amounts after deductions and losses are set
* test: difference_amount changes after update_references_in_payment_entry
* chore: linter
* fix: use kwargs instad of destructing a dict
[skip ci]
* fix(test): test payment entry difference_amount after payment reconciliation.
2023-01-02 08:55:12 +05:30
Sagar Sharma
7126d71627
Merge branch 'develop' into fix/github-issue/28766
2023-01-01 22:24:47 +05:30
Devin Slauenwhite
239a5f8bf4
test: get_item_details contains bin details
2022-12-31 15:41:07 -05:00
Devin Slauenwhite
8d62cdfd5f
fix: add missing 'ordered_qty' to get_bin_details
2022-12-31 14:14:25 -05:00
Deepesh Garg
bb4725e9b5
Merge pull request #33488 from deepeshgarg007/multi_currency_bank_reco
...
fix: Multi-currency issues in Bank Reconciliation Tool
2022-12-31 13:05:25 +05:30
sonali
12822f7c36
fix: data format
2022-12-30 14:06:19 +05:30
Deepesh Garg
ad53ecf2b4
fix: Multi-currency issues in Bank Recociliation Tool
2022-12-30 13:37:41 +05:30
Gughan Ravikumar
48a9cd5ef3
fix: allow arbitary items in Quotation ans Sales Order ( #33430 )
...
fix: allow arbitary items in Quotation ans Sales Order
2022-12-30 13:16:40 +05:30
rohitwaghchaure
728dc1acf4
Revert "fix: daily scheduler to identify and fix stock transfer entries having incorrect valuation"
2022-12-30 11:08:31 +05:30
Sagar Sharma
d072169340
Merge branch 'develop' into fix/github-issue/28766
2022-12-29 16:38:53 +05:30
s-aga-r
c3911a592a
chore: use frappe.qb instead of frappe.db.get_value
2022-12-29 16:38:08 +05:30
sonali
d65243eb65
feat: consolidated auto bank reconciliation
...
Added a button of Auto Reconcile, to reconcile the bank entries as per the matching reference number with the bank transaction and count of transactions reconciled message will be pop up on clicking the auto reconcile button.
2022-12-29 16:12:25 +05:30
s-aga-r
c716dcc01e
fix: consider child nodes while getting bin details
2022-12-29 14:01:42 +05:30
sonali
c764f14f53
fix: pre-commit
2022-12-29 13:58:06 +05:30
sonali
35c29e0226
fix: pre-commit
2022-12-29 13:45:15 +05:30
sonali
f1810803e1
fix: passing from_date and to_date filters in test cases
...
passing from_date and to_date filters in test_linked_payments and test_debit_credit_output for unit testing
2022-12-29 13:07:06 +05:30
sonali
e2614b8a21
fix: pre-commit
2022-12-29 12:21:45 +05:30
sonali
3aaa2f5326
fix: filtered as per reference date
...
On bank reconciliation, transactions will be filtered as per date selected in 'from_date' and 'to_date' fields , In dialog, all the bank entries will be fetched as per the posting date selected and if filtered by reference date checkbox is tick then then there will be two fields 'from_reference_date' and 'to_reference_date' then all bank entries in dialog box came as per reference date, selected. And by default journal entry checkbox is tick.
Also sorted the bank transactions and bank entries as per ascending order date wise.
2022-12-29 12:05:22 +05:30
Deepesh Garg
617518389a
fix: Conversion factor error for invoices without item code (petty expenses) ( #32714 )
...
* fix: Set default uom conversion factor to 1 for invoices
* chore: set default conversion_factor as 1
* chore: remove print statements
2022-12-29 10:41:36 +05:30
Devin Slauenwhite
123920d0bc
feat: add after_refresh hook to item dashboard ( #33372 )
...
* fix: return promise
* fix: use after_refresh hook instead of promise
# Because there is already a before_refresh hook. I think it makes sense to do the same for after.
2022-12-29 10:31:26 +05:30
ruthra kumar
e3a0ce5d63
fix: use base_net_amount in case of missing stock qty ( #33457 )
2022-12-29 09:34:51 +05:30
Dany Robert
cabaed9ed2
fix(pricing rule): consider child tables in condition ( #33469 )
2022-12-28 18:05:55 +05:30
s-aga-r
6f5824cb21
fix: fg_item_qty in non-subcontracted PO
2022-12-28 14:54:24 +05:30
Sabu Siyad
8e271fd719
feat(exotel): make use of CustomField in API ( #33338 )
...
* feat(exotel): pass kwargs for `make_a_call`
https://developer.exotel.com/api/make-a-call-api#call-agent
Signed-off-by: Sabu Siyad <hello@ssiyad.com>
* feat(exotel): map custom field to doctype
Signed-off-by: Sabu Siyad <hello@ssiyad.com>
Signed-off-by: Sabu Siyad <hello@ssiyad.com>
2022-12-28 08:11:28 +05:30
Deepesh Garg
0b75aa5390
fix: Default dimensions on fetching items from BOM ( #33439 )
2022-12-27 17:53:43 +05:30
Deepesh Garg
d2686ce75b
fix: Multiple rows for same warehouse and batches in pick list ( #33456 )
2022-12-27 17:42:03 +05:30
anandbaburajan
21a09e7431
chore: fix patch
2022-12-27 15:01:42 +05:30
anandbaburajan
97f8588202
chore: fix patch name
2022-12-27 15:01:42 +05:30
anandbaburajan
c916fb0513
chore: fix module name in patch
2022-12-27 15:01:42 +05:30
anandbaburajan
57adcc0b03
chore: move patch to pre_model_sync
2022-12-27 15:01:42 +05:30
Anand Baburajan
4ff70db668
Merge branch 'develop' into asset_depreciation_schedule
2022-12-27 14:59:53 +05:30
Deepesh Garg
8263bf9a9a
fix: Random behaviour while picking items using picklist ( #33449 )
2022-12-27 14:59:35 +05:30
anandbaburajan
482116db9f
chore: improve tests
2022-12-27 10:03:32 +05:30
Anand Baburajan
6f4e6fafa9
Merge branch 'develop' into asset_depreciation_schedule
2022-12-27 07:36:32 +05:30
anandbaburajan
6d791cabd1
chore: more refactoring
2022-12-26 22:13:11 +05:30
Sagar Sharma
88edc412e3
Merge branch 'develop' into fix/purchase-order/shipping_address
2022-12-26 12:00:39 +05:30
s-aga-r
67a7ccf3ce
fix: shipping_address for non-drop shipping item
2022-12-26 11:57:50 +05:30
Deepesh Garg
8a79efab4b
feat: Accounting Dimension updation in Payment Request and Entry ( #33411 )
2022-12-26 10:17:55 +05:30
Solufyin
7d9f3f23dd
fix: Customer Primary Contact ( #33424 )
...
Co-authored-by: Nihantra C. Patel <n.patel.serpentcs@gmail.com>
2022-12-26 10:15:10 +05:30
Sagar Sharma
32f3b64a89
Merge branch 'develop' into fix/github-issue/32258
2022-12-25 18:12:08 +05:30
s-aga-r
7e1b6b3c2a
fix: shipping_address in PO
2022-12-25 18:11:05 +05:30
anandbaburajan
03662be150
chore: have different functions for draft. active and cancelled depr schedules
2022-12-25 18:05:19 +05:30
ruthra kumar
a0484793c3
refactor: remove unrelated filters from Supplier Ledger Summary
...
Territory, Sales Partner and Sales Person doesn't belong in Supplier Ledger
2022-12-24 11:20:39 +05:30
ruthra kumar
89229d9b58
refactor: additional doctype access for 'Accounts User' role
2022-12-24 11:20:16 +05:30
ruthra kumar
bfa511cb65
refactor: hidden columns to help framework handle user permissions
...
'territory', 'supplier_group', 'customer_group' have been added as
hidden columns to handle 'user permission' based access control.
2022-12-24 10:30:30 +05:30
rohitwaghchaure
40769998c6
Merge pull request #33422 from rohitwaghchaure/fix-stock-entry-submit-performance
...
fix: timeout error while submitting stock entry
2022-12-23 13:57:25 +05:30
Rohit Waghchaure
a05c47e499
fix: timeout error while submitting stock entry
...
Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-12-23 13:27:32 +05:30
Anand Baburajan
b17ef34042
Merge branch 'develop' into asset_depreciation_schedule
2022-12-23 11:02:17 +05:30
anandbaburajan
3e91a56c19
chore: only consider draft and active assets in patch, and allow asset depr schedule to be manually createed
2022-12-23 11:01:18 +05:30
ruthra kumar
8f5d8e0474
Merge pull request #33418 from ruthra-kumar/filter_issue_in_ar_ap_report
...
fix: payment terms and sales partner filter issue in Accounts Receivable report
2022-12-22 11:38:38 +05:30
ruthra kumar
13c4420f42
fix: payment terms and sales partner filter issue in AR/AP report
2022-12-22 10:55:22 +05:30
ruthra kumar
a26698b88e
Merge pull request #33410 from ruthra-kumar/typeerror_on_gp_due_to_incorrect_warehouse_on_bundle_item
...
fix: TypeError on GP Report due to multiple warehouse on bundled items
2022-12-21 18:26:40 +05:30
ruthra kumar
5918bb03f7
test: type error on bundled products with different warehouses
2022-12-21 17:47:57 +05:30
ruthra kumar
e684eb32d0
fix: typerror on multi warehouse in Packed Items
...
DN(with bundled item with varying warehouses)-> Sales Invoice.
2022-12-21 15:09:55 +05:30
