Devin Slauenwhite
20de27d480
fix(accounts): validate payment entry references with latest data. ( #31166 )
...
* test: payment entry over allocation.
* fix: validate allocated_amount against latest outstanding amount.
* fix: payment entry get outstanding documents for advance payments
* fix: only fetch latest outstanding_amount.
* fix: throw if reference is allocated
* test: throw error if a reference has been partially allocated after inital creation.
* chore: test name
* fix: remove unused part of test
* chore: linter
* chore: more user friendly error messages
* fix: only validate outstanding amount if partly paid and don't filter by cost center
* chore: minor refactor for doc.cost_center
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
---------
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com>
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
2023-06-13 19:06:53 +05:30
Ankush Menat
a3ea985348
refactor: Use db.set_single_value ( #35668 )
...
I just applied semgrep autofix. Untested completed, review before merging.
```yaml
- id: frappe-set-value-semantics
patterns:
- pattern-either:
- pattern: frappe.db.set_value($DOCTYPE, None, $...AFTER)
- pattern: frappe.db.set_value($DOCTYPE, $DOCTYPE, $...AFTER)
fix: frappe.db.set_single_value($DOCTYPE, $...AFTER)
message: |
If $DOCTYPE is a single doctype then using `frappe.db.set_value` is discouraged for setting values in DB. Use db.set_single_value for single doctype instead.
languages: [python]
severity: ERROR
```
2023-06-13 17:30:38 +05:30
Gursheen Anand
17341adf1c
fix: calculate outstanding amount on reconcile correctly
2023-06-13 15:00:46 +05:30
ruthra kumar
b43e068852
Merge pull request #35659 from ruthra-kumar/fix_attribute_error_in_payment_reconciliation
...
fix: attribute error on payment reconciliation tool
2023-06-13 10:16:26 +05:30
ruthra kumar
b672616617
Merge pull request #35620 from ruthra-kumar/err_higher_allowance_for_debit_credit_diff
...
fix: allow custom rounding loss allowance in Exchange Rate Revaluation
2023-06-13 09:46:08 +05:30
ruthra kumar
bada5796fa
fix: attribute error on payment reconciliation tool
2023-06-13 09:32:24 +05:30
ruthra kumar
96a0132501
fix: allow user to set rounding loss allowance for accounts balance
2023-06-12 22:05:08 +05:30
rohitwaghchaure
64586187de
Merge branch 'develop' into fixed-process-loss-in-job-card
2023-06-12 21:39:29 +05:30
rohitwaghchaure
62011410b2
fix: test case PyPDF2 ( #35652 )
...
fix: test case
2023-06-12 19:22:55 +05:30
Ankush Menat
1e8ee9354a
fix(DX): Check Frappe and ERPNext major versions ( #35651 )
2023-06-12 19:20:52 +05:30
rohitwaghchaure
93fe923e2a
Merge branch 'develop' into fixed-process-loss-in-job-card
2023-06-12 19:04:19 +05:30
mergify[bot]
4f3d531f35
fix: don't set default payment amount in case of invoice return (backport #35645 ) ( #35647 )
...
fix: don't set default payment amount in case of invoice return (#35645 )
(cherry picked from commit 79483cc90eb71fa82d645b2cf54d9731502cf6c7)
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com>
2023-06-12 18:43:26 +05:30
Deepesh Garg
011ac131cf
fix: Add column values
2023-06-12 18:42:49 +05:30
s-aga-r
db159dd11f
fix: Stock Reconciliation document update while reposting
2023-06-12 18:28:16 +05:30
Rohit Waghchaure
0382eecff4
fix: test case
2023-06-12 18:20:38 +05:30
Gursheen Anand
5e9821dce2
test: modify test to check posting date
2023-06-12 18:00:15 +05:30
ruthra kumar
42f4f80e0c
fix: Payment against credit notes will be considered as payment against parent invoice in Accounts Receivable/Payable report ( #35642 )
...
* fix: payment against credit note should be linked to parent invoice
* test: AR/AP report for payment against cr note scenario
* fix: cr_note shows up as outstanding invoice
Payment made against cr_note causes it be reported as outstanding invoice
2023-06-12 17:35:13 +05:30
Gursheen Anand
a06017c2c3
fix: Use advance account from Reconciliation document for fetching Payment Entries
2023-06-12 15:24:53 +05:30
Deepesh Garg
2f24546b21
fix: Make difference entry button not working ( #35622 )
2023-06-12 15:20:28 +05:30
s-aga-r
c9923e4996
fix: 'NoneType' object has no attribute 'precision'
2023-06-12 12:33:13 +05:30
s-aga-r
c6acb0d200
fix: DocType not found
2023-06-12 12:33:13 +05:30
s-aga-r
0b009da122
fix(ux): only list related DocTypes
2023-06-12 12:33:13 +05:30
s-aga-r
9a12545ac3
fix(ux): add filter disabled=0 for batch no
2023-06-12 12:33:07 +05:30
Deepesh Garg
e30c3eafef
fix: Stock ledger preview
2023-06-12 11:46:51 +05:30
Gursheen Anand
7591f1010b
fix: Make get party account method return a list instead of a single default account.
2023-06-12 11:06:03 +05:30
David Arnold
c1b42b858d
fix: set Phone and Email option in doctypes ( #35549 )
2023-06-11 19:34:41 +05:30
ruthra kumar
dcbd7d5f1f
fix: incorrect TCS amount while customer has advance payment ( #35397 )
...
* fix: incorrect TCS amount while customer has advance payment
* test: only unallocated advance should for threshold breach validation
2023-06-10 20:55:30 +05:30
Rohit Waghchaure
e9a6191af9
fix: added process loss in job card
2023-06-09 20:33:46 +05:30
Sagar Sharma
e3802d1c3f
Merge pull request #35618 from s-aga-r/FIX-SBB-SERIAL-NO-QTY
...
fix: reset entries qty to `1` for serial item
2023-06-09 13:01:01 +05:30
Anand Baburajan
7bd369c49b
fix: calculate wdv depr schedule properly for existing assets [dev] ( #35614 )
...
* fix: calculate wdv depr schedule properly for existing assets
* fix: calculate wdv depr schedule properly for existing assets properly
* chore: properly call _get_pro_rata_amt
2023-06-09 12:53:10 +05:30
s-aga-r
b5c5a90f71
fix(ux): set warehouse for new row
2023-06-09 12:22:24 +05:30
s-aga-r
1f28ca717e
fix(ux): set entries qty to 1 before making the field read-only
2023-06-09 12:06:46 +05:30
s-aga-r
1d904c0a86
fix(ux): make qty field read-only for serial item
2023-06-09 12:05:02 +05:30
s-aga-r
93e3fe8445
fix: reset entries qty to 1 for serial item
2023-06-09 11:10:47 +05:30
s-aga-r
446253ff39
fix: TypeError in Closing Stock Balance
2023-06-09 09:30:24 +05:30
Christian Werner
65b2e1fc33
fix: set parent_project when creating a new timesheet ( #35607 )
...
fix "When Creating a new Timesheet from an Task - parent_project is empty" #35578
2023-06-08 20:00:40 +05:30
Raffael Meyer
b91bb17779
refactor: get default contact or address ( #35248 )
...
* refactor: get_party_shipping_address
* refactor: get_default_contact
* chore: adding docstrings
* fix: keep original order
* fix: use get_all instead of get_list
---------
Co-authored-by: ruthra kumar <ruthra@erpnext.com>
2023-06-08 19:49:09 +05:30
Gursheen Anand
b65e58c1ae
test: add tests for advance liability entries
...
Add Sales and Purchase Invoice Tests to check if GL entries and Outstanding Amount are generated correctly when advance entries are recorded as liability.
Few changes to return value of added column in Payment Entry References.
2023-06-08 18:15:37 +05:30
ruthra kumar
992d61bd90
chore: fix travis
2023-06-08 15:11:46 +05:30
Gursheen Anand
4ee163742a
fix: Using one field for both advance liability accounts
2023-06-08 13:15:23 +05:30
Devin Slauenwhite
54935438e1
fix: reconcile invoice against credit note
2023-06-07 15:55:37 -04:00
Devin Slauenwhite
7973951c37
fix: missing attribute error
2023-06-07 15:55:16 -04:00
Devin Slauenwhite
f68ab3dfff
test: reconcile credit against invoice
2023-06-07 15:14:24 -04:00
Didiman1998
0c12d4d3c5
fix: remove code that causes upscrolling ( #35140 )
...
Co-authored-by: Dietmar Fischer <fischer@kk-software.de>
2023-06-07 22:35:44 +05:30
Deepesh Garg
0bd4de4504
fix: Remove special treatment for P&L Accounts
2023-06-07 22:33:35 +05:30
Trusted Computer
781548e46e
Fix: CSS not applied to product title ( #35582 )
...
In an erpnext website, the /all-products route shows website items that have been published to the web site.
In the list view (erpnext/e_commerce/product_ui/list.js), the css class is null for the product title. Instead, inline style statements have been added in that can not be modified by overriding CSS.
This fix uses a similar approach to that which is taken in the grid view (erpnext/e_commerce/product_ui/grid.js). It removes the null CSS parameter in the product title link as well as the inline style statement. Then, as in the grid view, the product title is wrapped in a div tag with the product_title CSS class.
This makes it possible to style the product title as desired with a CSS override.
Closes #35580
2023-06-07 22:11:49 +05:30
Deepesh Garg
f732cac678
fix: Project in item-wise sales register ( #35596 )
2023-06-07 22:06:05 +05:30
Raffael Meyer
0dde4d4c69
refactor: use delete_contact_and_address ( #34497 )
...
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
2023-06-07 22:02:38 +05:30
Dirk van der Laarse
3b409af9a0
fix: exclude disabled customers when fetching customers on process statement of accounts ( #35539 )
...
fix: exclude disabled when fetching customers
2023-06-07 22:01:44 +05:30
Raffael Meyer
e9d7b9f0f4
fix: column formatting in Bank Reconciliation Tool ( #35540 )
...
* fix(Bank Reconciliation): format Date column
* fix(Bank Reconciliation): format Party column
* fix(Bank Reconciliation): actions button
- wrong closing tag
- explicitly quote data-name
* fix(Bank Reco): format date and link in dialog
2023-06-07 21:51:49 +05:30
Raffael Meyer
e1f3b7cbc8
fix: pass translated label to change button type ( #35564 )
...
fix: change button type for translated labels
Co-authored-by: Marica <maricadsouza221197@gmail.com>
2023-06-07 21:49:02 +05:30
HarryPaulo
a9a47a51e4
fix: based on status_update.py update opportunity status to converted… ( #35145 )
...
fix: based on status_update.py update opportunity status to converted on sales submit
2023-06-07 21:35:52 +05:30
Deepesh Garg
0108b1abe2
fix: Improve validation message ( #35489 )
...
* fix: Improve validation message
* Update erpnext/selling/doctype/customer/customer.py
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
---------
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
2023-06-07 21:33:36 +05:30
Ankush Menat
0166f69b31
chore: extend default role profiles
2023-06-07 15:09:49 +05:30
Nikhil Kothari
83a7584475
fix: tests now create filters with checkbox enabled
2023-06-07 15:00:05 +05:30
rohitwaghchaure
930a107af8
Merge pull request #35567 from s-aga-r/FIX-SBB-STATUS
...
fix(ux): serial and batch bundle status
2023-06-07 14:49:43 +05:30
Nikhil Kothari
e1116bbbbb
fix: added server side check for allow/restrict
2023-06-07 14:20:42 +05:30
Nikhil Kothari
83c46085fb
feat: added support for mandatory dimensions per account
2023-06-07 14:14:57 +05:30
DaizyModi
5155d5bfb2
chore: remove whitelisting for methods not accessed from UI
2023-06-07 12:05:17 +05:30
Ankush Menat
4507cb3cd7
fix: enqueue_after_commit wherever it makes sense ( #35588 )
2023-06-07 11:58:36 +05:30
marination
eb1db5eaa3
chore: Remove instances of bank_party_mapper and use new_doc
2023-06-07 11:54:51 +05:30
Deepesh Garg
76197cc437
chore: Default role profiles ( #35584 )
2023-06-07 10:11:32 +05:30
Deepesh Garg
2ffcca6f10
fix: Interest Accrual on Loan Topup ( #35555 )
...
* fix: Interest Accrual on Loan Topup
* chore: CI
* chore: Ignore test
2023-06-07 10:06:13 +05:30
Nabin Hait
1cf1c7943f
Merge pull request #35572 from nabinhait/quotation-fix
...
feat: ability to create quotation against a prospect
2023-06-06 21:54:24 +05:30
Marica
75387bbaef
Merge branch 'develop' into bank-trans-party-automatch
2023-06-06 19:03:26 +05:30
marination
752a92bd8b
chore: Remove Bank Party Mapper implementation
...
- Matching by Acc No/IBAN can easily happen with Bank Accounts. It's not a tedious query
- Historical lookups for Party Name/Desc match are very tricky. The user could have manually set a match and we would not know. Also this leaves the Bank Party Mapper only useful for Party Name/Desc lookups, which feels excessive.
- We want to reduce the number of places the same data is stored and reduce confusion
- The Party Name/Desc will optionally happen fuzzily, or not at all
- There will be no Mapper lookups
2023-06-06 18:59:07 +05:30
Nabin Hait
5a0aacc0b6
fix: get party details
2023-06-06 15:39:22 +05:30
Nabin Hait
47ce6de57d
feat: ability to create quotation against a prospect
2023-06-06 15:19:04 +05:30
s-aga-r
8fe1904f3f
fix(test): test_stock_reservation_against_sales_order
2023-06-06 14:59:17 +05:30
s-aga-r
d6208d2e45
fix(ux): serial and batch bundle status
2023-06-06 12:07:46 +05:30
Rohit Waghchaure
dcb0462d51
fix: added validation for insufficient stock during stock transfer
2023-06-05 16:58:54 +05:30
Smit Vora
b1ef19a0cd
fix(regional): allow regional override for updating gl_dict ( #35550 )
2023-06-05 01:43:26 +05:30
Deepesh Garg
2e52a63b0d
feat: Accounting Ledger Preview
2023-06-04 19:20:28 +05:30
rohitwaghchaure
64f767b95d
Merge pull request #35552 from rohitwaghchaure/fixed-serial-batch-get-query
...
fix: get_query for batch number and incorrect batch qty
2023-06-04 16:56:46 +05:30
Rohit Waghchaure
acd12c5830
fix: get_query for batch number and incorrect batch qty
2023-06-04 16:09:01 +05:30
Sagar Sharma
5ebf46a1b5
Merge pull request #35510 from s-aga-r/FIX-ISS-23-24-01141
...
fix: ignore `Non-Stock Item` while calculating `% Picked` in Sales Order
2023-06-03 11:18:05 +05:30
rohitwaghchaure
14292ffc6f
Merge pull request #34564 from rohitwaghchaure/serial-no-normalization
...
Feat: Serial No Normalization and Serial Batch Bundle
2023-06-02 18:13:02 +05:30
Deepesh Garg
abc6fe0b06
refactor!: Remove custom cashflow report mapper ( #35523 )
...
* refactor: Remove custom cashflow mapper
* chore: patch to delete docs
* fix: Cleanup defaults during install
* fix: Remove custom cashflow mapper from consolidated financial statement
2023-06-02 17:48:59 +05:30
Rohit Waghchaure
bb95451db6
feat: added jinja method get_serial_or_batch_nos for print format and new print format 'Purchase Receipt Serial and Batch Bundle Print for reference
2023-06-02 17:14:18 +05:30
Rohit Waghchaure
40ab3bdd35
test: test cases for serial and batch bundle
2023-06-02 17:14:18 +05:30
Rohit Waghchaure
42b229435c
fix: stock reco test case for serial and batch bundle
2023-06-02 17:14:18 +05:30
Rohit Waghchaure
f4cfc589c6
fix: serial and batch selector
2023-06-02 17:14:18 +05:30
Rohit Waghchaure
39da92929b
fix: serial and batch selector
2023-06-02 17:14:18 +05:30
Rohit Waghchaure
26b39ac7f4
fix: travis for asset capitalization and asset repair
2023-06-02 17:14:18 +05:30
Rohit Waghchaure
e88c5d6d90
fix: travis for subcontracting module
2023-06-02 17:14:18 +05:30
Rohit Waghchaure
f79f2a3bab
fix: dialog issue
2023-06-02 17:14:18 +05:30
Rohit Waghchaure
74ab20f97a
fix: travis for POS merge invoice and putaway rule
2023-06-02 17:14:18 +05:30
Rohit Waghchaure
f8bf4aa7c8
fix: travis for work order, pos invoice and landed cost voucher
2023-06-02 17:14:17 +05:30
Rohit Waghchaure
48fbf99e6d
fix: travis for sales and purchase invoice
2023-06-02 17:14:17 +05:30
Rohit Waghchaure
d3ceb07936
fix: travis
2023-06-02 17:14:17 +05:30
Rohit Waghchaure
f704eb7581
fix: average batch wise valuation
2023-06-02 17:14:17 +05:30
Rohit Waghchaure
854b89f252
fix: batch valuation for old entries
2023-06-02 17:14:17 +05:30
Rohit Waghchaure
c2d7461d3c
fix: travis issue
2023-06-02 17:14:17 +05:30
Rohit Waghchaure
7290dd87be
fix: linters and travis
2023-06-02 17:14:16 +05:30
Rohit Waghchaure
9b72845f0f
feat: serial and batch bundle for pick list
2023-06-02 17:14:16 +05:30
Rohit Waghchaure
648efca940
feat: auto create serial and batch bundle
2023-06-02 17:14:16 +05:30
Rohit Waghchaure
c1132d1e6d
fix: serial and batch selector and added deprecated decorator
2023-06-02 17:14:16 +05:30
Rohit Waghchaure
440510337c
fix: travis
2023-06-02 17:14:16 +05:30
Rohit Waghchaure
0eaf6de5de
feat: serial and batch bundle for POS
2023-06-02 17:14:16 +05:30
Rohit Waghchaure
467046436b
refactor: serial no ledger and batchwise balance history report
2023-06-02 17:14:16 +05:30
Rohit Waghchaure
ba6e1447ef
refactor: serial and batch bundle for Maintenance Schedule
2023-06-02 17:14:16 +05:30
Rohit Waghchaure
e50e5cc7b1
feat: serial and batch bundle for GIT stock entry
2023-06-02 17:14:15 +05:30
Rohit Waghchaure
5bb3173676
refactor: rename doctype serial and batch ledger to serial and batch entry
2023-06-02 17:14:15 +05:30
Rohit Waghchaure
16f26fb3d8
refactor: serial and batch package creation for finished item and cleanup code
2023-06-02 17:14:15 +05:30
Rohit Waghchaure
86da306cca
feat: added negative inventory validation and restrict to make backdated entry for serial nos
2023-06-02 17:14:15 +05:30
Rohit Waghchaure
674bd3e2e5
feat: serial and batch bundle for Packing Items
2023-06-02 17:14:15 +05:30
Rohit Waghchaure
9c097e85f8
feat: serial and batch bundle for Stock Reconciliation
2023-06-02 17:14:14 +05:30
Rohit Waghchaure
5ddd55a8ae
feat: serial and batch bundle for Subcontracting
2023-06-02 17:14:14 +05:30
Rohit Waghchaure
e6143abb8a
refactor: added new file serial batch bundle
2023-06-02 17:14:14 +05:30
Rohit Waghchaure
f1b5966680
refactor: serial and batch reposting
2023-06-02 17:14:14 +05:30
Rohit Waghchaure
6c9b212dd1
fix: removed sales and purchase fields from serial nos
2023-06-02 17:14:14 +05:30
Rohit Waghchaure
ba1aac1613
chore: used frappe.db.bulk_insert to create serial nos and serial bunndle
2023-06-02 17:14:14 +05:30
Rohit Waghchaure
bc75a7ef44
refactor: serial no normalization
2023-06-02 17:14:14 +05:30
Gursheen Anand
74619269f0
feat: Record Advance Payments as Liability
...
Ability to let user record advance payments as liability instead of a negative asset.
Issue #34282
2023-06-02 17:13:51 +05:30
Nabin Hait
f11d9b019d
fix: Ignore permissions while submitting account closing balance record ( #35536 )
2023-06-02 16:57:00 +05:30
Suraj Shetty
f7b2d103e7
fix: Task gantt popup style
2023-06-02 10:55:29 +05:30
Raffael Meyer
09872301bd
Merge branch 'develop' into bank-trans-party-automatch
2023-06-01 18:03:10 +02:00
s-aga-r
0fa56bcdce
test: add test case for update stock reconciliation doc
...
(cherry picked from commit 5c9506c8ca26899536be823755f1bbb747716e01)
2023-06-01 15:55:28 +00:00
s-aga-r
88a3f65d3d
fix: update Stock Reconciliation document while reposting
...
(cherry picked from commit cc95cedfee3c09037a97574ca1a04b2d98c72965)
2023-06-01 15:55:28 +00:00
Sagar Sharma
ebf03a51f3
Merge pull request #35525 from s-aga-r/FIX-STOCK-RESERVATION-TEST-CASE
...
fix(test): `test_stock_reservation_against_sales_order`
2023-06-01 19:41:12 +05:30
rohitwaghchaure
fe6a0a6c30
Merge pull request #35498 from rohitwaghchaure/fixed-db-binlogs-getting-full
...
fix: old data reposting causing low server disk space
2023-06-01 19:28:03 +05:30
s-aga-r
4044c2ed40
fix(test): test_stock_reservation_against_sales_order
2023-06-01 17:00:57 +05:30
brunoherrick
4eb2717c3b
feat(accounts): add Portuguese SNC CoA ( #35486 )
...
The ultimate goal of this commit is to add an updated Portuguese Chart of Accounts (CoA), based on Portugal's SNC norm. Account numbers are included. "Account types" shall ideally be confirmed and improved by an accountant. Howbeit, the account types are mostly inspired on former OpenERP, now designated Odoo.
2023-06-01 15:38:18 +05:30
ruthra kumar
c02fc955c5
Merge pull request #35518 from ruthra-kumar/add_precision_in_exchange_rate_revaluation
...
fix:higher precision causes ERR to misjudge zero bal acc as non-zero
2023-06-01 14:59:04 +05:30
ruthra kumar
0319650187
Merge pull request #35112 from ruthra-kumar/gp_report_simplify_groupby_invoice
...
refactor(Gross Profit): simplify group by invoice logic
2023-06-01 14:34:01 +05:30
ruthra kumar
0cd47f07a6
fix: higher precision makes ERR to misjudge zero bal acc as non-zero
2023-06-01 14:24:03 +05:30
s-aga-r
0305a925fe
fix: ignore Non-Stock Item while calculating % Picked in Sales Order
2023-06-01 14:18:48 +05:30
s-aga-r
03d7742737
fix: ignore Non-Stock Item mapping in Pick List
2023-06-01 14:18:39 +05:30
Akshay
e08d6fb2cb
chore: typo in pricing rule schema ( #35457 )
2023-06-01 14:16:52 +05:30
Rohit Waghchaure
fb1a40cada
fix: old data reposting causing low server disk space
2023-05-31 18:20:56 +05:30
rohitwaghchaure
cb19ebcd85
Merge pull request #35482 from rohitwaghchaure/fixed-stock-entry-missing-bom-details
...
fix: missing bom details in the stock entry
2023-05-31 17:29:19 +05:30
Ankush Menat
4bdd276f74
Merge pull request #35409 from nabinhait/workspace-cleanup
...
refactor: Workspace cleanup
2023-05-31 16:40:26 +05:30
Sagar Sharma
fe7c626098
Merge branch 'develop' into FIX-ISS-23-24-01158
2023-05-31 16:34:00 +05:30
Ankush Menat
bb67cc03df
chore: typo
2023-05-31 16:31:58 +05:30
s-aga-r
1905239ec2
fix(ux): throw if no row selected to create repost entries
2023-05-31 15:30:45 +05:30
Sagar Vora
517d8a03ec
chore: remove whitelisting for method not accessed from UI
2023-05-31 14:39:03 +05:30
Ankush Menat
686685bba0
fix: use kwargs in new_doc ( #35497 )
...
To handle https://github.com/frappe/frappe/pull/21190#event-9386089620
2023-05-31 12:50:14 +05:30
Deepesh Garg
bb21c044f6
fix: Billing Address display in buying transactions ( #35451 )
2023-05-31 11:02:30 +05:30
Deepesh Garg
27d5e6a99b
fix: Error while validating budget ( #35487 )
...
* fix: Error while validating budget
* chore: remove print statement
2023-05-31 10:51:33 +05:30
Rohit Waghchaure
2fc7d82324
fix: missing bom details in the stock entry
2023-05-30 18:22:48 +05:30
rohitwaghchaure
ffd5308ed9
Merge pull request #35478 from rohitwaghchaure/fixed-lead-time-calculation-in-work-order
...
fix: incorrect transferred qty in the job card
2023-05-30 18:11:57 +05:30
Rohit Waghchaure
d3a5e49db9
fix: incorrect transfer quantity in the job card
2023-05-30 17:27:16 +05:30
Anand Baburajan
dbdc420066
fix: allow assets with depr entries to be cancelled ( #35477 )
...
fix: allow asset with depr entries to be cancelled
2023-05-30 16:28:57 +05:30
Nabin Hait
e78a7de1e5
fix: Rearranged accounting module links
2023-05-30 13:25:00 +05:30
Nabin Hait
5cf4c8c8b7
fix: removed duplicate links of manufacturing workspace
2023-05-30 13:18:58 +05:30
Nabin Hait
86f88817a9
fix: Added pos links in Selling workspace
2023-05-30 13:18:58 +05:30
Nabin Hait
0b28f641ad
fix: Delete Retail and Utilities worspaces amd hide default Settings and Integration workspaces
2023-05-30 13:18:52 +05:30
Nabin Hait
243c49c550
refactor: Workspace cleanup
2023-05-30 13:17:59 +05:30
Sagar Sharma
91ca266db6
Merge branch 'develop' into FIX_retention_stock_entry_conversion_factor
2023-05-30 11:05:37 +05:30
rohitwaghchaure
df921b79a4
Merge pull request #35465 from rohitwaghchaure/fixed-inter-transfer-company
...
fix: rate not fetching properly for inter transfer purchase order
2023-05-30 09:14:16 +05:30
Rohit Waghchaure
2931c657f4
fix: rate not fetching properly for inter transfer purchase order
2023-05-30 08:34:12 +05:30
rohitwaghchaure
7dce06021e
Merge pull request #35462 from ankush/item_quick_entry
...
refactor!: Drop custom item quick entry
2023-05-30 08:32:09 +05:30
Sagar Sharma
ed0c8ae452
Merge branch 'develop' into FIX_retention_stock_entry_conversion_factor
2023-05-30 08:05:54 +05:30
Anand Baburajan
ae26d72f7f
fix: monthly wdv depr schedule for existing assets [dev] ( #35460 )
...
fix: monthly wdv depr schedule for existing assets
2023-05-29 23:18:07 +05:30
Ankush Menat
b10e19141c
refactor!: Drop item quick entry
...
- Item variants creator - we have better one on document
- Everything else - hardcoded behaviour that's not needed anymore IMO.
2023-05-29 22:33:56 +05:30
Marc de Lima Lucio
6954f538c9
fix: retention stock entry: grab conversion factor from source
2023-05-29 17:41:14 +02:00
Ankush Menat
964bb1d948
chore: docs for stock settings
...
[skip ci]
2023-05-29 15:11:28 +05:30
Ankush Menat
8fe8f80033
fix: replace stock projected with ledger
...
Ledger is much more widely used report, better to show that first?
2023-05-29 14:44:54 +05:30
Ankush Menat
dd245ccc7f
fix: reorder stock reco tour
2023-05-29 14:44:54 +05:30
Ankush Menat
3341cd6b80
fix: filter parent warehouses by company
2023-05-29 14:44:54 +05:30
Ankush Menat
aa9f926298
fix: warehouse tour
...
- remove warehouse type, it doesn't do what it says. Misleading.
2023-05-29 14:44:54 +05:30
Ankush Menat
81e901ba62
fix: disable/enable with button
2023-05-29 14:44:54 +05:30
Ankush Menat
40ce33dff1
fix: warehouse form cleanup
...
- organize fields
- group transit fields and move them lower
- enable/disable should be button
- hide pointless fields from listview
2023-05-29 14:44:54 +05:30
Ankush Menat
7a18db561f
fix: hide ledger button on new warehouse
2023-05-29 14:44:54 +05:30
Ankush Menat
2e13fbab5e
fix: stock settings tour
...
- remove dead fields
- Keep only essential fields in tour
2023-05-29 14:44:50 +05:30
HarryPaulo
b7407a1d81
feat: add todo calendar to bootinfo.calendars ( #35124 )
...
* feat: add todo calendar to bootinfo.calendars
* chore: Linting Issues
---------
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
2023-05-29 10:37:35 +05:30
Raffael Meyer
1f08330ae1
fix: labels and translations ( #34896 )
...
* fix: german translation of expense claim
* fix: consistent labels and translations in project Costing and Billing
* fix: german translation of Stock Entry
---------
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
2023-05-29 09:56:16 +05:30
Akshay
1ab04344db
fix (ui): debit note issued status indicator color ( #35401 )
...
* fix: debit note issued status indicator color
* fix: change DebitNoteIssued color from grey to gray
2023-05-29 09:42:01 +05:30
Vishnu VS
01567b5ec4
fix(UX): task and project name in error message ( #35435 )
2023-05-29 09:39:13 +05:30
Nabin Hait
3504bf7f62
fix: Show future payments in accounts receivable summary ( #35416 )
2023-05-29 09:23:40 +05:30
Sagar Sharma
336ff5b327
Merge branch 'develop' into FIX-ISS-23-24-01015
2023-05-27 12:13:39 +05:30
Sagar Sharma
027de41600
fix: incorrect POS Reserved Qty in Stock Projected Qty Report
2023-05-27 12:05:37 +05:30
rohitwaghchaure
4099330bf4
Merge pull request #35426 from rohitwaghchaure/fixed-incorrect-actual-qty-bin
...
fix: incorrect available quantity in BIN
2023-05-26 22:47:42 +05:30
Sagar Sharma
8cc8af8204
Merge branch 'develop' into stock-reservation
2023-05-26 15:28:54 +05:30
Rohit Waghchaure
718ad3f240
fix: travis
2023-05-26 11:29:22 +05:30
Sagar Sharma
761f8a9f05
fix: use float_precision while checking for negative stock in BIN
2023-05-26 04:23:36 +05:30
Rohit Waghchaure
9e5e2de5d5
fix: incorrect available quantity in BIN
2023-05-25 23:56:23 +05:30
Sagar Sharma
b4362e5517
Merge branch 'develop' into PACKING-SLIP-FOR-DN-PACKED-ITEMS
2023-05-25 23:15:46 +05:30
mergify[bot]
55806c51f2
fix: Gross and Net Profit Report - incorrect calculation of totals
...
* fix: account group totals calculation to consider include_in_gross
(cherry picked from commit 8dcb9302b417618505ea24e5566c017eff451c1e)
* refactor: remove unused parameters
(cherry picked from commit 50822f207ec5272d4d71a2b6579693da2088105d)
* refactor: merge separate loops for calculating group / leaf node totals
rename function
remove return statement as the list is mutated
(cherry picked from commit 1a3b9c5bdfb9fac04a3a7d8724e6b3c3b593ec19)
* fix: add total col for gross and net profit
(cherry picked from commit cb9b4fbb91f4b73916416167932064ef5965eed1)
---------
Co-authored-by: Anoop Kurungadam <anoop@earthianslive.com>
2023-05-25 18:12:50 +05:30
Sagar Sharma
6f0867b006
Merge branch 'develop' into PACKING-SLIP-FOR-DN-PACKED-ITEMS
2023-05-25 18:04:06 +05:30
Sagar Sharma
196e18187f
fix(patch): add patch to set packed_qty in draft DN
2023-05-25 18:03:39 +05:30
Sagar Sharma
5c7f3adf5a
Merge branch 'develop' into stock-balance-typo
2023-05-25 16:04:11 +05:30
Sagar Sharma
c4e1f927ee
chore: typo in stock balance
2023-05-25 16:03:15 +05:30
Sagar Sharma
82f0bd9ee9
feat: add Reserved Stock column in Stock Balance Report
2023-05-25 15:57:06 +05:30
Sagar Sharma
988db2eaf6
Merge branch 'develop' into stock-reservation
2023-05-25 15:10:54 +05:30
ruthra kumar
ec5d34117b
Merge pull request #35417 from ruthra-kumar/fix_ambiguous_company_in_gross_profit_report
...
fix(Gross Profit): 'company' column is ambiguous in filter
2023-05-25 15:06:35 +05:30
Sagar Sharma
ccb2dc4df5
Merge branch 'develop' into stock-reservation
2023-05-25 14:35:59 +05:30
ruthra kumar
448712f719
fix(Gross Profit): 'company' column is ambiguous in filter
2023-05-25 14:18:41 +05:30
Sagar Sharma
fefd788eb5
fix(ux): add non-group warehouse filter
2023-05-25 11:49:47 +05:30
rohitwaghchaure
0bc9c3260e
Merge pull request #35348 from rohitwaghchaure/refactor-stock-balance-report
...
refactor: stock balance report
2023-05-24 19:46:04 +05:30
rohitwaghchaure
693133d8f7
Merge pull request #35410 from rohitwaghchaure/fixed-negative-reserved-qty-for-production-plan
...
fix: Negative value in Reserved Qty for Production Plan
2023-05-24 19:08:14 +05:30
Rohit Waghchaure
a37608a36c
fix: Negative value in Reserved Qty for Production Plan
2023-05-24 17:14:00 +05:30
Sagar Sharma
2813042936
Merge branch 'develop' into PACKING-SLIP-FOR-DN-PACKED-ITEMS
2023-05-24 14:35:51 +05:30
rohitwaghchaure
565322daba
Merge branch 'develop' into stock-reservation
2023-05-24 14:32:04 +05:30
rohitwaghchaure
0d8f48891d
Merge pull request #35405 from rohitwaghchaure/fixed-available-qty-issue
...
fix: available qty not fetching for raw material in PP
2023-05-24 14:24:53 +05:30
Rohit Waghchaure
8e3463c4ef
fix: available qty not fetching for raw material in PP
2023-05-24 14:12:58 +05:30
Gursheen Kaur Anand
c1f1a033c9
fix: tab-uniformity ( #35400 )
...
Made Doctype tabs uniform
Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com>
2023-05-24 12:45:00 +05:30
Anand Baburajan
edb7b0db8f
fix: incorrect depr schedule and posting dates on selling of existing assets [dev] ( #35398 )
...
* fix: calc depr amount properly on selling of existing assets and fix incorrect posting dates
* chore: get number_of_depreciations_booked properly
* chore: fix test_gle_made_by_asset_sale_for_existing_asset
2023-05-24 12:29:46 +05:30
Rohit Waghchaure
3f548ac910
fix: Stock Analytics and Warehouse wise Item Balance Age and Value issue
2023-05-23 17:06:11 +05:30
Rohit Waghchaure
545b2d32cd
fix: balance quantity
2023-05-23 17:06:11 +05:30
Rohit Waghchaure
d9979b2ffb
refactor: stock balance report
2023-05-23 17:06:11 +05:30
Ankush Menat
b0eb72ffac
fix: replace quotation with invoice in first onboarding ( #35389 )
...
[skip ci]
2023-05-23 15:35:55 +05:30
Sagar Sharma
a111917114
fix: Pick List TypeError
2023-05-23 12:57:48 +05:30
Sagar Sharma
00bb8add40
Merge pull request #35380 from CodeVenturers/OpenContrib
...
fix: TypeError while saving Job card
2023-05-23 10:49:42 +05:30
vishnu
8c34cc0e00
fix: use flt instead of mandatory field
2023-05-23 04:27:50 +00:00
rohitwaghchaure
4cb9cbee06
Merge pull request #35381 from rohitwaghchaure/fixed-skip-available-qty-for-sub-assembly
...
feat: provision to skip available sub assembly items in the production plan
2023-05-23 09:39:09 +05:30
Sagar Sharma
4fee4fb3b7
Merge branch 'develop' into PACKING-SLIP-FOR-DN-PACKED-ITEMS
2023-05-23 07:10:09 +05:30
Rohit Waghchaure
9dd566c1e8
test: test case to skip available qty for sub-assembly items
2023-05-23 01:02:16 +05:30
Rohit Waghchaure
64751ec4d9
feat: provision to skip available sub assembly items in the production plan
2023-05-23 00:16:48 +05:30
vishnu
a209fb4b64
fix: error while saving job card
2023-05-22 18:00:50 +00:00
Sagar Sharma
57ee473fa4
fix: don't recalculate rate for SCR rejected warehouse SLE
2023-05-22 15:07:39 +05:30
Sagar Sharma
7e4dc11c4c
Merge branch 'develop' into PACKING-SLIP-FOR-DN-PACKED-ITEMS
2023-05-21 08:34:41 +05:30
Ankush Menat
ba61865ee6
chore: drop outdated navigation video
...
new stuff is in work, this one is actually counter-productive rn.
2023-05-20 19:45:59 +05:30
rohitwaghchaure
44cd76bb48
Merge pull request #35365 from rohitwaghchaure/create-reposting-entries-from-report
...
feat: provision to make reposting entries from Stock and Account Value Comparison Report
2023-05-20 17:06:13 +05:30
Rohit Waghchaure
7b818e9d34
feat: provision to make reposting entries from Stock and Account Value Comparison Report
2023-05-19 18:53:40 +05:30
Deepesh Garg
68eee35c5d
Merge pull request #35346 from nabinhait/account-closing-balance-patch-fix
...
fix: account closing balance patch
2023-05-19 11:09:39 +05:30
rohitwaghchaure
216983a729
Merge pull request #34909 from ihosseinu/get_incoming_rate_v14_fix
...
Get incoming rate v14 fix
2023-05-19 09:56:32 +05:30
Sagar Sharma
44b0bc2d76
Merge branch 'develop' into PACKING-SLIP-FOR-DN-PACKED-ITEMS
2023-05-19 09:20:21 +05:30
Marica
6fe5264ae2
Merge branch 'develop' into bank-trans-party-automatch
2023-05-18 12:57:58 +05:30
ruthra kumar
b2290c6f57
fix: possible type error on quotation -> sales order creation
2023-05-18 12:48:15 +05:30
ruthra kumar
1587ce3bfb
Merge pull request #35335 from ruthra-kumar/incorrect_tds_calcuation_if_supplier_has_different_category
...
fix: tds incorrectly calculated for invoice that are below threshold
2023-05-18 12:38:31 +05:30
ruthra kumar
132846bbd1
fix(test): cumulative threshold checks
2023-05-18 12:00:59 +05:30
MOHAMMED NIYAS
90ddf1c0f0
fix: create sales order
...
Getting error while clicking create sales order button from quotation
Taceback (most recent call last):
File "apps/frappe/frappe/app.py", line 66, in application
response = frappe.api.handle()
File "apps/frappe/frappe/api.py", line 54, in handle
return frappe.handler.handle()
File "apps/frappe/frappe/handler.py", line 45, in handle
data = execute_cmd(cmd)
File "apps/frappe/frappe/handler.py", line 83, in execute_cmd
return frappe.call(method, **frappe.form_dict)
File "apps/frappe/frappe/__init__.py", line 1607, in call
return fn(*args, **newargs)
File "apps/frappe/frappe/model/mapper.py", line 36, in make_mapped_doc
return method(source_name)
File "apps/erpnext/erpnext/selling/doctype/quotation/quotation.py", line 263, in make_sales_order
return _make_sales_order(source_name, target_doc)
File "apps/erpnext/erpnext/selling/doctype/quotation/quotation.py", line 333, in _make_sales_order
doclist = get_mapped_doc(
File "apps/frappe/frappe/model/mapper.py", line 144, in get_mapped_doc
postprocess(source_doc, target_doc)
File "apps/erpnext/erpnext/selling/doctype/quotation/quotation.py", line 291, in set_missing_values
for d in customer.get("sales_team"):
TypeError: 'NoneType' object is not iterable
2023-05-18 10:23:58 +05:30
rohitwaghchaure
ffb353032d
Merge branch 'develop' into get_incoming_rate_v14_fix
2023-05-18 06:13:52 +05:30
rohitwaghchaure
6fbcc3d196
Merge pull request #35298 from CodeVenturers/OpenContirb
...
fix: Creating landed cost voucher from connections
2023-05-18 06:00:07 +05:30
Anand Baburajan
8c53e0f004
fix: depreciation schedule for existing assets [dev] ( #35256 )
...
* fix: depreciation schedule for existing assets
* chore: correct logic for existing assets and fix test
* chore: properly check if depr amount is non zero
2023-05-17 22:29:09 +05:30
Nabin Hait
2b8c39eee9
fix: account closing balance patch
2023-05-17 22:05:46 +05:30
marination
4364fb9628
feat: Optional Fuzzy Matching & Skip Matches for multiple similar matches
...
- Fuzzy matching can be enabled optionally in the settings
- If a query gets multiple matches with the same score, do not set a party as it is an extremely close call
- misc: Add 'cancelled' status to Bank transaction
- Test for skipping matching with extremely close matches
2023-05-17 19:45:03 +05:30
Sagar Sharma
fcea907cf9
Merge branch 'develop' into FIX-35014
2023-05-17 16:09:21 +05:30
Sagar Sharma
9fb8b1827d
fix: Pick List Status
2023-05-17 16:07:58 +05:30
Ankush Menat
e5c86bc2e8
fix: consider 0 if rate/qty are null ( #35338 )
...
[skip ci]
2023-05-17 16:04:49 +05:30
Sagar Sharma
adf2474d9d
fix(ux): SCR consumed-qty read-only property
2023-05-17 15:12:47 +05:30
marination
4a14e9ea4e
fix: Tests
2023-05-17 14:23:44 +05:30
ruthra kumar
84b7c1bba0
fix: tds incorrectly calculated for invoice that are below threshold
...
Two purchase invoices for the same supplier, using different tax
withholding categories have this issue.
| Category | single | cumulative |
|----------+--------+------------|
| cat1 | 100 | 500 |
| cat2 | 1000 | 5000 |
1. PINV1 of net total: 105/- uses cat1. TDS is calculated as it
breached single threshold
2. PINV2 of net total: 200/- uses cat2. TDS incorrectly calculated as
PINV1 already has TDS calculated and 'consider_party_ledger_amount' is enabled.
2023-05-17 13:55:41 +05:30
Sagar Sharma
42804306fd
Merge branch 'develop' into PACKING-SLIP-FOR-DN-PACKED-ITEMS
2023-05-17 13:17:59 +05:30
ruthra kumar
e927f6cab1
Merge pull request #35239 from ashish-greycube/patch-8
...
fix: in payment_entry difference amount cal is broken
2023-05-17 10:25:55 +05:30
ruthra kumar
0da6c1688b
fix: unable to create partial invoice with auto fetch terms enabled ( #35285 )
...
fix: fetch so/po terms if auto fetch is enabled
2023-05-16 18:57:42 +05:30
rohitwaghchaure
96e6014d12
Merge pull request #35328 from rohitwaghchaure/fixed-create-reposting-entry-for-cancelled-documents
...
fix: force to do reposting for cancelled document
2023-05-16 17:31:45 +05:30
Ashish Shah
ae4e56747c
refactor: use 'flt' for base_total_taxes_and_charges
...
difference_amount calculation is broken, as calculation gives NaN. Fix is make frm.doc.base_total_taxes_and_charges as flt(frm.doc.base_total_taxes_and_charges)
2023-05-16 16:55:11 +05:30
Rohit Waghchaure
6e661e7c0e
fix: force to do reposting for cancelled document
2023-05-16 16:23:52 +05:30
ruthra kumar
776a83066d
fix: cancelled vouchers in tax withheld vouchers list ( #35309 )
2023-05-16 15:54:46 +05:30
Ankush Menat
5574d9a72d
fix(UX): misc "home" onboarding improvements ( #35319 )
...
* fix(UX): cleanup "Home" onboarding
- Remove company, letterhead, data import etc from home onboarding step
* fix(UX): Show quick entry for item
* chore: fix copy here and there
2023-05-16 13:38:55 +05:30
Rucha Mahabal
9feda1b829
perf: cache and simplify queries for holiday list ( #35315 )
2023-05-16 13:11:47 +05:30
rohitwaghchaure
5c2d7701ea
Merge pull request #35312 from rohitwaghchaure/fixed-item-list-view-not-working
...
fix: item list view not working
2023-05-16 01:09:44 +05:30
Rohit Waghchaure
0489e30244
fix: item list view not working
2023-05-16 00:48:52 +05:30
rohitwaghchaure
8afbb06a33
Merge branch 'develop' into FIX-ISS-23-24-00368
2023-05-15 13:42:20 +05:30
Wolfram Schmidt
c236979508
fix: Update de.csv ( #35278 )
...
added many fixes on the base of 'No' which is often wrongly translated to 'Kein'.
Also removed translation of Naming Seris like ACC-INV-.YYYY.- to ACC-INV-.YYYY.-
2023-05-15 13:25:23 +05:30
Smit Vora
2a609616d9
fix: port option for additional_conditions in item wise sales register ( #35187 )
...
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
2023-05-15 13:24:39 +05:30
vishnu
f2ceb00379
fix: Creating landed cost voucher from connections
2023-05-14 09:35:38 +00:00
Indrajith.vs
0c8276ec82
fix: sales person allocated amount calculation error nonetype and float ( #35293 )
...
fix: sales person allocated amount calculation error nontype and float
2023-05-14 11:47:46 +05:30
