rohitwaghchaure
675a0b810f
Merge pull request #39659 from rohitwaghchaure/fixed-timeout-error-while-making-auto-mr
...
perf: timeout for auto material request through reorder level
2024-02-05 11:38:11 +05:30
Divyam Mistry
e9fe10c6f1
fix: fetch/change tax template on basis of base_net_rate instead of net_rate ( #39448 )
...
fix: change tax template on basis of base_net_rate instead of net_rate
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
2024-02-01 16:15:43 +05:30
Rohit Waghchaure
951023f434
perf: timeout for auto material request through reorder level
2024-01-31 17:27:32 +05:30
Deepesh Garg
f52d7c7665
fix: Pricing rule application/removal on qty change
2024-01-02 13:37:39 +05:30
rohitwaghchaure
db24e24882
fix: supplier removed on selection of item ( #38712 )
2023-12-13 14:06:45 +05:30
barredterra
0465c9aabb
fix: attribute error
2023-12-08 14:15:26 +01:00
Deepesh Garg
2989e36b1d
Merge pull request #38284 from vorasmit/fetch-item-tax-values
...
fix: fetch item_tax_template values if fields with fetch_from exisit
2023-11-26 17:54:35 +05:30
Smit Vora
b206b0583b
fix: fetch item_tax_template values if fields with fetch_from exisit
2023-11-23 15:10:47 +05:30
Gursheen Anand
8bdb61cb87
fix: condition in other bundle utils
2023-11-22 16:17:23 +05:30
Deepesh Garg
70d99eebc0
Revert "fix: set empty value for tax template in item details ( #37496 )"
...
This reverts commit b0d440c34b9cb4d0e0d75153c279ccaa6206253d.
2023-11-08 18:38:39 +05:30
Deepesh Garg
1081df3d7e
Merge pull request #37674 from GursheenK/item-variant-tax-template
...
fix(minor): set tax values for item variants
2023-10-29 10:33:03 +05:30
David Arnold
1612d7ba3f
fix(defaults): apply discount and provisonal defaults from item group and brand if available ( #37466 )
2023-10-26 12:03:22 +00:00
Gursheen Anand
d436a40739
fix: only update if variant table empty
2023-10-25 13:06:03 +05:30
Gursheen Kaur Anand
b0d440c34b
fix: set empty value for tax template in item details ( #37496 )
...
* fix: empty tax template for items with invalid templates
* fix: test for empty tax template
* fix: test for item tax template calculation
* fix: test for pos inv tax template calculation
2023-10-21 17:58:43 +05:30
rohitwaghchaure
14b009b093
fix: incorrect cost center in the purchase invoice ( #37591 )
2023-10-20 16:22:29 +05:30
rohitwaghchaure
e6199dc802
fix: allow to select parent warehouse in the website item ( #37047 )
2023-09-20 17:27:35 +05:30
Gursheen Kaur Anand
099468e3cf
fix: company wise deferred accounting fields in item ( #37023 )
...
* fix: move deferred accounts in accounting section
* fix: move deferred check boxes in item accounting
* fix: show company wise acc in filters
* fix: fetch item deferred account from child table
* fix: tests using deferred acc
* refactor: use cached value
* fix: cached value call
* feat: patch to migrate deferred acc
* fix: hardcode education module doctypes in patch
* chore: resolve conflicts
---------
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
2023-09-16 21:25:31 +05:30
DaizyModi
5155d5bfb2
chore: remove whitelisting for methods not accessed from UI
2023-06-07 12:05:17 +05:30
Rohit Waghchaure
648efca940
feat: auto create serial and batch bundle
2023-06-02 17:14:16 +05:30
Rohit Waghchaure
16f26fb3d8
refactor: serial and batch package creation for finished item and cleanup code
2023-06-02 17:14:15 +05:30
Rohit Waghchaure
6c9b212dd1
fix: removed sales and purchase fields from serial nos
2023-06-02 17:14:14 +05:30
Rohit Waghchaure
bdf2f7416a
fix: not able to create delivery note from sales order
2023-04-28 15:16:02 +05:30
Deepesh Garg
a7051cb9b5
fix: Don't use stale item details ( #34847 )
2023-04-14 09:59:42 +05:30
Deepesh Garg
6f6928fa7b
fix: Item tax validity comparison fixes ( #34784 )
...
fix: Item tax validity comparsion fixes
2023-04-09 09:38:13 +05:30
Deepesh Garg
4c61ee30bb
fix: Multiple issues in purchase invoice submission ( #34600 )
...
* fix: Multiple issues in purchase invoice submission
* fix: Base grand total calculation
* chore: Calculate base grand total separately only in multi currency docs
* fix: Add gl entry for round off
2023-04-02 09:35:27 +05:30
s-aga-r
58c027d4cc
chore: Linters
2023-02-28 15:14:34 +05:30
s-aga-r
35489fbbf9
refactor: remove method get_serial_no_batchwise from get_item_details.py
2023-02-18 22:23:53 +05:30
s-aga-r
6b144baa69
refactor: rewrite get_item_details.py queries in QB
2023-02-18 22:23:51 +05:30
HENRY Florian
231fe4156f
fix: should never get cutomer price on purchase document ( #34002 )
...
* fix: never get cutomer price on purchase document
chores: syntax
chore: typo in stock_entry get_uom_details (#33998 )
fix: typo in stock_entry get_uom_details
chores: syntax
* feat: add test for get_item_detail price list oriented
* feat: add test for get_item_detail price price oriented
* feat: add test for get_item_detail price price oriented
* chore: clean test code
2023-02-13 20:56:05 +05:30
Rohit Waghchaure
2c83fff1a1
fix: don't add template item in sales/purchase transaction
2023-01-18 23:29:06 +05:30
ruthra kumar
be382054e5
revert: Reverting changes done on 33495 ( #33662 )
...
'ordered_qty' will not be fetched from `tabBin`
2023-01-16 08:50:39 +05:30
Rohit Waghchaure
ec171fc7c1
test: test case to check disable last purchase rate
2023-01-09 22:02:35 +05:30
Rohit Waghchaure
d1d4671320
feat: provision to disable get last purchase rate
...
fix: set_incoming_rate condition
2023-01-09 18:10:52 +05:30
s-aga-r
b425c2d7ec
Merge branch 'develop' into fix/github-issue/28766
2023-01-02 11:25:13 +05:30
Devin Slauenwhite
8d62cdfd5f
fix: add missing 'ordered_qty' to get_bin_details
2022-12-31 14:14:25 -05:00
s-aga-r
c3911a592a
chore: use frappe.qb instead of frappe.db.get_value
2022-12-29 16:38:08 +05:30
s-aga-r
c716dcc01e
fix: consider child nodes while getting bin details
2022-12-29 14:01:42 +05:30
Rohit Waghchaure
0f28074e5a
fix: unsupported operand type(s) for +: 'int' and 'NoneType'
2022-12-15 16:36:47 +05:30
Deepesh Garg
6192af5cf0
chore: Update tests
2022-12-08 18:04:40 +05:30
Deepesh Garg
b741ae143c
fix: Reapply pricing rule on qty change
2022-12-02 17:14:06 +05:30
Sagar Vora
57038c3969
fix: set stock UOM in args to ensure item price is fetched
2022-11-09 18:56:09 +05:30
s-aga-r
f6ef3068d7
Merge branch 'develop' into subcontracting
2022-06-20 23:10:31 +05:30
s-aga-r
6d89b2fa28
refactor: backport old subcontracting code
2022-06-20 23:10:02 +05:30
Conor
74a782d81d
refactor: DB independent quoting and truthy/falsy values ( #31358 )
...
* refactor: DB independent quoting and truthy/falsy values
* style: reformat to black spec
* fix: ifnull -> coalesce
* fix: coalesce -> Coalesce
* fix: revert pypika comparison
* refactor: convert queries to QB
* fix: incorrect value types for query
`=` query makes no sense with list of values
* fix: remove warehouse docstatus condition
* fix: keep using base rate as rate
Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-06-17 17:01:27 +05:30
Sagar Vora
1a3997a566
fix: transaction date gets unset in material request ( #31327 )
...
* fix: set date correctly in material request
* fix: use only `transaction_date` in `get_item_details`
2022-06-16 22:33:47 +05:30
marination
9f2d325e67
fix: Pick Template BOM if variant BOM absent in WO popup from SO
...
- Use `get_default_bom` in sales_order.py (reduce duplicate utility functions)
- Remove redundant if else in `get_work_order_items`
- `get_default_bom`: If no BOM and template exists try to fetch template BOM
- test: `get_work_order_items` via SO and if right BOM is picked
2022-06-14 17:20:44 +05:30
s-aga-r
992ba974e2
Merge branch 'develop' into subcontracting
2022-06-03 13:25:49 +05:30
maharshivpatel
b3ccc4bfb9
fix: Auto Insert Item Price If Missing when discount & blank UOM ( #31168 )
...
* fix: Auto Insert Item Price If Missing when discount and blank UOM
fixes wrong item price insert when discount is used and adds uom=stock_uom instead of blank as price is converted to stock uom
* unit tests added for item with discount
I have added test for auto_insert_price where discount is used.
* unit test issue fixed
fixed make_sales_order as some of the test that depended on it were failing due to passing of incorrect parameters.
Co-authored-by: Ankush Menat <me@ankush.dev>
2022-05-31 19:48:30 +05:30
Sagar Sharma
4ff734c25a
Merge branch 'develop' into subcontracting
2022-05-25 12:32:33 +05:30
Devin Slauenwhite
55276f11f8
fix: don't fetch item_code if already exists. ( #31113 )
...
fix: check if item_code exists before fetching
2022-05-25 09:35:22 +05:30
