ruthra kumar
f2f5c1a0eb
Merge pull request #40220 from ruthra-kumar/exc_gain_loss_on_journal_against_journals
...
refactor: Gain/Loss Journal creation for Journals against Journals
2024-03-02 15:36:27 +05:30
ruthra kumar
8a5078b826
test: gain/loss on Journals against Journals
2024-03-01 20:10:57 +05:30
rohitwaghchaure
4b24fcd221
fix: set batch created from bundle to batch field in stock transaction ( #39966 )
...
* fix: set batch created from bundle to batch field in stock transaction
* fix: validation for serial and batch no
2024-02-20 23:45:07 +05:30
ruthra kumar
2f676ced5c
refactor(test): Forex Credit Note cancellation against Invoice
2024-02-07 19:59:33 +05:30
ruthra kumar
ebaa5d3add
Merge pull request #39054 from ruthra-kumar/provision_to_set_dimension_in_reconciliation_tool
...
refactor: provision to filter on dimensions in reconciliation tool
2024-01-23 17:28:21 +05:30
ruthra kumar
fcf4687c52
test: dimension inheritance on adv allocation
2024-01-19 16:50:54 +05:30
ruthra kumar
6148fb024b
test: dimension inheritance in PE reconciliation
2024-01-19 15:57:13 +05:30
ruthra kumar
ba5a7c8cd8
test: dimension inheritance for cr note reconciliation
2024-01-18 13:29:33 +05:30
ruthra kumar
e3c44231ab
chore: test dimension filter output
2024-01-17 12:51:44 +05:30
ruthra kumar
3349dde5e2
fix(test): test case for project query
2024-01-16 14:28:09 +05:30
rohitwaghchaure
fddf341f44
fix: incorrect ordered qty for Subcontracting Order ( #38415 )
2023-11-29 12:21:11 +05:30
ruthra kumar
514d5434a3
test: varying posting date for gain loss journal
2023-10-23 12:32:10 +05:30
ruthra kumar
0366928db5
test: cost center inheritance from payment
2023-09-03 09:21:26 +05:30
ruthra kumar
79fa562004
test: extend test to cancellation
2023-09-02 14:43:25 +05:30
ruthra kumar
cb6da6ec59
test: deduplicate gain/loss JE on reconciling journals against inv
2023-09-02 13:29:33 +05:30
s-aga-r
305d39f6a1
test: add test case for Subcontract PO update items
2023-08-22 18:24:30 +05:30
ruthra kumar
466734fb4b
fix(test): replace hardcoded reference to adv with dynamic one
2023-08-05 14:11:57 +05:30
ruthra kumar
804afaa647
chore(test): use existing company for unit test
2023-07-27 09:30:38 +05:30
ruthra kumar
47bbb37291
chore: use frappetestcase
2023-07-27 05:54:13 +05:30
ruthra kumar
ae424fdfed
test: assert ledger after cr note cancellation
2023-07-26 22:33:58 +05:30
ruthra kumar
e3d2a2c5bd
test: cr notes against invoice
2023-07-26 22:33:58 +05:30
ruthra kumar
70dd9d0671
chore(test): fix broken unit test
2023-07-26 22:33:58 +05:30
ruthra kumar
f3363e813a
test: journals against sales invoice
2023-07-26 22:33:58 +05:30
ruthra kumar
5695d6a5a6
refactor: unit tests for journals
2023-07-26 22:33:58 +05:30
ruthra kumar
73cc1ba654
refactor: assert payment ledger outstanding in both currencies
2023-07-26 22:33:58 +05:30
ruthra kumar
6e18bb6456
refactor: cancel gain/loss JE on Journal as payment cancellation
2023-07-26 22:33:58 +05:30
ruthra kumar
5e1cd1f227
test: different scenarios for exchange booking
2023-07-26 22:33:58 +05:30
Ankush Menat
a3ea985348
refactor: Use db.set_single_value ( #35668 )
...
I just applied semgrep autofix. Untested completed, review before merging.
```yaml
- id: frappe-set-value-semantics
patterns:
- pattern-either:
- pattern: frappe.db.set_value($DOCTYPE, None, $...AFTER)
- pattern: frappe.db.set_value($DOCTYPE, $DOCTYPE, $...AFTER)
fix: frappe.db.set_single_value($DOCTYPE, $...AFTER)
message: |
If $DOCTYPE is a single doctype then using `frappe.db.set_value` is discouraged for setting values in DB. Use db.set_single_value for single doctype instead.
languages: [python]
severity: ERROR
```
2023-06-13 17:30:38 +05:30
Rohit Waghchaure
e88c5d6d90
fix: travis for subcontracting module
2023-06-02 17:14:18 +05:30
Sagar Sharma
d6433f803b
refactor(minor): rename function to be more descriptive
2023-05-12 11:45:33 +05:30
Sagar Sharma
324bfa9fde
test: fix test case
2022-11-05 16:18:31 +05:30
Sagar Sharma
2effbb55ae
test: Add test case for Subcontracting Receipt GL Entries
2022-08-22 22:14:56 +05:30
Sagar Sharma
c247cf728c
chore: add test for additional-cost
2022-08-19 11:46:36 +05:30
s-aga-r
6d89b2fa28
refactor: backport old subcontracting code
2022-06-20 23:10:02 +05:30
s-aga-r
9a68af36ec
Merge branch 'develop' into subcontracting
2022-06-14 19:13:10 +05:30
Sagar Sharma
213113bc00
Merge branch 'develop' into subcontracting
2022-05-20 12:13:13 +05:30
Sagar Sharma
574181f3d7
test: SubcontractingController
2022-05-20 10:45:33 +05:30
Ankush Menat
494bd9ef78
style: format code with black
2022-03-28 18:52:46 +05:30
Ankush Menat
41a95e5624
fix: ignore empty customer/supplier in item query ( #29610 )
...
* fix: dont try to filter by customer/supplier if None
* test: item query with emtpy supplier
2022-02-03 13:02:13 +05:30
Marica
efcfb825d7
Merge pull request #29257 from marination/fix-reset-wh-defaults
...
fix: Avoid resetting Default wh fields for Manufacture Entry
2022-01-12 16:44:33 +05:30
Ankush Menat
33aad4b950
fix: UOM autocomplete broken
...
All new recent sites seem to have all UOMs as disabled by default. The
desired behaviour is exact opposite of this.
2022-01-11 17:49:30 +05:30
Sagar Sharma
6485ac4e59
fix: misleading "Set Default X" fields after saving ( #28798 )
...
* fix: misleading "Set Default X" fields after saving
* refactor: remove unncessary code and minor formatting
* fix: extend to more doctypes and correct fieldnames
Co-authored-by: Ankush Menat <ankush@frappe.io>
2021-12-09 17:04:00 +05:30
Ankush Menat
8fe5feb6a4
chore: remove all six compat code
2021-11-05 11:16:29 +05:30
Ankush Menat
6098e92ba9
chore: remove utf-8 compat code
2021-11-05 11:16:29 +05:30
Ankush Menat
62fc544280
test: basic tests for controllers/queries ( #27422 )
2021-09-10 12:46:35 +05:30
Chillar Anand
915b34391c
chore: Clean up imports ( #27302 )
...
* chore: Added isort to pre-commit config
* chore: Sort imports with isort
* chore: Clean up imports with pycln
* chore: Sort imports with isort
* chore: Fix import issues
* chore: Clean up sider issues
* chore: Remove import errors from flake8 ignore list
* chore: Clean up lint issues
2021-09-02 16:44:59 +05:30
Ankush Menat
9891780f5a
perf(minor): remove unnecessary comprehensions (port #25645 )
2021-06-11 18:40:22 +05:30
marination
7877d5a7c2
fix: Create QI Parameters (links) in test cases
2021-01-04 11:10:04 +05:30
Deepesh Garg
a9820cdcf6
fix: Remove every bit of randomness from this test
2020-07-11 19:38:51 +05:30
Deepesh Garg
46bcb46422
fix: Do not use random customers
2020-07-11 18:36:32 +05:30
