From ffec8be85f7ddd8bb75774719c01d9aeb3bd81af Mon Sep 17 00:00:00 2001 From: deepeshgarg007 Date: Tue, 28 May 2019 17:56:07 +0530 Subject: [PATCH] fix: Styling and test case fixes --- .../doctype/accounting_dimension/test_accounting_dimension.py | 4 ++-- erpnext/public/js/utils/dimension_tree_filter.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/erpnext/accounts/doctype/accounting_dimension/test_accounting_dimension.py b/erpnext/accounts/doctype/accounting_dimension/test_accounting_dimension.py index 8cf2151079..060299729d 100644 --- a/erpnext/accounts/doctype/accounting_dimension/test_accounting_dimension.py +++ b/erpnext/accounts/doctype/accounting_dimension/test_accounting_dimension.py @@ -71,8 +71,8 @@ class TestAccountingDimension(unittest.TestCase): gle = frappe.get_doc("GL Entry", {"voucher_no": je.name, "account": "Sales - _TC"}) gle1 = frappe.get_doc("GL Entry", {"voucher_no": je.name, "account": "Sales Expenses - _TC"}) - self.assertEqual(gle.department, "_Test Department - _TC") - self.assertEqual(gle1.department, "_Test Department - _TC") + self.assertEqual(gle.get('department'), "_Test Department - _TC") + self.assertEqual(gle1.get('department'), "_Test Department - _TC") def test_mandatory(self): si = create_sales_invoice(do_not_save=1) diff --git a/erpnext/public/js/utils/dimension_tree_filter.js b/erpnext/public/js/utils/dimension_tree_filter.js index e0c055cc1b..827095ae55 100644 --- a/erpnext/public/js/utils/dimension_tree_filter.js +++ b/erpnext/public/js/utils/dimension_tree_filter.js @@ -21,4 +21,4 @@ doclist.forEach((doctype) => { }); } }); -}) \ No newline at end of file +}); \ No newline at end of file