Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #24468 from deepeshgarg007/lse_report_fix

Browse Source 
fix: Division by 0 error in security exposure reports
This commit is contained in:
Deepesh Garg 2021-01-26 10:13:39 +05:30 committed by GitHub
commit ff3adfd1cf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 30 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/loan_management/report/applicant_wise_loan_security_exposure/applicant_wise_loan_security_exposure.py
View File

@ -43,6 +43,7 @@ def get_data(filters):
currency = erpnext.get_company_currency(filters.get('company')) currency = erpnext.get_company_currency(filters.get('company'))
for key, qty in iteritems(pledge_values): for key, qty in iteritems(pledge_values):
if qty:
row = {} row = {}
current_value = flt(qty * loan_security_details.get(key[1], {}).get('latest_price', 0)) current_value = flt(qty * loan_security_details.get(key[1], {}).get('latest_price', 0))
valid_upto = loan_security_details.get(key[1], {}).get('valid_upto') valid_upto = loan_security_details.get(key[1], {}).get('valid_upto')
@ -54,7 +55,8 @@ def get_data(filters):
'total_qty': qty, 'total_qty': qty,
'current_value': current_value, 'current_value': current_value,
'price_valid_upto': valid_upto, 'price_valid_upto': valid_upto,
'portfolio_percent': flt(current_value * 100 / total_value_map.get(key[0]), 2), 'portfolio_percent': flt(current_value * 100 / total_value_map.get(key[0]), 2) if total_value_map.get(key[0]) \
else 0.0,
'currency': currency 'currency': currency
}) })

1
erpnext/loan_management/report/loan_security_exposure/loan_security_exposure.py
View File

@ -40,6 +40,7 @@ def get_data(filters):
currency = erpnext.get_company_currency(filters.get('company')) currency = erpnext.get_company_currency(filters.get('company'))
for security, value in iteritems(current_pledges): for security, value in iteritems(current_pledges):
if value.get('qty'):
row = {} row = {}
current_value = flt(value.get('qty', 0) * loan_security_details.get(security, {}).get('latest_price', 0)) current_value = flt(value.get('qty', 0) * loan_security_details.get(security, {}).get('latest_price', 0))
valid_upto = loan_security_details.get(security, {}).get('valid_upto') valid_upto = loan_security_details.get(security, {}).get('valid_upto')