From fed4fd0f02bda5f5c61487722ad9ed132d102dde Mon Sep 17 00:00:00 2001
From: scmmishra <scm.mymail@gmail.com>
Date: Wed, 17 Apr 2019 15:46:15 +0530
Subject: [PATCH] style: linting issue fixed

---
 erpnext/public/js/utils/serial_no_batch_selector.js | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/erpnext/public/js/utils/serial_no_batch_selector.js b/erpnext/public/js/utils/serial_no_batch_selector.js
index 5287942819..b22d5ca4c4 100644
--- a/erpnext/public/js/utils/serial_no_batch_selector.js
+++ b/erpnext/public/js/utils/serial_no_batch_selector.js
@@ -5,9 +5,10 @@ erpnext.SerialNoBatchSelector = Class.extend({
 		this.show_dialog = show_dialog;
 		// frm, item, warehouse_details, has_batch, oldest
 		let d = this.item;
-		if(d && d.has_batch_no && (!d.batch_no || this.show_dialog)) {
+		if (d && d.has_batch_no && (!d.batch_no || this.show_dialog)) {
 			this.has_batch = 1;
 			this.setup();
+		// !(this.show_dialog == false) ensures that show_dialog is implictly true, even when undefined
 		} else if(d && d.has_serial_no && !(this.show_dialog == false)) {
 			this.has_batch = 0;
 			this.setup();
@@ -66,14 +67,14 @@ erpnext.SerialNoBatchSelector = Class.extend({
 			{
 				fieldname: 'qty',
 				fieldtype:'Float',
-				read_only: me.has_batch ? 1 : 0,
+				read_only: me.has_batch,
 				label: __(me.has_batch ? 'Total Qty' : 'Qty'),
 				default: 0
 			},
 			{
 				fieldname: 'auto_fetch_button',
 				fieldtype:'Button',
-				hidden: me.has_batch ? 1 : 0,
+				hidden: me.has_batch,
 				label: __('Fetch based on FIFO'),
 				click: () => {
 					let qty = this.dialog.fields_dict.qty.get_value();
@@ -89,7 +90,7 @@ erpnext.SerialNoBatchSelector = Class.extend({
 					numbers.then((data) => {
 						let auto_fetched_serial_numbers = data.message;
 						let records_length = auto_fetched_serial_numbers.length;
-						if(records_length < qty) {
+						if (records_length < qty) {
 							frappe.msgprint(`Fetched only ${records_length} serial numbers.`);
 						}
 						let serial_no_list_field = this.dialog.fields_dict.serial_no;
@@ -100,7 +101,7 @@ erpnext.SerialNoBatchSelector = Class.extend({
 			}
 		];
 
-		if(this.has_batch) {
+		if (this.has_batch) {
 			title = __("Select Batch Numbers");
 			fields = fields.concat(this.get_batch_fields());
 		} else {