Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: review fixes

Browse Source
This commit is contained in:
Himanshu Warekar 2019-09-02 12:10:15 +05:30
parent a5b78f3c0d
commit fd85b1689d
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/communication/doctype/call_log/call_log.py
View File

@ -75,7 +75,7 @@ def set_caller_information(doc, state):
# Contact now has all the nos saved in child table # Contact now has all the nos saved in child table
if doc.doctype == 'Contact': if doc.doctype == 'Contact':
numbers = [nos.phone for nos in doc.phone_nos] numbers = [d.phone for d in doc.phone_nos]
for number in numbers: for number in numbers:
number = strip_number(number) number = strip_number(number)

6
erpnext/crm/doctype/opportunity/test_opportunity.py
View File

@ -45,7 +45,7 @@ class TestOpportunity(unittest.TestCase):
# create new customer and create new contact against 'new.opportunity@example.com' # create new customer and create new contact against 'new.opportunity@example.com'
customer = make_customer(opp_doc.party_name).insert(ignore_permissions=True) customer = make_customer(opp_doc.party_name).insert(ignore_permissions=True)
d = frappe.get_doc({ contact = frappe.get_doc({
"doctype": "Contact", "doctype": "Contact",
"first_name": "_Test Opportunity Customer", "first_name": "_Test Opportunity Customer",
"links": [{ "links": [{
@ -53,8 +53,8 @@ class TestOpportunity(unittest.TestCase):
"link_name": customer.name "link_name": customer.name
}] }]
}) })
d.add_email(new_lead_email_id) contact.add_email(new_lead_email_id)
d.insert(ignore_permissions=True) contact.insert(ignore_permissions=True)
opp_doc = frappe.get_doc(args).insert(ignore_permissions=True) opp_doc = frappe.get_doc(args).insert(ignore_permissions=True)
self.assertTrue(opp_doc.party_name) self.assertTrue(opp_doc.party_name)