fix: review fixes

This commit is contained in:
Himanshu Warekar 2019-09-02 12:10:15 +05:30
parent a5b78f3c0d
commit fd85b1689d
3 changed files with 7 additions and 7 deletions

View File

@ -75,7 +75,7 @@ def set_caller_information(doc, state):
# Contact now has all the nos saved in child table
if doc.doctype == 'Contact':
numbers = [nos.phone for nos in doc.phone_nos]
numbers = [d.phone for d in doc.phone_nos]
for number in numbers:
number = strip_number(number)

View File

@ -45,7 +45,7 @@ class TestOpportunity(unittest.TestCase):
# create new customer and create new contact against 'new.opportunity@example.com'
customer = make_customer(opp_doc.party_name).insert(ignore_permissions=True)
d = frappe.get_doc({
contact = frappe.get_doc({
"doctype": "Contact",
"first_name": "_Test Opportunity Customer",
"links": [{
@ -53,8 +53,8 @@ class TestOpportunity(unittest.TestCase):
"link_name": customer.name
}]
})
d.add_email(new_lead_email_id)
d.insert(ignore_permissions=True)
contact.add_email(new_lead_email_id)
contact.insert(ignore_permissions=True)
opp_doc = frappe.get_doc(args).insert(ignore_permissions=True)
self.assertTrue(opp_doc.party_name)

View File

@ -21,7 +21,7 @@
{% endif %}
{% if(contact_list[i].phone_nos) { %}
{% for(var j=0, k=contact_list[i].phone_nos.length; j<k; j++) { %}
{%= __("Phone ") %}: {%= contact_list[i].phone_nos[j].phone %}<br>
{%= __("Phone") %}: {%= contact_list[i].phone_nos[j].phone %}<br>
{% } %}
{% endif %}
</p>
@ -31,14 +31,14 @@
{% endif %}
{% if(contact_list[i].email_ids) { %}
{% for(var j=0, k=contact_list[i].email_ids.length; j<k; j++) { %}
{%= __("Email ") %}: {%= contact_list[i].email_ids[j].email_id %}<br>
{%= __("Email") %}: {%= contact_list[i].email_ids[j].email_id %}<br>
{% } %}
{% endif %}
</p>
{% endif %}
<p>
{% if (contact_list[i].address) { %}
{%= __("Address ") %}: {%= contact_list[i].address %}<br>
{%= __("Address") %}: {%= contact_list[i].address %}<br>
{% endif %}
</p>
</div>