fix: Supplied Qty not updated on Stock Entry cancel

- Loop over PO supplied items and update them as data from SE will exclude a row if supplied qty becomes 0 on cancel
- Use DB API insteaf of raw SQL
This commit is contained in:
marination 2022-06-13 17:59:03 +05:30
parent 83367bfe5e
commit fa1d9d548e

View File

@ -1980,23 +1980,30 @@ class StockEntry(StockController):
): ):
# Get PO Supplied Items Details # Get PO Supplied Items Details
item_wh = frappe._dict( po_supplied_items = frappe.db.get_all(
frappe.db.sql( "Purchase Order Item Supplied",
""" filters={"parent": self.purchase_order},
select rm_item_code, reserve_warehouse fields=["name", "rm_item_code", "reserve_warehouse"],
from `tabPurchase Order` po, `tabPurchase Order Item Supplied` poitemsup
where po.name = poitemsup.parent
and po.name = %s""",
self.purchase_order,
)
) )
# Get Items Supplied in Stock Entries against PO
supplied_items = get_supplied_items(self.purchase_order) supplied_items = get_supplied_items(self.purchase_order)
for name, item in supplied_items.items():
frappe.db.set_value("Purchase Order Item Supplied", name, item)
# Update reserved sub contracted quantity in bin based on Supplied Item Details and for row in po_supplied_items:
key, item = row.name, {}
if not supplied_items.get(key):
# no stock transferred against PO Supplied Items row
item = {"supplied_qty": 0, "returned_qty": 0, "total_supplied_qty": 0}
else:
item = supplied_items.get(key)
frappe.db.set_value("Purchase Order Item Supplied", row.name, item)
# RM Item-Reserve Warehouse Dict
item_wh = {x.get("rm_item_code"): x.get("reserve_warehouse") for x in po_supplied_items}
for d in self.get("items"): for d in self.get("items"):
# Update reserved sub contracted quantity in bin based on Supplied Item Details and
item_code = d.get("original_item") or d.get("item_code") item_code = d.get("original_item") or d.get("item_code")
reserve_warehouse = item_wh.get(item_code) reserve_warehouse = item_wh.get(item_code)
if not (reserve_warehouse and item_code): if not (reserve_warehouse and item_code):