Changed columns and added currency conditions

This commit is contained in:
deepeshgarg007 2018-11-13 15:07:05 +05:30
parent b6c083706a
commit f98adf2be5

View File

@ -65,8 +65,8 @@ class ReceivablePayableReport(object):
"width": 120 "width": 120
}) })
columns.append({ columns.append({
"label": "Payment Term Amount", "label": "Invoice Grand Total",
"fieldname": "payment_term_amount", "fieldname": "invoice_grand_total",
"fieldtype": "Currency", "fieldtype": "Currency",
"options": "currency", "options": "currency",
"width": 120 "width": 120
@ -128,14 +128,14 @@ class ReceivablePayableReport(object):
"fieldname": "pdc/lc_amount", "fieldname": "pdc/lc_amount",
"label": _("PDC/LC Amount"), "label": _("PDC/LC Amount"),
"fieldtype": "Currency", "fieldtype": "Currency",
"options": "Currency", "options": "currency",
"width": 130 "width": 130
}, },
{ {
"fieldname": "remaining_balance", "fieldname": "remaining_balance",
"label": _("Remaining Balance"), "label": _("Remaining Balance"),
"fieldtype": "Currency", "fieldtype": "Currency",
"options": "Currency", "options": "currency",
"width": 130 "width": 130
}] }]
@ -166,7 +166,7 @@ class ReceivablePayableReport(object):
def get_data(self, party_naming_by, args): def get_data(self, party_naming_by, args):
from erpnext.accounts.utils import get_currency_precision from erpnext.accounts.utils import get_currency_precision
currency_precision = get_currency_precision() or 2 self.currency_precision = get_currency_precision() or 2
self.dr_or_cr = "debit" if args.get("party_type") == "Customer" else "credit" self.dr_or_cr = "debit" if args.get("party_type") == "Customer" else "credit"
future_vouchers = self.get_entries_after(self.filters.report_date, args.get("party_type")) future_vouchers = self.get_entries_after(self.filters.report_date, args.get("party_type"))
@ -193,8 +193,8 @@ class ReceivablePayableReport(object):
for gle in gl_entries_data: for gle in gl_entries_data:
if self.is_receivable_or_payable(gle, self.dr_or_cr, future_vouchers): if self.is_receivable_or_payable(gle, self.dr_or_cr, future_vouchers):
outstanding_amount, credit_note_amount, payment_amount = self.get_outstanding_amount( outstanding_amount, credit_note_amount, payment_amount = self.get_outstanding_amount(
gle,self.filters.report_date, self.dr_or_cr, return_entries, currency_precision) gle,self.filters.report_date, self.dr_or_cr, return_entries)
if abs(outstanding_amount) > 0.1/10**currency_precision: if abs(outstanding_amount) > 0.1/10**self.currency_precision:
if self.filters.based_on_payment_terms and self.payment_term_map.get(gle.voucher_no): if self.filters.based_on_payment_terms and self.payment_term_map.get(gle.voucher_no):
pdc_amount = flt(self.pdc_details.get((gle.voucher_no, gle.party), {}).get("pdc_amount")) pdc_amount = flt(self.pdc_details.get((gle.voucher_no, gle.party), {}).get("pdc_amount"))
for d in self.payment_term_map.get(gle.voucher_no): for d in self.payment_term_map.get(gle.voucher_no):
@ -210,7 +210,8 @@ class ReceivablePayableReport(object):
else: else:
pdc = pdc_amount pdc = pdc_amount
pdc_amount = 0 pdc_amount = 0
if self.filters.get(gle.party_type):
d[1] = d[1] * d[3]
row = self.prepare_row(party_naming_by, args, gle, outstanding_amount, row = self.prepare_row(party_naming_by, args, gle, outstanding_amount,
credit_note_amount, d[0], payment_amount , d[1], d[2], pdc) credit_note_amount, d[0], payment_amount , d[1], d[2], pdc)
payment_amount = 0 payment_amount = 0
@ -247,7 +248,9 @@ class ReceivablePayableReport(object):
invoiced_amount = gle.get(self.dr_or_cr) if (gle.get(self.dr_or_cr) > 0) else 0 invoiced_amount = gle.get(self.dr_or_cr) if (gle.get(self.dr_or_cr) > 0) else 0
if self.filters.based_on_payment_terms: if self.filters.based_on_payment_terms:
row+=[payment_term, payment_term_amount] row+=[payment_term, invoiced_amount]
if payment_term_amount:
invoiced_amount = payment_term_amount
if paid_amt == None: if paid_amt == None:
paid_amt = invoiced_amount - outstanding_amount - credit_note_amount paid_amt = invoiced_amount - outstanding_amount - credit_note_amount
@ -344,23 +347,23 @@ class ReceivablePayableReport(object):
doctype = "Sales Invoice" if party_type=="Customer" else "Purchase Invoice" doctype = "Sales Invoice" if party_type=="Customer" else "Purchase Invoice"
return [d.name for d in frappe.get_all(doctype, filters={"is_return": 1, "docstatus": 1})] return [d.name for d in frappe.get_all(doctype, filters={"is_return": 1, "docstatus": 1})]
def get_outstanding_amount(self, gle, report_date, dr_or_cr, return_entries, currency_precision): def get_outstanding_amount(self, gle, report_date, dr_or_cr, return_entries):
payment_amount, credit_note_amount = 0.0, 0.0 payment_amount, credit_note_amount = 0.0, 0.0
reverse_dr_or_cr = "credit" if dr_or_cr=="debit" else "debit" reverse_dr_or_cr = "credit" if dr_or_cr=="debit" else "debit"
for e in self.get_gl_entries_for(gle.party, gle.party_type, gle.voucher_type, gle.voucher_no): for e in self.get_gl_entries_for(gle.party, gle.party_type, gle.voucher_type, gle.voucher_no):
if getdate(e.posting_date) <= report_date and e.name!=gle.name: if getdate(e.posting_date) <= report_date and e.name!=gle.name:
amount = flt(e.get(reverse_dr_or_cr), currency_precision) - flt(e.get(dr_or_cr), currency_precision) amount = flt(e.get(reverse_dr_or_cr), self.currency_precision) - flt(e.get(dr_or_cr), self.currency_precision)
if e.voucher_no not in return_entries: if e.voucher_no not in return_entries:
payment_amount += amount payment_amount += amount
else: else:
credit_note_amount += amount credit_note_amount += amount
outstanding_amount = (flt((flt(gle.get(dr_or_cr), currency_precision) outstanding_amount = (flt((flt(gle.get(dr_or_cr), self.currency_precision)
- flt(gle.get(reverse_dr_or_cr), currency_precision) - flt(gle.get(reverse_dr_or_cr), self.currency_precision)
- payment_amount - credit_note_amount), currency_precision)) - payment_amount - credit_note_amount), self.currency_precision))
credit_note_amount = flt(credit_note_amount, currency_precision) credit_note_amount = flt(credit_note_amount, self.currency_precision)
return outstanding_amount, credit_note_amount, payment_amount return outstanding_amount, credit_note_amount, payment_amount
@ -498,16 +501,22 @@ class ReceivablePayableReport(object):
def get_payment_term_detail(self, voucher_nos): def get_payment_term_detail(self, voucher_nos):
payment_term_map = frappe._dict() payment_term_map = frappe._dict()
for d in frappe.db.sql(""" select si.name, si.payment_terms_template, ps.due_date, ps.payment_amount, ps.description for d in frappe.db.sql(""" select si.name, si.payment_terms_template,
from `tabSales Invoice` si, `tabPayment Schedule` ps party_account_currency, currency, si.conversion_rate,
where si.name = ps.parent and ps.due_date, ps.payment_amount, ps.description
si.docstatus = 1 and si.company = '%s' and from `tabSales Invoice` si, `tabPayment Schedule` ps
si.name in (%s) order by ps.due_date""" where si.name = ps.parent and
si.docstatus = 1 and si.company = '%s' and
si.name in (%s) order by ps.due_date"""
% (self.filters.company, ','.join(['%s'] *len(voucher_nos))), (tuple(voucher_nos)), as_dict = 1): % (self.filters.company, ','.join(['%s'] *len(voucher_nos))), (tuple(voucher_nos)), as_dict = 1):
if d.payment_terms_template: if d.payment_terms_template:
payment_term_map.setdefault(d.name, []) if self.filters.get("customer") and d.currency == d.party_account_currency:
payment_term_map[d.name].append((d.due_date, d.payment_amount, d.description)) payment_term_amount = d.payment_amount
else:
payment_term_amount = flt(flt(d.payment_amount) * flt(d.conversion_rate), self.currency_precision)
payment_term_map.setdefault(d.name, [])
payment_term_map[d.name].append((d.due_date, payment_term_amount, d.description))
return payment_term_map return payment_term_map
def get_chart_data(self, columns, data): def get_chart_data(self, columns, data):