From f7f32634c873572391d7f7f19cb35e92a67bcb3f Mon Sep 17 00:00:00 2001 From: scmmishra Date: Sun, 24 Mar 2019 20:43:15 +0530 Subject: [PATCH] feat: Added check for no end date and refactored query --- erpnext/projects/doctype/task/task.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/erpnext/projects/doctype/task/task.py b/erpnext/projects/doctype/task/task.py index ca78e5eace..221df41a01 100755 --- a/erpnext/projects/doctype/task/task.py +++ b/erpnext/projects/doctype/task/task.py @@ -160,7 +160,7 @@ class Task(NestedSet): self.update_nsm_model() def update_status(self): - if self.status not in ('Cancelled', 'Closed'): + if self.status not in ('Cancelled', 'Closed') and self.exp_end_date: from datetime import datetime if self.exp_end_date < datetime.now().date(): self.date = 'Overdue' @@ -193,7 +193,7 @@ def set_multiple_status(names, status): task.save() def set_tasks_as_overdue(): - tasks = frappe.get_all("Task") + tasks = frappe.get_all("Task", filters={'status':['not in',['Cancelled', 'Closed']]}) for task in tasks: frappe.get_doc("Task", task.name).update_status()