From f7daab739303e50cf6af17ac9509a146dbeb82c5 Mon Sep 17 00:00:00 2001 From: Pratik Vyas Date: Thu, 10 Apr 2014 17:53:30 +0530 Subject: [PATCH] pass only valid columns to get_item_details --- erpnext/controllers/accounts_controller.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/erpnext/controllers/accounts_controller.py b/erpnext/controllers/accounts_controller.py index 9758b99b7f..a0eb85dba5 100644 --- a/erpnext/controllers/accounts_controller.py +++ b/erpnext/controllers/accounts_controller.py @@ -87,10 +87,14 @@ class AccountsController(TransactionBase): """set missing item values""" from erpnext.stock.get_item_details import get_item_details if hasattr(self, "fname"): + parent_dict = {} + for fieldname in self.meta.get_valid_columns(): + parent_dict[fieldname] = self.get(fieldname) + for item in self.get(self.fname): if item.get("item_code"): - args = self.as_dict() - args.update(item.as_dict()) + args = item.as_dict() + args.update(parent_dict) ret = get_item_details(args) for fieldname, value in ret.items(): if item.meta.get_field(fieldname) and \