diff --git a/erpnext/setup/doctype/email_digest/email_digest.py b/erpnext/setup/doctype/email_digest/email_digest.py index 6524f5cc0a..e391d37216 100644 --- a/erpnext/setup/doctype/email_digest/email_digest.py +++ b/erpnext/setup/doctype/email_digest/email_digest.py @@ -377,8 +377,11 @@ class DocType: * Execute get method * Send email to recipients """ + if not self.doc.recipient_list: return + self.sending = True result, email_body = self.get() + recipient_list = self.doc.recipient_list.split("\n") # before sending, check if user is disabled or not @@ -633,7 +636,7 @@ class DocType: [ "%s" % bank['name'], currency_amount_str % (currency, fmt_money(bank['value'])) - ] for bank in result['bank_balance'] + ] for bank in result.get('bank_balance', []) ] }), 'idx': 400 diff --git a/erpnext/support/doctype/support_ticket/__init__.py b/erpnext/support/doctype/support_ticket/__init__.py index 1b09fc95cc..e6cf07ed4f 100644 --- a/erpnext/support/doctype/support_ticket/__init__.py +++ b/erpnext/support/doctype/support_ticket/__init__.py @@ -63,7 +63,7 @@ class SupportMailbox(POP3Mailbox): st = get_obj('Support Ticket', thread_id) st.make_response_record(content, mail.mail['From'], content_type) webnotes.conn.set(st.doc, 'status', 'Open') - update_feed(st.doc) + update_feed(st.doc, 'on_update') # extract attachments self.save_attachments(st.doc, mail.attachments) return @@ -84,7 +84,7 @@ class SupportMailbox(POP3Mailbox): d.save(1) # update feed - update_feed(d) + update_feed(d, 'on_update') # send auto reply self.send_auto_reply(d)