From f702d72c3542f5bcf7d2c66ed8861787170e5ecd Mon Sep 17 00:00:00 2001 From: Rushabh Mehta Date: Wed, 27 Sep 2017 15:31:30 +0530 Subject: [PATCH] [minor] [performance] push hsn code creation after setup (#10928) --- erpnext/regional/india/setup.py | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/erpnext/regional/india/setup.py b/erpnext/regional/india/setup.py index 106a3d5740..2798cfbd53 100644 --- a/erpnext/regional/india/setup.py +++ b/erpnext/regional/india/setup.py @@ -12,7 +12,7 @@ def setup(company=None, patch=True): make_custom_fields() add_permissions() add_custom_roles_for_reports() - add_hsn_sac_codes() + frappe.enqueue('erpnext.regional.india.setup.add_hsn_sac_codes') add_print_formats() if not patch: update_address_template() @@ -47,12 +47,14 @@ def add_hsn_sac_codes(): def create_hsn_codes(data, code_field): for d in data: - if not frappe.db.exists("GST HSN Code", d[code_field]): - hsn_code = frappe.new_doc('GST HSN Code') - hsn_code.description = d["description"] - hsn_code.hsn_code = d[code_field] - hsn_code.name = d[code_field] + hsn_code = frappe.new_doc('GST HSN Code') + hsn_code.description = d["description"] + hsn_code.hsn_code = d[code_field] + hsn_code.name = d[code_field] + try: hsn_code.db_insert() + except frappe.DuplicateEntryError: + pass def add_custom_roles_for_reports(): for report_name in ('GST Sales Register', 'GST Purchase Register',