Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Product Filters Lookup

Browse Source 
- bind the right classes to the filter lookup field
- make class names more descriptive
- make filter lookup field more visible with white bg and border
- bind lookup input field js in `views.js`
- make filter lookup field functioning for atribute filters too
- added placeholder to lookup field
This commit is contained in:
marination 2022-03-21 17:53:18 +05:30
parent d3be84bfe8
commit f6e64c2cac
5 changed files with 31 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
erpnext/e_commerce/product_ui/views.js
View File

@ -418,6 +418,22 @@ erpnext.ProductView = class {
me.change_route_with_filters(); me.change_route_with_filters();
}); });
// bind filter lookup input box
$('.filter-lookup-input').on('keydown', frappe.utils.debounce((e) => {
const $input = $(e.target);
const keyword = ($input.val() || '').toLowerCase();
const $filter_options = $input.next('.filter-options');
$filter_options.find('.filter-lookup-wrapper').show();
$filter_options.find('.filter-lookup-wrapper').each((i, el) => {
const $el = $(el);
const value = $el.data('value').toLowerCase();
if (!value.includes(keyword)) {
$el.hide();
}
});
}, 300));
} }
change_route_with_filters() { change_route_with_filters() {

9
erpnext/public/scss/shopping_cart.scss
View File

@ -264,6 +264,15 @@ body.product-page {
font-size: 13px; font-size: 13px;
} }
.filter-lookup-input {
background-color: white;
border: 1px solid var(--gray-300);
&:focus {
border: 1px solid var(--primary);
}
}
.filter-label { .filter-label {
font-size: 11px; font-size: 11px;
font-weight: 600; font-weight: 600;

18
erpnext/templates/generators/item_group.html
View File

@ -52,24 +52,6 @@
</div> </div>
<script>
frappe.ready(() => {
$('.product-filter-filter').on('keydown', frappe.utils.debounce((e) => {
const $input = $(e.target);
const keyword = ($input.val() || '').toLowerCase();
const $filter_options = $input.next('.filter-options');
$filter_options.find('.custom-control').show();
$filter_options.find('.custom-control').each((i, el) => {
const $el = $(el);
const value = $el.data('value').toLowerCase();
if (!value.includes(keyword)) {
$el.hide();
}
});
}, 300));
})
</script>
</div> </div>
</div> </div>
</div> </div>

12
erpnext/templates/includes/macros.html
View File

@ -300,13 +300,13 @@
{% if values | len > 20 %} {% if values | len > 20 %}
<!-- show inline filter if values more than 20 --> <!-- show inline filter if values more than 20 -->
<input type="text" class="form-control form-control-sm mb-2 product-filter-filter"/> <input type="text" class="form-control form-control-sm mb-2 filter-lookup-input" placeholder="Search {{ item_field.label + 's' }}"/>
{% endif %} {% endif %}
{% if values %} {% if values %}
<div class="filter-options"> <div class="filter-options">
{% for value in values %} {% for value in values %}
<div class="checkbox" data-value="{{ value }}"> <div class="filter-lookup-wrapper checkbox" data-value="{{ value }}">
<label for="{{value}}"> <label for="{{value}}">
<input type="checkbox" <input type="checkbox"
class="product-filter field-filter" class="product-filter field-filter"
@ -329,16 +329,16 @@
{%- macro attribute_filter_section(filters)-%} {%- macro attribute_filter_section(filters)-%}
{% for attribute in filters %} {% for attribute in filters %}
<div class="mb-4 filter-block pb-5"> <div class="mb-4 filter-block pb-5">
<div class="filter-label mb-3">{{ attribute.name}}</div> <div class="filter-label mb-3">{{ attribute.name }}</div>
{% if values | len > 20 %} {% if attribute.item_attribute_values | len > 20 %}
<!-- show inline filter if values more than 20 --> <!-- show inline filter if values more than 20 -->
<input type="text" class="form-control form-control-sm mb-2 product-filter-filter"/> <input type="text" class="form-control form-control-sm mb-2 filter-lookup-input" placeholder="Search {{ attribute.name + 's' }}"/>
{% endif %} {% endif %}
{% if attribute.item_attribute_values %} {% if attribute.item_attribute_values %}
<div class="filter-options"> <div class="filter-options">
{% for attr_value in attribute.item_attribute_values %} {% for attr_value in attribute.item_attribute_values %}
<div class="checkbox"> <div class="filter-lookup-wrapper checkbox" data-value="{{ attr_value }}">
<label data-value="{{ attr_value }}"> <label data-value="{{ attr_value }}">
<input type="checkbox" <input type="checkbox"
class="product-filter attribute-filter" class="product-filter attribute-filter"

18
erpnext/www/all-products/index.html
View File

@ -31,24 +31,6 @@
{% endif %} {% endif %}
</div> </div>
<script>
frappe.ready(() => {
$('.product-filter-filter').on('keydown', frappe.utils.debounce((e) => {
const $input = $(e.target);
const keyword = ($input.val() || '').toLowerCase();
const $filter_options = $input.next('.filter-options');
$filter_options.find('.custom-control').show();
$filter_options.find('.custom-control').each((i, el) => {
const $el = $(el);
const value = $el.data('value').toLowerCase();
if (!value.includes(keyword)) {
$el.hide();
}
});
}, 300));
})
</script>
</div> </div>
</div> </div>