Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf: significant reduction in time taken to save a delivery note (#25475)

Browse Source
This commit is contained in:
Sagar Vora 2021-05-06 16:40:06 +05:30 committed by GitHub
parent d502f76319
commit f43a86d90f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 24 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
erpnext/selling/doctype/customer/customer.py
View File

@ -490,7 +490,7 @@ def get_customer_outstanding(customer, company, ignore_outstanding_sales_order=F
outstanding_based_on_gle = flt(outstanding_based_on_gle[0][0]) if outstanding_based_on_gle else 0 outstanding_based_on_gle = flt(outstanding_based_on_gle[0][0]) if outstanding_based_on_gle else 0
# Outstanding based on Sales Order # Outstanding based on Sales Order
outstanding_based_on_so = 0.0 outstanding_based_on_so = 0
# if credit limit check is bypassed at sales order level, # if credit limit check is bypassed at sales order level,
# we should not consider outstanding Sales Orders, when customer credit balance report is run # we should not consider outstanding Sales Orders, when customer credit balance report is run
@ -501,9 +501,11 @@ def get_customer_outstanding(customer, company, ignore_outstanding_sales_order=F
where customer=%s and docstatus = 1 and company=%s where customer=%s and docstatus = 1 and company=%s
and per_billed < 100 and status != 'Closed'""", (customer, company)) and per_billed < 100 and status != 'Closed'""", (customer, company))
outstanding_based_on_so = flt(outstanding_based_on_so[0][0]) if outstanding_based_on_so else 0.0 outstanding_based_on_so = flt(outstanding_based_on_so[0][0]) if outstanding_based_on_so else 0
# Outstanding based on Delivery Note, which are not created against Sales Order # Outstanding based on Delivery Note, which are not created against Sales Order
outstanding_based_on_dn = 0
unmarked_delivery_note_items = frappe.db.sql("""select unmarked_delivery_note_items = frappe.db.sql("""select
dn_item.name, dn_item.amount, dn.base_net_total, dn.base_grand_total dn_item.name, dn_item.amount, dn.base_net_total, dn.base_grand_total
from `tabDelivery Note` dn, `tabDelivery Note Item` dn_item from `tabDelivery Note` dn, `tabDelivery Note Item` dn_item
@ -515,15 +517,29 @@ def get_customer_outstanding(customer, company, ignore_outstanding_sales_order=F
and ifnull(dn_item.against_sales_invoice, '') = '' and ifnull(dn_item.against_sales_invoice, '') = ''
""", (customer, company), as_dict=True) """, (customer, company), as_dict=True)
outstanding_based_on_dn = 0.0 if not unmarked_delivery_note_items:
return outstanding_based_on_gle + outstanding_based_on_so
si_amounts = frappe.db.sql("""
SELECT
dn_detail, sum(amount) from `tabSales Invoice Item`
WHERE
docstatus = 1
and dn_detail in ({})
GROUP BY dn_detail""".format(", ".join(
frappe.db.escape(dn_item.name)
for dn_item in unmarked_delivery_note_items
))
)
si_amounts = {si_item[0]: si_item[1] for si_item in si_amounts}
for dn_item in unmarked_delivery_note_items: for dn_item in unmarked_delivery_note_items:
si_amount = frappe.db.sql("""select sum(amount) dn_amount = flt(dn_item.amount)
from `tabSales Invoice Item` si_amount = flt(si_amounts.get(dn_item.name))
where dn_detail = %s and docstatus = 1""", dn_item.name)[0][0]
if flt(dn_item.amount) > flt(si_amount) and dn_item.base_net_total: if dn_amount > si_amount and dn_item.base_net_total:
outstanding_based_on_dn += ((flt(dn_item.amount) - flt(si_amount)) \ outstanding_based_on_dn += ((dn_amount - si_amount)
/ dn_item.base_net_total) * dn_item.base_grand_total / dn_item.base_net_total) * dn_item.base_grand_total
return outstanding_based_on_gle + outstanding_based_on_so + outstanding_based_on_dn return outstanding_based_on_gle + outstanding_based_on_so + outstanding_based_on_dn