From 04d61717bcc23715a118844694c16c0d36c16615 Mon Sep 17 00:00:00 2001
From: Shivam Mishra <scm.mymail@gmail.com>
Date: Fri, 7 Jun 2019 13:03:46 +0530
Subject: [PATCH 1/3] fix: lms card hero image no visible

---
 erpnext/www/lms/course.html      | 2 +-
 erpnext/www/lms/macros/card.html | 2 +-
 erpnext/www/lms/program.html     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/erpnext/www/lms/course.html b/erpnext/www/lms/course.html
index 0bfd059013..84cad36f9d 100644
--- a/erpnext/www/lms/course.html
+++ b/erpnext/www/lms/course.html
@@ -45,7 +45,7 @@
 			<div>
 		{% endif %}
 			{% if topic.hero_image %}
-			<div class="card-hero-img" style="background-image: url({{ topic.hero_image }})"></div>
+			<div class="card-hero-img" style="background-image: url('{{ topic.hero_image }})'"></div>
 			{% else %}
 			<div class="card-image-wrapper text-center">
 				<div class="image-body"><i class="fa fa-picture-o" aria-hidden="true"></i></div>
diff --git a/erpnext/www/lms/macros/card.html b/erpnext/www/lms/macros/card.html
index f227355832..9964d2df34 100644
--- a/erpnext/www/lms/macros/card.html
+++ b/erpnext/www/lms/macros/card.html
@@ -3,7 +3,7 @@
 	<a href="/lms/program?program={{ program.name }}" class="no-decoration no-underline">
 	<div class="card h-100">
 		{% if program.hero_image %}
-		<div class="card-hero-img" style="background-image: url({{ program.hero_image }})"></div>
+		<div class="card-hero-img" style="background-image: url('{{ program.hero_image }}')"></div>
 		{% else %}
 		<div class="card-image-wrapper text-center">
 			<div class="image-body"><i class="fa fa-picture-o" aria-hidden="true"></i></div>
diff --git a/erpnext/www/lms/program.html b/erpnext/www/lms/program.html
index d1227788b8..b6d696653b 100644
--- a/erpnext/www/lms/program.html
+++ b/erpnext/www/lms/program.html
@@ -42,7 +42,7 @@
 	<a href="/lms/course?name={{ course.name }}&program={{ program.name }}" class="no-decoration no-underline">
 	<div class="card h-100">
 		{% if course.hero_image %}
-		<div class="card-hero-img" style="background-image: url({{ course.hero_image }})"></div>
+		<div class="card-hero-img" style="background-image: url('{{ course.hero_image }}')"></div>
 		{% else %}
 		<div class="card-image-wrapper text-center">
 			<div class="image-body"><i class="fa fa-picture-o" aria-hidden="true"></i></div>

From 8d1117cbee989e06c2b6c02e5225e9d77daa2ae6 Mon Sep 17 00:00:00 2001
From: Shivam Mishra <scm.mymail@gmail.com>
Date: Thu, 6 Jun 2019 19:27:21 +0530
Subject: [PATCH 2/3] fix: link typo

---
 erpnext/www/lms/index.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/erpnext/www/lms/index.html b/erpnext/www/lms/index.html
index 7ea39d8a99..3e107ac608 100644
--- a/erpnext/www/lms/index.html
+++ b/erpnext/www/lms/index.html
@@ -45,7 +45,7 @@
 		<p class='lead'>{{ education_settings.description }}</p>
 		<p class="mt-4">
 			{% if frappe.session.user == 'Guest' %}
-			<a class="btn btn-primary btn-lg" href="'/login#signup'}}">Start Learning</a>
+				<a class="btn btn-primary btn-lg" href="'/login#signup'">Sign Up</a>
 			{% endif %}
 		</p>
 	</div>

From 449f2611280025fba48aa918f9e6a4ac88b9bc12 Mon Sep 17 00:00:00 2001
From: Shivam Mishra <scm.mymail@gmail.com>
Date: Thu, 6 Jun 2019 18:33:58 +0530
Subject: [PATCH 3/3] feat: show signup dialog for Guest

---
 erpnext/www/lms/course.html | 21 ++++++++++++++++++++-
 erpnext/www/lms/topic.html  |  2 +-
 2 files changed, 21 insertions(+), 2 deletions(-)

diff --git a/erpnext/www/lms/course.html b/erpnext/www/lms/course.html
index 84cad36f9d..f8618e08ec 100644
--- a/erpnext/www/lms/course.html
+++ b/erpnext/www/lms/course.html
@@ -42,7 +42,7 @@
 		{% if has_access %}
 			<a href="/lms/topic?program={{ program }}&course={{ course.name }}&topic={{ topic.name }}" class="no-decoration no-underline">
 		{% else %}
-			<div>
+			<div onclick="show_singup()">
 		{% endif %}
 			{% if topic.hero_image %}
 			<div class="card-hero-img" style="background-image: url('{{ topic.hero_image }})'"></div>
@@ -103,4 +103,23 @@
 		</div>
 	</div>
 </section>
+{% endblock %}
+
+{% block script %}
+<script>
+	function show_singup() {
+		if (frappe.session.user == "Guest") {
+			let signup_dialog = new frappe.ui.Dialog({
+				title: __('Sign Up'),
+				primary_action: function() {
+					window.location.href = '/login#signup'
+				},
+				primary_action_label: 'Sign Up'
+			})
+			signup_dialog.set_message('You have to sign up to access the course');
+			signup_dialog.$message.show()
+			signup_dialog.show();
+		}
+	}
+</script>
 {% endblock %}
\ No newline at end of file
diff --git a/erpnext/www/lms/topic.html b/erpnext/www/lms/topic.html
index 3a777765a1..3bbfbd0936 100644
--- a/erpnext/www/lms/topic.html
+++ b/erpnext/www/lms/topic.html
@@ -17,7 +17,7 @@
 	<a href="/lms/content?program={{ program }}&course={{ course }}&topic={{ topic.name }}&type={{ content.content_type }}&content={{ content.content.name }}" class="no-decoration no-underline">
 	<div class="card h-100">
 		<div class='card-body'>
-			<div>{{ content.content_type or '' }}</div>
+			<div class="text-muted">{{ content.content_type or '' }}</div>
 			<h5 class='card-title'>{{ content.content.name }}</h5>
 		</div>
 		{% if has_access %}