From 3edc1019577d9b1402ea633f1a71b2501aaae845 Mon Sep 17 00:00:00 2001 From: Rohit Waghchaure Date: Mon, 26 Feb 2018 13:04:26 +0530 Subject: [PATCH] [Fix] POS discount issue --- .../page/point_of_sale/point_of_sale.js | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/erpnext/selling/page/point_of_sale/point_of_sale.js b/erpnext/selling/page/point_of_sale/point_of_sale.js index d1f6b7a7c2..0fa082fddc 100644 --- a/erpnext/selling/page/point_of_sale/point_of_sale.js +++ b/erpnext/selling/page/point_of_sale/point_of_sale.js @@ -257,12 +257,16 @@ erpnext.pos.PointOfSale = class PointOfSale { frappe.msgprint(__("Quantity must be positive")); value = item.qty; } else { - item[field] = value; - if (field == "serial_no" && value) { - let serial_nos = value.split("\n"); - item["qty"] = serial_nos.filter(d => { - return d!==""; - }).length; + if (in_list(["qty", "serial_no", "batch"], field)) { + item[field] = value; + if (field == "serial_no" && value) { + let serial_nos = value.split("\n"); + item["qty"] = serial_nos.filter(d => { + return d!==""; + }).length; + } + } else { + return frappe.model.set_value(item.doctype, item.name, field, value); } } @@ -1475,7 +1479,7 @@ class Payment { fieldname: p.mode_of_payment, default: p.amount, onchange: () => { - const value = this.dialog.get_value(this.fieldname); + const value = this.dialog.get_value(this.fieldname) || 0; me.update_payment_value(this.fieldname, value); } };