From ffd4990a70c5e2f10519fb7cd676c6ca8774a7b3 Mon Sep 17 00:00:00 2001 From: Mangesh-Khairnar Date: Thu, 2 May 2019 19:19:03 +0530 Subject: [PATCH 1/2] feat: unlink task from project on task deletion --- erpnext/projects/doctype/task/task.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/erpnext/projects/doctype/task/task.py b/erpnext/projects/doctype/task/task.py index ac71b285dc..6862971402 100755 --- a/erpnext/projects/doctype/task/task.py +++ b/erpnext/projects/doctype/task/task.py @@ -163,6 +163,13 @@ class Task(NestedSet): if check_if_child_exists(self.name): throw(_("Child Task exists for this Task. You can not delete this Task.")) + if self.project: + tasks = (frappe.get_doc('Project', self.project)).tasks + for task in tasks: + if (task.get('task_id') == self.name): + frappe.delete_doc('Project Task', task.name) + + self.update_nsm_model() def update_status(self): From b9dc4687dcdd6fe5d73fc8ddee6c6b87f8917b56 Mon Sep 17 00:00:00 2001 From: Faris Ansari Date: Thu, 2 May 2019 20:14:16 +0530 Subject: [PATCH 2/2] fix: Remove parens --- erpnext/projects/doctype/task/task.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/erpnext/projects/doctype/task/task.py b/erpnext/projects/doctype/task/task.py index 6862971402..84ee715198 100755 --- a/erpnext/projects/doctype/task/task.py +++ b/erpnext/projects/doctype/task/task.py @@ -164,9 +164,9 @@ class Task(NestedSet): throw(_("Child Task exists for this Task. You can not delete this Task.")) if self.project: - tasks = (frappe.get_doc('Project', self.project)).tasks + tasks = frappe.get_doc('Project', self.project).tasks for task in tasks: - if (task.get('task_id') == self.name): + if task.get('task_id') == self.name: frappe.delete_doc('Project Task', task.name)