diff --git a/erpnext/accounts/doctype/purchase_invoice_item/purchase_invoice_item.json b/erpnext/accounts/doctype/purchase_invoice_item/purchase_invoice_item.json index 29173e2c71..1280cc0c1e 100755 --- a/erpnext/accounts/doctype/purchase_invoice_item/purchase_invoice_item.json +++ b/erpnext/accounts/doctype/purchase_invoice_item/purchase_invoice_item.json @@ -40,7 +40,7 @@ { "fieldname": "description", "fieldtype": "Text", - "in_list_view": 1, + "in_list_view": 0, "label": "Description", "oldfieldname": "description", "oldfieldtype": "Text", @@ -452,7 +452,7 @@ ], "idx": 1, "istable": 1, - "modified": "2015-05-27 02:47:16.341373", + "modified": "2015-06-02 14:18:56.294949", "modified_by": "Administrator", "module": "Accounts", "name": "Purchase Invoice Item", diff --git a/erpnext/accounts/doctype/sales_invoice_item/sales_invoice_item.json b/erpnext/accounts/doctype/sales_invoice_item/sales_invoice_item.json index 612a89e8e5..4ace40a672 100644 --- a/erpnext/accounts/doctype/sales_invoice_item/sales_invoice_item.json +++ b/erpnext/accounts/doctype/sales_invoice_item/sales_invoice_item.json @@ -58,7 +58,7 @@ { "fieldname": "description", "fieldtype": "Text", - "in_list_view": 1, + "in_list_view": 0, "label": "Description", "oldfieldname": "description", "oldfieldtype": "Text", @@ -505,7 +505,7 @@ ], "idx": 1, "istable": 1, - "modified": "2015-05-27 02:47:15.645114", + "modified": "2015-06-02 14:18:45.176726", "modified_by": "Administrator", "module": "Accounts", "name": "Sales Invoice Item", diff --git a/erpnext/accounts/report/purchase_register/purchase_register.py b/erpnext/accounts/report/purchase_register/purchase_register.py index a104ced598..6f80029fc9 100644 --- a/erpnext/accounts/report/purchase_register/purchase_register.py +++ b/erpnext/accounts/report/purchase_register/purchase_register.py @@ -12,7 +12,6 @@ def execute(filters=None): invoice_list = get_invoices(filters) columns, expense_accounts, tax_accounts = get_columns(invoice_list) - if not invoice_list: msgprint(_("No record found")) return columns, invoice_list @@ -30,7 +29,8 @@ def execute(filters=None): purchase_receipt = list(set(invoice_po_pr_map.get(inv.name, {}).get("purchase_receipt", []))) project_name = list(set(invoice_po_pr_map.get(inv.name, {}).get("project_name", []))) - row = [inv.name, inv.posting_date, inv.supplier, inv.supplier_name, supplier_details.get(inv.supplier), + row = [inv.name, inv.posting_date, inv.supplier, inv.supplier_name, + supplier_details.get(inv.supplier), inv.credit_to, ", ".join(project_name), inv.bill_no, inv.bill_date, inv.remarks, ", ".join(purchase_order), ", ".join(purchase_receipt)] @@ -54,8 +54,7 @@ def execute(filters=None): # total tax, grand total, outstanding amount & rounded total row += [total_tax, inv.base_grand_total, flt(inv.base_grand_total, 2), inv.outstanding_amount] - data.append(row) - # raise Exception + data.append(row) return columns, data @@ -107,7 +106,7 @@ def get_conditions(filters): def get_invoices(filters): conditions = get_conditions(filters) - return frappe.db.sql("""select name, posting_date, credit_to, supplier, supplier_name + return frappe.db.sql("""select name, posting_date, credit_to, supplier, supplier_name, bill_no, bill_date, remarks, base_net_total, base_grand_total, outstanding_amount from `tabPurchase Invoice` where docstatus = 1 %s order by posting_date desc, name desc""" % conditions, filters, as_dict=1) diff --git a/erpnext/accounts/report/sales_register/sales_register.py b/erpnext/accounts/report/sales_register/sales_register.py index 79a54ae09d..ffb274c32d 100644 --- a/erpnext/accounts/report/sales_register/sales_register.py +++ b/erpnext/accounts/report/sales_register/sales_register.py @@ -30,7 +30,8 @@ def execute(filters=None): delivery_note = list(set(invoice_so_dn_map.get(inv.name, {}).get("delivery_note", []))) row = [inv.name, inv.posting_date, inv.customer, inv.customer_name, - customer_map.get(inv.customer)["customer_group"], customer_map.get(inv.customer)["territory"], + customer_map.get(inv.customer, {}).get("customer_group"), + customer_map.get(inv.customer, {}).get("territory"), inv.debit_to, inv.project_name, inv.remarks, ", ".join(sales_order), ", ".join(delivery_note)] # map income values diff --git a/erpnext/buying/doctype/purchase_order/purchase_order.json b/erpnext/buying/doctype/purchase_order/purchase_order.json index 6eb23709d8..bae6496be7 100644 --- a/erpnext/buying/doctype/purchase_order/purchase_order.json +++ b/erpnext/buying/doctype/purchase_order/purchase_order.json @@ -26,7 +26,7 @@ "reqd": 1 }, { - "description": "Supplier (vendor) name as entered in supplier master", + "description": "", "fieldname": "supplier", "fieldtype": "Link", "in_filter": 1, @@ -873,7 +873,7 @@ "icon": "icon-file-text", "idx": 1, "is_submittable": 1, - "modified": "2015-05-27 02:48:02.452899", + "modified": "2015-06-02 17:15:44.711032", "modified_by": "Administrator", "module": "Buying", "name": "Purchase Order", diff --git a/erpnext/buying/doctype/purchase_order_item/purchase_order_item.json b/erpnext/buying/doctype/purchase_order_item/purchase_order_item.json index 43a0e0b7c4..9f80ba3342 100755 --- a/erpnext/buying/doctype/purchase_order_item/purchase_order_item.json +++ b/erpnext/buying/doctype/purchase_order_item/purchase_order_item.json @@ -75,7 +75,7 @@ { "fieldname": "description", "fieldtype": "Small Text", - "in_list_view": 1, + "in_list_view": 0, "label": "Description", "oldfieldname": "description", "oldfieldtype": "Small Text", @@ -538,7 +538,7 @@ ], "idx": 1, "istable": 1, - "modified": "2015-05-27 02:47:16.553472", + "modified": "2015-06-02 14:19:21.459032", "modified_by": "Administrator", "module": "Buying", "name": "Purchase Order Item", diff --git a/erpnext/buying/doctype/supplier_quotation/supplier_quotation.json b/erpnext/buying/doctype/supplier_quotation/supplier_quotation.json index 20abaad0ba..374258bd92 100644 --- a/erpnext/buying/doctype/supplier_quotation/supplier_quotation.json +++ b/erpnext/buying/doctype/supplier_quotation/supplier_quotation.json @@ -26,7 +26,7 @@ "reqd": 1 }, { - "description": "Supplier (vendor) name as entered in supplier master", + "description": "", "fieldname": "supplier", "fieldtype": "Link", "in_filter": 1, @@ -660,7 +660,7 @@ "icon": "icon-shopping-cart", "idx": 1, "is_submittable": 1, - "modified": "2015-05-27 02:48:02.098540", + "modified": "2015-06-02 17:15:57.283516", "modified_by": "Administrator", "module": "Buying", "name": "Supplier Quotation", diff --git a/erpnext/buying/doctype/supplier_quotation_item/supplier_quotation_item.json b/erpnext/buying/doctype/supplier_quotation_item/supplier_quotation_item.json index ccfade2b28..c591b9652e 100644 --- a/erpnext/buying/doctype/supplier_quotation_item/supplier_quotation_item.json +++ b/erpnext/buying/doctype/supplier_quotation_item/supplier_quotation_item.json @@ -59,7 +59,7 @@ { "fieldname": "description", "fieldtype": "Small Text", - "in_list_view": 1, + "in_list_view": 0, "label": "Description", "oldfieldname": "description", "oldfieldtype": "Small Text", @@ -413,7 +413,7 @@ ], "idx": 1, "istable": 1, - "modified": "2015-05-27 02:47:15.853886", + "modified": "2015-06-02 14:19:33.922968", "modified_by": "Administrator", "module": "Buying", "name": "Supplier Quotation Item", diff --git a/erpnext/crm/doctype/opportunity_item/opportunity_item.json b/erpnext/crm/doctype/opportunity_item/opportunity_item.json index d33fdcaeb2..d809f5b9fd 100644 --- a/erpnext/crm/doctype/opportunity_item/opportunity_item.json +++ b/erpnext/crm/doctype/opportunity_item/opportunity_item.json @@ -85,7 +85,7 @@ { "fieldname": "description", "fieldtype": "Text", - "in_list_view": 1, + "in_list_view": 0, "label": "Description", "oldfieldname": "description", "oldfieldtype": "Text", @@ -134,7 +134,7 @@ ], "idx": 1, "istable": 1, - "modified": "2015-05-14 14:55:18.325286", + "modified": "2015-06-02 14:18:16.622288", "modified_by": "Administrator", "module": "CRM", "name": "Opportunity Item", diff --git a/erpnext/manufacturing/doctype/bom/bom.py b/erpnext/manufacturing/doctype/bom/bom.py index d4fa02c752..f550a8afe4 100644 --- a/erpnext/manufacturing/doctype/bom/bom.py +++ b/erpnext/manufacturing/doctype/bom/bom.py @@ -425,5 +425,5 @@ def validate_bom_no(item, bom_no): if not getattr(frappe.flags, "in_test", False): frappe.throw(_("BOM {0} must be submitted").format(bom_no)) if item and not (bom.item.lower() == item.lower() or \ - bom.item.lower() == frappe.db.get_value("Item", item, "variant_of").lower()): + bom.item.lower() == cstr(frappe.db.get_value("Item", item, "variant_of")).lower()): frappe.throw(_("BOM {0} does not belong to Item {1}").format(bom_no, item)) diff --git a/erpnext/public/js/stock_analytics.js b/erpnext/public/js/stock_analytics.js index 6b3e3f2a98..e07e3d4c5b 100644 --- a/erpnext/public/js/stock_analytics.js +++ b/erpnext/public/js/stock_analytics.js @@ -139,7 +139,7 @@ erpnext.StockAnalytics = erpnext.StockGridReport.extend({ if(sl.voucher_type=="Stock Reconciliation") { var diff = (sl.qty_after_transaction * sl.valuation_rate) - item.closing_qty_value; - wh.fifo_stack.push([sl.qty_after_transaction, sl.valuation_rate, sl.posting_date]); + wh.fifo_stack = [[sl.qty_after_transaction, sl.valuation_rate, sl.posting_date]]; wh.balance_qty = sl.qty_after_transaction; wh.balance_value = sl.valuation_rate * sl.qty_after_transaction; } else { @@ -167,7 +167,6 @@ erpnext.StockAnalytics = erpnext.StockGridReport.extend({ }, update_groups: function() { var me = this; - $.each(this.data, function(i, item) { // update groups if(!item.is_group && me.apply_filter(item, "brand")) { diff --git a/erpnext/selling/doctype/quotation_item/quotation_item.json b/erpnext/selling/doctype/quotation_item/quotation_item.json index 29b7d7cfb3..ec10b59273 100644 --- a/erpnext/selling/doctype/quotation_item/quotation_item.json +++ b/erpnext/selling/doctype/quotation_item/quotation_item.json @@ -55,7 +55,7 @@ { "fieldname": "description", "fieldtype": "Small Text", - "in_list_view": 1, + "in_list_view": 0, "label": "Description", "oldfieldname": "description", "oldfieldtype": "Small Text", @@ -298,12 +298,13 @@ }, { "fieldname": "prevdoc_doctype", - "fieldtype": "Data", + "fieldtype": "Link", "hidden": 1, "label": "Against Doctype", "no_copy": 1, "oldfieldname": "prevdoc_doctype", "oldfieldtype": "Data", + "options": "DocType", "permlevel": 0, "print_hide": 1, "print_width": "150px", @@ -313,11 +314,12 @@ }, { "fieldname": "prevdoc_docname", - "fieldtype": "Data", + "fieldtype": "Dynamic Link", "label": "Against Docname", "no_copy": 1, "oldfieldname": "prevdoc_docname", "oldfieldtype": "Data", + "options": "prevdoc_doctype", "permlevel": 0, "print_hide": 1, "print_width": "150px", @@ -390,7 +392,7 @@ ], "idx": 1, "istable": 1, - "modified": "2015-05-27 02:47:15.474119", + "modified": "2015-06-02 14:18:00.266748", "modified_by": "Administrator", "module": "Selling", "name": "Quotation Item", diff --git a/erpnext/setup/doctype/company/delete_company_transactions.py b/erpnext/setup/doctype/company/delete_company_transactions.py index f27ba86211..87c13754bf 100644 --- a/erpnext/setup/doctype/company/delete_company_transactions.py +++ b/erpnext/setup/doctype/company/delete_company_transactions.py @@ -27,12 +27,7 @@ def delete_for_doctype(doctype, company_name): company_fieldname = meta.get("fields", {"fieldtype": "Link", "options": "Company"})[0].fieldname - if meta.issingle: - single = frappe.get_doc(doctype, doctype) - single.set(company_fieldname, "") - single.flags.ignore_mandatory = True - single.save() - else: + if not meta.issingle: if not meta.istable: # delete children for df in meta.get_table_fields(): diff --git a/erpnext/stock/doctype/delivery_note_item/delivery_note_item.json b/erpnext/stock/doctype/delivery_note_item/delivery_note_item.json index 956f57698a..4bb326bd10 100644 --- a/erpnext/stock/doctype/delivery_note_item/delivery_note_item.json +++ b/erpnext/stock/doctype/delivery_note_item/delivery_note_item.json @@ -65,7 +65,7 @@ { "fieldname": "description", "fieldtype": "Small Text", - "in_list_view": 1, + "in_list_view": 0, "label": "Description", "oldfieldname": "description", "oldfieldtype": "Small Text", @@ -523,7 +523,7 @@ ], "idx": 1, "istable": 1, - "modified": "2015-05-27 02:47:16.946934", + "modified": "2015-06-02 14:18:34.512236", "modified_by": "Administrator", "module": "Stock", "name": "Delivery Note Item", diff --git a/erpnext/stock/doctype/material_request_item/material_request_item.json b/erpnext/stock/doctype/material_request_item/material_request_item.json index 3b659e3ac2..c4bebebe64 100644 --- a/erpnext/stock/doctype/material_request_item/material_request_item.json +++ b/erpnext/stock/doctype/material_request_item/material_request_item.json @@ -48,7 +48,7 @@ { "fieldname": "description", "fieldtype": "Text", - "in_list_view": 1, + "in_list_view": 0, "label": "Description", "oldfieldname": "description", "oldfieldtype": "Text", @@ -264,7 +264,7 @@ ], "idx": 1, "istable": 1, - "modified": "2015-02-19 01:07:00.695393", + "modified": "2015-06-02 14:19:45.611733", "modified_by": "Administrator", "module": "Stock", "name": "Material Request Item", diff --git a/erpnext/stock/doctype/purchase_receipt_item/purchase_receipt_item.json b/erpnext/stock/doctype/purchase_receipt_item/purchase_receipt_item.json index 4cf4107d93..c48aa2c269 100755 --- a/erpnext/stock/doctype/purchase_receipt_item/purchase_receipt_item.json +++ b/erpnext/stock/doctype/purchase_receipt_item/purchase_receipt_item.json @@ -49,7 +49,7 @@ { "fieldname": "description", "fieldtype": "Text", - "in_list_view": 1, + "in_list_view": 0, "label": "Description", "oldfieldname": "description", "oldfieldtype": "Text", @@ -642,7 +642,7 @@ ], "idx": 1, "istable": 1, - "modified": "2015-05-27 02:47:16.086625", + "modified": "2015-06-02 14:19:13.528248", "modified_by": "Administrator", "module": "Stock", "name": "Purchase Receipt Item", diff --git a/erpnext/templates/form_grid/includes/visible_cols.html b/erpnext/templates/form_grid/includes/visible_cols.html index e9be40ceb2..285c1254b6 100644 --- a/erpnext/templates/form_grid/includes/visible_cols.html +++ b/erpnext/templates/form_grid/includes/visible_cols.html @@ -1,6 +1,6 @@ {% $.each(visible_columns || [], function(i, df) { %} {% var val = doc.get_formatted(df.fieldname); - if((df.fieldname !== "description") && val) { %} + if(val) { %}