diff --git a/erpnext/accounts/doctype/budget/budget.json b/erpnext/accounts/doctype/budget/budget.json index 49463042be..d9464a5215 100644 --- a/erpnext/accounts/doctype/budget/budget.json +++ b/erpnext/accounts/doctype/budget/budget.json @@ -8,6 +8,7 @@ "docstatus": 0, "doctype": "DocType", "document_type": "", + "editable_grid": 1, "fields": [ { "allow_on_submit": 0, @@ -65,24 +66,24 @@ "allow_on_submit": 0, "bold": 0, "collapsible": 0, - "fieldname": "monthly_distribution", + "fieldname": "company", "fieldtype": "Link", "hidden": 0, "ignore_user_permissions": 0, "ignore_xss_filter": 0, "in_filter": 0, "in_list_view": 0, - "label": "Monthly Distribution", + "label": "Company", "length": 0, "no_copy": 0, - "options": "Monthly Distribution", + "options": "Company", "permlevel": 0, "precision": "", "print_hide": 0, "print_hide_if_no_value": 0, "read_only": 0, "report_hide": 0, - "reqd": 0, + "reqd": 1, "search_index": 0, "set_only_once": 0, "unique": 0 @@ -170,24 +171,25 @@ "allow_on_submit": 0, "bold": 0, "collapsible": 0, - "fieldname": "company", + "depends_on": "eval:in_list([\"Stop\", \"Warn\"], doc.action_if_accumulated_monthly_budget_exceeded)", + "fieldname": "monthly_distribution", "fieldtype": "Link", "hidden": 0, "ignore_user_permissions": 0, "ignore_xss_filter": 0, "in_filter": 0, "in_list_view": 0, - "label": "Company", + "label": "Monthly Distribution", "length": 0, "no_copy": 0, - "options": "Company", + "options": "Monthly Distribution", "permlevel": 0, "precision": "", "print_hide": 0, "print_hide_if_no_value": 0, "read_only": 0, "report_hide": 0, - "reqd": 1, + "reqd": 0, "search_index": 0, "set_only_once": 0, "unique": 0 @@ -271,13 +273,14 @@ "hide_heading": 0, "hide_toolbar": 0, "idx": 0, + "image_view": 0, "in_create": 0, "in_dialog": 0, "is_submittable": 1, "issingle": 0, "istable": 0, "max_attachments": 0, - "modified": "2016-05-16 15:00:40.233685", + "modified": "2016-08-18 14:46:02.653081", "modified_by": "Administrator", "module": "Accounts", "name": "Budget", diff --git a/erpnext/accounts/doctype/budget/budget.py b/erpnext/accounts/doctype/budget/budget.py index 7b6cde7df1..529401c84b 100644 --- a/erpnext/accounts/doctype/budget/budget.py +++ b/erpnext/accounts/doctype/budget/budget.py @@ -73,13 +73,14 @@ def validate_expense_against_budget(args): args.posting_date, args.fiscal_year, budget.budget_amount) args["month_end_date"] = get_last_day(args.posting_date) - + compare_expense_with_budget(args, budget.cost_center, budget_amount, _("Accumulated Monthly"), monthly_action) - elif yearly_action in ["Stop", "Warn"]: - compare_expense_with_budget(args, budget.cost_center, - flt(budget.budget_amount), _("Annual"), yearly_action) + if yearly_action in ("Stop", "Warn") and monthly_action != "Stop" \ + and yearly_action != monthly_action: + compare_expense_with_budget(args, budget.cost_center, + flt(budget.budget_amount), _("Annual"), yearly_action) def compare_expense_with_budget(args, cost_center, budget_amount, action_for, action): actual_expense = get_actual_expense(args, cost_center)