Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Don't add to deductions if amount is 0

Browse Source 
- misc: better docstring
This commit is contained in:
marination 2023-03-07 12:12:45 +05:30
parent ee12313dbb
commit f02fc8acf0
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
erpnext/accounts/doctype/payment_entry/payment_entry.py
View File

@ -1941,7 +1941,7 @@ def apply_early_payment_discount(paid_amount, received_amount, doc):
def set_early_payment_discount_loss(pe, doc, valid_discounts, discount_amount): def set_early_payment_discount_loss(pe, doc, valid_discounts, discount_amount):
"""Split early bird discount deductions into Income Loss & Tax Loss.""" """Split early payment discount into Income Loss & Tax Loss."""
if not (discount_amount and valid_discounts): if not (discount_amount and valid_discounts):
return discount_amount return discount_amount
@ -2013,12 +2013,16 @@ def add_tax_discount_loss(pe, doc, total_discount_percenatage) -> float:
for account, loss in tax_discount_loss.items(): for account, loss in tax_discount_loss.items():
total_tax_loss += loss total_tax_loss += loss
amount = flt(loss * doc.get("conversion_rate", 1), precision)
if amount == 0.0:
continue
pe.append( pe.append(
"deductions", "deductions",
{ {
"account": account, "account": account,
"cost_center": pe.cost_center or frappe.get_cached_value("Company", pe.company, "cost_center"), "cost_center": pe.cost_center or frappe.get_cached_value("Company", pe.company, "cost_center"),
"amount": flt(loss * doc.get("conversion_rate", 1), precision), "amount": amount,
}, },
) )