Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(plaid): query to check if bank account exists

Browse Source
This commit is contained in:
Saqib 2021-09-20 15:33:29 +05:30 committed by GitHub
parent f07ff92a35
commit ef66beec51
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
erpnext/erpnext_integrations/doctype/plaid_settings/plaid_settings.py
View File

@ -85,10 +85,8 @@ def add_bank_accounts(response, bank, company):
if not acc_subtype: if not acc_subtype:
add_account_subtype(account["subtype"]) add_account_subtype(account["subtype"])
existing_bank_account = frappe.db.exists("Bank Account", { bank_account_name = "{} - {}".format(account["name"], bank["bank_name"])
'account_name': account["name"], existing_bank_account = frappe.db.exists("Bank Account", bank_account_name)
'bank': bank["bank_name"]
})
if not existing_bank_account: if not existing_bank_account:
try: try:
@ -197,6 +195,7 @@ def get_transactions(bank, bank_account=None, start_date=None, end_date=None):
plaid = PlaidConnector(access_token) plaid = PlaidConnector(access_token)
transactions = []
try: try:
transactions = plaid.get_transactions(start_date=start_date, end_date=end_date, account_id=account_id) transactions = plaid.get_transactions(start_date=start_date, end_date=end_date, account_id=account_id)
except ItemError as e: except ItemError as e:
@ -205,7 +204,7 @@ def get_transactions(bank, bank_account=None, start_date=None, end_date=None):
msg += _("Please refresh or reset the Plaid linking of the Bank {}.").format(bank) + " " msg += _("Please refresh or reset the Plaid linking of the Bank {}.").format(bank) + " "
frappe.log_error(msg, title=_("Plaid Link Refresh Required")) frappe.log_error(msg, title=_("Plaid Link Refresh Required"))
return transactions or [] return transactions
def new_bank_transaction(transaction): def new_bank_transaction(transaction):