Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf: use unbuffered_cursor for stock_ageing report (#39399)

Browse Source 
perf: use unbuffered_cursor for stock stock_ageing report

Unbuffered cursor lets us load one row at a time in memory from mysql instead of lowing all at once.

This makes it possible to run the report for large number of SLEs.
This commit is contained in:
Ankush Menat 2024-01-16 11:43:35 +05:30 committed by GitHub
parent 82026f780d
commit ed927f102e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
erpnext/stock/report/stock_ageing/stock_ageing.py
View File

@ -233,28 +233,30 @@ class FIFOSlots:
""" """
stock_ledger_entries = self.sle stock_ledger_entries = self.sle
if stock_ledger_entries is None:
stock_ledger_entries = self.__get_stock_ledger_entries()
for d in stock_ledger_entries: with frappe.db.unbuffered_cursor():
key, fifo_queue, transferred_item_key = self.__init_key_stores(d) if stock_ledger_entries is None:
stock_ledger_entries = self.__get_stock_ledger_entries()
if d.voucher_type == "Stock Reconciliation": for d in stock_ledger_entries:
# get difference in qty shift as actual qty key, fifo_queue, transferred_item_key = self.__init_key_stores(d)
prev_balance_qty = self.item_details[key].get("qty_after_transaction", 0)
d.actual_qty = flt(d.qty_after_transaction) - flt(prev_balance_qty)
serial_nos = get_serial_nos(d.serial_no) if d.serial_no else [] if d.voucher_type == "Stock Reconciliation":
# get difference in qty shift as actual qty
prev_balance_qty = self.item_details[key].get("qty_after_transaction", 0)
d.actual_qty = flt(d.qty_after_transaction) - flt(prev_balance_qty)
if d.actual_qty > 0: serial_nos = get_serial_nos(d.serial_no) if d.serial_no else []
self.__compute_incoming_stock(d, fifo_queue, transferred_item_key, serial_nos)
else:
self.__compute_outgoing_stock(d, fifo_queue, transferred_item_key, serial_nos)
self.__update_balances(d, key) if d.actual_qty > 0:
self.__compute_incoming_stock(d, fifo_queue, transferred_item_key, serial_nos)
else:
self.__compute_outgoing_stock(d, fifo_queue, transferred_item_key, serial_nos)
# Note that stock_ledger_entries is an iterator, you can not reuse it like a list self.__update_balances(d, key)
del stock_ledger_entries
# Note that stock_ledger_entries is an iterator, you can not reuse it like a list
del stock_ledger_entries
if not self.filters.get("show_warehouse_wise_stock"): if not self.filters.get("show_warehouse_wise_stock"):
# (Item 1, WH 1), (Item 1, WH 2) => (Item 1) # (Item 1, WH 1), (Item 1, WH 2) => (Item 1)