Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Iterate over list instead of map's output and formatting

Browse Source
This commit is contained in:
marination 2023-01-31 17:13:05 +05:30
parent fa9b327501
commit ece6358e60
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
erpnext/selling/doctype/quotation/quotation.py
View File

@ -102,7 +102,7 @@ class Quotation(SellingController):
def validate_alternative_items(self):
items_with_alternatives = filter(lambda item: not item.is_alternative, self.get("items"))
items_with_alternatives = map(lambda item: item.item_code, items_with_alternatives)
items_with_alternatives = list(map(lambda item: item.item_code, items_with_alternatives))
alternative_items = filter(lambda item: item.is_alternative, self.get("items"))
for row in alternative_items:
@ -114,7 +114,6 @@ class Quotation(SellingController):
title=_("Invalid Item"),
)
def update_opportunity(self, status):
for opportunity in set(d.prevdoc_docname for d in self.get("items")):
if opportunity:
@ -227,7 +226,8 @@ def _make_sales_order(source_name, target_doc=None, ignore_permissions=False):
)
alternative_map = {
x.get("original_item") : x.get("alternative_item") for x in frappe.flags.get("args", {}).get("mapping", [])
x.get("original_item"): x.get("alternative_item")
for x in frappe.flags.get("args", {}).get("mapping", [])
}
def set_missing_values(source, target):
@ -275,7 +275,6 @@ def _make_sales_order(source_name, target_doc=None, ignore_permissions=False):
is_selected = alternative_map.get(item.item_code) is None
return is_selected and has_qty
doclist = get_mapped_doc(
"Quotation",
source_name,