[fix] [setup_wizard] fiscal year fix for setup wizard

accounts/doctype/fiscal_year/fiscal_year.js

@@ -1,18 +1,39 @@
 // Copyright (c) 2013, Web Notes Technologies Pvt. Ltd. and Contributors
 // License: GNU General Public License v3. See license.txt
 
-cur_frm.cscript.refresh = function(doc, dt, dn) {
+$.extend(cur_frm.cscript, {
-	cur_frm.toggle_enable('year_start_date', doc.__islocal)
+	refresh: function (doc, dt, dn) {
+		var me = this;
+		this.frm.toggle_enable('year_start_date', doc.__islocal)
+		this.frm.toggle_enable('year_end_date', doc.__islocal)
 	
-	if (!doc.__islocal && (doc.name != sys_defaults.fiscal_year)) {
+		if (!doc.__islocal && (doc.name != sys_defaults.fiscal_year)) {
-		cur_frm.add_custom_button(wn._("Set as Default"), cur_frm.cscript.set_as_default);
+			this.frm.add_custom_button(wn._("Set as Default"), this.frm.cscript.set_as_default);
-		cur_frm.set_intro(wn._("To set this Fiscal Year as Deafult, click on 'Set as Default'"));
+			this.frm.set_intro(wn._("To set this Fiscal Year as Default, click on 'Set as Default'"));
-	} else cur_frm.set_intro("");
+		} else this.frm.set_intro("");
-}
 
-cur_frm.cscript.set_as_default = function() {
+		if (doc.__islocal && this.frm.doc.year_start_date)
-	return wn.call({
+			this.frm.script_manager.trigger("year_start_date", dt, dn);
-		doc: cur_frm.doc,
+	},
-		method: "set_as_default"
+	set_as_default: function() {
-	});
+		return wn.call({
-}
+			doc: cur_frm.doc,
+			method: "set_as_default"
+		});
+	},
+	year_start_date: function(doc, dt, dn) {
+		var me = this;
+
+		wn.call({
+			method: 'controllers.trends.get_period_date_ranges',
+			args: {
+				period: "Yearly",
+				year_start_date: this.frm.doc.year_start_date
+			},
+			callback: function(r) {
+				if (!r.exc)
+					me.frm.set_value("year_end_date", r.message[0][1])
+			}
+		});
+	},
+});

accounts/doctype/fiscal_year/fiscal_year.py

@@ -17,4 +17,24 @@ class DocType:
 		webnotes.clear_cache()
 		
 		msgprint(self.doc.name + _(""" is now the default Fiscal Year. \
-			Please refresh your browser for the change to take effect."""))
+			Please refresh your browser for the change to take effect."""))
+
+	def on_update(self):
+		from webnotes.utils import getdate
+
+		# validate year start date and year end date
+		if getdate(self.doc.year_start_date) > getdate(self.doc.year_end_date):
+			webnotes.throw(_("Year Start Date should not be greater than Year End Date"))
+
+		if (getdate(self.doc.year_end_date) - getdate(self.doc.year_start_date)).days > 366:
+			webnotes.throw([getdate(self.doc.year_end_date), getdate(self.doc.year_start_date)])
+			webnotes.throw((getdate(self.doc.year_end_date) - getdate(self.doc.year_start_date)).days)
+			webnotes.throw(_("Year Start Date and Year End Date are not within Fiscal Year."))
+
+		year_start_end_dates = webnotes.conn.sql("""select name, year_start_date, year_end_date 
+			from `tabFiscal Year` where name!=%s""", (self.doc.name))
+
+		for fiscal_year, ysd, yed in year_start_end_dates:
+			if getdate(self.doc.year_start_date) == ysd and getdate(self.doc.year_end_date) == yed:
+				webnotes.throw(_("Year Start Date and Year End Date are already \
+					set in Fiscal Year: ") + fiscal_year)

accounts/doctype/fiscal_year/fiscal_year.txt

@@ -2,7 +2,7 @@
  {
   "creation": "2013-01-22 16:50:25", 
   "docstatus": 0, 
-  "modified": "2013-07-23 11:59:11", 
+  "modified": "2013-11-25 11:40:02", 
   "modified_by": "Administrator", 
   "owner": "Administrator"
  }, 
@@ -56,6 +56,14 @@
   "oldfieldtype": "Date", 
   "reqd": 1
  }, 
+ {
+  "doctype": "DocField", 
+  "fieldname": "year_end_date", 
+  "fieldtype": "Date", 
+  "label": "Year End Date", 
+  "no_copy": 1, 
+  "reqd": 1
+ }, 
  {
   "default": "No", 
   "description": "Entries are not allowed against this Fiscal Year if the year is closed.", 

accounts/doctype/fiscal_year/test_fiscal_year.py

@@ -7,26 +7,31 @@ test_records = [
 	[{
 		"doctype": "Fiscal Year", 
 		"year": "_Test Fiscal Year 2012", 
-		"year_start_date": "2012-01-01"
+		"year_start_date": "2012-01-01",
+		"year_end_date": "2012-12-31"
 	}],
 	[{
 		"doctype": "Fiscal Year", 
 		"year": "_Test Fiscal Year 2013", 
-		"year_start_date": "2013-01-01"
+		"year_start_date": "2013-01-01",
+		"year_end_date": "2013-12-31"
 	}],
 	[{
 		"doctype": "Fiscal Year",
 		"year": "_Test Fiscal Year 2014", 
-		"year_start_date": "2014-01-01"
+		"year_start_date": "2014-01-01",
+		"year_end_date": "2014-12-31"
 	}],
 	[{
 		"doctype": "Fiscal Year",
 		"year": "_Test Fiscal Year 2015", 
-		"year_start_date": "2015-01-01"
+		"year_start_date": "2015-01-01",
+		"year_end_date": "2015-12-31"
 	}],
 	[{
 		"doctype": "Fiscal Year",
 		"year": "_Test Fiscal Year 2016", 
-		"year_start_date": "2016-01-01"
+		"year_start_date": "2016-01-01",
+		"year_end_date": "2016-12-31"
 	}],
 ]

accounts/doctype/mis_control/mis_control.py

@@ -254,7 +254,6 @@ class DocType:
 			for i in range(4):
 				pn = 'Q'+str(i+1)
 				self.period_list.append(pn)
-			
 				self.period_start_date[pn] = get_first_day(ysd,0,i*3)
 				self.period_end_date[pn] = get_last_day(get_first_day(ysd,0,((i+1)*3)-1))	
 

accounts/utils.py

@@ -24,14 +24,10 @@ def get_fiscal_years(date=None, fiscal_year=None, label="Date", verbose=1):
 	if fiscal_year:
 		cond = "name = '%s'" % fiscal_year
 	else:
-		cond = "'%s' >= year_start_date and '%s' < adddate(year_start_date, interval 1 year)" % \
+		cond = "'%s' >= year_start_date and '%s' <= year_end_date" % \
 			(date, date)
-	fy = webnotes.conn.sql("""select name, year_start_date, 
+	fy = webnotes.conn.sql("""select name, year_start_date, year_end_date
-		subdate(adddate(year_start_date, interval 1 year), interval 1 day) 
+		from `tabFiscal Year` where %s order by year_start_date desc""" % cond)
-			as year_end_date
-		from `tabFiscal Year`
-		where %s
-		order by year_start_date desc""" % cond)
 	
 	if not fy:
 		error_msg = """%s %s not in any Fiscal Year""" % (label, formatdate(date))

controllers/trends.py

@@ -151,24 +151,32 @@ def get_period_wise_query(bet_dates, trans_date, query_details):
 				""" % {"trans_date": trans_date, "sd": bet_dates[0],"ed": bet_dates[1]}
 	return query_details
 
-def get_period_date_ranges(period, fiscal_year):
+@webnotes.whitelist(allow_guest=True)
-  from dateutil.relativedelta import relativedelta
+def get_period_date_ranges(period, fiscal_year=None, year_start_date=None):
+	from dateutil.relativedelta import relativedelta
 
-  year_start_date = webnotes.conn.get_value("Fiscal Year", fiscal_year, "year_start_date")
+	if not year_start_date:
-  increment = {
+		year_start_date, year_end_date = webnotes.conn.get_value("Fiscal Year", 
-    "Monthly": 1,
+			fiscal_year, ["year_start_date", "year_end_date"])
-    "Quarterly": 3,
-    "Half-Yearly": 6,
-    "Yearly": 12
-  }.get(period)
 
-  period_date_ranges = []
+	increment = {
-  for i in xrange(1, 13, increment): 
+		"Monthly": 1,
-    period_end_date = year_start_date + relativedelta(months=increment, days=-1)
+		"Quarterly": 3,
-    period_date_ranges.append([year_start_date, period_end_date])
+		"Half-Yearly": 6,
-    year_start_date = period_end_date + relativedelta(days=1)
+		"Yearly": 12
+	}.get(period)
 
-  return period_date_ranges
+	period_date_ranges = []
+	for i in xrange(1, 13, increment):
+		period_end_date = getdate(year_start_date) + relativedelta(months=increment, days=-1)
+		if period_end_date > getdate(year_end_date):
+			period_end_date = year_end_date
+		period_date_ranges.append([year_start_date, period_end_date])
+		year_start_date = period_end_date + relativedelta(days=1)
+		if period_end_date == year_end_date:
+			break
+
+	return period_date_ranges
 
 def get_period_month_ranges(period, fiscal_year):
 	from dateutil.relativedelta import relativedelta

hr/doctype/holiday_list/holiday_list.py

@@ -45,11 +45,8 @@ class DocType:
 			raise Exception
 
 	def get_fy_start_end_dates(self):
-		return webnotes.conn.sql("""select year_start_date, 
+		return webnotes.conn.sql("""select year_start_date, year_end_date
-			subdate(adddate(year_start_date, interval 1 year), interval 1 day) 
+			from `tabFiscal Year` where name=%s""", (self.doc.fiscal_year,))[0]
-				as year_end_date
-			from `tabFiscal Year`
-			where name=%s""", (self.doc.fiscal_year,))[0]
 
 	def get_weekly_off_date_list(self, year_start_date, year_end_date):
 		from webnotes.utils import getdate

hr/doctype/salary_manager/salary_manager.py

@@ -59,7 +59,6 @@ class DocType:
 		return cond
 		
 		
-		
 	def check_mandatory(self):
 		for f in ['company', 'month', 'fiscal_year']:
 			if not self.doc.fields[f]:
@@ -84,8 +83,6 @@ class DocType:
 				'month_days': month_days
 			}
 
-		
-		
 	def create_sal_slip(self):
 		"""
 			Creates salary slip for selected employees if already not created

patches/1311/p04_update_year_end_date_of_fiscal_year.py

@@ -0,0 +1,11 @@
+# Copyright (c) 2013, Web Notes Technologies Pvt. Ltd. and Contributors
+# License: GNU General Public License v3. See license.txt
+
+from __future__ import unicode_literals
+import webnotes
+
+def execute():
+	webnotes.reload_doc("accounts", "doctype", "fiscal_year")
+
+	webnotes.conn.sql("""update `tabFiscal Year` set year_end_date = 
+		subdate(adddate(year_start_date, interval 1 year), interval 1 day)""")

patches/patch_list.py

@@ -250,4 +250,5 @@ patch_list = [
 	"execute:webnotes.reload_doc('website', 'doctype', 'website_sitemap') #2013-11-20",
 	"execute:webnotes.bean('Style Settings').save() #2013-11-20",
     "execute:webnotes.get_module('website.doctype.website_sitemap_config.website_sitemap_config').rebuild_website_sitemap_config()",
+    "patches.1311.p04_update_year_end_date_of_fiscal_year",
 ]

setup/doctype/global_defaults/global_defaults.py

@@ -35,15 +35,15 @@ class DocType:
 			webnotes.conn.set_default(key, self.doc.fields.get(keydict[key], ''))
 			
 		# update year start date and year end date from fiscal_year
-		ysd = webnotes.conn.sql("""select year_start_date from `tabFiscal Year` 
+		year_start_end_date = webnotes.conn.sql("""select year_start_date, year_end_date 
-			where name=%s""", self.doc.current_fiscal_year)
+			from `tabFiscal Year` where name=%s""", self.doc.current_fiscal_year)
-			
+
-		ysd = ysd and ysd[0][0] or ''
+		ysd = year_start_end_date[0][0] or ''
-		from webnotes.utils import get_first_day, get_last_day
+		yed = year_start_end_date[0][1] or ''
-		if ysd:
+
+		if ysd and yed:
 			webnotes.conn.set_default('year_start_date', ysd.strftime('%Y-%m-%d'))
-			webnotes.conn.set_default('year_end_date', \
+			webnotes.conn.set_default('year_end_date', yed.strftime('%Y-%m-%d'))
-				get_last_day(get_first_day(ysd,0,11)).strftime('%Y-%m-%d'))
 		
 		# enable default currency
 		if self.doc.default_currency:

setup/page/setup_wizard/setup_wizard.js

@@ -88,9 +88,10 @@ wn.pages['setup-wizard'].onload = function(wrapper) {
 						placeholder: 'e.g. "My Company LLC"'},
 					{fieldname:'company_abbr', label: wn._('Company Abbreviation'), fieldtype:'Data',
 						placeholder:'e.g. "MC"',reqd:1},
-					{fieldname:'fy_start', label:'Financial Year Start Date', fieldtype:'Select',
+					{fieldname:'fy_start_date', label:'Financial Year Start Date', fieldtype:'Date',
-						description:'Your financial year begins on', reqd:1,
+						description:'Your financial year begins on', reqd:1},
-						options: ['', '1st Jan', '1st Apr', '1st Jul', '1st Oct'] },
+					{fieldname:'fy_end_date', label:'Financial Year End Date', fieldtype:'Date',
+						description:'Your financial year ends on', reqd:1},
 					{fieldname:'company_tagline', label: wn._('What does it do?'), fieldtype:'Data',
 						placeholder:'e.g. "Build tools for builders"', reqd:1},
 				],

setup/page/setup_wizard/setup_wizard.py

@@ -72,18 +72,12 @@ def update_profile_name(args):
 	add_all_roles_to(args.get("name"))
 	
 def create_fiscal_year_and_company(args):
-	curr_fiscal_year, fy_start_date, fy_abbr = get_fy_details(args.get('fy_start'), True)
+	curr_fiscal_year = get_fy_details(args.get('fy_start_date'), args.get('fy_end_date'))
 	webnotes.bean([{
 		"doctype":"Fiscal Year",
 		'year': curr_fiscal_year,
-		'year_start_date': fy_start_date
+		'year_start_date': args.get('fy_start_date'),
-	}]).insert()
+		'year_end_date': args.get('fy_end_date'),
-
-	curr_fiscal_year, fy_start_date, fy_abbr = get_fy_details(args.get('fy_start'))
-	webnotes.bean([{
-		"doctype":"Fiscal Year",
-		'year': curr_fiscal_year,
-		'year_start_date': fy_start_date,
 	}]).insert()
 
 	
@@ -196,25 +190,13 @@ def create_email_digest():
 		
 			edigest.insert()
 		
-def get_fy_details(fy_start, last_year=False):
+def get_fy_details(fy_start_date, fy_end_date):
-	st = {'1st Jan':'01-01','1st Apr':'04-01','1st Jul':'07-01', '1st Oct': '10-01'}
+	start_year = getdate(fy_start_date).year
-	if cint(getdate(nowdate()).month) < cint((st[fy_start].split('-'))[0]):
+	if start_year == getdate(fy_end_date).year:
-		curr_year = getdate(nowdate()).year - 1
+		fy = cstr(start_year)
 	else:
-		curr_year = getdate(nowdate()).year
+		fy = cstr(start_year) + '-' + cstr(start_year + 1)
-	
+	return fy
-	if last_year:
-		curr_year = curr_year - 1
-	
-	stdt = cstr(curr_year)+'-'+cstr(st[fy_start])
-
-	if(fy_start == '1st Jan'):
-		fy = cstr(curr_year)
-		abbr = cstr(fy)[-2:]
-	else:
-		fy = cstr(curr_year) + '-' + cstr(curr_year+1)
-		abbr = cstr(curr_year)[-2:] + '-' + cstr(curr_year+1)[-2:]
-	return fy, stdt, abbr
 
 def create_taxes(args):
 	for i in xrange(1,6):

startup/report_data_map.py

@@ -12,8 +12,7 @@ data_map = {
 		"conditions": ["docstatus < 2"]
 	},
 	"Fiscal Year": {
-		"columns": ["name", "year_start_date", 
+		"columns": ["name", "year_start_date", "year_end_date"],
-			"adddate(adddate(year_start_date, interval 1 year), interval -1 day) as year_end_date"],
 		"conditions": ["docstatus < 2"],
 	},
 

utilities/demo/demo_docs/Fiscal_Year.csv

@@ -13,11 +13,11 @@ You can only upload upto 5000 records in one go. (may be less in some cases),,,,
 ,,,,
 DocType:,Fiscal Year,,,
 Column Labels:,ID,Year Name,Year Start Date,Year Closed
-Column Name:,name,year,year_start_date,is_fiscal_year_closed
+Column Name:,name,year,year_start_date,year_end_date,is_fiscal_year_closed
 Mandatory:,Yes,Yes,Yes,No
 Type:,Data (text),Data,Date,Select
 Info:,,,,"One of: No, Yes"
 Start entering data below this line,,,,
-,,2009,01-Jan-2009,No
+,,2009,01-01-2009,31-12-2009,No
-,,2010,01-Jan-2010,No
+,,2010,01-01-2010,31-12-2010,No
-,,2011,01-Jan-2011,No
+,,2011,01-01-2011,31-12-2011,No