Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: Remove instances of bank_party_mapper and use new_doc

Browse Source
This commit is contained in:
marination 2023-06-07 11:54:16 +05:30
parent 75387bbaef
commit eb1db5eaa3
1 changed files with 20 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
erpnext/accounts/doctype/bank_transaction/test_auto_match_party.py
View File

@ -66,7 +66,6 @@ class TestAutoMatchParty(FrappeTestCase):
) )
self.assertEqual(doc.party_type, "Supplier") self.assertEqual(doc.party_type, "Supplier")
self.assertEqual(doc.party, "Microsoft") self.assertEqual(doc.party, "Microsoft")
self.assertFalse(doc.bank_party_mapper)
def test_skip_match_if_multiple_close_results(self): def test_skip_match_if_multiple_close_results(self):
create_supplier_for_match(supplier_name="Adithya Medical & General Stores") create_supplier_for_match(supplier_name="Adithya Medical & General Stores")
@ -82,7 +81,6 @@ class TestAutoMatchParty(FrappeTestCase):
# Mapping is skipped as both Supplier names have the same match score # Mapping is skipped as both Supplier names have the same match score
self.assertEqual(doc.party_type, None) self.assertEqual(doc.party_type, None)
self.assertEqual(doc.party, None) self.assertEqual(doc.party, None)
self.assertFalse(doc.bank_party_mapper)
def create_supplier_for_match(supplier_name="John Doe & Co.", iban=None, account_no=None): def create_supplier_for_match(supplier_name="John Doe & Co.", iban=None, account_no=None):
@ -99,35 +97,26 @@ def create_supplier_for_match(supplier_name="John Doe & Co.", iban=None, account
return return
# Create Supplier and Bank Account for the same # Create Supplier and Bank Account for the same
supplier = frappe.get_doc( supplier = frappe.new_doc("Supplier")
{ supplier.supplier_name = supplier_name
"doctype": "Supplier", supplier.supplier_group = "Services"
"supplier_name": supplier_name, supplier.supplier_type = "Company"
"supplier_group": "Services", supplier.insert()
"supplier_type": "Company",
}
).insert()
if not frappe.db.exists("Bank", "TestBank"): if not frappe.db.exists("Bank", "TestBank"):
frappe.get_doc( bank = frappe.new_doc("Bank")
{ bank.bank_name = "TestBank"
"doctype": "Bank", bank.insert(ignore_if_duplicate=True)
"bank_name": "TestBank",
}
).insert(ignore_if_duplicate=True)
if not frappe.db.exists("Bank Account", supplier.name + " - " + "TestBank"): if not frappe.db.exists("Bank Account", supplier.name + " - " + "TestBank"):
frappe.get_doc( bank_account = frappe.new_doc("Bank Account")
{ bank_account.account_name = supplier.name
"doctype": "Bank Account", bank_account.bank = "TestBank"
"account_name": supplier.name, bank_account.iban = iban
"bank": "TestBank", bank_account.bank_account_no = account_no
"iban": iban, bank_account.party_type = "Supplier"
"bank_account_no": account_no, bank_account.party = supplier.name
"party_type": "Supplier", bank_account.insert()
"party": supplier.name,
}
).insert()
def create_bank_transaction( def create_bank_transaction(
@ -139,7 +128,8 @@ def create_bank_transaction(
account_no=None, account_no=None,
iban=None, iban=None,
): ):
doc = frappe.get_doc( doc = frappe.new_doc("Bank Transaction")
doc.update(
{ {
"doctype": "Bank Transaction", "doctype": "Bank Transaction",
"description": description or "1512567 BG/000002918 OPSKATTUZWXXX AT776000000098709837 Herr G", "description": description or "1512567 BG/000002918 OPSKATTUZWXXX AT776000000098709837 Herr G",
@ -153,7 +143,8 @@ def create_bank_transaction(
"bank_party_account_number": account_no, "bank_party_account_number": account_no,
"bank_party_iban": iban, "bank_party_iban": iban,
} }
).insert() )
doc.insert()
doc.submit() doc.submit()
doc.reload() doc.reload()