From ea810509d3dae6093904cc9fa410908927f778be Mon Sep 17 00:00:00 2001 From: Pratik Vyas Date: Wed, 18 Sep 2013 18:35:47 +0530 Subject: [PATCH] refactor newsletter for naming_series global --- support/doctype/newsletter/newsletter.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/support/doctype/newsletter/newsletter.py b/support/doctype/newsletter/newsletter.py index b201cc5586..9a27d839f8 100644 --- a/support/doctype/newsletter/newsletter.py +++ b/support/doctype/newsletter/newsletter.py @@ -105,7 +105,6 @@ def get_lead_options(): } -lead_naming_series = None def create_lead(email_id): """create a lead if it does not exist""" from email.utils import parseaddr @@ -119,7 +118,7 @@ def create_lead(email_id): "email_id": email_id, "lead_name": real_name or email_id, "status": "Contacted", - "naming_series": lead_naming_series or get_lead_naming_series(), + "naming_series": get_lead_naming_series(), "company": webnotes.conn.get_default("company"), "source": "Email" }) @@ -127,7 +126,7 @@ def create_lead(email_id): def get_lead_naming_series(): """gets lead's default naming series""" - global lead_naming_series + lead_naming_series = None naming_series_field = webnotes.get_doctype("Lead").get_field("naming_series") if naming_series_field.default: lead_naming_series = naming_series_field.default