Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Employee Benefit Application - fix (#14837)

Browse Source
This commit is contained in:
Ranjith Kurungadam 2018-07-09 14:01:18 +05:30 committed by Nabin Hait
parent e4a53f961a
commit ea089d67ce
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
erpnext/hr/doctype/employee_benefit_application/employee_benefit_application.py
View File

@ -14,12 +14,15 @@ from erpnext.hr.utils import get_sal_slip_total_benefit_given, get_holidays_for_
class EmployeeBenefitApplication(Document):
def validate(self):
self.validate_duplicate_on_payroll_period()
if flt(self.max_benefits) <= 0:
frappe.throw(_("Employee {0} has no maximum benefit amount").format(self.employee))
self.validate_max_benefit_for_component()
self.validate_prev_benefit_claim()
if self.remaining_benefit > 0:
self.validate_remaining_benefit_amount()
if not self.max_benefits:
self.max_benefits = get_max_benefits_remaining(self.employee, self.date, self.payroll_period)
if self.max_benefits and self.max_benefits > 0:
self.validate_max_benefit_for_component()
self.validate_prev_benefit_claim()
if self.remaining_benefit > 0:
self.validate_remaining_benefit_amount()
else:
frappe.throw(_("As per your assigned Salary Structure you cannot apply for benefits").format(self.employee))
def validate_prev_benefit_claim(self):
if self.employee_benefits: