Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #23649 from rohitwaghchaure/set-current-serial-no-in-serial-no-field-develop

Browse Source 
fix: serial no field is blank in stock reconciliation
This commit is contained in:
rohitwaghchaure 2020-10-15 16:56:39 +05:30 committed by GitHub
commit e8a3825ed1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.js
View File

@ -109,6 +109,10 @@ frappe.ui.form.on("Stock Reconciliation", {
frappe.model.set_value(cdt, cdn, "current_amount", r.message.rate * r.message.qty);
frappe.model.set_value(cdt, cdn, "amount", r.message.rate * r.message.qty);
frappe.model.set_value(cdt, cdn, "current_serial_no", r.message.serial_nos);
if (frm.doc.purpose == "Stock Reconciliation") {
frappe.model.set_value(cdt, cdn, "serial_no", r.message.serial_nos);
}
}
});
}

2
erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.py
View File

@ -67,6 +67,8 @@ class StockReconciliation(StockController):
if item_dict.get("serial_nos"):
item.current_serial_no = item_dict.get("serial_nos")
if self.purpose == "Stock Reconciliation":
item.serial_no = item.current_serial_no
item.current_qty = item_dict.get("qty")
item.current_valuation_rate = item_dict.get("rate")

2
erpnext/stock/doctype/stock_reconciliation/test_stock_reconciliation.py
View File

@ -124,7 +124,7 @@ class TestStockReconciliation(unittest.TestCase):
to_delete_records.append(sr.name)
sr = create_stock_reconciliation(item_code=serial_item_code,
warehouse = serial_warehouse, qty=5, rate=300, serial_no = '\n'.join(serial_nos))
warehouse = serial_warehouse, qty=5, rate=300)
serial_nos1 = get_serial_nos(sr.items[0].serial_no)
self.assertEqual(len(serial_nos1), 5)