Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Unable to create item variant based on manufacturer (#17652)

Browse Source 
* fix: Unable to create item variant against manufacturer

* fix: Spacing fixes

* fix: Spacing fixes in item.js
This commit is contained in:
Deepesh Garg 2019-05-17 15:39:22 +05:30 committed by Nabin Hait
parent c356fef9c4
commit e796d2844c
1 changed files with 25 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
erpnext/stock/doctype/item/item.js
View File

@ -375,10 +375,18 @@ $.extend(erpnext.item, {
show_modal_for_manufacturers: function(frm) {
var dialog = new frappe.ui.Dialog({
fields: [
{fieldtype:'Link', options:'Manufacturer',
reqd:1, label:'Manufacturer'},
{fieldtype:'Data', label:'Manufacturer Part Number',
fieldname: 'manufacturer_part_no'},
{
fieldtype: 'Link',
fieldname: 'manufacturer',
options: 'Manufacturer',
label: 'Manufacturer',
reqd: 1,
},
{
fieldtype: 'Data',
label: 'Manufacturer Part Number',
fieldname: 'manufacturer_part_no'
},
]
});
@ -389,7 +397,7 @@ $.extend(erpnext.item, {
// call the server to make the variant
data.template = frm.doc.name;
frappe.call({
method:"erpnext.controllers.item_variant.get_variant",
method: "erpnext.controllers.item_variant.get_variant",
args: data,
callback: function(r) {
var doclist = frappe.model.sync(r.message);
@ -464,7 +472,7 @@ $.extend(erpnext.item, {
me.multiple_variant_dialog.hide();
frappe.call({
method:"erpnext.controllers.item_variant.enqueue_multiple_variant_creation",
method: "erpnext.controllers.item_variant.enqueue_multiple_variant_creation",
args: {
"item": frm.doc.name,
"args": selected_attributes
@ -514,9 +522,9 @@ $.extend(erpnext.item, {
let p = new Promise(resolve => {
if(!d.numeric_values) {
frappe.call({
method:"frappe.client.get_list",
args:{
doctype:"Item Attribute Value",
method: "frappe.client.get_list",
args: {
doctype: "Item Attribute Value",
filters: [
["parent","=", d.attribute]
],
@ -534,9 +542,9 @@ $.extend(erpnext.item, {
});
} else {
frappe.call({
method:"frappe.client.get",
args:{
doctype:"Item Attribute",
method: "frappe.client.get",
args: {
doctype: "Item Attribute",
name: d.attribute
}
}).then((r) => {
@ -599,7 +607,7 @@ $.extend(erpnext.item, {
var args = d.get_values();
if(!args) return;
frappe.call({
method:"erpnext.controllers.item_variant.get_variant",
method: "erpnext.controllers.item_variant.get_variant",
btn: d.get_primary_btn(),
args: {
"template": frm.doc.name,
@ -622,7 +630,7 @@ $.extend(erpnext.item, {
} else {
d.hide();
frappe.call({
method:"erpnext.controllers.item_variant.create_variant",
method: "erpnext.controllers.item_variant.create_variant",
args: {
"item": frm.doc.name,
"args": d.get_values()
@ -660,8 +668,8 @@ $.extend(erpnext.item, {
.on('input', function(e) {
var term = e.target.value;
frappe.call({
method:"erpnext.stock.doctype.item.item.get_item_attribute",
args:{
method: "erpnext.stock.doctype.item.item.get_item_attribute",
args: {
parent: i,
attribute_value: term
},
@ -723,7 +731,7 @@ frappe.ui.form.on("UOM Conversion Detail", {
var row = locals[cdt][cdn];
if (row.uom) {
frappe.call({
method:"erpnext.stock.doctype.item.item.get_uom_conv_factor",
method: "erpnext.stock.doctype.item.item.get_uom_conv_factor",
args: {
"uom": row.uom,
"stock_uom": frm.doc.stock_uom