Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Validation for single threshold in Tax With Holding Category (#30382)

Browse Source 
(cherry picked from commit 0a2c72c594963f63551985a908c1c79302556e91)
This commit is contained in:
Sherin KR 2022-04-04 06:37:51 -07:00 committed by mergify-bot
parent a9811c601c
commit e796267214
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py
View File

@ -34,7 +34,9 @@ class TaxWithholdingCategory(Document):
def validate_thresholds(self): def validate_thresholds(self):
for d in self.get("rates"): for d in self.get("rates"):
if d.cumulative_threshold and d.cumulative_threshold < d.single_threshold: if (
d.cumulative_threshold and d.single_threshold and d.cumulative_threshold < d.single_threshold
):
frappe.throw( frappe.throw(
_("Row #{0}: Cumulative threshold cannot be less than Single Transaction threshold").format( _("Row #{0}: Cumulative threshold cannot be less than Single Transaction threshold").format(
d.idx d.idx