Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: update existing doc if possible

Browse Source
This commit is contained in:
Smit Vora 2023-10-20 09:33:37 +05:30 committed by Ankush Menat
parent 844e6f47df
commit e76860fae1
1 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
erpnext/stock/doctype/purchase_receipt/purchase_receipt.py
View File

@ -822,14 +822,14 @@ class PurchaseReceipt(BuyingController):
po_details.append(d.purchase_order_item) po_details.append(d.purchase_order_item)
if po_details: if po_details:
updated_pr += update_billed_amount_based_on_po(po_details, update_modified) updated_pr += update_billed_amount_based_on_po(po_details, update_modified, self)
for pr in set(updated_pr): for pr in set(updated_pr):
pr_doc = self if (pr == self.name) else frappe.get_doc("Purchase Receipt", pr) pr_doc = self if (pr == self.name) else frappe.get_doc("Purchase Receipt", pr)
update_billing_percentage(pr_doc, update_modified=update_modified) update_billing_percentage(pr_doc, update_modified=update_modified)
def update_billed_amount_based_on_po(po_details, update_modified=True): def update_billed_amount_based_on_po(po_details, update_modified=True, pr_doc=None):
po_billed_amt_details = get_billed_amount_against_po(po_details) po_billed_amt_details = get_billed_amount_against_po(po_details)
# Get all Purchase Receipt Item rows against the Purchase Order Items # Get all Purchase Receipt Item rows against the Purchase Order Items
@ -858,13 +858,19 @@ def update_billed_amount_based_on_po(po_details, update_modified=True):
po_billed_amt_details[pr_item.purchase_order_item] = billed_against_po po_billed_amt_details[pr_item.purchase_order_item] = billed_against_po
if pr_item.billed_amt != billed_amt_agianst_pr: if pr_item.billed_amt != billed_amt_agianst_pr:
frappe.db.set_value( # update existing doc if possible
"Purchase Receipt Item", if pr_doc and pr_item.parent == pr_doc.name:
pr_item.name, pr_item = next((item for item in pr_doc.items if item.name == pr_item.name), None)
"billed_amt", pr_item.db_set("billed_amt", billed_amt_agianst_pr, update_modified=update_modified)
billed_amt_agianst_pr,
update_modified=update_modified, else:
) frappe.db.set_value(
"Purchase Receipt Item",
pr_item.name,
"billed_amt",
billed_amt_agianst_pr,
update_modified=update_modified,
)
updated_pr.append(pr_item.parent) updated_pr.append(pr_item.parent)