From 7d780ce77279b2f104707cc64113e459f687231f Mon Sep 17 00:00:00 2001 From: aakvatech <35020381+aakvatech@users.noreply.github.com> Date: Fri, 4 Sep 2020 16:41:09 +0300 Subject: [PATCH 1/2] fix: Repayment Method not visible correctly https://github.com/frappe/erpnext/issues/23266 --- erpnext/loan_management/doctype/loan/loan.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/erpnext/loan_management/doctype/loan/loan.js b/erpnext/loan_management/doctype/loan/loan.js index ffef60b6b0..363af0c1bd 100644 --- a/erpnext/loan_management/doctype/loan/loan.js +++ b/erpnext/loan_management/doctype/loan/loan.js @@ -73,7 +73,7 @@ frappe.ui.form.on('Loan', { loan_type: function(frm) { frm.toggle_reqd("repayment_method", frm.doc.is_term_loan); - frm.toggle_display("repayment_method", 1 - frm.doc.is_term_loan); + frm.toggle_display("repayment_method", frm.doc.is_term_loan); frm.toggle_display("repayment_periods", s1 - frm.doc.is_term_loan); }, From f658b7bd8c9737ef6b7ea50adda5df6b901f2e7d Mon Sep 17 00:00:00 2001 From: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com> Date: Sat, 5 Sep 2020 21:07:56 +0530 Subject: [PATCH 2/2] fix: typo --- erpnext/loan_management/doctype/loan/loan.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/erpnext/loan_management/doctype/loan/loan.js b/erpnext/loan_management/doctype/loan/loan.js index 363af0c1bd..479bf1e6d7 100644 --- a/erpnext/loan_management/doctype/loan/loan.js +++ b/erpnext/loan_management/doctype/loan/loan.js @@ -74,7 +74,7 @@ frappe.ui.form.on('Loan', { loan_type: function(frm) { frm.toggle_reqd("repayment_method", frm.doc.is_term_loan); frm.toggle_display("repayment_method", frm.doc.is_term_loan); - frm.toggle_display("repayment_periods", s1 - frm.doc.is_term_loan); + frm.toggle_display("repayment_periods", frm.doc.is_term_loan); },