From e1f3b7cbc8c7f2d5f7b2e8786905cbe74afabe2b Mon Sep 17 00:00:00 2001 From: Raffael Meyer <14891507+barredterra@users.noreply.github.com> Date: Wed, 7 Jun 2023 18:19:02 +0200 Subject: [PATCH] fix: pass translated label to change button type (#35564) fix: change button type for translated labels Co-authored-by: Marica --- .../doctype/bank_clearance/bank_clearance.js | 10 +++++----- .../bank_reconciliation_tool.js | 2 +- .../payment_reconciliation/payment_reconciliation.js | 12 ++++++------ 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/erpnext/accounts/doctype/bank_clearance/bank_clearance.js b/erpnext/accounts/doctype/bank_clearance/bank_clearance.js index 71f2dcca1b..7af635bdd6 100644 --- a/erpnext/accounts/doctype/bank_clearance/bank_clearance.js +++ b/erpnext/accounts/doctype/bank_clearance/bank_clearance.js @@ -41,7 +41,7 @@ frappe.ui.form.on("Bank Clearance", { frm.trigger("get_payment_entries") ); - frm.change_custom_button_type('Get Payment Entries', null, 'primary'); + frm.change_custom_button_type(__('Get Payment Entries'), null, 'primary'); }, update_clearance_date: function(frm) { @@ -53,8 +53,8 @@ frappe.ui.form.on("Bank Clearance", { frm.refresh_fields(); if (!frm.doc.payment_entries.length) { - frm.change_custom_button_type('Get Payment Entries', null, 'primary'); - frm.change_custom_button_type('Update Clearance Date', null, 'default'); + frm.change_custom_button_type(__('Get Payment Entries'), null, 'primary'); + frm.change_custom_button_type(__('Update Clearance Date'), null, 'default'); } } }); @@ -72,8 +72,8 @@ frappe.ui.form.on("Bank Clearance", { frm.trigger("update_clearance_date") ); - frm.change_custom_button_type('Get Payment Entries', null, 'default'); - frm.change_custom_button_type('Update Clearance Date', null, 'primary'); + frm.change_custom_button_type(__('Get Payment Entries'), null, 'default'); + frm.change_custom_button_type(__('Update Clearance Date'), null, 'primary'); } } }); diff --git a/erpnext/accounts/doctype/bank_reconciliation_tool/bank_reconciliation_tool.js b/erpnext/accounts/doctype/bank_reconciliation_tool/bank_reconciliation_tool.js index d977261441..0647a5ccf3 100644 --- a/erpnext/accounts/doctype/bank_reconciliation_tool/bank_reconciliation_tool.js +++ b/erpnext/accounts/doctype/bank_reconciliation_tool/bank_reconciliation_tool.js @@ -81,7 +81,7 @@ frappe.ui.form.on("Bank Reconciliation Tool", { frm.add_custom_button(__('Get Unreconciled Entries'), function() { frm.trigger("make_reconciliation_tool"); }); - frm.change_custom_button_type('Get Unreconciled Entries', null, 'primary'); + frm.change_custom_button_type(__('Get Unreconciled Entries'), null, 'primary'); }, diff --git a/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.js b/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.js index 08d38dde47..2283677634 100644 --- a/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.js +++ b/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.js @@ -65,22 +65,22 @@ erpnext.accounts.PaymentReconciliationController = class PaymentReconciliationCo this.frm.add_custom_button(__('Get Unreconciled Entries'), () => this.frm.trigger("get_unreconciled_entries") ); - this.frm.change_custom_button_type('Get Unreconciled Entries', null, 'primary'); + this.frm.change_custom_button_type(__('Get Unreconciled Entries'), null, 'primary'); } if (this.frm.doc.invoices.length && this.frm.doc.payments.length) { this.frm.add_custom_button(__('Allocate'), () => this.frm.trigger("allocate") ); - this.frm.change_custom_button_type('Allocate', null, 'primary'); - this.frm.change_custom_button_type('Get Unreconciled Entries', null, 'default'); + this.frm.change_custom_button_type(__('Allocate'), null, 'primary'); + this.frm.change_custom_button_type(__('Get Unreconciled Entries'), null, 'default'); } if (this.frm.doc.allocation.length) { this.frm.add_custom_button(__('Reconcile'), () => this.frm.trigger("reconcile") ); - this.frm.change_custom_button_type('Reconcile', null, 'primary'); - this.frm.change_custom_button_type('Get Unreconciled Entries', null, 'default'); - this.frm.change_custom_button_type('Allocate', null, 'default'); + this.frm.change_custom_button_type(__('Reconcile'), null, 'primary'); + this.frm.change_custom_button_type(__('Get Unreconciled Entries'), null, 'default'); + this.frm.change_custom_button_type(__('Allocate'), null, 'default'); } // check for any running reconciliation jobs